* chore(#2992): widen the when= grammar and key the section manifest per workflow Epic #1671 Phase 6.1. Two blockers stopped the fragment model reaching any file beyond execute-phase.md: the when= vocabulary was frozen at 4 atoms (3 execute-phase-specific), and the section manifest was single-workflow by construction with 'execute-phase' hardcoded into buildSectionManifestField. - widen WHEN_VOCABULARY 4 -> 14 via a coordinated ADR-1671 amendment; the grammar stays CLOSED (one atom, no operators, negation or nesting) and WHEN_PREDICATES stays a hand-written literal map, never deriving a predicate from its atom string - InvocationFacts gains flags: ReadonlySet<string> plus three computed state booleans; add the missing reverse vocabulary/predicate parity guard - key the manifest artifact per workflow; a stale flat {sections:[...]} artifact now fails shape validation instead of being misattributed - wire the field into six init entry points and parse the flags each needs An atom ships only with both a real consuming section and a fact the init seam actually computes. Six surveyed atoms are withheld because their workflows have no dedicated init entry point; an atom without a computed fact evaluates false forever and silently disables its own section. Fixes a defect found while wiring: parseNamedArgs always materializes a boolean flag key, so folding its false into the absent sentinel is required or every flag reads as present and gating is silently always-on. Also resolves ADR-1671:194 by measurement: --mvp stays unmarkable, because its interleaved sites are always-run flag resolution and a ~340 byte block that already delegates lazily. Refs #2992 * fix(#2992): treat any falsy option value as an absent flag and reject unsafe manifest read paths Findings from two orthogonal reviews (Claude /code-review + an isolated adversarial pass); both independently reproduced the first one. - MAJOR: the flags-builder treated only `undefined` as absent, but parseNamedArgs yields `null` for an absent value-flag and `false` for an absent boolean-flag, so `--granularity` read as present on every plan-phase invocation. Fixed at the root: a flag is present iff its option value is truthy. The six per-handler `|| undefined` folds are now redundant and removed, which also closes the duplicate-translation and missed-onboard-handler findings. - MAJOR: state:needs-codebase-map had zero coverage. Added unit, property and real-CLI integration tests. - MINOR: reject absolute, UNC/drive and `..`-traversing `read` paths in the manifest, degrading the whole load to null like every other shape violation. Verified: `/etc/passwd` previously reached section_manifest.read. - MINOR: corrected a stale "4 to 20" doc comment; the vocabulary is 14. Refs #2992 * test(#2992): update the generator suite for the per-workflow manifest shape The remote matrix went red with 5 unique failures, identical on linux-node22 and linux-node24, all in tests/gen-section-manifest.test.cjs. Re-keying the artifact to {workflows:{...}} left this suite asserting the old flat {sections:[...]} shape; nothing else in the tree still does. - three tests read manifest.sections.length, now undefined; retargeted at workflows.<name> with their original intent preserved (a fenced or loop-host marker still asserts NO section is produced, not merely a changed count) - the stale-manifest test wrote its fixture in the OLD shape, so it tripped shape validation and stopped exercising staleness at all. Its fixture is now valid-but-mismatched so FAIL_STALE is genuinely reached again. - added the coverage that exposed: a pre-6.1 flat artifact must report FAIL_MANIFEST_MALFORMED_SHAPE. That is the real upgrade path for an installed tree and nothing covered it. Refs #2992 * chore(#2992): backfill changeset pr number to 3013 --------- Co-authored-by: sim <sim@local>
15 KiB
Workflow fragments (reference)
Diátaxis quadrant: Reference. This is the canonical specification of the in-file
<!-- gsd:section -->marker grammar used to fragmentize GSD workflow markdown for per-runtime emission. For the surrounding seam (why it exists and how it composes with the shared budget composer), see Architecture: Workflow Fragmentization and Emission and ADR-1671 (open questions 1 and 2).
Workflow authors can mark one or more sections of a gsd-core/workflows/*.md file
so that bin/install.js's emission path can compose them per runtime, and so that
a separate init-time seam can select which sections apply to one concrete
invocation — see The manifest artifact and per-workflow
keying below.
Marker syntax
An open marker is a line whose only content (after trimming leading/trailing whitespace) is:
<!-- gsd:section id="<id>" when="<when>" -->
A close marker is a line whose only content is:
<!-- /gsd:section -->
- Attribute order is free and inner spacing around
=and between attributes is flexible. idmust match/^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/and must be unique within one file.whenmust be exactly one entry of the frozen vocabulary below — no operators, no negation, no nesting.- Both
idandwhenare required on every open marker; a marker missing either attribute fails closed (see Fails closed).
Text between an open marker and its matching close marker is that section's body, byte-for-byte (including its own line terminators). Text outside any marker pair becomes an implicit "gap" fragment — the file's ordinary, unmarked content — so a workflow with no markers at all parses to exactly one gap fragment and composes back byte-identical to its source.
The frozen when= vocabulary
when= takes exactly one of 14 atoms (widened from 4 via the ADR-1671
amendment for #2992, epic #1671 Phase 6.1):
| Value | Meaning |
|---|---|
always |
Section is always applicable. |
flag:--wave |
Applicable when the workflow runs with --wave. |
state:gap-closure-phase |
Applicable when the phase number is a gap-closure phase (has a decimal, e.g. 4.1). |
state:has-prior-phases |
Applicable when prior phases (and their VERIFICATION.md files) exist. |
flag:--auto |
Applicable when the workflow runs with --auto. |
flag:--discuss |
Applicable when the workflow runs with --discuss. |
flag:--forensic |
Applicable when the workflow runs with --forensic. |
flag:--full |
Applicable when the workflow runs with --full. |
flag:--research |
Applicable when the workflow runs with --research. |
flag:--reset-phase-numbers |
Applicable when the workflow runs with --reset-phase-numbers. |
flag:--validate |
Applicable when the workflow runs with --validate. |
state:needs-codebase-map |
Applicable when a codebase map is needed (init-computed). |
state:phase-mvp-mode |
Applicable when the current phase's ROADMAP.md entry declares **Mode:** mvp. |
state:worktrees-enabled |
Applicable when .planning/config.json's workflow.use_worktrees is enabled. |
This list is closed by design (Greenspun's Tenth Rule): left open-ended,
when= would acquire boolean operators, negation, precedence, and
runtime/capability predicates one edit at a time, becoming an ad-hoc,
informally-specified applicability language. Widening the vocabulary is a
coordinated ADR amendment to ADR-1671, never an organic edit to the parser —
when= remains exactly one atom per marker: no operators, no negation, no
nesting, regardless of how many atoms the frozen list holds. An unknown value
still throws (see Fails closed).
An atom only ships once it clears two independent admission gates, both required:
- A named consuming section. Some workflow's marked section actually needs the condition — an atom with no section that uses it is dead vocabulary, and dead vocabulary is how a closed list rots into an open one.
- A fact the init seam can actually compute. Only a workflow with a
dedicated
cmdInit*entry point (see The manifest artifact below) can carry a manifest, and only a condition that entry point can resolve at init time — from parsed CLI options or from.planning/state — may become an atom. An atom without a computable fact would always evaluatefalse, so a section marked with it would silently never include: the exact silent-wrong-answer class this gate exists to prevent.
Six further atoms (flag:--converge, flag:--fix, flag:--verify-only,
state:fallow-enabled, state:git-create-tag, state:is-monorepo) satisfy
gate 1 but not yet gate 2 — their workflows (autonomous, code-review,
complete-milestone, docs-update) route through shared generic init entry
points invoked by 20+ other workflows, so a dedicated cmdInit* seam does
not yet exist to compute their facts. They are withheld pending that seam,
not rejected.
Fails closed
An authoring mistake throws at parse time, naming the source file and 1-based line number, rather than being silently dropped or swallowed to end-of-file:
- Missing
id=orwhen=attribute (MISSING_ID,MISSING_WHEN). when=value not in the frozen vocabulary above, including any boolean operator or negation form (UNKNOWN_WHEN).id=value that does not match the id grammar (MALFORMED_ID).- Malformed attribute syntax on an open marker — the attribute text is not a
run of well-formed
key="value"tokens (e.g. an unterminated quote or a duplicate attribute key) (MALFORMED_ATTRIBUTES). - An unrecognized attribute on an open marker (
UNRECOGNIZED_ATTRIBUTE). - A close marker carrying attributes (
CLOSE_WITH_ATTRIBUTES). - An unmatched close marker, i.e. close with no open (
UNMATCHED_CLOSE). - A nested marker, i.e. open marker while already inside an open section
(
NESTED_SECTION). - A duplicate
id=within one file (DUPLICATE_ID). - An open marker with no matching close before end of file
(
UNCLOSED_SECTION).
An unrecognized when= is treated as an authoring instruction that must never
be silently ignored, not as a value to fail open on — this is deliberately
asymmetric with the marker formatting tolerance above (free attribute order,
flexible spacing), which is liberal by design.
Markers are stripped at emit
Composition runs parseWorkflowSections → map sections to fragments → the
shared context-composer.cjs budget seam (every fragment uses the verbatim
strategy, so nothing is trimmed) → re-join fragment bodies in document order.
The marker lines themselves are never part of any fragment body, so the
composed output — and therefore every installed runtime artifact — contains
no gsd:section markers at all. An unmarked file composes to itself exactly;
a marked file composes to itself minus the marker line bytes.
Composition runs before the per-runtime converters (the .claude/ →
.windsurf/-style path and reference rewrites), so a marker's id/when
attribute text is never exposed to a rewrite regex.
Fenced and commented lookalikes are literal
A <!-- gsd:section ... -->-shaped line inside a fenced code block (three or
more backticks or tildes, CommonMark-style) is not a marker — it is
literal fence content, because workflows document their own marker syntax in
fenced examples (as in this page and in the workflow files themselves). The
same applies to a gsd:section mention inside an unrelated HTML comment, or
in prose/backtick text that never opens a real one-line comment. Fence and
comment detection run as a single interleaved left-to-right scan, mirroring
the discipline used by the CONTEXT.md predicate parser
(src/context-predicates.cts): while a fence is open, only a matching closer
can end it; while a comment is open, only --> can end it; an unclosed fence
running to end of file is not an error — everything after it is simply
literal.
The pre-existing <!-- gsd:loop-host ... --> marker family (consumed by
scripts/gen-loop-host-contract.cjs) is a different, already-established
marker and is never treated as a gsd:section marker.
The manifest artifact and per-workflow keying
bin/install.js's emission path always composes every fragment into the
output regardless of its when= value — marker lines are stripped, nothing
else changes there. Applicability selection is a separate, later seam:
scripts/gen-section-manifest.cjs --write scans gsd-core/workflows/*.md for
gsd:section markers and generates a committed artifact,
gsd-core/workflows/section-manifest.json, shaped as
{"workflows": {"<workflow-name>": [{"id", "when", "read"}, ...], ...}},
where <workflow-name> is a source .md file's basename without extension
and read is the POSIX-normalized, repo-root-relative path of the step file
the section body was extracted to. This is a per-workflow superset of the
pre-#2992 shape, which was a single flat {"sections": [...]} array with no
workflow key — that shape is now rejected outright rather than mis-parsed, so
a stale committed artifact can never be silently attributed to whichever
workflow asks first.
A workflow key's presence vs. absence is meaningful, not cosmetic:
- The key is absent when the workflow has zero marked sections. A caller
for that workflow must treat this as degraded/unknown (
null) — safe superset, read everything. - The key is present with an empty array when the workflow's sections were evaluated and none applied to this invocation — genuinely nothing to read, not "unknown."
Collapsing these two states inverts behavior on the degraded path: null
means "I don't know, so include everything"; [] means "I computed this,
and the answer is nothing."
At init time, a separate pure evaluator, src/section-manifest.cts
(selectSections), partitions a workflow's manifest sections into
included/excluded id lists against one invocation's
InvocationFacts — {flags, phaseNumber, hasPriorPhases, needsCodebaseMap?, phaseMvpMode?, worktreesEnabled?}. Only a workflow with a dedicated
cmdInit* entry point in src/init.cts can have this evaluation run for
it, because only that entry point can assemble InvocationFacts from its own
parsed CLI options and .planning/ state reads — this is admission gate 2
from The frozen when= vocabulary above,
applied per-workflow rather than per-atom. Six entry points are wired today:
execute-phase, plan-phase, new-project, new-milestone, quick, and
progress.
InvocationFacts.flags is a ReadonlySet<string> of the literal --<name>
tokens seen on the invocation, and membership is token-presence, not
value-truthiness. This matters because parseNamedArgs's booleanFlags
always materializes the key in its result object — true when the token was
seen, false otherwise, never undefined. A caller that passed a
boolean-flag's own false straight through as an "option value" would add it
to flags anyway (any non-undefined value counts as present for a
value flag), making that flag: atom permanently true regardless of the
actual command line — the fix is that every boolean-flag call site folds its
own false into undefined (namedArgs['wave'] || undefined) before
handing options to the facts builder, so flags only ever contains tokens
that were actually seen.
Piloted on one workflow so far
Only gsd-core/workflows/execute-phase.md carries markers today. The marker
grammar and composer seam are general-purpose across any workflow file, but
rollout to other LARGE/XL workflows is intentionally sequenced as later work,
not part of this phase.
The pilot marks three <step> blocks: partial-wave (flag:--wave),
gap-closure-artifacts (state:gap-closure-phase), and regression-gate
(state:has-prior-phases).
The pilot was retargeted from plan-phase.md mid-phase. Issue #2930's
own motivating mutually-exclusive branches (--prd, --ingest, --mvp,
--reviews) all live in plan-phase.md, not execute-phase.md. But
plan-phase.md sits only 36 B under an independent, pre-existing size gate
(tests/phase6-capstone-conformance.test.cjs's PRE_PHASE6, an ADR-857
Phase-6 completion property) and cannot absorb any marker overhead at all —
so it could not be fragmentized under this phase's grammar regardless of
branch shape. This is direct evidence for the epic's premise that
fragmentization pays off, and it also means Phase 4 (moving size caps from
source bytes to emitted bytes) may need to land before plan-phase.md
itself can be fragmentized. Separately, and independent of the size-gate
finding, --mvp would remain unmarkable by this grammar even if the size
gate allowed it: its content in plan-phase.md is INTERLEAVED with other
flags rather than living in its own contiguous section (MVP_MODE
resolution shares a single bash block with --tdd, --no-tracer, and
--no-reversibility-gates handling at plan-phase.md:125-158, and
elsewhere it is inline ${MVP_MODE === 'true' ? ... } template
interpolation embedded inside the planner prompt at plan-phase.md:794-803)
— the marker grammar is closed, non-nesting, and whole-line (see
Marker syntax above), with no way to wrap part of a line
or split a shared conditional block without either corrupting the
conditional or bundling unrelated flags into one section. See
ADR-1671 open
question 1's resolution for the full record, and Phase 6 (LARGE/XL rollout)
for how both limits get addressed.
Related
- ADR-1671 — the platform decision record, including open questions 1 (fragment unit) and 2 (build-time vs. run-time emission), both resolved by this phase.
- Architecture: Workflow Fragmentization and Emission.
src/workflow-fragments.cts— the compiled parser/composer source.src/context-composer.cts— the shared budget-composition seam consumed bycomposeWorkflow.src/section-manifest.cts— the purewhen=evaluator (selectSections,InvocationFacts) consumed by the init seam.scripts/gen-section-manifest.cjs— generates the committedgsd-core/workflows/section-manifest.jsonartifact from markers.src/init.cts—buildSectionManifestFieldand the six wiredcmdInit*entry points.