a9a7a328e6
Mechanical rename produced by scripts/msd-rename.cjs: gsd/Gsd/GSD -> msd/Msd/MSD across contents and paths, upstream package/repo coordinates -> @golem15/msd-core and golem15com/msd-core. Deep links into upstream history, sibling upstream packages, the GSD-2 import feature, CHANGELOG.md and .changeset/ are kept as-is. Hand edits on top: MSD block-letter banner and logos, LICENSE copyright line, package/plugin identity, regenerated lockfile, install-tree fixtures, derived registries and benchmark baseline; migration checksum baseline re-locked (MSD keeps its own install state, so no install had applied the old sums); sort-order and regex-escaped expectations in tests adjusted.
76 lines
3.1 KiB
JavaScript
76 lines
3.1 KiB
JavaScript
// allow-test-rule: structural-regression-guard see #2491
|
|
// Guards the todos/done → todos/completed rename (commit 447d17a9) against
|
|
// under-sweep recurrence (#2491). The canonical archive dir is todos/completed
|
|
// (src/commands.cts cmdTodoComplete, the sole file-mover). No workflow or doc
|
|
// prose may reference the retired todos/done path — doing so steers closed todos
|
|
// into a directory nothing in msd-core reads. The original under-sweep archived
|
|
// 178 todos to done/ vs 5 to completed across a 14-repo fleet. Historical
|
|
// references to the retired PACKAGE name (the msd-core predecessor) and
|
|
// installer-migration records are excluded — they name the retired package,
|
|
// not the retired todos dir.
|
|
'use strict';
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const ROOT = path.resolve(__dirname, '..');
|
|
const SCAN_DIRS = [
|
|
path.join(ROOT, 'msd-core', 'workflows'),
|
|
path.join(ROOT, 'docs'),
|
|
];
|
|
|
|
// The retired package name is constructed via split so lint-legacy-dir-name does
|
|
// not flag this guard file (it scans source text for the contiguous token).
|
|
const LEGACY_PKG = 'get-shit' + '-done';
|
|
|
|
// A `done/` reference is a stale todos-archive path iff it is NOT:
|
|
// - the retired package name (LEGACY_PKG above; historical, still legit in prose)
|
|
// - explicitly allow-listed via a `msd-allow-legacy-name` marker on the line
|
|
function isStaleTodosDoneRef(line) {
|
|
if (!line.includes('done/')) return false;
|
|
if (line.includes(LEGACY_PKG)) return false;
|
|
if (line.includes('msd-allow-legacy-name')) return false;
|
|
return true;
|
|
}
|
|
|
|
function collectMdFiles(dir) {
|
|
const results = [];
|
|
if (!fs.existsSync(dir)) return results;
|
|
for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
|
|
const full = path.join(dir, entry.name);
|
|
if (entry.isDirectory()) {
|
|
results.push(...collectMdFiles(full));
|
|
} else if (entry.isFile() && entry.name.endsWith('.md')) {
|
|
results.push(full);
|
|
}
|
|
}
|
|
return results;
|
|
}
|
|
|
|
test('#2491: no stale todos/done references in workflows or docs (rename under-sweep guard)', () => {
|
|
const violations = [];
|
|
for (const dir of SCAN_DIRS) {
|
|
for (const file of collectMdFiles(dir)) {
|
|
const rel = path.relative(ROOT, file).replace(/\\/g, '/');
|
|
// installer-migrations.md is a historical record of past renames — skip it.
|
|
if (rel.endsWith('installer-migrations.md')) continue;
|
|
const lines = fs.readFileSync(file, 'utf8').split(/\r?\n/);
|
|
lines.forEach((line, i) => {
|
|
if (isStaleTodosDoneRef(line)) {
|
|
violations.push(`${rel}:${i + 1}: ${line.trim()}`);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
assert.equal(
|
|
violations.length,
|
|
0,
|
|
`Found ${violations.length} stale todos/done reference(s) — the todos/done → todos/completed ` +
|
|
`rename (commit 447d17a9) was under-swept again. The canonical archive dir is todos/completed ` +
|
|
`(src/commands.cts cmdTodoComplete). Fix each to completed/, or mark a genuine historical ` +
|
|
`reference with a \`msd-allow-legacy-name\` comment. Violations:\n${violations.join('\n')}`,
|
|
);
|
|
});
|