* fix(3668): isolate --local install from global gsd-sdk - `buildGsdSdkVersionMismatchReport` now accepts `opts.isLocal`; when true it sets `fix_command` to `npx get-shit-done-cc@latest --claude --local` instead of `npm install -g …`, removing the misleading global upgrade suggestion for local installs. - Propagate `isLocal` from `installSdkIfNeeded` into the mismatch report builder so the right fix_command reaches the renderer. - Export `buildGsdSdkVersionMismatchReport` and `renderGsdSdkVersionMismatchReport` so tests can assert on the IR contract directly. - Add `command -v gsd-sdk … elif node "$GSD_TOOLS"` preflight SDK resolution block to all 69 workflow files that called bare `gsd-sdk` with no fallback, matching the pattern established in update.md, execute-phase.md, and quick.md. - Add `tests/bug-3668-local-install-sdk-soft-dep.test.cjs` with 5 tests covering Defects 1-3, including a CI lint guard that blocks future workflow regressions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * changeset: add Fixed entry for #3668 * fix(3668): add allow-test-rule to suppress false lint-no-source-grep violation The test reads workflow .md files (product content) to assert structural invariants — not .cjs source files. The file-presence check is the only viable IR for markdown guard patterns. Add the // allow-test-rule annotation so lint-no-source-grep passes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3668): fix do.md false-positive and discuss-phase.md size overflow Two CI failures introduced by the 69-workflow preflight block: 1. do.md: the path `bin/gsd-tools.cjs` contains `/gsd-tools` which the bug-2954 parity test regex `/\/gsd[:-]([a-z][a-z0-9-]*)/g` mistakenly extracts as a slash command named `tools`. Fix: store the shim filename in _GSD_SHIM_NAME so the path construction no longer contains a static `/gsd-tools` literal. Also wire $GSD_SDK into the actual query call. 2. discuss-phase.md: the file was at 499 lines (the 500-line budget from #2551). Adding the 11-line preflight block pushed it to 510, failing workflow-size-budget.test.cjs. Fix: compress the 11-line preflight + 2-line invocations into 3 lines (one-liner guard + two $GSD_SDK calls) returning the file to 499 lines while retaining the command -v guard required by bug-3668-local-install-sdk-soft-dep.test.cjs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3668): wire \$GSD_SDK through all workflow callsites (#3797) PR #3797 introduced the resolution preflight block (setting \$GSD_SDK) in 69 workflows but left every downstream gsd-sdk callsite using the bare command. On local-only installs the preflight exits cleanly, then the very next line fails with 'command not found'. This is the structural gap the Codex review flagged. Changes: - 687 bare `gsd-sdk` callsites replaced with `\$GSD_SDK` across 75 workflow files (all bash/sh fenced blocks excluding the resolution guard blocks themselves) - execute-phase.md: was missing the preflight block entirely — added the standard 11-line resolution block at the initialize step - execute-phase.md: inline `if command -v gsd-sdk` availability guard (legacy #3384 fallback) replaced with `\$GSD_SDK` + error fallback since the new preflight guarantees SDK availability or exits 1 - 6 sub-workflow files (discuss-phase/modes/*, execute-phase/steps/*) that have no preflight of their own but use \$GSD_SDK — these are loaded by parent workflows that set the variable; callsites updated to use \$GSD_SDK so they work when variable is in scope Transformation script used: /private/tmp/fw2.js (regex-based fence parser with segment join invariant verification — preserves all blank lines and prose formatting). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(3668): upgrade CI guard to detect bare callsite routing (#3797) The previous Defect 3 test checked that 'command -v gsd-sdk' appeared as a string in the file — a guard-presence check, not a callsite-routing check. A workflow with the preflight block but 40 bare gsd-sdk calls below it passed the old test. This is exactly the bug state PR #3797 was supposed to fix. Upgraded test: - Parses each workflow file into markdown segments using a regex-based fence extractor (preserves all content invariantly) - Skips bash/sh blocks that contain 'command -v gsd-sdk' (those are resolution guards — bare references there are expected) - Flags any remaining bash/sh block line that invokes gsd-sdk without the \$ prefix (isBareGsdSdkInvocation predicate) - Counter-test proves the predicate correctly flags real callsite lines and correctly exempts guard assignments, comments, and \$GSD_SDK refs Also adds helper functions parseMarkdownSegments, isBareGsdSdkInvocation, and findMdFiles which are used by both the upgraded Defect 3 test and the counter-test. This test would have caught the originally-shipped bug: the preflight block was present but callsites still used bare gsd-sdk. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tests): update workflow content tests to accept \$GSD_SDK callsite form (#3797) Six regression tests assert on the exact textual pattern of gsd-sdk calls inside workflow .md files. After the #3797 callsite replacement (687 bare `gsd-sdk` invocations replaced with `\$GSD_SDK`), these tests failed because they searched for the literal string `gsd-sdk query <cmd>` which no longer appears at callsites. Updated each test to accept both the pre-#3797 bare form and the post-#3797 variable form using `(?:\$GSD_SDK|gsd-sdk)` regex alternation (or two-branch `includes()` checks for non-regex assertions). The structural invariants each test enforces are unchanged — we're accepting the same behavioral contract through the new callsite surface. Tests fixed: - bug-2334-quick-gsd-sdk-preflight: find init.quick call via \$GSD_SDK or bare - bug-2661-roadmap-sync-parallel: roadmap.update-plan-progress call pattern - bug-3360-codex-execute-phase-worktrees: RUNTIME config-get call detection - bug-3381-verify-work-workstream: init.verify-work / phase.mvp-mode calls - enh-2433-todo-phase-linking: commit call in new-milestone.md - enh-2792-namespace-skills: validate.context invocation in context_check step Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tests): update remaining workflow content tests to accept \$GSD_SDK form (#3797) After #3797 callsite replacement, ultraplan-phase.test.cjs and worktree-cleanup.test.cjs still assert bare gsd-sdk form. Update to accept either \$GSD_SDK or gsd-sdk. Also trim the execute-phase.md preflight comment to stay within the XL line-count budget (1810). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3668): adopt inline-per-fence SDK resolution + restore safety semantics The brief offered three options: (a) inline preflight block per fence (b) wrapper script (c) shared shell fragment sourced at the top 71 of 72 workflow files already had inline preflight blocks (just broken ones). Option (b)/(c) would have required changes to install.js + a new shared artifact, with significant risk of breaking the install pipeline. Option (a) was the path of least resistance and least new blast radius. **BLOCKER 1+2+3 (quick.md — GSD_SDK never assigned):** - quick.md had 12 `$GSD_SDK` references but zero `GSD_SDK=` assignments. - Added proper local-first preflight block with `git rev-parse --show-toplevel` path (not the broken `CLAUDE_FILE_PATHS` which is always empty in Claude Code). - Each Bash fence in Claude Code runs as a fresh `bash -c`, so env vars don't persist. The preflight block must appear in every fence that uses $GSD_SDK. **BLOCKER 4 (execute-phase.md — || exit 1 dropped):** - Restored `|| exit 1` after every `worktree.cleanup-wave` call. SDK safety refusals (drift detection #3174, deletion block #2384) must surface, not be swallowed by the old `|| { fallback }` branch. **F5 (verify-work.md untyped fence):** - Changed bare `gsd-sdk` in an untyped fence to `$GSD_SDK`. - Changed fence tag from untyped to `bash`. **F6 (non-recursive readdirSync):** - Defect 2 test now uses `findMdFiles` (recursive) to cover workflow subdirectories, not the flat `fs.readdirSync` that missed subdirs. **F7 (lint misses untyped fences):** - `parseMarkdownSegments` now treats `lang === ''` fences as bash-fences. **F8 (missing propagation test):** - Added two propagation tests in the Defect 3 describe block. **F9 (priority inverted — global before local):** - All 72 workflow files now check `[ -f "$GSD_TOOLS" ]` before `command -v gsd-sdk`. - Path: `$(git rev-parse --show-toplevel 2>/dev/null || pwd)/get-shit-done/bin/gsd-tools.cjs` **F10/F11 (broken quoting):** - Changed `GSD_SDK="node "$GSD_TOOLS""` → `GSD_SDK="node $GSD_TOOLS"` across all files. **SDK-absence fallback removal:** - The old `|| { STATE_BACKUP=...; while IFS=...WAS_DELETED...; done }` fallback code was dead — preflight now exits if neither local nor global SDK exists. Removed from quick.md, execute-phase.md. Tests updated to verify SDK delegation rather than inline shell mechanics. **Tests updated:** - bug-2384, bug-2501, bug-2838, bug-3091, bug-3195, bug-3521, bug-3668, worktree-cleanup — all updated to reflect SDK delegation contract. - Defect 2 test now uses bash-fence scan (not raw content) to skip docs-only gsd-sdk prose references (e.g. discuss-phase/modes/text.md). Closes #3668 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3668): restore _GSD_SHIM_NAME indirection in do.md to prevent false-positive The top commit re-introduced a literal /get-shit-done/bin/gsd-tools.cjs path in do.md, causing bug-2954 test to match /gsd-tools as an unshipped slash command. Restore the _GSD_SHIM_NAME variable indirection (from ff9939e5) to break the literal path while preserving local-first preference order. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tests): update worktree.test.cjs to accept SDK delegation contract (#3797) Mirror the contract update already applied to worktree-cleanup.test.cjs: - pre-merge deletion check tests: accept worktree.cleanup-wave + deletion mention as valid (inline --diff-filter=D was in the removed shell fallback) - quick.md bug-2431 tests (lock-aware, unlock retry, residual warning): accept worktree.cleanup-wave delegation as sufficient (these safety behaviors are now handled internally by the SDK cleanup-wave command) execute-phase.md tests unchanged: it retains inline .git/worktrees/, locked, git worktree unlock, and Residual worktree in its cleanup-tail snippet. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(3668): refactor bug-2384 and bug-2838 from grep to structured assertions Replace content.includes() on readFileSync-bound variables with parser functions that split lines and return typed boolean fields, matching the project's no-source-grep contract (lint-no-source-grep rule F/G). --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
16 KiB
Supports two modes:
- Idea mode (default) — user describes a design idea to sketch
- Frontier mode — no argument or "frontier" / "what should I sketch?" — analyzes existing sketch landscape and proposes consistency and frontier sketches
<required_reading> Read all files referenced by the invoking prompt's execution_context before starting.
@/.claude/get-shit-done/references/sketch-theme-system.md
@/.claude/get-shit-done/references/sketch-variant-patterns.md
@/.claude/get-shit-done/references/sketch-interactivity.md
@/.claude/get-shit-done/references/sketch-tooling.md
</required_reading>
Parse $ARGUMENTS for:
--quickflag → setQUICK_MODE=true--textflag → setTEXT_MODE=truefrontieror empty → setFRONTIER_MODE=true- Remaining text → the design idea to sketch
Text mode: If TEXT_MODE is enabled, replace AskUserQuestion calls with plain-text numbered lists.
## Routing- FRONTIER_MODE is true → Jump to
frontier_mode - Otherwise → Continue to
setup_directory
Load the Sketch Landscape
If no .planning/sketches/ directory exists, tell the user there's nothing to analyze and offer to start fresh with an idea instead.
Otherwise, load in this order:
a. MANIFEST.md — the design direction, reference points, and sketch table with winners.
b. Findings skills — glob ./.claude/skills/sketch-findings-*/SKILL.md and read any that exist, plus their references/*.md. These contain curated design decisions from prior wrap-ups.
c. All sketch READMEs — read .planning/sketches/*/README.md for design questions, winners, and tags.
Analyze for Consistency Sketches
Review winning variants across all sketches. Look for:
- Visual consistency gaps: Two sketches made independent design choices that haven't been tested together.
- State combinations: Individual states validated but not seen in sequence.
- Responsive gaps: Validated at one viewport but the real app needs multiple.
- Theme coherence: Individual components look good but haven't been composed into a full-page view.
If consistency risks exist, present them as concrete proposed sketches with names and design questions. If no meaningful gaps, say so and skip.
Analyze for Frontier Sketches
Think laterally about the design direction from MANIFEST.md and what's been explored:
- Unsketched screens: UI surfaces assumed but unexplored.
- Interaction patterns: Static layouts validated but transitions, loading, drag-and-drop need feeling.
- Edge case UI: 0 items, 1000 items, errors, slow connections.
- Alternative directions: Fresh takes on "fine but not great" sketches.
- Polish passes: Typography, spacing, micro-interactions, empty states.
Present frontier sketches as concrete proposals numbered from the highest existing sketch number.
Get Alignment and Execute
Present all consistency and frontier candidates, then ask which to run. When the user picks sketches, update .planning/sketches/MANIFEST.md and proceed directly to building them starting at build_sketches.
mkdir -p .planning/sketches/themes
Check for existing sketches to determine numbering:
ls -d .planning/sketches/[0-9][0-9][0-9]-* 2>/dev/null | sort | tail -1
Check commit_docs config:
# SDK resolution: prefer local gsd-tools.cjs, fall back to global gsd-sdk (#3668)
GSD_TOOLS="${RUNTIME_DIR:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}/get-shit-done/bin/gsd-tools.cjs"
if [ -f "$GSD_TOOLS" ]; then
GSD_SDK="node $GSD_TOOLS"
elif command -v gsd-sdk >/dev/null 2>&1; then
GSD_SDK="gsd-sdk"
else
echo "ERROR: gsd-sdk not found on PATH and $GSD_TOOLS does not exist." >&2
echo "Run: npx get-shit-done-cc@latest --claude --local" >&2
exit 1
fi
COMMIT_DOCS=$($GSD_SDK query config-get commit_docs 2>/dev/null || echo "true")
Otherwise:
Before sketching anything, explore the design intent through conversation. Ask one question at a time — using AskUserQuestion in normal mode, or a plain-text numbered list if TEXT_MODE is active.
Questions to cover (adapt to what the user has already shared):
- Feel: "What should this feel like? Give me adjectives, emotions, or a vibe."
- References: "What apps, sites, or products have a similar feel to what you're imagining?"
- Core action: "What's the single most important thing a user does here?"
After each answer, briefly reflect what you heard and how it shapes your thinking.
When you have enough signal, ask: "I think I have a good sense of the direction. Ready for me to sketch, or want to keep discussing?"
Only proceed when the user says go.
## Load Spike ContextIf spikes exist for this project, read them to ground the sketches in reality. Mockups are still pure HTML, but they should reflect what's actually been proven — real data shapes, real component names, real interaction patterns.
a. Glob for ./.claude/skills/spike-findings-*/SKILL.md and read any that exist, plus their references/*.md. These contain validated patterns and requirements.
b. Read .planning/spikes/MANIFEST.md if it exists — check the Requirements section for non-negotiable design constraints (e.g., "must support streaming", "must render markdown"). These requirements should be visible in the mockup even though the mockup doesn't implement them for real.
c. Read .planning/spikes/CONVENTIONS.md if it exists — the established stack informs what's buildable and what interaction patterns are idiomatic.
How spike context improves sketches:
- Use real field names and data shapes from spike findings instead of generic placeholders
- Show realistic UI states that match what the spikes proved (e.g., if streaming was validated, show a streaming message state)
- Reference real component names and patterns from the target stack
- Include interaction states that reflect what the spikes discovered (loading, error, reconnection states)
If no spikes exist, skip this step.
Break the idea into 2-5 design questions. Present as a table:| Sketch | Design question | Approach | Risk |
|---|---|---|---|
| 001 | Does a two-panel layout feel right? | Sidebar + main, variants: fixed/collapsible/floating | High — sets page structure |
| 002 | How should the form controls look? | Grouped cards, variants: stacked/inline/floating labels | Medium |
Each sketch answers one specific visual question. Good sketches:
- "Does this layout feel right?" — build with real-ish content
- "How should these controls be grouped?" — build with actual labels and inputs
- "What does this interaction feel like?" — build the hover/click/transition
- "Does this color palette work?" — apply to actual UI, not a swatch grid
Bad sketches:
- "Design the whole app" — too broad
- "Set up the component library" — that's implementation
- "Pick a color palette" — apply it to UI instead
Present the table and get alignment before building.
## Research the Target StackBefore sketching, ground the design in what's actually buildable. Sketches are HTML, but they should reflect real constraints of the target implementation.
a. Identify the target stack. Check for package.json, Cargo.toml, etc. If the user mentioned a framework (React, SwiftUI, Flutter, etc.), note it.
b. Check component/pattern availability. Use context7 (resolve-library-id → query-docs) or web search to answer:
- What layout primitives does the target framework provide?
- Are there existing component libraries in use? What components are available?
- What interaction patterns are idiomatic?
c. Note constraints that affect design:
- Platform conventions (iOS nav patterns, desktop menu bars, terminal grid constraints)
- Framework limitations (what's easy vs requires custom work)
- Existing design tokens or theme systems already in the project
d. Let research inform variants. At least one variant should follow the path of least resistance for the target stack.
Skip when unnecessary. Greenfield project with no stack, or user says "just explore visually." The point is grounding, not gatekeeping.
Create or update `.planning/sketches/MANIFEST.md`:# Sketch Manifest
## Design Direction
[One paragraph capturing the mood/feel/direction from the intake conversation]
## Reference Points
[Apps/sites the user referenced]
## Sketches
| # | Name | Design Question | Winner | Tags |
|---|------|----------------|--------|------|
If MANIFEST.md already exists, append new sketches to the existing table.
If no theme exists yet at `.planning/sketches/themes/default.css`, create one based on the mood/direction from the intake step. See `sketch-theme-system.md` for the full template.Adapt colors, fonts, spacing, and shapes to match the agreed aesthetic — don't use the defaults verbatim unless they match the mood.
Build each sketch in order.For Each Sketch:
a. Find next available number. Format: three-digit zero-padded + hyphenated descriptive name.
b. Create the sketch directory: .planning/sketches/NNN-descriptive-name/
c. Build index.html with 2-3 variants:
First round — dramatic differences: 2-3 meaningfully different approaches. Subsequent rounds — refinements: Subtler variations within the chosen direction.
Each variant is a page/tab in the same HTML file. Include:
- Tab navigation to switch between variants (see
sketch-variant-patterns.md) - Clear labels: "Variant A: Sidebar Layout", "Variant B: Top Nav", etc.
- The sketch toolbar (see
sketch-tooling.md) - All interactive elements functional (see
sketch-interactivity.md) - Real-ish content, not lorem ipsum (use real field names from spike context if available)
- Link to
../themes/default.cssfor shared theme variables
All sketches are plain HTML with inline CSS and JS. No build step, no npm, no framework.
d. Write README.md:
---
sketch: NNN
name: descriptive-name
question: "What layout structure feels right for the dashboard?"
winner: null
tags: [layout, dashboard]
---
# Sketch NNN: Descriptive Name
## Design Question
[The specific visual question this sketch answers]
## How to View
open .planning/sketches/NNN-descriptive-name/index.html
## Variants
- **A: [name]** — [one-line description of this approach]
- **B: [name]** — [one-line description]
- **C: [name]** — [one-line description]
## What to Look For
[Specific things to pay attention to when comparing variants]
e. Present to the user with a checkpoint:
╔══════════════════════════════════════════════════════════════╗ ║ CHECKPOINT: Verification Required ║ ╚══════════════════════════════════════════════════════════════╝
Sketch {NNN}: {name}
Open: open .planning/sketches/NNN-name/index.html
Compare: {what to look for between variants}
────────────────────────────────────────────────────────────── → Which variant feels right? Or cherry-pick elements across variants. ──────────────────────────────────────────────────────────────
f. Handle feedback:
- Pick a direction: mark winner, move to next sketch
- Cherry-pick elements: build synthesis as new variant, show again
- Want more exploration: build new variants
Iterate until satisfied.
g. Finalize:
- Mark winning variant in README frontmatter (
winner: "B") - Add ★ indicator to winning tab in HTML
- Update
.planning/sketches/MANIFEST.md
h. Commit (if COMMIT_DOCS is true):
$GSD_SDK query commit "docs(sketch-NNN): [winning direction] — [key visual insight]" --files .planning/sketches/NNN-descriptive-name/ .planning/sketches/MANIFEST.md
i. Report:
◆ Sketch NNN: {name}
Winner: Variant {X} — {description}
Insight: {key visual decision made}
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
GSD ► SKETCH COMPLETE ✓
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
## Design Direction
{what we landed on overall}
## Key Decisions
{layout, palette, typography, spacing, interaction patterns}
## Open Questions
{anything unresolved or worth revisiting}
───────────────────────────────────────────────────────────────
▶ Next Up
Package findings — wrap design decisions into a reusable skill
/gsd:sketch --wrap-up
───────────────────────────────────────────────────────────────
Also available:
/gsd:sketch— sketch more (or run with no argument for frontier mode)/gsd:plan-phase— start building the real UI/gsd:spike— spike technical feasibility of a design pattern
───────────────────────────────────────────────────────────────
<success_criteria>
.planning/sketches/created (auto-creates if needed, no project init required)- Design direction explored conversationally before any code (unless --quick)
- Spike context loaded — real data shapes, requirements, and conventions inform mockups
- Target stack researched — component availability, constraints, idioms (unless greenfield/skipped)
- Each sketch has 2-3 variants for comparison (at least one follows path of least resistance)
- User can open and interact with sketches in a browser
- Winning variant selected and marked for each sketch
- All variants preserved (winner marked, not others deleted)
- MANIFEST.md is current
- Commits use
docs(sketch-NNN): [winner]format - Summary presented with next-step routing </success_criteria>