* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
196 lines
8.4 KiB
JavaScript
196 lines
8.4 KiB
JavaScript
#!/usr/bin/env node
|
|
// gsd-hook-version: {{GSD_VERSION}}
|
|
// Context Monitor - PostToolUse/AfterTool hook (Gemini uses AfterTool)
|
|
// Reads context metrics from the statusline bridge file and injects
|
|
// warnings when context usage is high. This makes the AGENT aware of
|
|
// context limits (the statusline only shows the user).
|
|
//
|
|
// How it works:
|
|
// 1. The statusline hook writes metrics to /tmp/claude-ctx-{session_id}.json
|
|
// 2. This hook reads those metrics after each tool use
|
|
// 3. When remaining context drops below thresholds, it injects a warning
|
|
// as additionalContext, which the agent sees in its conversation
|
|
//
|
|
// Thresholds:
|
|
// WARNING (remaining <= 35%): Agent should wrap up current task
|
|
// CRITICAL (remaining <= 25%): Agent should stop immediately and save state
|
|
//
|
|
// Debounce: 5 tool uses between warnings to avoid spam
|
|
// Severity escalation bypasses debounce (WARNING -> CRITICAL fires immediately)
|
|
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
const path = require('path');
|
|
const { spawn } = require('child_process');
|
|
|
|
const WARNING_THRESHOLD = 35; // remaining_percentage <= 35%
|
|
const CRITICAL_THRESHOLD = 25; // remaining_percentage <= 25%
|
|
const STALE_SECONDS = 60; // ignore metrics older than 60s
|
|
const DEBOUNCE_CALLS = 5; // min tool uses between warnings
|
|
|
|
let input = '';
|
|
// Timeout guard: if stdin doesn't close within 10s (e.g. pipe issues on
|
|
// Windows/Git Bash, or slow Claude Code piping during large outputs),
|
|
// exit silently instead of hanging until Claude Code kills the process
|
|
// and reports "hook error". See #775, #1162.
|
|
const stdinTimeout = setTimeout(() => process.exit(0), 10000);
|
|
process.stdin.setEncoding('utf8');
|
|
process.stdin.on('data', chunk => input += chunk);
|
|
process.stdin.on('end', () => {
|
|
clearTimeout(stdinTimeout);
|
|
try {
|
|
const data = JSON.parse(input);
|
|
const sessionId = data.session_id;
|
|
|
|
if (!sessionId) {
|
|
process.exit(0);
|
|
}
|
|
|
|
// Reject session IDs that contain path traversal sequences or path separators.
|
|
// session_id is used to construct file paths in /tmp — an unsanitized value
|
|
// could escape the temp directory and read or write arbitrary files.
|
|
if (/[/\\]|\.\./.test(sessionId)) {
|
|
process.exit(0);
|
|
}
|
|
|
|
// Check if context warnings are disabled via config.
|
|
// Collapsed existsSync+readFileSync into a single read guarded by try/catch
|
|
// (ENOENT or parse error → use defaults, same as old "planningDir absent" branch).
|
|
const cwd = data.cwd || process.cwd();
|
|
try {
|
|
const configPath = path.join(cwd, '.planning', 'config.json');
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
if (config.hooks?.context_warnings === false) {
|
|
process.exit(0);
|
|
}
|
|
} catch (e) {
|
|
// Missing or unparseable config → proceed with defaults (context warnings enabled)
|
|
}
|
|
|
|
const tmpDir = os.tmpdir();
|
|
const metricsPath = path.join(tmpDir, `claude-ctx-${sessionId}.json`);
|
|
|
|
// If no metrics file, this is a subagent or fresh session -- exit silently.
|
|
// Collapsed existsSync+readFileSync: ENOENT → exit 0 (identical to old !existsSync branch),
|
|
// other errors rethrow to the outer catch (swallowed → exit 0, as before).
|
|
let metricsRaw;
|
|
try {
|
|
metricsRaw = fs.readFileSync(metricsPath, 'utf8');
|
|
} catch (e) {
|
|
if (e && e.code === 'ENOENT') process.exit(0);
|
|
throw e;
|
|
}
|
|
const metrics = JSON.parse(metricsRaw);
|
|
const now = Math.floor(Date.now() / 1000);
|
|
|
|
// Ignore stale metrics
|
|
if (metrics.timestamp && (now - metrics.timestamp) > STALE_SECONDS) {
|
|
process.exit(0);
|
|
}
|
|
|
|
const remaining = metrics.remaining_percentage;
|
|
const usedPct = metrics.used_pct;
|
|
|
|
// No warning needed
|
|
if (remaining > WARNING_THRESHOLD) {
|
|
process.exit(0);
|
|
}
|
|
|
|
// Debounce: check if we warned recently
|
|
const warnPath = path.join(tmpDir, `claude-ctx-${sessionId}-warned.json`);
|
|
let warnData = { callsSinceWarn: 0, lastLevel: null };
|
|
let firstWarn = true;
|
|
|
|
// Collapsed existsSync+readFileSync: ENOENT or parse error → keep default warnData
|
|
// (same as old "file absent" branch). firstWarn tracks whether we read a valid sentinel.
|
|
try {
|
|
warnData = JSON.parse(fs.readFileSync(warnPath, 'utf8'));
|
|
firstWarn = false;
|
|
} catch (e) {
|
|
// Missing or corrupted sentinel → firstWarn stays true, warnData stays at defaults
|
|
}
|
|
|
|
warnData.callsSinceWarn = (warnData.callsSinceWarn || 0) + 1;
|
|
|
|
const isCritical = remaining <= CRITICAL_THRESHOLD;
|
|
const currentLevel = isCritical ? 'critical' : 'warning';
|
|
|
|
// Emit immediately on first warning, then debounce subsequent ones
|
|
// Severity escalation (WARNING -> CRITICAL) bypasses debounce
|
|
const severityEscalated = currentLevel === 'critical' && warnData.lastLevel === 'warning';
|
|
if (!firstWarn && warnData.callsSinceWarn < DEBOUNCE_CALLS && !severityEscalated) {
|
|
// Update counter and exit without warning
|
|
fs.writeFileSync(warnPath, JSON.stringify(warnData));
|
|
process.exit(0);
|
|
}
|
|
|
|
// Reset debounce counter
|
|
warnData.callsSinceWarn = 0;
|
|
warnData.lastLevel = currentLevel;
|
|
fs.writeFileSync(warnPath, JSON.stringify(warnData));
|
|
|
|
// Detect if GSD is active (has .planning/STATE.md in working directory)
|
|
const isGsdActive = fs.existsSync(path.join(cwd, '.planning', 'STATE.md'));
|
|
|
|
// On CRITICAL with active GSD project, auto-record session state as a
|
|
// breadcrumb for /gsd:resume-work (#1974). Fire-and-forget subprocess —
|
|
// doesn't block the hook or the agent. Fires ONCE per CRITICAL session,
|
|
// guarded by warnData.criticalRecorded to prevent repeated overwrites
|
|
// of the "crash moment" record on every debounce cycle.
|
|
if (isCritical && isGsdActive && !warnData.criticalRecorded) {
|
|
try {
|
|
// Runtime-agnostic path: this hook lives at <runtime-config>/hooks/
|
|
// and gsd-tools.cjs lives at <runtime-config>/gsd-core/bin/.
|
|
// Using __dirname makes this work on Claude Code, OpenCode, Gemini,
|
|
// Kilo, etc. without hardcoding ~/.claude/.
|
|
const gsdTools = path.join(__dirname, '..', 'gsd-core', 'bin', 'gsd-tools.cjs');
|
|
// Coerce usedPct to a safe number in case bridge file is malformed
|
|
const safeUsedPct = Number(usedPct) || 0;
|
|
const stoppedAt = `context exhaustion at ${safeUsedPct}% (${new Date().toISOString().split('T')[0]})`;
|
|
spawn(
|
|
process.execPath,
|
|
[gsdTools, 'state', 'record-session', '--stopped-at', stoppedAt],
|
|
{ cwd, detached: true, stdio: 'ignore' }
|
|
).unref();
|
|
warnData.criticalRecorded = true;
|
|
// Persist the sentinel so subsequent debounce cycles don't re-fire
|
|
fs.writeFileSync(warnPath, JSON.stringify(warnData));
|
|
} catch { /* non-critical — don't let state recording break the hook */ }
|
|
}
|
|
|
|
// Build advisory warning message (never use imperative commands that
|
|
// override user preferences — see #884)
|
|
let message;
|
|
if (isCritical) {
|
|
message = isGsdActive
|
|
? `CONTEXT CRITICAL: Usage at ${usedPct}%. Remaining: ${remaining}%. ` +
|
|
'Context is nearly exhausted. Do NOT start new complex work or write handoff files — ' +
|
|
'GSD state is already tracked in STATE.md. Inform the user so they can run ' +
|
|
'/gsd:pause-work at the next natural stopping point.'
|
|
: `CONTEXT CRITICAL: Usage at ${usedPct}%. Remaining: ${remaining}%. ` +
|
|
'Context is nearly exhausted. Inform the user that context is low and ask how they ' +
|
|
'want to proceed. Do NOT autonomously save state or write handoff files unless the user asks.';
|
|
} else {
|
|
message = isGsdActive
|
|
? `CONTEXT WARNING: Usage at ${usedPct}%. Remaining: ${remaining}%. ` +
|
|
'Context is getting limited. Avoid starting new complex work. If not between ' +
|
|
'defined plan steps, inform the user so they can prepare to pause.'
|
|
: `CONTEXT WARNING: Usage at ${usedPct}%. Remaining: ${remaining}%. ` +
|
|
'Be aware that context is getting limited. Avoid unnecessary exploration or ' +
|
|
'starting new complex work.';
|
|
}
|
|
|
|
const output = {
|
|
hookSpecificOutput: {
|
|
hookEventName: process.env.GEMINI_API_KEY ? "AfterTool" : "PostToolUse",
|
|
additionalContext: message
|
|
}
|
|
};
|
|
|
|
process.stdout.write(JSON.stringify(output));
|
|
} catch (e) {
|
|
// Silent fail -- never block tool execution
|
|
process.exit(0);
|
|
}
|
|
});
|