* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
239 lines
8.7 KiB
JavaScript
239 lines
8.7 KiB
JavaScript
'use strict';
|
|
|
|
// allow-test-rule: source-text-is-the-product
|
|
// Reads .md/.json/.yml product files whose deployed text IS what the
|
|
// runtime loads — testing text content tests the deployed contract.
|
|
|
|
/**
|
|
* Tests for #2430 — LEARNINGS.md consumption loop.
|
|
*
|
|
* Part A: plan-phase.md cross-phase context load includes LEARNINGS.md
|
|
* Part B: transition.md graduation_scan step + graduation.md helper
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const WORKFLOWS_DIR = path.join(__dirname, '../gsd-core/workflows');
|
|
|
|
function readWorkflow(name) {
|
|
return fs.readFileSync(path.join(WORKFLOWS_DIR, name), 'utf-8');
|
|
}
|
|
|
|
describe('enh-2430 Part A — plan-phase LEARNINGS.md context load', () => {
|
|
let content;
|
|
|
|
test('plan-phase.md includes LEARNINGS.md in cross-phase context load', () => {
|
|
content = readWorkflow('plan-phase.md');
|
|
assert.ok(
|
|
content.includes('LEARNINGS.md files from the 3 most recent completed phases'),
|
|
'plan-phase.md must mention LEARNINGS.md in cross-phase context block'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md LEARNINGS load is inside the 1M context-window gate', () => {
|
|
content = content || readWorkflow('plan-phase.md');
|
|
const windowBlock = content.match(/\$\{CONTEXT_WINDOW >= 500000[\s\S]*?\` : ''\}/);
|
|
assert.ok(windowBlock, 'CONTEXT_WINDOW gate block must exist');
|
|
assert.ok(
|
|
windowBlock[0].includes('LEARNINGS.md'),
|
|
'LEARNINGS.md load must be inside the CONTEXT_WINDOW >= 500000 gate'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md source attribution mentioned for LEARNINGS load', () => {
|
|
content = content || readWorkflow('plan-phase.md');
|
|
assert.ok(
|
|
content.includes('[from Phase N LEARNINGS]') || content.includes('source attribution'),
|
|
'plan-phase.md must document source attribution for loaded LEARNINGS.md content'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md handles missing LEARNINGS.md gracefully (silent skip)', () => {
|
|
content = content || readWorkflow('plan-phase.md');
|
|
assert.ok(
|
|
content.includes('skip silently if a phase has no LEARNINGS.md') ||
|
|
content.includes('skip silently'),
|
|
'plan-phase.md must document silent skip when LEARNINGS.md is absent'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md LEARNINGS load includes Depends-on chain', () => {
|
|
content = content || readWorkflow('plan-phase.md');
|
|
const dependsSection = content.match(/Depends on.*?(\n.*?)+/);
|
|
assert.ok(
|
|
content.includes('LEARNINGS.md from any phases listed in'),
|
|
'plan-phase.md must load LEARNINGS.md for Depends on chain phases'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md specifies context budget limit for LEARNINGS', () => {
|
|
content = content || readWorkflow('plan-phase.md');
|
|
assert.ok(
|
|
content.includes('15%') || content.includes('drop oldest'),
|
|
'plan-phase.md must specify budget limit and truncation strategy for LEARNINGS'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('enh-2430 Part B — graduation_scan in transition.md', () => {
|
|
let content;
|
|
|
|
test('transition.md contains graduation_scan step', () => {
|
|
content = readWorkflow('transition.md');
|
|
assert.ok(
|
|
content.includes('graduation_scan'),
|
|
'transition.md must contain graduation_scan step'
|
|
);
|
|
});
|
|
|
|
test('graduation_scan is placed after evolve_project step', () => {
|
|
content = content || readWorkflow('transition.md');
|
|
const evolvePos = content.indexOf('name="evolve_project"');
|
|
const graduationPos = content.indexOf('name="graduation_scan"');
|
|
assert.ok(evolvePos >= 0, 'evolve_project step must exist');
|
|
assert.ok(graduationPos >= 0, 'graduation_scan step must exist');
|
|
assert.ok(
|
|
graduationPos > evolvePos,
|
|
'graduation_scan must appear after evolve_project in transition.md'
|
|
);
|
|
});
|
|
|
|
test('graduation_scan is non-blocking (transition continues regardless)', () => {
|
|
content = content || readWorkflow('transition.md');
|
|
const scanBlock = content.match(/name="graduation_scan"[\s\S]*?<\/step>/);
|
|
assert.ok(scanBlock, 'graduation_scan step must be parseable');
|
|
assert.ok(
|
|
scanBlock[0].includes('non-blocking') || scanBlock[0].includes('always non-blocking'),
|
|
'graduation_scan must be documented as non-blocking'
|
|
);
|
|
});
|
|
|
|
test('graduation_scan delegates to graduation.md helper', () => {
|
|
content = content || readWorkflow('transition.md');
|
|
assert.ok(
|
|
content.includes('graduation.md'),
|
|
'graduation_scan must reference graduation.md helper workflow'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('enh-2430 Part B — graduation.md helper workflow', () => {
|
|
let content;
|
|
|
|
test('graduation.md exists', () => {
|
|
content = readWorkflow('graduation.md');
|
|
assert.ok(content.length > 0, 'graduation.md must exist and be non-empty');
|
|
});
|
|
|
|
test('graduation.md documents features.graduation config flag', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('features.graduation'),
|
|
'graduation.md must document features.graduation config flag'
|
|
);
|
|
});
|
|
|
|
test('graduation.md documents graduation_window config', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('graduation_window'),
|
|
'graduation.md must document features.graduation_window config'
|
|
);
|
|
});
|
|
|
|
test('graduation.md documents graduation_threshold config', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('graduation_threshold'),
|
|
'graduation.md must document features.graduation_threshold config'
|
|
);
|
|
});
|
|
|
|
test('graduation.md specifies HITL: Promote / Defer / Dismiss', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(content.includes('Promote'), 'graduation.md must document Promote action');
|
|
assert.ok(content.includes('Defer'), 'graduation.md must document Defer action');
|
|
assert.ok(content.includes('Dismiss'), 'graduation.md must document Dismiss action');
|
|
});
|
|
|
|
test('graduation.md specifies category→target routing', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('PROJECT.md') && content.includes('PATTERNS.md'),
|
|
'graduation.md must route categories to appropriate target files'
|
|
);
|
|
});
|
|
|
|
test('graduation.md specifies graduation_backlog in STATE.md', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('graduation_backlog'),
|
|
'graduation.md must document STATE.md graduation_backlog for Defer/Dismiss'
|
|
);
|
|
});
|
|
|
|
test('graduation.md skips items with graduated: annotation', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('graduated:') || content.includes('Graduated:'),
|
|
'graduation.md must skip already-graduated items'
|
|
);
|
|
});
|
|
|
|
test('graduation.md has silent no-op for first phase / insufficient data', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('no-op') || content.includes('silent'),
|
|
'graduation.md must silently no-op when there is insufficient data'
|
|
);
|
|
});
|
|
|
|
test('graduation.md specifies Defer-all shorthand (A key)', () => {
|
|
content = content || readWorkflow('graduation.md');
|
|
assert.ok(
|
|
content.includes('Defer all') || content.includes('[Defer all]'),
|
|
'graduation.md must document the Defer all shorthand for first-run batches'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('enh-2430 — extract-learnings.md graduated: field', () => {
|
|
test('extract-learnings.md documents optional graduated: annotation', () => {
|
|
const content = readWorkflow('extract-learnings.md');
|
|
assert.ok(
|
|
content.includes('graduated:') || content.includes('Graduated:'),
|
|
'extract-learnings.md must document optional graduated: field'
|
|
);
|
|
});
|
|
|
|
test('extract-learnings.md clarifies graduated: is written only by graduation workflow', () => {
|
|
const content = readWorkflow('extract-learnings.md');
|
|
assert.ok(
|
|
content.includes('graduation workflow') || content.includes('graduation.md'),
|
|
'extract-learnings.md must clarify that graduated: is written only by graduation.md'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('enh-2430 — INVENTORY sync', () => {
|
|
test('INVENTORY.md lists graduation.md', () => {
|
|
const inventory = fs.readFileSync(
|
|
path.join(__dirname, '../docs/INVENTORY.md'), 'utf-8'
|
|
);
|
|
assert.ok(inventory.includes('graduation.md'), 'INVENTORY.md must list graduation.md');
|
|
});
|
|
|
|
test('INVENTORY-MANIFEST.json includes graduation.md', () => {
|
|
const manifest = JSON.parse(
|
|
fs.readFileSync(path.join(__dirname, '../docs/INVENTORY-MANIFEST.json'), 'utf-8')
|
|
);
|
|
assert.ok(
|
|
manifest.families.workflows.includes('graduation.md'),
|
|
'INVENTORY-MANIFEST.json must include graduation.md in workflows array'
|
|
);
|
|
});
|
|
});
|