* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
291 lines
11 KiB
JavaScript
291 lines
11 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Reads .md/.json/.yml product files whose deployed text IS what the
|
|
// runtime loads — testing text content tests the deployed contract.
|
|
|
|
/**
|
|
* Profile Output Tests
|
|
*
|
|
* Tests for profile rendering commands and PROFILING_QUESTIONS data.
|
|
*/
|
|
|
|
const { test, describe, beforeEach, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { runGsdTools, createTempProject, createTempGitProject, cleanup } = require('./helpers.cjs');
|
|
|
|
const {
|
|
PROFILING_QUESTIONS,
|
|
CLAUDE_INSTRUCTIONS,
|
|
} = require('../gsd-core/bin/lib/profile-output.cjs');
|
|
|
|
// ─── PROFILING_QUESTIONS data ─────────────────────────────────────────────────
|
|
|
|
describe('PROFILING_QUESTIONS', () => {
|
|
test('is a non-empty array', () => {
|
|
assert.ok(Array.isArray(PROFILING_QUESTIONS));
|
|
assert.ok(PROFILING_QUESTIONS.length > 0);
|
|
});
|
|
|
|
test('each question has required fields', () => {
|
|
for (const q of PROFILING_QUESTIONS) {
|
|
assert.ok(q.dimension, `question missing dimension`);
|
|
assert.ok(q.header, `${q.dimension} missing header`);
|
|
assert.ok(q.question, `${q.dimension} missing question`);
|
|
assert.ok(Array.isArray(q.options), `${q.dimension} options should be array`);
|
|
assert.ok(q.options.length >= 2, `${q.dimension} should have at least 2 options`);
|
|
}
|
|
});
|
|
|
|
test('each option has label, value, and rating', () => {
|
|
for (const q of PROFILING_QUESTIONS) {
|
|
for (const opt of q.options) {
|
|
assert.ok(opt.label, `${q.dimension} option missing label`);
|
|
assert.ok(opt.value, `${q.dimension} option missing value`);
|
|
assert.ok(opt.rating, `${q.dimension} option missing rating`);
|
|
}
|
|
}
|
|
});
|
|
|
|
test('all dimension keys are unique', () => {
|
|
const dims = PROFILING_QUESTIONS.map(q => q.dimension);
|
|
const unique = [...new Set(dims)];
|
|
assert.strictEqual(dims.length, unique.length);
|
|
});
|
|
});
|
|
|
|
// ─── CLAUDE_INSTRUCTIONS ──────────────────────────────────────────────────────
|
|
|
|
describe('CLAUDE_INSTRUCTIONS', () => {
|
|
test('is a non-empty object', () => {
|
|
assert.ok(typeof CLAUDE_INSTRUCTIONS === 'object');
|
|
assert.ok(Object.keys(CLAUDE_INSTRUCTIONS).length > 0);
|
|
});
|
|
|
|
test('each dimension has at least one instruction', () => {
|
|
for (const [dim, instructions] of Object.entries(CLAUDE_INSTRUCTIONS)) {
|
|
assert.ok(typeof instructions === 'object', `${dim} should be an object`);
|
|
assert.ok(Object.keys(instructions).length > 0, `${dim} should have instructions`);
|
|
}
|
|
});
|
|
|
|
test('every PROFILING_QUESTIONS dimension has CLAUDE_INSTRUCTIONS', () => {
|
|
for (const q of PROFILING_QUESTIONS) {
|
|
assert.ok(
|
|
CLAUDE_INSTRUCTIONS[q.dimension],
|
|
`${q.dimension} has questions but no CLAUDE_INSTRUCTIONS`
|
|
);
|
|
}
|
|
});
|
|
});
|
|
|
|
// ─── write-profile command ────────────────────────────────────────────────────
|
|
|
|
describe('write-profile command', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempProject();
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('writes USER-PROFILE.md from analysis JSON', () => {
|
|
const analysis = {
|
|
profile_version: '1.0',
|
|
dimensions: {
|
|
communication_style: { rating: 'terse-direct', confidence: 'HIGH' },
|
|
decision_speed: { rating: 'fast-intuitive', confidence: 'MEDIUM' },
|
|
explanation_depth: { rating: 'concise', confidence: 'HIGH' },
|
|
debugging_approach: { rating: 'fix-first', confidence: 'LOW' },
|
|
ux_philosophy: { rating: 'function-first', confidence: 'MEDIUM' },
|
|
vendor_philosophy: { rating: 'pragmatic', confidence: 'HIGH' },
|
|
frustration_triggers: { rating: 'over-explanation', confidence: 'LOW' },
|
|
learning_style: { rating: 'hands-on', confidence: 'MEDIUM' },
|
|
},
|
|
};
|
|
|
|
const analysisPath = path.join(tmpDir, 'analysis.json');
|
|
fs.writeFileSync(analysisPath, JSON.stringify(analysis));
|
|
|
|
const result = runGsdTools(['write-profile', '--input', analysisPath, '--raw'], tmpDir, { HOME: tmpDir });
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
const out = JSON.parse(result.output);
|
|
assert.ok(out.profile_path, 'should return profile_path');
|
|
assert.ok(out.dimensions_scored > 0, 'should have scored dimensions');
|
|
});
|
|
|
|
test('errors when --input is missing', () => {
|
|
const result = runGsdTools('write-profile --raw', tmpDir);
|
|
assert.ok(!result.success, 'should fail without --input');
|
|
assert.ok(result.error.includes('--input'), 'should mention --input');
|
|
});
|
|
});
|
|
|
|
// ─── generate-claude-md command ───────────────────────────────────────────────
|
|
|
|
describe('generate-claude-md command', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempGitProject();
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning', 'PROJECT.md'),
|
|
'# My Project\n\nA test project.\n\n## Tech Stack\n\n- Node.js\n- TypeScript\n'
|
|
);
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('generates CLAUDE.md with --auto flag', () => {
|
|
const outputPath = path.join(tmpDir, 'CLAUDE.md');
|
|
const result = runGsdTools(['generate-claude-md', '--output', outputPath, '--auto', '--raw'], tmpDir);
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
|
|
if (fs.existsSync(outputPath)) {
|
|
const content = fs.readFileSync(outputPath, 'utf-8');
|
|
assert.ok(content.length > 0, 'should have content');
|
|
}
|
|
});
|
|
|
|
test('does not overwrite existing CLAUDE.md without --force', () => {
|
|
const outputPath = path.join(tmpDir, 'CLAUDE.md');
|
|
fs.writeFileSync(outputPath, '# Custom CLAUDE.md\n\nUser content.\n');
|
|
|
|
const result = runGsdTools(['generate-claude-md', '--output', outputPath, '--auto', '--raw'], tmpDir);
|
|
// Should merge, not overwrite
|
|
const content = fs.readFileSync(outputPath, 'utf-8');
|
|
assert.ok(content.length > 0, 'should still have content');
|
|
});
|
|
|
|
test('skills fallback mentions the normalized project roots', () => {
|
|
const result = runGsdTools('generate-claude-md', tmpDir);
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
|
|
const content = fs.readFileSync(path.join(tmpDir, 'CLAUDE.md'), 'utf-8');
|
|
assert.ok(content.includes('.claude/skills/'));
|
|
assert.ok(content.includes('.agents/skills/'));
|
|
assert.ok(content.includes('.cursor/skills/'));
|
|
assert.ok(content.includes('.github/skills/'));
|
|
assert.ok(content.includes('.codex/skills/'));
|
|
assert.ok(!content.includes('gsd-core/skills'));
|
|
});
|
|
|
|
test('codex runtime aliases default output to AGENTS.md', () => {
|
|
const result = runGsdTools(
|
|
['generate-claude-md', '--auto', '--raw'],
|
|
tmpDir,
|
|
{ GSD_RUNTIME: 'codex-cli' }
|
|
);
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
assert.ok(fs.existsSync(path.join(tmpDir, 'AGENTS.md')), 'AGENTS.md should be generated for codex aliases');
|
|
});
|
|
});
|
|
|
|
// ─── generate-dev-preferences ─────────────────────────────────────────────────
|
|
|
|
describe('generate-dev-preferences command', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempProject();
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('errors when --analysis is missing', () => {
|
|
const result = runGsdTools('generate-dev-preferences --raw', tmpDir);
|
|
assert.ok(!result.success, 'should fail without --analysis');
|
|
assert.ok(result.error.includes('--analysis'), 'should mention --analysis');
|
|
});
|
|
|
|
test('generates preferences from analysis file', () => {
|
|
const analysis = {
|
|
profile_version: '1.0',
|
|
dimensions: {
|
|
communication_style: { rating: 'terse-direct', confidence: 'HIGH' },
|
|
decision_speed: { rating: 'fast-intuitive', confidence: 'MEDIUM' },
|
|
},
|
|
};
|
|
const analysisPath = path.join(tmpDir, 'analysis.json');
|
|
fs.writeFileSync(analysisPath, JSON.stringify(analysis));
|
|
|
|
const result = runGsdTools(
|
|
['generate-dev-preferences', '--analysis', analysisPath, '--raw'],
|
|
tmpDir,
|
|
{ HOME: tmpDir }
|
|
);
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
const out = JSON.parse(result.output);
|
|
assert.ok(out.command_path || out.command_name, 'should return command output');
|
|
});
|
|
|
|
test('uses runtime-aware skills dir for codex by default', () => {
|
|
const analysis = {
|
|
profile_version: '1.0',
|
|
dimensions: {
|
|
communication_style: { rating: 'terse-direct', confidence: 'HIGH' },
|
|
},
|
|
};
|
|
const analysisPath = path.join(tmpDir, 'analysis.json');
|
|
const codexHome = path.join(tmpDir, 'codex-home');
|
|
fs.writeFileSync(analysisPath, JSON.stringify(analysis));
|
|
|
|
const result = runGsdTools(
|
|
['generate-dev-preferences', '--analysis', analysisPath, '--raw'],
|
|
tmpDir,
|
|
{ CODEX_HOME: codexHome, GSD_RUNTIME: 'codex' }
|
|
);
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
const out = JSON.parse(result.output);
|
|
assert.strictEqual(out.command_path, path.join(codexHome, 'skills', 'gsd-dev-preferences', 'SKILL.md'));
|
|
assert.ok(fs.existsSync(out.command_path), 'runtime-aware output should be written');
|
|
});
|
|
|
|
test('canonicalizes codex runtime aliases for skills output path', () => {
|
|
const analysis = {
|
|
profile_version: '1.0',
|
|
dimensions: {
|
|
communication_style: { rating: 'terse-direct', confidence: 'HIGH' },
|
|
},
|
|
};
|
|
const analysisPath = path.join(tmpDir, 'analysis.json');
|
|
const codexHome = path.join(tmpDir, 'codex-home');
|
|
fs.writeFileSync(analysisPath, JSON.stringify(analysis));
|
|
|
|
const result = runGsdTools(
|
|
['generate-dev-preferences', '--analysis', analysisPath, '--raw'],
|
|
tmpDir,
|
|
{ CODEX_HOME: codexHome, GSD_RUNTIME: 'codex-app' }
|
|
);
|
|
assert.ok(result.success, `Failed: ${result.error}`);
|
|
const out = JSON.parse(result.output);
|
|
assert.strictEqual(out.command_path, path.join(codexHome, 'skills', 'gsd-dev-preferences', 'SKILL.md'));
|
|
});
|
|
|
|
test('errors for cline unless --output is supplied', () => {
|
|
const analysis = {
|
|
profile_version: '1.0',
|
|
dimensions: {
|
|
communication_style: { rating: 'terse-direct', confidence: 'HIGH' },
|
|
},
|
|
};
|
|
const analysisPath = path.join(tmpDir, 'analysis.json');
|
|
fs.writeFileSync(analysisPath, JSON.stringify(analysis));
|
|
|
|
const result = runGsdTools(
|
|
['generate-dev-preferences', '--analysis', analysisPath, '--raw'],
|
|
tmpDir,
|
|
{ GSD_RUNTIME: 'cline' }
|
|
);
|
|
assert.ok(!result.success, 'cline should require explicit --output');
|
|
assert.ok(result.error.includes('does not use a skills directory'), 'should explain unsupported runtime');
|
|
});
|
|
});
|