918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
85 lines
3.7 KiB
JavaScript
85 lines
3.7 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* GSD Tools Tests - chain flag preservation in plan-phase
|
|
*
|
|
* Validates that plan-phase.md correctly handles the --chain flag
|
|
* so that discuss→plan→execute auto-advance works without manual
|
|
* intervention.
|
|
*
|
|
* Closes: #1620
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('plan-phase chain flag preservation (#1620)', () => {
|
|
const planPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'plan-phase.md');
|
|
const discussPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'discuss-phase.md');
|
|
// After #2551, discuss-phase chain logic moved to modes/chain.md.
|
|
const discussChainPath = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'discuss-phase', 'modes', 'chain.md');
|
|
const readDiscuss = () => {
|
|
// Fail loudly if either source is missing — silent filtering would let a
|
|
// regression that deletes modes/chain.md pass this whole suite.
|
|
assert.ok(fs.existsSync(discussPath), `discuss-phase.md missing: ${discussPath}`);
|
|
assert.ok(fs.existsSync(discussChainPath), `discuss-phase/modes/chain.md missing after #2551 split: ${discussChainPath}`);
|
|
return [discussPath, discussChainPath].map(p => fs.readFileSync(p, 'utf8')).join('\n');
|
|
};
|
|
|
|
test('plan-phase sync-flag guard checks both --auto AND --chain', () => {
|
|
const content = fs.readFileSync(planPath, 'utf8');
|
|
// The guard that clears _auto_chain_active must require BOTH flags to be absent
|
|
assert.ok(
|
|
content.includes('if [[ ! "$ARGUMENTS" =~ --auto ]] && [[ ! "$ARGUMENTS" =~ --chain ]]; then'),
|
|
'plan-phase should check for both --auto and --chain before clearing chain flag'
|
|
);
|
|
});
|
|
|
|
test('plan-phase persists chain flag to config before auto-advancing', () => {
|
|
const content = fs.readFileSync(planPath, 'utf8');
|
|
// Plan-phase must persist the chain flag (config-set workflow._auto_chain_active true)
|
|
assert.ok(
|
|
content.includes('config-set workflow._auto_chain_active true'),
|
|
'plan-phase should persist chain flag via config-set workflow._auto_chain_active true'
|
|
);
|
|
});
|
|
|
|
test('plan-phase and discuss-phase use the same guard pattern for clearing _auto_chain_active', () => {
|
|
const planContent = fs.readFileSync(planPath, 'utf8');
|
|
const discussContent = readDiscuss();
|
|
|
|
const guardPattern = 'if [[ ! "$ARGUMENTS" =~ --auto ]] && [[ ! "$ARGUMENTS" =~ --chain ]]; then';
|
|
|
|
assert.ok(
|
|
planContent.includes(guardPattern),
|
|
'plan-phase should use the dual-flag guard pattern'
|
|
);
|
|
assert.ok(
|
|
discussContent.includes(guardPattern),
|
|
'discuss-phase (or discuss-phase/modes/chain.md after #2551 split) should use the dual-flag guard pattern'
|
|
);
|
|
});
|
|
|
|
test('plan-phase auto-advance trigger includes --chain flag', () => {
|
|
const content = fs.readFileSync(planPath, 'utf8');
|
|
// The trigger condition should mention --chain alongside --auto
|
|
assert.ok(
|
|
content.includes('`--auto` or `--chain` flag present OR `AUTO_CHAIN` is true OR `AUTO_CFG` is true'),
|
|
'plan-phase auto-advance trigger should check for --chain flag'
|
|
);
|
|
});
|
|
|
|
test('plan-phase parses both --auto and --chain flags', () => {
|
|
const content = fs.readFileSync(planPath, 'utf8');
|
|
assert.ok(
|
|
content.includes('Parse `--auto` and `--chain` flags from $ARGUMENTS'),
|
|
'plan-phase step 15 should parse both --auto and --chain flags'
|
|
);
|
|
});
|
|
});
|