* feat(#2790): consolidate 86 gsd-* skills to 59 — zero functional loss Closes #2790 - `capture.md` — absorbs add-todo (default), note (--note), add-backlog (--backlog), plant-seed (--seed), check-todos (--list) - `phase.md` — absorbs add-phase (default), insert-phase (--insert), remove-phase (--remove), edit-phase (--edit) - `config.md` — absorbs settings-advanced (--advanced), settings-integrations (--integrations), set-profile (--profile); settings.md retained as-is - `workspace.md` — absorbs new-workspace (--new), list-workspaces (--list), remove-workspace (--remove) - `update.md` — adds --sync (absorbs sync-skills) and --reapply (absorbs reapply-patches) - `sketch.md` — adds --wrap-up (absorbs sketch-wrap-up) - `spike.md` — adds --wrap-up (absorbs spike-wrap-up) - `map-codebase.md` — adds --fast (absorbs scan) and --query (absorbs intel) - `code-review.md` — adds --fix (absorbs code-review-fix) - `progress.md` — adds --next (absorbs next) and --do (absorbs do) join-discord, research-phase, session-report, from-gsd2, analyze-dependencies, list-phase-assumptions, plan-milestone-gaps autonomous.md: updated Skill(skill="gsd:code-review-fix") → Skill(skill="gsd:code-review", args="--fix --auto") to match the consolidated skill name - New: tests/enh-2790-skill-consolidation.test.cjs (48 tests) - Updated: 14 existing test files redirected from deleted command paths to their consolidated equivalents - docs/INVENTORY.md: Commands count 86→59, ghost rows removed, new consolidated rows added - docs/INVENTORY-MANIFEST.json: regenerated to match filesystem Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs(#2790): add CHANGELOG entry for skill consolidation * docs(#2790): update COMMANDS.md for 86→59 skill consolidation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#2790): address CodeRabbit review findings - CHANGELOG.md: add --next alongside --do in progress flag list - config.md: remove trailing space from --profile code span (MD038) - COMMANDS.md: add required descriptions to /gsd-phase examples; /gsd-phase without args errors, not interactive - COMMANDS.md: add --next and --do to /gsd-progress flags table + examples - test: convert content.includes('--reapply') to structural frontmatter parse; add allow-test-rule comment for workflow content assertions - test: replace redundant existsSync duplicate with assertion that verifies the full consolidated flag surface (--sync | --reapply) in argument-hint Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#2790): restore reapply-patches workflow and strengthen test assertions - Create get-shit-done/workflows/reapply-patches.md: the #2790 consolidation deleted the 14K combined command+workflow file (reapply-patches.md) but update.md already referenced the workflow via execution_context_extended. Restoring it fixes a silent behavioral gap where --reapply had no workflow to load. Includes full three-way merge logic, hunk verification table (Step 4), and the Hunk Verification Gate (Step 5) that blocks cleanup until all user-added hunks are confirmed present in the merged output. - Fix update.md: /gsd-reapply-patches → /gsd-update --reapply (stale ref) - Fix reapply-verify-hunks.test.cjs: was checking existsSync(update.md) 8×; now points to the workflow file and asserts real behavioral content (Post-merge verification, Hunk presence check, Line-count check, backup reference, per-file tracking, structural ordering) - Fix reapply-patches.test.cjs: replace content.includes() stubs with frontmatter-parsed argument-hint assertions; replace 4 existsSync(update.md) no-ops with real assertions against the workflow content - Fix edit-phase.test.cjs: /gsd-edit-phase → /gsd-phase (COMMANDS.md now documents the consolidated command with --edit flag) - Fix next-safety-gates.test.cjs: split OR predicates into independent assertions — --next in progress.md and --force in next.md workflow - Fix workspace.test.cjs: add allow-test-rule comment for routing content checks (command routing text IS the deployed behavioral contract) - Fix bug-2439 test: strengthen pre-flight assertion to verify gsd-sdk is referenced (not just --profile) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address CodeRabbit review findings (CR round 2) - INVENTORY.md: update sync-skills.md row to reference /gsd-update --sync instead of stale /gsd-sync-skills (absorbed in #2790) - enh-2380-sync-skills.test.cjs: align INVENTORY.md assertion with the corrected reference; was asserting the old /gsd-sync-skills name while the manifest test correctly asserted /gsd-update, creating conflicting expectations in the same suite - reapply-verify-hunks.test.cjs: add explicit notEqual(-1) assertions for all three anchors before the ordering check so a missing anchor produces a clear failure instead of a false positive (writeIdx=-1 < verifyIdx=5 is true) - bug-2439-set-profile-gsd-sdk-preflight.test.cjs: defer fs.readFileSync until after the existence assertion; eager describe-level read caused the suite to crash before the existence test could run, making it effectively dead code Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#2790): address CR — INVENTORY routing + reapply test contract wording Two unresolved CodeRabbit findings (Major): - docs/INVENTORY.md: workflow-file table still pointed at obsolete /gsd-do, /gsd-next, /gsd-note, /gsd-add-todo, /gsd-add-backlog, /gsd-check-todos, /gsd-plant-seed slash commands. Re-route to the consolidated /gsd-progress (--next, --do) and /gsd-capture (--note, --backlog, --seed, --list) so the inventory is internally consistent. - tests/reapply-verify-hunks.test.cjs: 'verification tracks per-file status' asserted on phrasing that doesn't appear in reapply-patches.md (the 'per-file' substring only matched accidentally via 'sequential integer per file'). Switch to the actual contract text — Hunk Verification Table, one row per hunk per file, verified column. * test(#2790): update CR-INTEGRATION tests for consolidated --fix invocation After the merge of main (which carries #2843's hyphen-form fix), the consolidation in this branch absorbs gsd-code-review-fix into gsd-code-review as the --fix flag. Update the two CR-INTEGRATION tests that previously asserted on the standalone gsd-code-review-fix skill name to instead assert on a gsd-code-review invocation carrying --fix in its arg tokens. Tests still parse Skill() invocations structurally; only the asserted skill-name + arg-token shape changed. * test(#2790): scope success_criteria check to the <success_criteria> block CodeRabbit nitpick: 'success criteria includes verification' did a whole-file substring check, which can false-pass if the phrase appears elsewhere in the document. Extract the <success_criteria>...</success_criteria> block first via extractTagBlock() and assert against that scope only. * fix(#2790): post-rebase reconciliation with main - INVENTORY.md/JSON: add reapply-patches workflow row + bump count to 85 - autonomous.md: switch consolidated --fix invocation to hyphen Skill name - analyze-dependencies test: assert COMMANDS.md does NOT document the consolidated-away /gsd-analyze-dependencies entry (was: bare .includes()) * fix(#2790): address remaining CR findings — strengthen contract tests Doc-fixes: - INVENTORY.md: route transition.md & edit-phase.md rows to consolidated /gsd-progress --next and /gsd-phase --edit (was: deleted /gsd-next, /gsd-edit-phase) - config.md --profile branch: document #2439 pre-flight `command -v gsd-sdk` guard + install hint BEFORE the gsd-sdk invocation (closes opaque "command not found: gsd-sdk" regression path) Test discipline (no-source-grep contract): - bug-2439: replace bare `content.includes('gsd-sdk')` with structured parse of <context> block + --profile branch; assert pre-flight token, install hint, #2439 citation, and ordering vs gsd-sdk invocation - edit-phase: parse INVENTORY.md edit-phase.md row's "Invoked by" column and assert `/gsd-phase --edit` (not the deleted /gsd-edit-phase) - next-safety-gates: tighten `--next` documentation contract — require --next AND --force AND completeness routing (was OR-based, passed when only --next present) - reapply-patches: parse argument-hint flag list structurally; scan ALL <execution_context*> blocks for the @-include of reapply-patches.md; parse Hunk Verification Table header columns directly; locate Step 5 via heading parsing then assert (i) table reference, (ii) verified=no gate, (iii) STOP/halt directive, (iv) explicit absent-table halt path - workspace: parse frontmatter, tokenize argument-hint across multiple bracketed segments, parse @-include targets from <execution_context> rather than substring-matching the file body --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
269 lines
9.6 KiB
JavaScript
269 lines
9.6 KiB
JavaScript
/**
|
|
* GSD Tools Tests - Kilo Install Plumbing
|
|
*
|
|
* Tests for Kilo runtime directory resolution, config paths,
|
|
* permission config, and installer source integration.
|
|
*/
|
|
|
|
process.env.GSD_TEST_MODE = '1';
|
|
|
|
const { test, describe, beforeEach, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const os = require('node:os');
|
|
|
|
const { createTempProject, cleanup } = require('./helpers.cjs');
|
|
const {
|
|
getDirName,
|
|
getGlobalDir,
|
|
getConfigDirFromHome,
|
|
resolveKiloConfigPath,
|
|
configureKiloPermissions,
|
|
} = require('../bin/install.js');
|
|
|
|
describe('getDirName (Kilo)', () => {
|
|
test('returns .kilo for kilo', () => {
|
|
assert.strictEqual(getDirName('kilo'), '.kilo');
|
|
});
|
|
});
|
|
|
|
describe('getConfigDirFromHome (Kilo)', () => {
|
|
test('returns .kilo for local installs', () => {
|
|
assert.strictEqual(getConfigDirFromHome('kilo', false), "'.kilo'");
|
|
});
|
|
|
|
test('returns .config, kilo for global installs', () => {
|
|
assert.strictEqual(getConfigDirFromHome('kilo', true), "'.config', 'kilo'");
|
|
});
|
|
});
|
|
|
|
describe('getGlobalDir (Kilo)', () => {
|
|
let savedEnv;
|
|
|
|
beforeEach(() => {
|
|
savedEnv = {
|
|
KILO_CONFIG_DIR: process.env.KILO_CONFIG_DIR,
|
|
KILO_CONFIG: process.env.KILO_CONFIG,
|
|
XDG_CONFIG_HOME: process.env.XDG_CONFIG_HOME,
|
|
};
|
|
|
|
delete process.env.KILO_CONFIG_DIR;
|
|
delete process.env.KILO_CONFIG;
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (savedEnv.KILO_CONFIG_DIR === undefined) {
|
|
delete process.env.KILO_CONFIG_DIR;
|
|
} else {
|
|
process.env.KILO_CONFIG_DIR = savedEnv.KILO_CONFIG_DIR;
|
|
}
|
|
|
|
if (savedEnv.KILO_CONFIG === undefined) {
|
|
delete process.env.KILO_CONFIG;
|
|
} else {
|
|
process.env.KILO_CONFIG = savedEnv.KILO_CONFIG;
|
|
}
|
|
|
|
if (savedEnv.XDG_CONFIG_HOME === undefined) {
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
} else {
|
|
process.env.XDG_CONFIG_HOME = savedEnv.XDG_CONFIG_HOME;
|
|
}
|
|
});
|
|
|
|
test('returns ~/.config/kilo by default', () => {
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), '.config', 'kilo'));
|
|
});
|
|
|
|
test('respects KILO_CONFIG_DIR env var', () => {
|
|
process.env.KILO_CONFIG_DIR = '~/custom-kilo';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'custom-kilo'));
|
|
});
|
|
|
|
test('falls back to XDG_CONFIG_HOME/kilo', () => {
|
|
process.env.XDG_CONFIG_HOME = '~/xdg-config';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'xdg-config', 'kilo'));
|
|
});
|
|
|
|
test('uses dirname(KILO_CONFIG) when KILO_CONFIG_DIR is unset', () => {
|
|
process.env.KILO_CONFIG = '~/profiles/work/kilo.jsonc';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'profiles', 'work'));
|
|
});
|
|
|
|
test('KILO_CONFIG_DIR takes precedence over KILO_CONFIG', () => {
|
|
process.env.KILO_CONFIG_DIR = '~/custom-kilo';
|
|
process.env.KILO_CONFIG = '~/profiles/work/kilo.jsonc';
|
|
assert.strictEqual(getGlobalDir('kilo'), path.join(os.homedir(), 'custom-kilo'));
|
|
});
|
|
|
|
test('explicit config-dir overrides env vars', () => {
|
|
process.env.KILO_CONFIG_DIR = '~/from-env';
|
|
process.env.XDG_CONFIG_HOME = '~/xdg-config';
|
|
assert.strictEqual(getGlobalDir('kilo', '/explicit/kilo'), '/explicit/kilo');
|
|
});
|
|
});
|
|
|
|
describe('Kilo config file helpers', () => {
|
|
let tmpDir;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempProject('gsd-kilo-');
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('resolveKiloConfigPath prefers kilo.jsonc when present', () => {
|
|
const configDir = path.join(tmpDir, '.kilo');
|
|
fs.mkdirSync(configDir, { recursive: true });
|
|
fs.writeFileSync(path.join(configDir, 'kilo.jsonc'), '{\n // comment\n}\n');
|
|
|
|
assert.strictEqual(resolveKiloConfigPath(configDir), path.join(configDir, 'kilo.jsonc'));
|
|
});
|
|
|
|
test('resolveKiloConfigPath falls back to kilo.json', () => {
|
|
const configDir = path.join(tmpDir, '.kilo');
|
|
fs.mkdirSync(configDir, { recursive: true });
|
|
|
|
assert.strictEqual(resolveKiloConfigPath(configDir), path.join(configDir, 'kilo.json'));
|
|
});
|
|
});
|
|
|
|
describe('configureKiloPermissions', () => {
|
|
let tmpDir;
|
|
let configDir;
|
|
let savedEnv;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = createTempProject('gsd-kilo-perms-');
|
|
configDir = path.join(tmpDir, '.config', 'kilo');
|
|
savedEnv = {
|
|
KILO_CONFIG_DIR: process.env.KILO_CONFIG_DIR,
|
|
XDG_CONFIG_HOME: process.env.XDG_CONFIG_HOME,
|
|
};
|
|
process.env.KILO_CONFIG_DIR = configDir;
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (savedEnv.KILO_CONFIG_DIR === undefined) {
|
|
delete process.env.KILO_CONFIG_DIR;
|
|
} else {
|
|
process.env.KILO_CONFIG_DIR = savedEnv.KILO_CONFIG_DIR;
|
|
}
|
|
|
|
if (savedEnv.XDG_CONFIG_HOME === undefined) {
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
} else {
|
|
process.env.XDG_CONFIG_HOME = savedEnv.XDG_CONFIG_HOME;
|
|
}
|
|
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('writes GSD permissions to kilo.json when config is missing', () => {
|
|
configureKiloPermissions(true);
|
|
|
|
const configPath = path.join(configDir, 'kilo.json');
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${configDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
|
|
test('updates existing kilo.jsonc configs via JSONC parsing', () => {
|
|
fs.mkdirSync(configDir, { recursive: true });
|
|
const configPath = path.join(configDir, 'kilo.jsonc');
|
|
fs.writeFileSync(configPath, '{\n // existing config\n "permission": {\n "bash": "ask",\n },\n}\n');
|
|
|
|
configureKiloPermissions(true);
|
|
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${configDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.bash, 'ask');
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
|
|
test('writes permissions to an explicit config dir argument', () => {
|
|
const explicitDir = path.join(tmpDir, 'custom-kilo-config');
|
|
|
|
configureKiloPermissions(true, explicitDir);
|
|
|
|
const configPath = path.join(explicitDir, 'kilo.json');
|
|
const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
const gsdPath = `${explicitDir.replace(/\\/g, '/')}/get-shit-done/*`;
|
|
|
|
assert.strictEqual(config.permission.read[gsdPath], 'allow');
|
|
assert.strictEqual(config.permission.external_directory[gsdPath], 'allow');
|
|
});
|
|
});
|
|
|
|
describe('Source code integration (Kilo)', () => {
|
|
const src = fs.readFileSync(path.join(__dirname, '..', 'bin', 'install.js'), 'utf8');
|
|
const updateWorkflowSrc = fs.readFileSync(path.join(__dirname, '..', 'get-shit-done', 'workflows', 'update.md'), 'utf8');
|
|
// #2790: reapply-patches.md command was absorbed into update.md --reapply.
|
|
// The Kilo-specific env-var checks (KILO_CONFIG_DIR, KILO_CONFIG, XDG_CONFIG_HOME)
|
|
// now live in the update.md workflow (which covers both --sync and --reapply paths).
|
|
const reapplyPatchesSrc = updateWorkflowSrc;
|
|
|
|
test('--kilo flag parsing exists', () => {
|
|
assert.ok(src.includes("args.includes('--kilo')"), '--kilo flag parsed');
|
|
});
|
|
|
|
test('help text includes --kilo', () => {
|
|
assert.ok(src.includes('Install for Kilo only'), 'help text includes Kilo option');
|
|
});
|
|
|
|
test('--all array includes kilo', () => {
|
|
assert.ok(src.includes("'kilo'"), '--all includes kilo runtime');
|
|
});
|
|
|
|
test('promptRuntime runtimeMap has Kilo as option 10', () => {
|
|
assert.ok(src.includes("'10': 'kilo'"), 'runtimeMap has 10 -> kilo');
|
|
});
|
|
|
|
test('prompt text shows Kilo above OpenCode without marketing copy', () => {
|
|
assert.ok(src.includes('10${reset}) Kilo'), 'prompt lists Kilo as option 10');
|
|
assert.ok(!src.includes('the #1 AI coding platform on OpenRouter'), 'prompt does not include marketing tagline');
|
|
});
|
|
|
|
test('hooks are skipped for Kilo', () => {
|
|
assert.ok(src.includes('!isOpencode && !isKilo'), 'hooks skip check includes kilo');
|
|
});
|
|
|
|
test('settings.json write excludes Kilo', () => {
|
|
assert.ok(src.includes('!isCodex && !isCopilot && !isKilo && !isCursor && !isWindsurf'), 'settings write excludes kilo');
|
|
});
|
|
|
|
test('agent path replacement does not exclude Kilo', () => {
|
|
assert.ok(src.includes('if (!isCopilot && !isAntigravity)'), 'generic agent path replacement still applies');
|
|
});
|
|
|
|
test('finishInstall passes the actual config dir to Kilo permissions', () => {
|
|
assert.ok(src.includes('configureKiloPermissions(isGlobal, configDir);'), 'Kilo permission config uses actual install dir');
|
|
});
|
|
|
|
test('uninstall cleans Kilo permissions from the resolved target dir', () => {
|
|
assert.ok(src.includes('const configPath = resolveKiloConfigPath(targetDir);'), 'Kilo uninstall cleanup uses targetDir');
|
|
});
|
|
|
|
test('update workflow checks preferred custom config dirs before defaults', () => {
|
|
assert.ok(updateWorkflowSrc.includes('PREFERRED_CONFIG_DIR'), 'workflow tracks preferred config dir');
|
|
assert.ok(updateWorkflowSrc.includes('kilo.jsonc'), 'workflow infers Kilo from config files');
|
|
assert.ok(updateWorkflowSrc.includes('ENV_RUNTIME_DIRS'), 'workflow checks env-derived config dirs');
|
|
assert.ok(updateWorkflowSrc.includes('KILO_CONFIG'), 'workflow checks KILO_CONFIG');
|
|
});
|
|
|
|
test('reapply-patches checks Kilo custom config env vars first', () => {
|
|
assert.ok(reapplyPatchesSrc.includes('KILO_CONFIG_DIR'), 'reapply-patches checks KILO_CONFIG_DIR');
|
|
assert.ok(reapplyPatchesSrc.includes('KILO_CONFIG'), 'reapply-patches checks KILO_CONFIG');
|
|
assert.ok(reapplyPatchesSrc.includes('XDG_CONFIG_HOME'), 'reapply-patches checks XDG_CONFIG_HOME');
|
|
});
|
|
});
|