* test: reproduce model-catalog MODULE_NOT_FOUND in install layout (#3288) Tests A/B/C exercise the install-layout regression introduced by #3230: - A: confirms the old 3-level __dirname path fails when sdk/shared/ is absent - B: confirms the new co-located bin/shared/ path resolves correctly (RED) - C: confirms install() copies model-catalog.json to co-located path (RED) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(install): copy sdk/shared/model-catalog.json + resolve chain in CJS (#3288) Two-part fix for the CRITICAL regression introduced by #3230: Install-side: bin/install.js now copies sdk/shared/model-catalog.json into get-shit-done/bin/shared/model-catalog.json immediately after the main get-shit-done/ copy step. Every runtime install (Claude Code, Codex, OpenCode, Gemini, etc.) now includes this file in the payload. CJS-side: model-catalog.cjs replaces the brittle single-path require with a resolve-chain that checks candidates in order: 1. get-shit-done/bin/shared/model-catalog.json (co-located, preferred post-install) 2. sdk/shared/model-catalog.json (source-repo dev path, legacy fallback) 3. GSD_MODEL_CATALOG env override (custom deployments / test harnesses) When no candidate resolves, throws with a diagnostic listing all tried paths (PRED.k301 — throw must include candidate paths for debuggability). REFACTOR audit: three other __dirname traversals in bin/lib/ were inspected: - core.cjs:1242 (3 levels up → agents/) — safe; agents/ IS copied to targetDir - profile-output.cjs:547,740 (2 levels up → templates/) — safe; templates/ is inside get-shit-done/ and IS copied Only model-catalog.cjs traversed outside the installed payload. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * changeset: pr=3293 for #3288 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(model-catalog): narrow catch to missing-file errors; clear env in test (#3288) Two CR findings from PR #3293 review: 1. model-catalog.cjs catch block swallowed ALL errors — malformed JSON, permission errors, and other real failures were silently absorbed into the fallback chain. Now only MODULE_NOT_FOUND (with matching path in message) and ENOENT are treated as recoverable; any other error is rethrown immediately. 2. test beforeEach saved GSD_EXPLICIT_CONFIG_DIR but didn't clear it — a CI-set value could leak into install() and redirect the install to an unexpected directory, making test C non-deterministic. Added `delete process.env.GSD_EXPLICIT_CONFIG_DIR` to beforeEach. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
137 lines
4.9 KiB
JavaScript
137 lines
4.9 KiB
JavaScript
'use strict';
|
|
|
|
const path = require('node:path');
|
|
|
|
// Resolve model-catalog.json via a prioritised candidate list so the module
|
|
// works in every layout:
|
|
//
|
|
// 1. Co-located install path — get-shit-done/bin/shared/model-catalog.json
|
|
// Written by bin/install.js (#3288 fix). This is the canonical post-install
|
|
// location across all runtimes (Claude Code, Codex, OpenCode, etc.).
|
|
//
|
|
// 2. Source-repo dev path — sdk/shared/model-catalog.json
|
|
// Three levels up from bin/lib/: works when running directly from the
|
|
// gsd-build/get-shit-done clone (the original path introduced by #3230).
|
|
//
|
|
// 3. GSD_MODEL_CATALOG env override — allows test harnesses and custom
|
|
// deployments to point at an arbitrary catalog file.
|
|
//
|
|
// Throws with a diagnostic message that lists all candidates when none resolve,
|
|
// so MODULE_NOT_FOUND surfaces as a clear actionable error (PRED.k301).
|
|
const _catalogCandidates = [
|
|
path.resolve(__dirname, '..', 'shared', 'model-catalog.json'),
|
|
path.resolve(__dirname, '..', '..', '..', 'sdk', 'shared', 'model-catalog.json'),
|
|
process.env.GSD_MODEL_CATALOG ? path.resolve(process.env.GSD_MODEL_CATALOG) : null,
|
|
].filter(Boolean);
|
|
|
|
let catalog = null;
|
|
let _catalogLastErr = null;
|
|
for (const _p of _catalogCandidates) {
|
|
try {
|
|
catalog = require(_p);
|
|
break;
|
|
} catch (e) {
|
|
// Only treat missing-file errors as recoverable — rethrow parse errors,
|
|
// permission errors, and any other real failures so they surface clearly
|
|
// instead of being silently swallowed (CR finding, PR #3293).
|
|
const isMissingCandidate =
|
|
(e && e.code === 'MODULE_NOT_FOUND' && String(e.message || '').includes(_p)) ||
|
|
(e && e.code === 'ENOENT');
|
|
if (!isMissingCandidate) throw e;
|
|
_catalogLastErr = e;
|
|
}
|
|
}
|
|
if (!catalog) {
|
|
throw new Error(
|
|
`model-catalog.json not found. Tried:\n${_catalogCandidates.map((p) => ` ${p}`).join('\n')}\nLast error: ${_catalogLastErr?.message}`
|
|
);
|
|
}
|
|
|
|
const VALID_PROFILES = [...catalog.profiles];
|
|
const VALID_PHASE_TYPES = new Set(catalog.phaseTypes);
|
|
const VALID_AGENT_TIERS = new Set(Object.keys(catalog.adaptiveTierMap));
|
|
|
|
const MODEL_PROFILES = Object.fromEntries(
|
|
Object.entries(catalog.agents).map(([agent, meta]) => [agent, {
|
|
quality: meta.golden,
|
|
balanced: meta.balanced,
|
|
budget: meta.budget,
|
|
adaptive: catalog.adaptiveTierMap[meta.routingTier],
|
|
}])
|
|
);
|
|
|
|
const AGENT_TO_PHASE_TYPE = Object.fromEntries(
|
|
Object.entries(catalog.agents).map(([agent, meta]) => [agent, meta.phaseType])
|
|
);
|
|
|
|
const AGENT_DEFAULT_TIERS = Object.fromEntries(
|
|
Object.entries(catalog.agents).map(([agent, meta]) => [agent, meta.routingTier])
|
|
);
|
|
|
|
const MODEL_ALIAS_MAP = Object.fromEntries(
|
|
Object.entries(catalog.runtimeTierDefaults.claude).map(([tier, entry]) => [tier, entry?.model])
|
|
);
|
|
|
|
const RUNTIME_PROFILE_MAP = Object.fromEntries(
|
|
Object.entries(catalog.runtimeTierDefaults)
|
|
.map(([runtime, tiers]) => [
|
|
runtime,
|
|
Object.fromEntries(
|
|
Object.entries(tiers).filter(([, entry]) => entry).map(([tier, entry]) => [tier, entry])
|
|
),
|
|
])
|
|
.filter(([, tiers]) => Object.keys(tiers).length > 0)
|
|
);
|
|
|
|
const KNOWN_RUNTIMES = new Set(Object.keys(catalog.runtimeTierDefaults));
|
|
const RUNTIMES_WITH_REASONING_EFFORT = new Set(
|
|
Object.entries(catalog.runtimeTierDefaults)
|
|
.filter(([, tiers]) => Object.values(tiers).some((entry) => entry && entry.reasoning_effort))
|
|
.map(([runtime]) => runtime)
|
|
);
|
|
|
|
function nextTier(currentTier) {
|
|
const order = ['light', 'standard', 'heavy'];
|
|
const idx = order.indexOf(String(currentTier));
|
|
if (idx === -1) return null;
|
|
return order[Math.min(idx + 1, order.length - 1)];
|
|
}
|
|
|
|
function formatAgentToModelMapAsTable(agentToModelMap) {
|
|
const agentWidth = Math.max('Agent'.length, ...Object.keys(agentToModelMap).map((a) => a.length));
|
|
const modelWidth = Math.max('Model'.length, ...Object.values(agentToModelMap).map((m) => m.length));
|
|
const sep = '─'.repeat(agentWidth + 2) + '┼' + '─'.repeat(modelWidth + 2);
|
|
const header = ` ${'Agent'.padEnd(agentWidth)} │ ${'Model'.padEnd(modelWidth)}`;
|
|
let out = `${header}\n${sep}\n`;
|
|
for (const [agent, model] of Object.entries(agentToModelMap)) {
|
|
out += ` ${agent.padEnd(agentWidth)} │ ${model.padEnd(modelWidth)}\n`;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
function getAgentToModelMapForProfile(normalizedProfile) {
|
|
const profile = VALID_PROFILES.includes(normalizedProfile) ? normalizedProfile : 'balanced';
|
|
const out = {};
|
|
for (const [agent, profiles] of Object.entries(MODEL_PROFILES)) {
|
|
out[agent] = profile === 'inherit' ? 'inherit' : (profiles[profile] ?? profiles.balanced);
|
|
}
|
|
return out;
|
|
}
|
|
|
|
module.exports = {
|
|
catalog,
|
|
MODEL_PROFILES,
|
|
VALID_PROFILES,
|
|
AGENT_TO_PHASE_TYPE,
|
|
VALID_PHASE_TYPES,
|
|
AGENT_DEFAULT_TIERS,
|
|
VALID_AGENT_TIERS,
|
|
MODEL_ALIAS_MAP,
|
|
RUNTIME_PROFILE_MAP,
|
|
KNOWN_RUNTIMES,
|
|
RUNTIMES_WITH_REASONING_EFFORT,
|
|
nextTier,
|
|
formatAgentToModelMapAsTable,
|
|
getAgentToModelMapForProfile,
|
|
};
|