* fix(#3724): stop advisory Dimension 3b findings from forcing the revision loop Dimension 3b (undeclared/temporal coupling, #1954) is spec'd "never a blocker" but tagged severity: warning — the tier plan-phase's revision loop counts as must-fix — and the planner is never taught the rule, so every multi-wave phase touching shared mutable state replans at least once, and intentionally coupled plans re-flag identically every iteration to the stall prompt. Three coordinated changes: - gsd-plan-checker: retag 3b to severity: info, the tier references/revision-loop.md already exempts by design; recognize a coupling_justified frontmatter declaration in the Do-NOT-flag list so deliberate pairs converge. Additions are offset by trimming 3b motivation prose — the checker sits 45 bytes under its LARGE hard cap. - plan-phase step 12: INFO-only accept — an issues block with zero BLOCKER/WARNING entries accepts the plan and surfaces the advisories instead of re-entering the revision loop. Real blockers and warnings still gate unconditionally. - gsd-planner: slim pointer in assign_waves to the new progressive-disclosure reference gsd-core/references/planner-coupling.md (the planner sits 19 chars under its own cap), which carries the shared-mutable-state rule and the coupling_justified escape hatch so first-pass plans avoid the finding when the coupling is unintentional. Documented the coupling_justified field in docs/reference/plan-md.md. Growth acks per #2914; inventory manifest and install-tree fixtures regenerated for the new reference file. Closes #3724 Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * test(#3724): pin Dimension 3b at severity: info The severity retag makes the old assertion (severity: warning) stale; lock the advisory tier from both directions — info must be present, warning must not — so a future edit cannot silently re-arm the revision-loop trigger. Refs #3724 Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * chore(#3724): changeset fragment for PR #3758 Refs #3724 Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * docs(#3724): roster planner-coupling.md in docs/INVENTORY.md The new reference was enumerated in the manifest and all 19 install-tree fixtures but missing its row in the Modular Planner Decomposition table — the roster half the manifest-sync test cannot check. (Review Blocker.) Refs #3724 Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * test(#3724): cover all four acceptance criteria (review round 1) - plan-checker-coupling: the 3b severity assertion is now a PARITY check deriving the exempt tier from revision-loop.md's flow instead of hardcoding info — editing either side alone reds the suite. New describe pins the other three criteria: plan-phase's INFO-only accept clause (proven failing-first), the BLOCKER + WARNING count staying intact, the coupling_justified Do-NOT-flag exemption + fix_hint, and the planner pointer + planner-coupling.md content. - ack fragment: $comment's plan-phase figure corrected to +79B; the 2775 pin note carried forward into the gsd-planner.md entry, updated for upstream's #3761/#3764 Rule-paragraph anchor (which this diff leaves verbatim). The parallel-dependent-plans re-anchor this commit originally carried was superseded by upstream #3764 during review; this branch no longer touches that file. Refs #3724 Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): review round 2 — align the stance enumeration, complete the template contract MAJOR: <adversarial_stance>'s severity enumeration gains the INFO bullet so it agrees with Dimension 3b's 'ALWAYS INFO' mandate instead of contradicting it. Funded by extracting the inline <examples> block to the new progressive- disclosure reference gsd-core/references/plan-checker-examples.md (@-inlined from the same spot; #1949 precedent), which also restores the 3b motivation clause round 1 traded away (Nit 4) and nets the agent file SMALLER than base (49107 -> 48486) — the extraction the byte pressure was owed. MINOR: gsd-core/templates/phase-prompt.md now carries coupling_justified, and the field's shape becomes one 'plan-id: reason' string per coupled peer so a plan justified against two peers can express it; docs/reference/plan-md.md's Type column names the shape. NIT: the 3409 ack's plan-phase entry no longer calls the #1168 workflow ratchet an 'XL tier'. Acks and derived artifacts updated accordingly (checker entry removed — a shrink needs no ack; INVENTORY roster row + regen:derived for the new file). Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * test(#3724): derive the 3b negative severity assertion (review round 2) Every severity token in the 3b span must BE the tier revision-loop.md exempts, replacing the hardcoded severity:warning negative — if the loop's exemption ever moves, the failure names the real conflict instead of blaming the agent file with a mutually-unsatisfiable pair. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): refit the planner coupling pointer under the char cap Upstream #3299 (PR #3390) grew agents/gsd-planner.md to 49146 chars at the base, leaving 5 chars of headroom where the +16-char pointer was measured against 13 more. The pointer prose shortens to 'Non-file coupling:' — 49150 chars, back under the strict 49152-char cap — and the ack figures follow. The @-path the tests pin is unchanged. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): re-home the plan-phase ack after the #3823 spent-fragment sweep Upstream #3078/#3823 deleted all fully-spent ack fragments, including 3409-unreachable-guard-arms.json, which carried this PR's plan-phase.md +79B append. Per the collision remedy that sweep added: take the deletion and home the still-live entry in this PR's own fragment. Figures re-measured at this merge base (90871 -> 90950 LF bytes). Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): absorb the spent #3172 plan-phase fragment into this PR's ack Upstream #3825 shipped 3172-stated-failing-direction.json naming only plan-phase.md, now spent at the base — colliding with this PR's live plan-phase entry. Per the #3003 pattern the fully-spent single-path fragment is deleted and this fragment stays the path's one source; figures re-measured at this base (93073 -> 93152 LF bytes). Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): review round 3 — true up the ack figures, restore the wave comment The fragment's absolute sizes are re-measured and anchored to basee40e9670(planner 47259 -> 47330 chars, checker 45537 -> 44916 B, plan-phase 91186 -> 91265 LF bytes), with a note that absolutes rot as next moves — the deltas are the durable claims. The round-1 removal of the '# Implicit dependency: files_modified overlap forces a later wave.' pseudocode comment offset headroom base drift had already returned, so it is restored (findings 2-3). Changeset gains the (#3724) backlink (finding 4). Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): review round 4 — close the verify-work surface, harden the boundaries BLOCKER: verify-work.md's verify_gap_plans is the second multi-plan consumer of the checker's sentinels, and its ISSUES FOUND handler entered revision_loop with zero severity parsing — the guaranteed replan #3724 fixed in plan-phase, alive on the gap-closure surface. The handler now counts BLOCKER + WARNING and accepts INFO-only returns with advisories displayed. The checker's INFO stance bullet is reworded to the claim that is true everywhere ('revision gates count only BLOCKER + WARNING'). Minor 1: plan-phase's iteration_count >= 3 arm recounts severities, so an INFO-only third check accepts instead of halting on a '0 issues remain' user gate. Minor 2: the coupling_justified exemption now requires the entry to NAME the other plan, closing the blanket-suppression reading. Nit 1: INVENTORY row states the extraction buys cap headroom, not context. Nit 2: the advisory display gains a concrete format on both surfaces. Ack fragment re-anchored at baseddde001a: verify-work.md +264B (new entry), plan-phase.md +395B, checker still net negative (-512B). Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * test(#3724): pin the verify-work accept and the iteration-cap boundary (review round 4) Two wiring assertions: verify_gap_plans' ISSUES FOUND handler gates on BLOCKER + WARNING and accepts INFO-only blocks, and plan-phase's iteration_count >= 3 arm recounts severities instead of gating advisories — the limit+1 boundary of the gate this PR fixes. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): review round 5 — fail closed at the gates, surface the advisory Blocker 1: the checker's step-10 status rule routes an INFO-only result to ## ISSUES FOUND (with a new ### Advisories (info) template section and a severity-aware recommendation) so the orchestrator receives the block and displays the advisory instead of silently accepting a bare PASSED. Blockers 2+3: all three gate surfaces (plan-phase step 12 both arms, verify-work verify_gap_plans) carry one canonical clause verbatim — an entry whose severity is missing or unrecognized counts as a BLOCKER (fail closed) — making the accept condition an explicit-INFO whitelist while keeping issue_count coherent for stall math. Major 1: the INFO stance bullet scopes its claim to the plan-phase and verify-work gates (quick mode's loop still revises on any ISSUES FOUND). Major 2: INVENTORY row and ack $comment state the extraction's real trade (readability, +0.6 KB eager runtime context), not a cap remedy. Minor 1: plan-md.md marks coupling_justified as prompt convention, unvalidated. Nit 1: ack absolutes re-anchored at base 1e67ec97; checker now +120B and acked. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * test(#3724): pin the round-5 contract — fail-closed parity, INFO-only return shape New: three-surface verbatim parity test for the fail-closed clause (Blockers 2+3); checker return-contract test for the INFO-only ## ISSUES FOUND route and advisories section (Blocker 1). All seven newly pinned tokens are absent at f3a5682d, so each new assertion fails pre-fix. Updated: accept-clause regexes track the explicit-INFO whitelist wording; the severity sweep scopes to the span's fenced yaml examples via yamlSeverityTiers (round-5 Minor 3, applied to the blocker negative too); the iteration-cap comment states it is a prose pin, not an executed boundary check (Minor 4); splitLines call sites document the line-pin coupling (Nit 2). Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): adopt next's line wrap in the 3b motivation clause — drops a wrap-only hunk from the diff Byte-identical content; the wrap difference was an artifact of the round-1 base adaptation predating upstream's #3003 landing. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM * fix(#3724): review round 7 — gate every checker consumer, not just the two audited ones Blocker: quick/steps/plan-checker-loop.md (issue-named in #3724) gets the same canonical fail-closed clause and explicit-INFO whitelist accept as plan-phase/verify-work — an INFO-only result proceeds instead of entering quick mode's revision loop. Major: import.md plan_validate handles the checker return by severity (INFO-only never blocks an import) and is added to agent-contracts.md's consumer enumeration, which had omitted it. The checker's INFO stance bullet drops the quick-mode carve-out — the claim is universally true again now that every consuming gate is severity-aware. Minor: an applied coupling_justified exemption is surfaced as its own info advisory so a stale one-sided declaration stays observable. Nit: plan-phase's revision-iteration Display line is explicitly conditioned on not having already proceeded to step 13. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM Emitted-Drift-Ack-Growth: import.md — #3724 round 7: the plan_validate step's checker-return handler becomes severity-aware — counts BLOCKER + WARNING failing closed and accepts an explicitly-INFO-only return with advisories displayed instead of blocking the import * test(#3724): pin the round-7 surfaces — five-gate parity, quick/import accepts, exemption visibility The verbatim fail-closed parity test extends to quick/steps/plan-checker-loop.md and import.md plan_validate; new assertions pin quick mode's INFO-only proceed, import's never-blocks accept, import.md's presence in agent-contracts.md's consumer row, and the surfaced coupling_justified exemption advisory. All four newly pinned token families are absent at the pre-fix head, so each new assertion fails first. Claude-Session: https://claude.ai/code/session_01GshUzpGjoxiw6uNRiFMHvM --------- Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
39 KiB
User tests, Claude records. One test at a time. Plain text responses.
<available_agent_types> Valid GSD subagent types (use exact names — do not fall back to 'general-purpose'):
- gsd-planner — Creates detailed plans from phase scope
- gsd-plan-checker — Reviews plan quality before execution </available_agent_types>
Claude presents what SHOULD happen. User confirms or describes what's different.
- "yes" / "y" / "next" / empty → pass
- Anything else → logged as issue, severity inferred
No Pass/Fail buttons. No severity questions. Just: "Here's what should happen. Does it?"
@~/.claude/gsd-core/templates/UAT.md If $ARGUMENTS contains a phase number, load context:_GSD_SHIM_NAME="gsd-tools.cjs"; _GSD_RUNTIME_ROOT="${RUNTIME_DIR:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}"; GSD_TOOLS="${_GSD_RUNTIME_ROOT}/gsd-core/bin/${_GSD_SHIM_NAME}"; _gsd_at() { for _p; do if [ -f "$_p" ]; then GSD_TOOLS="$_p"; return 0; fi; done; return 1; }; if _gsd_at "${_GSD_RUNTIME_ROOT}/gsd-core/bin/${_GSD_SHIM_NAME}" "${_GSD_RUNTIME_ROOT}/.claude/gsd-core/bin/${_GSD_SHIM_NAME}" "${_GSD_RUNTIME_ROOT}/.codex/gsd-core/bin/${_GSD_SHIM_NAME}"; then gsd_run() { node "$GSD_TOOLS" "$@"; }; elif unset -f gsd_run; _G="$(command -v gsd_run)"; then GSD_TOOLS="$_G"; gsd_run() { "$GSD_TOOLS" "$@"; }; elif _gsd_at "${CLAUDE_CONFIG_DIR:-$HOME/.claude}/gsd-core/bin/${_GSD_SHIM_NAME}" "${HERMES_HOME:-$HOME/.hermes}/gsd-core/bin/${_GSD_SHIM_NAME}" "${CURSOR_CONFIG_DIR:-$HOME/.cursor}/gsd-core/bin/${_GSD_SHIM_NAME}" "${CODEX_HOME:-$HOME/.codex}/gsd-core/bin/${_GSD_SHIM_NAME}" "${GEMINI_CONFIG_DIR:-$HOME/.gemini}/gsd-core/bin/${_GSD_SHIM_NAME}" "${COPILOT_CONFIG_DIR:-$HOME/.copilot}/gsd-core/bin/${_GSD_SHIM_NAME}" "${WINDSURF_CONFIG_DIR:-$HOME/.codeium/windsurf}/gsd-core/bin/${_GSD_SHIM_NAME}" "${AUGMENT_CONFIG_DIR:-$HOME/.augment}/gsd-core/bin/${_GSD_SHIM_NAME}" "${TRAE_CONFIG_DIR:-$HOME/.trae}/gsd-core/bin/${_GSD_SHIM_NAME}" "${QWEN_CONFIG_DIR:-$HOME/.qwen}/gsd-core/bin/${_GSD_SHIM_NAME}" "${CODEBUDDY_CONFIG_DIR:-$HOME/.codebuddy}/gsd-core/bin/${_GSD_SHIM_NAME}" "${CLINE_CONFIG_DIR:-$HOME/.cline}/gsd-core/bin/${_GSD_SHIM_NAME}" "${GROK_AGENTS_HOME:-$HOME/.agents}/gsd-core/bin/${_GSD_SHIM_NAME}" "${ANTIGRAVITY_CONFIG_DIR:-$HOME/.gemini/antigravity}/gsd-core/bin/${_GSD_SHIM_NAME}" "${OPENCODE_CONFIG_DIR:-${XDG_CONFIG_HOME:-$HOME/.config}/opencode}/gsd-core/bin/${_GSD_SHIM_NAME}" "${KILO_CONFIG_DIR:-${XDG_CONFIG_HOME:-$HOME/.config}/kilo}/gsd-core/bin/${_GSD_SHIM_NAME}"; then gsd_run() { node "$GSD_TOOLS" "$@"; }; else echo "ERROR: gsd-tools.cjs not found at $GSD_TOOLS and gsd_run is not on PATH. Run: npx -y @opengsd/gsd-core@latest --claude --local" >&2; exit 1; fi; GSD_IDENTITY_STATUS=unverified; case "$(gsd_run runtime-identity --raw 2>/dev/null || true)" in '{"packageName":"@opengsd/gsd-core"'*'}') GSD_IDENTITY_STATUS=ok;; esac; export GSD_IDENTITY_STATUS; [ "$GSD_IDENTITY_STATUS" = ok ] || echo "WARNING: \"$GSD_TOOLS\" did not prove it is @opengsd/gsd-core - it is either a different package or an @opengsd/gsd-core older than the runtime-identity verb. See docs/how-to/diagnose-a-foreign-gsd-tools.md" >&2; if [ -n "${CLAUDE_ENV_FILE:-}" ] && [ -n "${GSD_TOOLS:-}" ]; then printf "export PATH='%s':\"\$PATH\"\n" "${GSD_TOOLS%/*}" >> "$CLAUDE_ENV_FILE" 2>/dev/null || true; fi
GSD_WS=""
echo "$ARGUMENTS" | grep -qE -- '--ws[[:space:]]+[A-Za-z0-9._-]+' && GSD_WS=$(echo "$ARGUMENTS" | grep -oE -- '--ws[[:space:]]+[A-Za-z0-9._-]+')
PHASE_ARG=$(echo "$ARGUMENTS" | sed -E 's/--ws[[:space:]]+[A-Za-z0-9._-]+//g' | xargs)
INIT=$(gsd_run query init.verify-work "${PHASE_ARG}" ${GSD_WS})
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
AGENT_SKILLS_PLANNER=$(gsd_run query agent-skills gsd-planner)
AGENT_SKILLS_CHECKER=$(gsd_run query agent-skills gsd-plan-checker)
Parse JSON for: planner_model, checker_model, commit_docs, phase_found, phase_dir, phase_number, phase_name, has_verification, uat_path, state_path, roadmap_path, response_language.
If response_language is set: All user-facing questions, prompts, and explanations in this workflow MUST be presented in {response_language}. Technical terms, code, file paths, and subagent prompts stay in English — only user-facing output is translated.
# MVP mode detection via the centralized phase.mvp-mode resolver.
# verify-work has no --mvp CLI flag (mode is inherited from the planned phase),
# so we omit --cli-flag — the verb falls through roadmap → config → false.
MVP_MODE=$(gsd_run query phase.mvp-mode "${phase_number}" ${GSD_WS} --pick active)
VERIFY_PRE_HOOKS_JSON=$(gsd_run loop render-hooks verify:pre --raw)
PHASE_DIR=$(printf '%s' "$INIT" | jq -r '.phase_dir // empty')
Read the activeHooks array from VERIFY_PRE_HOOKS_JSON in-context (do NOT pipe through a shell parser).
If activeHooks is empty or absent: skip silently to check_active_session.
Contribution dispatch: inject every kind == "contribution" fragment per @gsd-core/references/loop-hook-dispatch.md (skip when none), before the steps and gates below.
Step dispatch: dispatch every kind == "step" hook per @gsd-core/references/loop-hook-dispatch.md (skip when none) — not one shape of one. A step here is advisory: it never blocks the start of UAT, and a step that errors is routed by its own onError without failing verification. ⚠ Validate ref.command in-context before any shell use (third-party manifest input) — loop-hook-dispatch.md § step.
Record the union of produces artefact names declared by the active step entries as VERIFY_PRE_PRODUCED — extract_tests consumes it below. An entry declaring produces: [] contributes nothing, which is the normal case.
⚠ Validate check before shell use (third-party manifest input) — loop-hook-dispatch.md § gate.
Resolve active gate hooks from VERIFY_PRE_HOOKS_JSON where kind == "gate".
For each active gate hook, run its declared check (a check.query gate runs
gsd_run check ${hook.check.query} "${PHASE_DIR}" --raw; a predicate gate
runs gsd_run check predicate --predicate '<hook.check.predicate as JSON>' --phase-dir "${PHASE_DIR}" --raw):
GATE_RESULT=$(gsd_run check "${hook_check_query}" "${PHASE_DIR}" --raw)
GATE_BLOCK=$(printf '%s' "$GATE_RESULT" | jq -r '.block // false' 2>/dev/null || echo "false")
Two-step gate contract (same as execute:wave:post / execute:post):
- Step 1 — command failure: if the
gsd_run check ...invocation itself fails (non-zero exit, no JSON), route by the gate'sonError. AnonError: haltgate HALTs; anonError: skipgate logs a warning and continues. - Step 2 — block evaluation: parse
GATE_RESULT.block. For a blocking gate (hook.blocking == true) withblock == true: HALT — do not begin UAT, present the gate'smessage, and tell the user what artifact resolves it. For a non-blocking gate with a non-emptymessage: print⚠ {hook.capId} advisory: {GATE_RESULT.message}and continue. For any gate withblock == false: continue silently.
Example — the ai-integration capability's api-coverage.verify-pre gate
(when workflow.api_coverage_gate is on) blocks here if the phase integrates an
external API without a decided COVERAGE.md matrix. Present its message and
point the user at producing COVERAGE.md before re-running verification.
(find .planning/phases -name "*-UAT.md" -type f 2>/dev/null || true)
If active sessions exist AND no $ARGUMENTS provided:
Read each file's frontmatter (status, phase) and Current Test section.
Display inline:
## Active UAT Sessions
| # | Phase | Status | Current Test | Progress |
|---|-------|--------|--------------|----------|
| 1 | 04-comments | testing | 3. Reply to Comment | 2/6 |
| 2 | 05-auth | testing | 1. Login Form | 0/4 |
Reply with a number to resume, or provide a phase number to start new.
Wait for user response.
- If user replies with number (1, 2) → Load that file, go to
resume_from_file - If user replies with phase number → Treat as new session, go to
create_uat_file
If active sessions exist AND $ARGUMENTS provided:
Check if session exists for that phase. If yes, offer to resume or restart.
If no, continue to create_uat_file.
If no active sessions AND no $ARGUMENTS:
No active UAT sessions.
Provide a phase number to start testing (e.g., /gsd:verify-work 4)
If no active sessions AND $ARGUMENTS provided:
Continue to create_uat_file.
If section_manifest is null or "automated-ui-verification" is in its included list: read and execute gsd-core/workflows/verify-work/steps/automated-ui-verification.md. Otherwise skip — do not read the file.
Use phase_dir from init (or run init if not already done).
ls "$phase_dir"/*-SUMMARY.md 2>/dev/null || true
Read each SUMMARY.md to extract testable deliverables.
If `section_manifest` is `null` or `"mvp-uat-framing"` is in its `included` list: read and execute `gsd-core/workflows/verify-work/steps/mvp-uat-framing.md`. Otherwise skip — do not read the file.When MVP_MODE=false (mode is null, absent, or the phase has no **Mode:** line in ROADMAP.md), fall back to the standard UAT generation path — no behavioral change.
Coverage-aware deterministic classification (#1602). Before deriving checkpoints from prose, classify each SUMMARY's structured coverage: block. For each *-SUMMARY.md:
COVERAGE=$(gsd_run query uat.classify-coverage --summary "$SUMMARY_FILE")
Read the JSON result (mode, total, all_auto_covered, auto_passed[], present[], errors[]):
mode: legacy(nocoverage:block, OR a malformed block that could not be parsed) → fall through to the prose-based extraction below. Behavior is byte-identical to pre-#1602 for un-migrated SUMMARYs; do NOT auto-pass anything. Iferrors[]is non-empty (amalformed_block), note the broken coverage block to the user before proceeding so the SUMMARY can be fixed.mode: coverage→- Each
auto_passed[]entry is recorded in UAT.md asresult: pass,source: automated(seecreate_uat_file) — do not present it as a checkpoint. It is deterministically covered by the passing tests in itsverificationrefs. - Each
present[]entry becomes a human UAT checkpoint: use itsdescriptionas the test and carry itsrationaleinto the checkpoint context. Thereason(human_judgment/no_verification/verification_not_passing/validation_failed) explains why a human is needed. - If
all_auto_coveredistrue(every entry auto-passed, including thecoverage: []case) → do NOT generate zero checkpoints; present a single confirmation summary listing the auto-covered deliverables with their covering tests and ask the user to confirm. - Surface any
errors[]to the user (malformed coverage block) but still treat their entries as human checkpoints — never drop a deliverable (fail-safe).
- Each
The cold-start smoke test injection below still applies in coverage mode.
Verify:pre produced-artefact seam (#3866). If VERIFY_PRE_PRODUCED (recorded in
verify_pre_hooks) is empty or absent, skip this paragraph entirely — derivation is unchanged.
Otherwise, for each artefact name in it, locate the artefact the producing step wrote under
$PHASE_DIR and merge its checkpoints into the test list additively.
The artefact contract. A consumable artefact is a Markdown file holding a list of checkpoint
entries in the same shape extract_tests already emits and create_uat_file already consumes —
each entry a name (brief test name) and an expected (specific, user-observable outcome).
Nothing else is read: extra fields are ignored, not an error. There is no new schema and no new
parser — a producing step writes what a checkpoint already looks like. An artefact that yields zero
parseable entries is treated exactly like an absent one (see below).
Merge rules:
- ⚠ Validate the artefact name in-context before resolving it (third-party manifest input).
An artefact name is a registry-declared name, not a path: check the value you read from
producesagainst^[A-Za-z0-9][A-Za-z0-9._-]*$yourself — never by pasting it into a shell command to be tested there. A name carrying/,.., a leading-, a leading path separator, or any shell metacharacter is a malformed manifest: record a warning, skip that name, continue. Only a validated name is resolved, and only against what the step wrote inside$PHASE_DIR— never above it, and never through a symlink that leaves it. - A name with no artefact on disk means that step was inactive, skipped, or failed. Note it to the user and derive normally — never drop a deliverable and never block UAT over it.
- Merged entries are added to, never subtracted from, what
coverage:classification and the prose fallback produce. Anauto_passed[]entry stays un-presented; apresent[]entry stays a human checkpoint. This seam can deepen UAT, not suppress it. - Deduplicate against already-derived checkpoints by
name, keeping the earlier entry'sexpectedtext so a produced artefact cannot silently rewrite a criterion.
Extract testable deliverables from SUMMARY.md (legacy fallback — used when mode: legacy):
Parse for:
- Accomplishments - Features/functionality added
- User-facing changes - UI, workflows, interactions
Focus on USER-OBSERVABLE outcomes, not implementation details.
For each deliverable, create a test:
- name: Brief test name
- expected: What the user should see/experience (specific, observable)
If response_language is set, write the name and expected text in {response_language} — the examples below are illustrative templates only, not literal output to copy.
Examples:
- Accomplishment: "Added comment threading with infinite nesting" → Test: "Reply to a Comment" → Expected: "Clicking Reply opens inline composer below comment. Submitting shows reply nested under parent with visual indentation."
Skip internal/non-observable items (refactors, type changes, etc.).
Cold-start smoke test injection:
After extracting tests from SUMMARYs, scan the SUMMARY files for modified/created file paths. If ANY path matches these patterns:
server.ts, server.js, app.ts, app.js, index.ts, index.js, main.ts, main.js, database/*, db/*, seed/*, seeds/*, migrations/*, startup*, docker-compose*, Dockerfile*
Then prepend this test to the test list:
- name: "Cold Start Smoke Test"
- expected: "Kill any running server/service. Clear ephemeral state (temp DBs, caches, lock files). Start the application from scratch. Server boots without errors, any seed/migration completes, and a primary query (health check, homepage load, or basic API call) returns live data."
This catches bugs that only manifest on fresh start — race conditions in startup sequences, silent seed failures, missing environment setup — which pass against warm state but break in production.
**Create UAT file with all tests:**mkdir -p "$PHASE_DIR"
Build test list from extracted deliverables.
Create file:
---
status: testing
phase: XX-name
source: [list of SUMMARY.md files]
started: [ISO timestamp]
updated: [ISO timestamp]
---
## Current Test
<!-- OVERWRITE each test - shows where we are -->
number: 1
name: [first test name]
expected: |
[what user should observe]
awaiting: user response
## Tests
### 1. [Test Name]
expected: [observable behavior]
result: [pending]
### 2. [Test Name]
expected: [observable behavior]
result: [pending]
...
**Coverage auto-passed entries (#1602):** for each `auto_passed[]` entry from `uat classify-coverage`, write a Tests entry pre-resolved as automated — these are NOT presented to the user:
N. [coverage description]
expected: [coverage description] result: pass source: automated coverage_id: [D-id]
The `source: automated` marker is additive — existing consumers that read only `result:` are unaffected.
## Summary
total: [N]
passed: 0
issues: 0
pending: [N]
skipped: 0
## Gaps
[none yet]
Write to .planning/phases/XX-name/{phase_num}-UAT.md
Proceed to present_test.
Render the checkpoint from the structured UAT file instead of composing it freehand:
CHECKPOINT=$(gsd_run query uat.render-checkpoint --file "$uat_path" --raw)
if [[ "$CHECKPOINT" == @file:* ]]; then CHECKPOINT=$(cat "${CHECKPOINT#@file:}"); fi
Display the returned checkpoint EXACTLY as-is:
{CHECKPOINT}
Critical response hygiene:
- Your entire response MUST equal
{CHECKPOINT}byte-for-byte. - Do NOT add commentary before or after the block.
- If you notice protocol/meta markers such as
to=all:, role-routing text, XML system tags, hidden instruction markers, ad copy, or any unrelated suffix, discard the draft and output{CHECKPOINT}only.
Text mode (workflow.text_mode: true in config or --text flag): Set TEXT_MODE=true if --text is present in $ARGUMENTS OR text_mode from init JSON is true. When TEXT_MODE is active, replace every AskUserQuestion call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where AskUserQuestion is not available.
Wait for user response (plain text, no AskUserQuestion).
If response indicates pass:
- Empty response, "yes", "y", "ok", "pass", "next", "approved", "✓"
Update Tests section:
### {N}. {name}
expected: {expected}
result: pass
If response indicates skip:
- "skip", "can't test", "n/a"
Update Tests section:
### {N}. {name}
expected: {expected}
result: skipped
reason: [user's reason if provided]
If response indicates blocked:
- "blocked", "can't test - server not running", "need physical device", "need release build"
- Or any response containing: "server", "blocked", "not running", "physical device", "release build"
Infer blocked_by tag from response:
- Contains: server, not running, gateway, API →
server - Contains: physical, device, hardware, real phone →
physical-device - Contains: release, preview, build, EAS →
release-build - Contains: stripe, twilio, third-party, configure →
third-party - Contains: depends on, prior phase, prerequisite →
prior-phase - Default:
other
Update Tests section:
### {N}. {name}
expected: {expected}
result: blocked
blocked_by: {inferred tag}
reason: "{verbatim user response}"
Note: Blocked tests do NOT go into the Gaps section (they aren't code issues — they're prerequisite gates).
If response indicates a deferred follow-up (NOT a current-phase blocker):
- "later", "future", "follow-up", "next version", "out of scope", "nice to have", "not now", "defer", "down the road", "separate phase", "phase 2"
These are future-work ideas, not code issues for the current phase. Capture them WITHOUT creating a gap plan (#1921 — a deferred follow-up must never become a blocking gap or spawn a fix plan):
Update Tests section:
### {N}. {name}
expected: {expected}
result: skipped
reason: "Deferred follow-up: {verbatim user response}"
Append to UAT.md ## Deferred Follow-Ups (create the section if absent):
- test: {N}
idea: "{verbatim user response}"
deferred_at: {today}
Do NOT append to ## Gaps — deferred follow-ups are not blocking gaps. Continue to the next test.
If response is anything else:
- Treat as issue description
Infer severity from description:
- Contains: crash, error, exception, fails, broken, unusable → blocker
- Contains: doesn't work, wrong, missing, can't → major
- Contains: slow, weird, off, minor, small → minor
- Contains: color, font, spacing, alignment, visual → cosmetic
- Default if unclear: major
Update Tests section:
### {N}. {name}
expected: {expected}
result: issue
reported: "{verbatim user response}"
severity: {inferred}
Append to Gaps section (structured YAML for plan-phase --gaps):
- gap_id: G-{phase}-{N} # Stable id (phase + test number) — gap-closure plans tag it in their frontmatter so verify-work can reconcile resolved gaps on resume (#1921).
truth: "{expected behavior from test}"
status: failed
reason: "User reported: {verbatim user response}"
severity: {inferred}
test: {N}
artifacts: [] # Filled by diagnosis
missing: [] # Filled by diagnosis
After any response:
Update Summary counts. Update frontmatter.updated timestamp.
If more tests remain → Update Current Test, go to present_test
If no more tests → Go to complete_session
When verify-work resumes after /gsd:execute-phase --gaps-only, the UAT ## Gaps entries still read status: failed even though their fix plans have executed. Without reconciliation verify-work re-diagnoses them as fresh blockers and spawns new gap plans — losing the verification state. This step closes the loop.
Read the UAT ## Gaps section and the phase dir *-PLAN.md frontmatter. For each gap with status: failed:
- Find a
*-PLAN.mdwhose frontmattergap_idsincludes the gap'sgap_id(G-{phase}-{N}). - If such a plan exists AND has a matching
*-SUMMARY.mdin the phase dir (the plan was executed by--gaps-only), the gap is resolved — update its YAML in place:- gap_id: G-{phase}-{N} status: resolved # was: failed resolved_by: {plan basename} resolved_at: {today} - If no plan references the
gap_id, or the plan has no SUMMARY, leave the gapstatus: failed(still open).
Read plan frontmatter directly in-context — do not pipe it through a shell parser. After reconciliation, announce:
Reconciled gap-closure state: {resolved_count} gap(s) resolved by executed plans, {open_count} still open.
Resolved gaps are NOT re-diagnosed and do NOT spawn new gap plans. If the user later reports the same behavior as still broken, treat it as a new issue (a regression) with a fresh gap_id.
First run reconcile_gaps (above) so gaps already fixed by /gsd:execute-phase --gaps-only are marked resolved before testing resumes (#1921).
Read the full UAT file.
Find first test with result: [pending].
If no [pending] test found → go to complete_session.
Announce:
Resuming: Phase {phase} UAT
Progress: {passed + issues + skipped}/{total}
Issues found so far: {issues count}
Continuing from Test {N}...
Update Current Test section with the pending test.
Proceed to present_test.
Determine final status:
Count results:
pending_count: tests withresult: [pending]blocked_count: tests withresult: blockedskipped_no_reason: tests withresult: skippedand noreasonfield
if pending_count > 0 OR blocked_count > 0 OR skipped_no_reason > 0:
status: partial
# Session ended but not all tests resolved
else:
status: complete
# All tests have a definitive result (pass, issue, or skipped-with-reason)
Update frontmatter:
- status: {computed status}
- updated: [now]
Clear Current Test section:
## Current Test
[testing complete]
Commit the UAT file:
gsd_run query commit "test({phase_num}): complete UAT - {passed} passed, {issues} issues" --files ".planning/phases/XX-name/{phase_num}-UAT.md"
Present summary:
## UAT Complete: Phase {phase}
| Result | Count |
|--------|-------|
| Passed | {N} |
| Issues | {N} |
| Skipped| {N} |
[If issues > 0:]
### Issues Found
[List from Issues section]
If issues > 0: Proceed to diagnose_issues
If issues == 0:
VERIFY_POST_HOOKS_JSON=$(gsd_run loop render-hooks verify:post --raw)
SECURITY_FILE=$(ls "${PHASE_DIR}"/*-SECURITY.md 2>/dev/null | head -1)
Generic step dispatch: dispatch every kind == "step" hook from VERIFY_POST_HOOKS_JSON per @gsd-core/references/loop-hook-dispatch.md (skip silently when none). Each step is advisory and best-effort — honor onError and continue. The secure-phase handling below is an additional specialization of one such hook, not a replacement for the generic dispatch.
Resolve active step hooks from VERIFY_POST_HOOKS_JSON where kind == "step" and ref.skill == "secure-phase".
If an active secure-phase step hook exists AND SECURITY_FILE is empty, dispatch the registry-provided skill stem:
Skill(skill="gsd-${ref.skill}", args="{phase}")
After the skill returns, refresh SECURITY_FILE:
SECURITY_FILE=$(ls "${PHASE_DIR}"/*-SECURITY.md 2>/dev/null | head -1)
If SECURITY_FILE is still empty, stop before phase advancement and present:
⚠ Security enforcement enabled — /gsd:secure-phase {phase} did not produce SECURITY.md.
Resolve the security review failure before advancing to the next phase.
All tests passed, but phase advancement is blocked until security review produces SECURITY.md.
- `/gsd:secure-phase {phase}` — security review (required before advancing)
- `/gsd:ui-review {phase}` — visual quality audit (if frontend files were modified)
If an active secure-phase step hook exists AND SECURITY_FILE exists: check frontmatter threats_open. If > 0:
⚠ Security gate: {threats_open} threats open
/gsd:secure-phase {phase} — resolve before advancing
If no active secure-phase step hook exists OR (SECURITY_FILE exists AND threats_open is 0):
If execution verification is waiting only on human UAT and this session recorded zero issues, canonicalize the report before the shared completion predicate:
PHASE_DIR=$(printf '%s' "$INIT" | jq -r '.phase_dir // empty')
VERIFICATION_FILE=$(gsd_run query verification.resolve-file "$PHASE_DIR" --raw 2>/dev/null)
VERIFICATION_STATUS=$(gsd_run query verification.status "$PHASE_DIR" 2>/dev/null)
VERIFICATION_STATUS_VALUE=$(printf '%s' "$VERIFICATION_STATUS" | jq -r '.status // empty' 2>/dev/null || echo "")
PHASE_VERIFICATION_STATUS="$VERIFICATION_STATUS_VALUE"
if [ "$VERIFICATION_STATUS_VALUE" = "human_needed" ]; then
gsd_run query frontmatter.set "$VERIFICATION_FILE" --field status --value passed
fi
If PHASE_VERIFICATION_STATUS is stale, stop before phase advancement and present:
All UAT tests passed, but phase advancement is blocked until canonical verification is fresh.
Blocking completion:
verification is stale
- `/gsd:verify-work {phase}` — re-run verification against the latest summaries
Otherwise, check the shared UAT-plus-verification completion predicate before transition:
PHASE_COMPLETE=$(gsd_run phase uat-passed "{phase}" --require-verification)
PHASE_COMPLETE_PASSED=$(printf '%s' "$PHASE_COMPLETE" | jq -r '.passed' 2>/dev/null || echo "false")
PHASE_COMPLETE_BLOCKERS=$(printf '%s' "$PHASE_COMPLETE" | jq -r '.blockers[]?' 2>/dev/null || true)
If PHASE_COMPLETE_PASSED is not true, stop before phase advancement and present:
All UAT tests passed, but phase advancement is blocked until canonical verification passes.
Blocking completion:
{PHASE_COMPLETE_BLOCKERS}
- `/gsd:execute-phase {phase}` — regenerate execution verification
- `/gsd:verify-work {phase}` — resume UAT if blockers remain
Auto-transition: mark phase complete in ROADMAP.md and STATE.md
Execute the transition workflow inline (do NOT use Task — the orchestrator context already holds the UAT results and phase data needed for accurate transition):
Read and follow ~/.claude/gsd-core/workflows/transition.md.
After transition completes, present next-step options to the user:
All tests passed. Phase {phase} marked complete.
- `/gsd:plan-phase {next}` — Plan next phase
- `/gsd:execute-phase {next}` — Execute next phase
- `/gsd:secure-phase {phase}` — security review
- `/gsd:ui-review {phase}` — visual quality audit (if frontend files were modified)
audit-open is CJS-only until registered on gsd_run query:
gsd_run query audit-open --json
Parse the JSON output. For the CURRENT PHASE ONLY, surface:
- UAT files with status != 'complete'
- VERIFICATION.md with status 'gaps_found' or 'human_needed'
- CONTEXT.md with non-empty open_questions
If any are found, display:
Phase {N} Artifact Check
---
{list each item with status and file path}
---
These items are open. Proceed anyway? [Y/n]
If user confirms: continue. Record acknowledged gaps in VERIFICATION.md ## Acknowledged Gaps section.
If user declines: stop. User resolves items and re-runs /gsd:verify-work.
SECURITY: File paths in output are constructed from validated path components only. Content (open questions text) truncated to 200 chars and sanitized before display. Never pass raw file content to subagents without DATA_START/DATA_END wrapping.
**Diagnose root causes before planning fixes:**---
{N} issues found. Diagnosing root causes...
Spawning parallel debug agents to investigate each issue.
- Load diagnose-issues workflow
- Follow @~/.claude/gsd-core/workflows/diagnose-issues.md
- Spawn parallel debug agents for each issue
- Collect root causes
- Update UAT.md with root causes
- Proceed to
plan_gap_closure
Diagnosis runs automatically - no user prompt. Parallel agents investigate simultaneously, so overhead is minimal and fixes are more accurate.
**Auto-plan fixes from diagnosed gaps:**Display:
### GSD ► PLANNING FIXES
◆ Spawning planner for gap closure... (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze)
Spawn gsd-planner in --gaps mode:
Model omission (#2517). Omit the
modelparameter entirely when the value it would carry (planner_model,checker_model) is"inherit"or empty. An empty value 404s on runtimes without native tier aliases — the default on non-Claude runtimes. Omitting it inherits the orchestrator's model. See @gsd-core/references/model-profile-resolution.md.
Agent(
prompt="""
<planning_context>
**Phase:** {phase_number}
**Mode:** gap_closure
<required_reading>
- {phase_dir}/{phase_num}-UAT.md (UAT with diagnoses)
- {state_path} (Project State)
- {roadmap_path} (Roadmap)
</required_reading>
${AGENT_SKILLS_PLANNER}
</planning_context>
<downstream_consumer>
Output consumed by /gsd:execute-phase
Plans must be executable prompts.
<!-- #2508 runtime-aware-dispatch -->
> **Runtime-aware dispatch (#2508 Phase 4).** GSD workflows dispatch specialized subagents by role. Before dispatching on a built-in-only runtime (kimi-code — three built-ins only), resolve the role to a built-in via `gsd_run query resolve-dispatch-type --requested <role> --raw`. On named-dispatch runtimes (Claude/OpenCode/…) the role is returned unchanged; on kimi-code it maps to `coder`/`explore`/`plan` by role-suffix. The persona rides `${AGENT_SKILLS_<ROLE>}` (Phase 3) regardless. See @gsd-core/references/runtime-aware-dispatch.md.
**Gap linkage (#1921):** each created `*-PLAN.md` MUST list the UAT gap ids it addresses in its frontmatter:
```yaml
---
gap_closure: true
gap_ids: [G-{phase}-{N}, ...] # the ## Gaps gap_id values this plan fixes
---
```
This lets `/gsd:verify-work` reconcile resolved gaps on resume (a gap whose plan has a matching `*-SUMMARY.md` is marked `status: resolved`, not re-diagnosed as a fresh blocker).
</downstream_consumer>
""",
subagent_type="gsd-planner",
model="{planner_model}",
description="Plan gap fixes for Phase {phase}"
)
ORCHESTRATOR RULE — CODEX RUNTIME: After calling Agent() above, stop working on this task immediately. Do not read more files, edit code, or run tests related to this task while the subagent is active. Wait for the subagent to return its result. This prevents duplicate work, conflicting edits, and wasted context. Only resume when the subagent result is available.
On return:
- PLANNING COMPLETE: Proceed to
verify_gap_plans - PLANNING INCONCLUSIVE: Report and offer manual intervention
Display:
### GSD ► VERIFYING FIX PLANS
◆ Spawning plan checker... (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze)
Initialize: iteration_count = 1
Spawn gsd-plan-checker:
Agent(
prompt="""
<verification_context>
**Phase:** {phase_number}
**Phase Goal:** Close diagnosed gaps from UAT
<required_reading>
- {phase_dir}/*-PLAN.md (Plans to verify)
</required_reading>
${AGENT_SKILLS_CHECKER}
</verification_context>
<expected_output>
Return one of:
- ## VERIFICATION PASSED — all checks pass
- ## ISSUES FOUND — structured issue list
</expected_output>
""",
subagent_type="gsd-plan-checker",
model="{checker_model}",
description="Verify Phase {phase} fix plans"
)
ORCHESTRATOR RULE — CODEX RUNTIME: After calling Agent() above, stop working on this task immediately. Do not read more files, edit code, or run tests related to this task while the subagent is active. Wait for the subagent to return its result. This prevents duplicate work, conflicting edits, and wasted context. Only resume when the subagent result is available.
On return:
- VERIFICATION PASSED: Proceed to
present_ready - ISSUES FOUND: Count BLOCKER + WARNING entries in the YAML issues block; an entry whose severity is missing or unrecognized counts as a BLOCKER (fail closed). If zero — every entry is explicitly INFO — display
ℹ advisory — {dimension}: {description}per entry and proceed topresent_ready; INFO is advisory and never enters the loop (#3724). Otherwise proceed torevision_loop
If iteration_count < 3:
Display: Sending back to planner for revision... (iteration {N}/3)
Spawn gsd-planner with revision context:
Agent(
prompt="""
<revision_context>
**Phase:** {phase_number}
**Mode:** revision
<required_reading>
- {phase_dir}/*-PLAN.md (Existing plans)
</required_reading>
${AGENT_SKILLS_PLANNER}
**Checker issues:**
{structured_issues_from_checker}
</revision_context>
<instructions>
Read existing PLAN.md files. Make targeted updates to address checker issues.
Do NOT replan from scratch unless issues are fundamental.
</instructions>
""",
subagent_type="gsd-planner",
model="{planner_model}",
description="Revise Phase {phase} plans"
)
ORCHESTRATOR RULE — CODEX RUNTIME: After calling Agent() above, stop working on this task immediately. Do not read more files, edit code, or run tests related to this task while the subagent is active. Wait for the subagent to return its result. This prevents duplicate work, conflicting edits, and wasted context. Only resume when the subagent result is available.
After planner returns → spawn checker again (verify_gap_plans logic) Increment iteration_count
If iteration_count >= 3:
Display: Max iterations reached. {N} issues remain.
Offer options:
- Force proceed (execute despite issues)
- Provide guidance (user gives direction, retry)
- Abandon (exit, user runs /gsd:plan-phase manually)
Wait for user response.
**Present completion and next steps:**### GSD ► FIXES READY ✓
**Phase {X}: {Name}** — {N} gap(s) diagnosed, {M} fix plan(s) created
| Gap | Root Cause | Fix Plan |
|-----|------------|----------|
| {truth 1} | {root_cause} | {phase}-04 |
| {truth 2} | {root_cause} | {phase}-04 |
Plans verified and ready for execution.
---
## ▶ Next Up — [${PROJECT_CODE}] ${PROJECT_TITLE}
**Execute fixes** — run fix plans
`/clear` then `/gsd:execute-phase {phase} --gaps-only`
---
<update_rules> Batched writes for efficiency:
Keep results in memory. Write to file only when:
- Issue found — Preserve the problem immediately
- Session complete — Final write before commit
- Checkpoint — Every 5 passed tests (safety net)
| Section | Rule | When Written |
|---|---|---|
| Frontmatter.status | OVERWRITE | Start, complete |
| Frontmatter.updated | OVERWRITE | On any file write |
| Current Test | OVERWRITE | On any file write |
| Tests.{N}.result | OVERWRITE | On any file write |
| Summary | OVERWRITE | On any file write |
| Gaps | APPEND | When issue found |
On context reset: File shows last checkpoint. Resume from there. </update_rules>
<severity_inference> Infer severity from user's natural language:
| User says | Infer |
|---|---|
| "crashes", "error", "exception", "fails completely" | blocker |
| "doesn't work", "nothing happens", "wrong behavior" | major |
| "works but...", "slow", "weird", "minor issue" | minor |
| "color", "spacing", "alignment", "looks off" | cosmetic |
Default to major if unclear. User can correct if needed.
Never ask "how severe is this?" - just infer and move on. </severity_inference>
<success_criteria>
- UAT file created with all tests from SUMMARY.md
- Tests presented one at a time with expected behavior
- User responses processed as pass/issue/skip
- Severity inferred from description (never asked)
- Batched writes: on issue, every 5 passes, or completion
- Committed on completion
- If issues: parallel debug agents diagnose root causes
- If issues: gsd-planner creates fix plans (gap_closure mode)
- If issues: gsd-plan-checker verifies fix plans
- If issues: revision loop until plans pass (max 3 iterations)
- Ready for
/gsd:execute-phase --gaps-onlywhen complete </success_criteria>