* feat(#3415): ship local/no-unbounded-quantifier, burn down ReDoS class Phase 4 of epic #3212 (ADR-3212 §5/§7, the final phase). New rule flags an unbounded */+/{n,} quantifier over a broad character class ([\s\S], dotAll ., or a 1-2-unit negated class like [^\n]/[^)\n] — the exact #2128-fixed shape) applied to a regex whose match target is data-flow-traced to readFileSync content. eslint-rules/lib/readfilesync-trace.cjs extracts the data-flow tracer shared with no-crlf-fragile-split (Phase 2) rather than a second copy — no-crlf-fragile-split refactored onto it with zero behavior change, parity-tested. Real triage, not 798 mechanical edits: the ADR's census (2026-08-08) screened every unbounded quantifier in the tree unscoped. Correctly scoped to readFileSync-derived content (matching Phase 2's own G2/G3 scoping), the rule found 162 real hits across two detection waves — the second wave (93) surfaced only after a genuine off-by-one bug in this rule's own first draft was caught while writing its RuleTester tests and fixed (the bug silently missed every directly-quantified [\s\S]* with no gap before the quantifier — exactly the class this rule exists to catch). 3 hits landed in production src/ (commands.cts, milestone.cts, roadmap.cts) and were each empirically timed against adversarial input (matching #2128's own measured-not-assumed precedent) — all confirmed linear-time/benign, left unbounded with a measured-evidence comment rather than mechanically bounded. The remaining 159 are test-file fixture parsing (test-author-controlled, fixed-size content, not adversarial input) — each suppressed with a specific, non-generic reason. Zero functional behavior changed anywhere in this diff. tests/no-pending-3212-markers.test.cjs locks the epic's own closing invariant (ADR §7: "assert zero pending #3212 markers remain") — ground truth confirmed trivially true today (no phase left any such marker behind), now regression-locked going forward. Design: .gsd/phase/chore-3415-prohibition-with-teeth/40-design.md Test matrix: .gsd/phase/chore-3415-prohibition-with-teeth/50-test-matrix.md Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3415): correct rule category mislabel, add CI test-scope entry An orthogonal Standards-axis review found eslint-rules/no-unbounded-quantifier.cjs mistakenly carried meta.docs.category: 'Portability', copied from a sibling rule without realizing what that implied: docs/contributing/cross-platform- portability-rules.md governs an ADR-1703 rule family under a hard "zero escape hatches" contract (tests/portability-rule-disable-ban.test.cjs's PROTECTED_RULES bans eslint-disable for those rules entirely). This rule is not part of that family — it's ADR-3212 (ReDoS/CWE-1333), a different epic — and its eslint-disable-next-line suppressions (159 of them, added earlier this same phase after empirical benign-verification) are an intentional, correct design, not a bypass. Corrected to category: 'Best Practices', matching the actual precedent (no-adhoc-regex-escape.cjs, Phase 1 of the same epic, which is also correctly outside PROTECTED_RULES), and the rule's own docstring now states this explicitly so a future reader doesn't have to re-derive it. Also registers a new scripts/ci-test-scope.cjs bucket so editing this rule or the shared eslint-rules/lib/readfilesync-trace.cjs helper re-runs their own test suites under targeted CI selection — was previously unregistered and invisible to that fast-path (this PR's own gsd-test checkpoint runs the full suite regardless, so this only affects future narrowly-scoped PRs). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3415): bound no-unbounded-quantifier's own scanner (CWE-1333, ironic) Security review found the rule meant to catch algorithmic-complexity bugs had one of its own: hasUnboundedBroadQuantifier's negated-class inner scan walked from each `[^` occurrence to the next `]` (or EOF) with no bound, while the outer loop only ever advanced by one character — O(n²) total work on a pattern with many unclosed `[^` runs. Runs unconditionally inside checkPattern on any `new RegExp('literal string')` argument in any linted file, before the (cheap) readFileSync data-flow gate — so a single crafted string literal, no valid regex syntax required, could make `npm run lint` / CI hang. Empirically confirmed both the bug and the fix: pre-fix, n=4000/8000/ 16000/32000 chars took 30.8/115.6/463.8/1874.3ms (~4x work per 2x n, quadratic); extrapolated, the 300000-char repro from the finding would run ~165s. Post-fix (bail the inner scan once units exceeds the rule's own 1-2-unit scope, rather than continuing to hunt for a closing `]`), the same 300000-char input runs in 8.7ms via the real rule module, independently reconfirmed at 18ms via a fresh Linter.verify() call. New regression row in tests/no-unbounded-quantifier.rule.test.cjs asserts the RuleTester run on a 50000-char adversarial pattern completes and returns a defined result — no wall-clock assertion (CLAUDE.md Clock Seams / local/no-elapsed-assertion). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3415): triage 3 new sites, re-raise ceiling after upstream batch next merged 12 more PRs during this PR's review. Two consequences: - tests/edit-phase.test.cjs (fix #3262, unrelated) added 3 new content.match(/<tag>([\s\S]*?)<\/tag>/) reads of this repo's own workflow .md content — the same Class A pattern as the ~159 sites already triaged elsewhere in this PR. Suppressed with the same established reason. - lint-allow-test-rule-refs' ratchet ceiling needed re-raising again (301 -> 303) for the same reason as the two prior bumps: organic growth from unrelated, already-reviewed PRs landing concurrently, not a defect in this branch's own diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: sim <sim@local> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
132 lines
5.0 KiB
JavaScript
132 lines
5.0 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
/**
|
|
* Validates the gates taxonomy reference document (#1715).
|
|
*
|
|
* Ensures the reference file exists, defines all 4 canonical gate types,
|
|
* includes the gate matrix table, and is cross-referenced from workflows.
|
|
*/
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const ROOT = path.join(__dirname, '..');
|
|
const GATES_REF = path.join(ROOT, 'gsd-core', 'references', 'gates.md');
|
|
|
|
describe('gates taxonomy (#1715)', () => {
|
|
test('reference file exists', () => {
|
|
assert.ok(
|
|
fs.existsSync(GATES_REF),
|
|
'gsd-core/references/gates.md must exist'
|
|
);
|
|
});
|
|
|
|
test('defines all 4 canonical gate types', () => {
|
|
const content = fs.readFileSync(GATES_REF, 'utf-8');
|
|
const gateTypes = ['Pre-flight Gate', 'Revision Gate', 'Escalation Gate', 'Abort Gate'];
|
|
|
|
for (const gate of gateTypes) {
|
|
assert.ok(
|
|
content.includes(`### ${gate}`),
|
|
`gates.md must define "${gate}" as an h3 heading`
|
|
);
|
|
}
|
|
});
|
|
|
|
test('each gate type has Purpose, Behavior, Recovery, and Examples', () => {
|
|
const content = fs.readFileSync(GATES_REF, 'utf-8');
|
|
const sections = content.split('### ').slice(1); // split by h3, drop preamble
|
|
|
|
for (const section of sections) {
|
|
const name = section.split('\n')[0].trim();
|
|
// Only check gate type sections (not other h3s if any)
|
|
if (!name.endsWith('Gate')) continue;
|
|
|
|
for (const field of ['**Purpose:**', '**Behavior:**', '**Recovery:**', '**Examples:**']) {
|
|
assert.ok(
|
|
section.includes(field),
|
|
`Gate "${name}" must include ${field}`
|
|
);
|
|
}
|
|
}
|
|
});
|
|
|
|
test('contains Gate Matrix table', () => {
|
|
const content = fs.readFileSync(GATES_REF, 'utf-8');
|
|
assert.ok(
|
|
content.includes('## Gate Matrix'),
|
|
'gates.md must include a "Gate Matrix" section'
|
|
);
|
|
// Verify table header row
|
|
assert.ok(
|
|
content.includes('| Workflow |'),
|
|
'Gate Matrix must contain a table with Workflow column'
|
|
);
|
|
// Verify key workflow rows exist
|
|
assert.ok(content.includes('plan-phase'), 'Gate Matrix must reference plan-phase');
|
|
assert.ok(content.includes('execute-phase'), 'Gate Matrix must reference execute-phase');
|
|
assert.ok(content.includes('verify-work'), 'Gate Matrix must reference verify-work');
|
|
assert.ok(content.includes('| next |'), 'Gate Matrix must reference next workflow');
|
|
});
|
|
|
|
test('plan-phase.md references gates.md', () => {
|
|
const planPhase = path.join(ROOT, 'gsd-core', 'workflows', 'plan-phase.md');
|
|
const content = fs.readFileSync(planPhase, 'utf-8');
|
|
assert.ok(
|
|
content.includes('references/gates.md'),
|
|
'plan-phase.md must reference gates.md in its required_reading block'
|
|
);
|
|
});
|
|
|
|
test('execute-phase.md references gates.md', () => {
|
|
const execPhase = path.join(ROOT, 'gsd-core', 'workflows', 'execute-phase.md');
|
|
const content = fs.readFileSync(execPhase, 'utf-8');
|
|
assert.ok(
|
|
content.includes('references/gates.md'),
|
|
'execute-phase.md must reference gates.md in its required_reading block'
|
|
);
|
|
});
|
|
|
|
test('gsd-plan-checker.md references gates.md in required_reading block', () => {
|
|
const planChecker = path.join(ROOT, 'agents', 'gsd-plan-checker.md');
|
|
const content = fs.readFileSync(planChecker, 'utf-8');
|
|
// eslint-disable-next-line local/no-unbounded-quantifier -- parses this repo's own agent .md content, fixed-size author-controlled content
|
|
const match = content.match(/<required_reading>\r?\n([\s\S]*?)\r?\n<\/required_reading>/);
|
|
assert.ok(
|
|
match,
|
|
'gsd-plan-checker.md must have a <required_reading> block'
|
|
);
|
|
assert.ok(
|
|
match[1].includes('references/gates.md'),
|
|
'gsd-plan-checker.md must reference gates.md inside <required_reading>'
|
|
);
|
|
});
|
|
|
|
test('gsd-verifier.md references gates.md in required_reading block', () => {
|
|
const verifier = path.join(ROOT, 'agents', 'gsd-verifier.md');
|
|
const content = fs.readFileSync(verifier, 'utf-8');
|
|
// eslint-disable-next-line local/no-unbounded-quantifier -- parses this repo's own agent .md content, fixed-size author-controlled content
|
|
const match = content.match(/<required_reading>\r?\n([\s\S]*?)\r?\n<\/required_reading>/);
|
|
assert.ok(
|
|
match,
|
|
'gsd-verifier.md must have a <required_reading> block'
|
|
);
|
|
assert.ok(
|
|
match[1].includes('references/gates.md'),
|
|
'gsd-verifier.md must reference gates.md inside <required_reading>'
|
|
);
|
|
});
|
|
|
|
test('Revision Gate recovery mentions stall detection', () => {
|
|
const content = fs.readFileSync(GATES_REF, 'utf-8');
|
|
assert.ok(
|
|
content.includes('stall detection'),
|
|
'Revision Gate recovery must mention stall detection (early escalation when issues stop decreasing)'
|
|
);
|
|
});
|
|
});
|