* refactor(#1646): route capability routers through Command Routing Hub per ADR-959 Phase 2 of parent #1641. Converts graphify, intel, and audit command routers from hand-rolled if/else dispatch to routeHubCommandFamily, implementing the ADR-959 §III(B) line 75 mandate. The three routers now share the uniform dispatch shape with the 14 host routers. src/cjs-command-router-adapter.cts * Imported ERROR_REASON from io.cjs. * UnknownCommand translation now passes ERROR_REASON.SDK_UNKNOWN_COMMAND as the second arg to error() — additive for host routers (their existing one-arg error callbacks ignore the second arg), required for capability routers whose tests assert reason === 'sdk_unknown_command' on the JSON-error envelope. src/graphify-command-router.cts * Replaced 4-branch if/else with routeHubCommandFamily + handlers map. * Validation handlers (missing term, missing/invalid --budget) now return makeInvalidArgs(arg, reason, ERROR_REASON.USAGE) Results instead of calling error() directly (Q2=C, Q4=ii from grilling). * Success handlers keep direct output() calls. * Subcommands array is alphabetical for byte-identical 'Available:' text in the unknown-subcommand message. * The unknown-subcommand path is now owned by the Hub's manifest check (the adapter passes SDK_UNKNOWN_COMMAND). src/intel-command-router.cts * Replaced 9-branch if/else with routeHubCommandFamily + handlers map. * Validation handlers (missing term, missing filePath for patch-meta and extract-exports) return makeInvalidArgs Results. * Preserved the timeAgo mutation in the non-raw status handler. * Preserved the lazy require('./intel.cjs') inside the route function. src/audit-command-router.cts * routeAuditUat: routes through the Hub with a synthetic 'run' defaultSubcommand (no real subcommands). Gives uniform observability. * routeAuditOpen: captures --json in a closure, strips it from args before Hub dispatch (so it isn't mistaken for a subcommand by the manifest check), then branches on wantJson inside the handler to preserve the formatAuditReport success-path quirk. docs/CONFIGURATION.md * Observability section: noted capability commands (graphify, intel, audit-uat, audit-open) now emit DispatchEvent records since #1646. .changeset/capability-routers-via-hub.md * Changed fragment describing the user-visible audit-trail expansion. pr:0 placeholder will be backfilled after gh pr create returns the real PR number (DEFECT.CHANGESET-PR-FIELD-DRIFT). Verification * graphify cutover tests: 119/119 pass (all unit, dispatch, behavior, error path, JSON-errors, and registry assertions) * intel cutover tests: 39/39 pass * audit cutover tests: 24/24 pass * bug-974-graphify-budget-missing-value regression test: pass * npm run test:unit (full suite): 2384 tests, 0 fail * gsd-test-summary on docker: outcome=passed, 0 failures (RULESET.PR-FLOW.docker-before-push) JSON-error envelope parity verified byte-identical: reason values ('usage', 'sdk_unknown_command') and message texts are preserved across all three routers' error paths. * chore(#1646): backfill changeset pr: 1647 (DEFECT.CHANGESET-PR-FIELD-DRIFT)
146 lines
5.7 KiB
TypeScript
146 lines
5.7 KiB
TypeScript
'use strict';
|
|
/**
|
|
* Audit command routers — CLI dispatchers for `gsd-tools audit-uat` and
|
|
* `gsd-tools audit-open`.
|
|
*
|
|
* ADR-959 (phase 4d-impl-3): audit command family cutover.
|
|
* Extracted from the hardcoded `case 'audit-uat':` and `case 'audit-open':`
|
|
* arms in gsd-tools.cjs. Behaviour is preserved byte-for-behaviour from the
|
|
* prior inline cases; the dispatch path now flows:
|
|
* default → dispatchCapabilityCommand →
|
|
* require(audit-command-router.cjs) → routeAuditUat | routeAuditOpen.
|
|
*
|
|
* Router signatures: { args, cwd, raw, error } — identical to the existing
|
|
* host routers. No new handler/arg convention; the capability registry
|
|
* discovers these routers by name.
|
|
*
|
|
* Test seam: pass `_uat` / `_audit` / `_core` in the options object to inject
|
|
* recording mocks instead of the real modules. The `_`-prefix follows the
|
|
* repo's established seam convention (see graphify-command-router.cts).
|
|
* Production callers omit them.
|
|
*
|
|
* Lazy requires: uat.cjs and audit.cjs are required INSIDE each route function
|
|
* so the unneeded module is never loaded (preserves equivalence with the old
|
|
* inline case arms which each required only their own module).
|
|
*/
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
import io = require('./io.cjs');
|
|
// Phase 2 (#1646): route through the Hub per ADR-959 §III(B) line 75.
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
import cjsCommandRouterAdapter = require('./cjs-command-router-adapter.cjs');
|
|
|
|
const { routeHubCommandFamily } = cjsCommandRouterAdapter;
|
|
|
|
// ─── Types ────────────────────────────────────────────────────────────────────
|
|
|
|
interface UatModule {
|
|
cmdAuditUat(cwd: string, raw: boolean): void;
|
|
}
|
|
|
|
interface AuditModule {
|
|
auditOpenArtifacts(cwd: string): unknown;
|
|
formatAuditReport(result: unknown): string;
|
|
}
|
|
|
|
interface CoreModule {
|
|
output(value: unknown, raw: boolean, rawValue?: string): void;
|
|
}
|
|
|
|
interface RouteAuditUatOptions {
|
|
args: string[];
|
|
cwd: string;
|
|
raw: boolean;
|
|
error: (message: string, reason?: string) => void;
|
|
/** Test seam: inject a mock uat module. Defaults to the real module. */
|
|
_uat?: UatModule;
|
|
}
|
|
|
|
interface RouteAuditOpenOptions {
|
|
args: string[];
|
|
cwd: string;
|
|
raw: boolean;
|
|
error: (message: string, reason?: string) => void;
|
|
/** Test seam: inject a mock audit module. Defaults to the real module. */
|
|
_audit?: AuditModule;
|
|
/** Test seam: inject a mock core module to capture output calls. Defaults to the real module. */
|
|
_core?: CoreModule;
|
|
}
|
|
|
|
// ─── routeAuditUat ────────────────────────────────────────────────────────────
|
|
|
|
function routeAuditUat({ args, cwd, raw, error, _uat }: RouteAuditUatOptions): void {
|
|
// Suppress unused-variable warnings for args/error — this command has no
|
|
// subcommands and passes raw through directly to the uat module.
|
|
void args;
|
|
void error;
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-unsafe-assignment
|
|
const u: UatModule = _uat ?? require('./uat.cjs');
|
|
|
|
// Phase 2 (#1646): routes through the Hub for uniform observability and
|
|
// HandlerFailure taxonomy. audit-uat has no subcommands — a synthetic 'run'
|
|
// defaultSubcommand gives the Hub a single-handler manifest. The dispatch is
|
|
// trivial but the observability seam (DispatchEvent, GSD_AUDIT=1 trace) is
|
|
// now consistent with graphify/intel/host routers.
|
|
routeHubCommandFamily({
|
|
family: 'audit-uat',
|
|
args,
|
|
subcommands: ['run'],
|
|
defaultSubcommand: 'run',
|
|
handlers: {
|
|
run: () => u.cmdAuditUat(cwd, raw),
|
|
},
|
|
unknownMessage: (subcommand: string) =>
|
|
`Unknown audit-uat subcommand: "${subcommand}". audit-uat takes no subcommands.`,
|
|
error,
|
|
cwd,
|
|
raw,
|
|
});
|
|
}
|
|
|
|
// ─── routeAuditOpen ──────────────────────────────────────────────────────────
|
|
|
|
function routeAuditOpen({ args, cwd, raw, error, _audit, _core }: RouteAuditOpenOptions): void {
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-unsafe-assignment
|
|
const a: AuditModule = _audit ?? require('./audit.cjs');
|
|
const c: CoreModule = _core ?? io;
|
|
|
|
// Phase 2 (#1646): routes through the Hub for uniform observability.
|
|
// `--json` is a flag, not a subcommand — capture it in the closure and strip
|
|
// it from args before Hub dispatch so it isn't mistaken for a subcommand by
|
|
// the manifest check. The handler then branches on wantJson for the two
|
|
// output shapes (JSON object vs human-readable formatted report).
|
|
const wantJson = args.includes('--json');
|
|
const hubArgs = wantJson ? args.filter((arg) => arg !== '--json') : args;
|
|
|
|
routeHubCommandFamily({
|
|
family: 'audit-open',
|
|
args: hubArgs,
|
|
subcommands: ['run'],
|
|
defaultSubcommand: 'run',
|
|
handlers: {
|
|
run: () => {
|
|
const result = a.auditOpenArtifacts(cwd);
|
|
if (wantJson) {
|
|
// io.output JSON-stringifies its first arg; pass the object directly.
|
|
c.output(result, raw);
|
|
} else {
|
|
// Human-readable report must bypass JSON encoding — use the rawValue
|
|
// form (third arg) which io.output emits verbatim.
|
|
c.output(null, true, a.formatAuditReport(result));
|
|
}
|
|
},
|
|
},
|
|
unknownMessage: (subcommand: string) =>
|
|
`Unknown audit-open subcommand: "${subcommand}". audit-open takes no subcommands (use --json for JSON output).`,
|
|
error,
|
|
cwd,
|
|
raw,
|
|
});
|
|
}
|
|
|
|
export = {
|
|
routeAuditUat,
|
|
routeAuditOpen,
|
|
};
|