5b5d473e13
Phase 1 of #3464. Removes the `// allow-test-rule:` marker from 22 test files where it is provably vestigial, and tightens the ratchet ceiling in scripts/lint-allow-test-rule-refs.ceiling.json from 305 to 285. Eligibility is decided by two independent AST discriminators, both conservative (any doubt => keep): (a) Read-target type. Every readFileSync/readFile call in the file resolves statically to a prose/config extension (.md/.json/.yml/.yaml/.toml/.txt), or the file performs no reads at all. Any read of a source extension (.cjs/.js/.mjs/.ts/.cts/.mts/.jsx/.tsx), any dynamic/unresolvable path, and any other extension all disqualify the file. (b) Marker context. Every `allow-test-rule:` occurrence is a genuine comment node, never string- or template-literal payload. A marker that lives inside a RuleTester `code:` fixture is test DATA, not a suppression directive; stripping it corrupts the test. tests/eslint-rules.test.cjs is the one such fixture host and is deliberately untouched. An earlier attempt at this phase classified markers by "strip it and see if local/no-source-grep still passes" and was reverted in full before commit. That oracle is unsound: the rule only fires on a literal .cjs/.js/.ts path containing a quoted bin/lib/gsd-core/src segment, tracked one hop from the binding, so files that genuinely source-grep real JavaScript pass it silently -- tests/no-unbounded-spawn-allowlist.test.cjs (reads test sources through a listTestFiles() walk) and tests/claude-imperative-reference.test.cjs (matches bin/install.js through an intermediate variable) both cleared it while being real source-greps. The rule's implementation is narrower than its intent, so it cannot adjudicate whether an exemption is load-bearing. Scope is limited to comment deletions: the diff over the test tree is 100% line removals with zero insertions, and no executable line is altered. On the ceiling value. The measured count at this HEAD is 283, so 285 leaves 2 slack -- deliberate, and well inside the documented grace band of 3. Pinning the ceiling to the exact count makes this change effectively unmergeable: any concurrent PR that lands one marker-bearing test file re-reds it. That race fired twice while preparing this branch (once mid-rebase taking the count 304->305 on next, once between rebase and the verification run taking it 282->283), and it is the same race that broke next in #3461. A ceiling of actual+2 preserves a merge window while still ratcheting 305 -> 285. Known limit, disclosed rather than papered over: this clears 22 of 303 markers and does not reach #3464's trend-to-zero goal. Most of the remaining markers sit on dynamic-path reads, commonly a hoisted `const p = path.join(tmpDir, 'STATE.md')` whose target is prose but is unresolvable to this classifier. A stricter one-hop const resolution would flip an estimated 95 more; that is deliberately left to a follow-up so it can be reviewed on its own evidence. Marker discovery reads bytes rather than shelling out to grep: tests/security-prompt-injection.security.test.cjs carries a literal NUL byte (an intentional injection fixture) that makes grep treat it as binary and skip it, which is why the true marked-file count is 303 and not the 302 a shell scan reports. Closes #3465 Co-authored-by: sim <sim@local> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
98 lines
4.3 KiB
JavaScript
98 lines
4.3 KiB
JavaScript
// Reads .md/.json/.yml product files whose deployed text IS what the
|
|
// runtime loads — testing text content tests the deployed contract.
|
|
|
|
/**
|
|
* Tests for --all flag on /gsd-discuss-phase (#2188)
|
|
*
|
|
* The --all flag auto-selects all gray areas, skipping the interactive
|
|
* AskUserQuestion, but does NOT auto-advance to plan-phase afterward
|
|
* (unlike --auto which both auto-selects and auto-advances).
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('#2188: discuss-phase --all flag', () => {
|
|
test('discuss-phase command argument-hint includes --all', () => {
|
|
const command = fs.readFileSync(
|
|
path.join(__dirname, '..', 'commands', 'gsd', 'discuss-phase.md'), 'utf8'
|
|
);
|
|
assert.ok(command.includes('--all'), 'argument-hint should include --all');
|
|
});
|
|
|
|
test('discuss-phase command description mentions --all', () => {
|
|
const command = fs.readFileSync(
|
|
path.join(__dirname, '..', 'commands', 'gsd', 'discuss-phase.md'), 'utf8'
|
|
);
|
|
// The description frontmatter or objective should reference --all
|
|
assert.ok(command.includes('--all'), 'command description should mention --all flag');
|
|
});
|
|
|
|
test('discuss-phase workflow handles --all flag in present_gray_areas', () => {
|
|
const workflow = fs.readFileSync(
|
|
path.join(__dirname, '..', 'gsd-core', 'workflows', 'discuss-phase.md'), 'utf8'
|
|
);
|
|
assert.ok(workflow.includes('--all'), 'workflow should handle --all flag');
|
|
});
|
|
|
|
test('discuss-phase workflow auto-selects all areas when --all is present', () => {
|
|
const workflow = fs.readFileSync(
|
|
path.join(__dirname, '..', 'gsd-core', 'workflows', 'discuss-phase.md'), 'utf8'
|
|
);
|
|
// The present_gray_areas step must trigger auto-select when --all is set
|
|
const grayAreasStep = workflow.slice(
|
|
workflow.indexOf('<step name="present_gray_areas">'),
|
|
workflow.indexOf('</step>', workflow.indexOf('<step name="present_gray_areas">'))
|
|
);
|
|
assert.ok(grayAreasStep.includes('--all'), 'present_gray_areas step should handle --all');
|
|
assert.ok(
|
|
grayAreasStep.includes('Auto-select') || grayAreasStep.includes('auto-select'),
|
|
'present_gray_areas step should auto-select areas when --all is set'
|
|
);
|
|
});
|
|
|
|
test('discuss-phase workflow does NOT auto-advance when --all is used without --auto or --chain', () => {
|
|
const workflow = fs.readFileSync(
|
|
path.join(__dirname, '..', 'gsd-core', 'workflows', 'discuss-phase.md'), 'utf8'
|
|
);
|
|
// The auto_advance step should NOT treat --all as a trigger for plan-phase auto-launch
|
|
const autoAdvanceStep = workflow.slice(
|
|
workflow.indexOf('<step name="auto_advance">'),
|
|
workflow.indexOf('</step>', workflow.indexOf('<step name="auto_advance">'))
|
|
);
|
|
// --all should NOT appear in the auto-advance trigger conditions
|
|
// (it is not a chain/auto flag — it only affects area selection)
|
|
assert.ok(
|
|
!autoAdvanceStep.includes('--all') ||
|
|
autoAdvanceStep.includes('--all does not trigger auto-advance') ||
|
|
autoAdvanceStep.includes('--all is NOT an auto-advance trigger'),
|
|
'--all should not trigger auto-advance in auto_advance step'
|
|
);
|
|
});
|
|
|
|
test('discuss-phase workflow initialize step documents --all flag behavior', () => {
|
|
const workflow = fs.readFileSync(
|
|
path.join(__dirname, '..', 'gsd-core', 'workflows', 'discuss-phase.md'), 'utf8'
|
|
);
|
|
// The initialize step should document --all mode like it documents --auto and --chain
|
|
const initStep = workflow.slice(
|
|
workflow.indexOf('<step name="initialize"'),
|
|
workflow.indexOf('</step>', workflow.indexOf('<step name="initialize"'))
|
|
);
|
|
assert.ok(initStep.includes('--all'), 'initialize step should document --all flag');
|
|
});
|
|
|
|
test('COMMANDS.md documents --all flag for discuss-phase', () => {
|
|
const commands = fs.readFileSync(
|
|
path.join(__dirname, '..', 'docs', 'COMMANDS.md'), 'utf8'
|
|
);
|
|
// Find the discuss-phase section and verify --all is documented
|
|
const discussSection = commands.slice(
|
|
commands.indexOf('gsd-discuss-phase') > -1 ? commands.indexOf('gsd-discuss-phase') : commands.indexOf('discuss-phase')
|
|
);
|
|
assert.ok(discussSection.includes('--all'), 'COMMANDS.md should document --all for discuss-phase');
|
|
});
|
|
});
|