* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
95 lines
4.2 KiB
JavaScript
95 lines
4.2 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* Regression test for #2196
|
|
*
|
|
* autonomous.md exceeded the Claude Code Read tool's 10K token limit
|
|
* (reported as 11,748 tokens), causing it to be read in 150-line chunks.
|
|
*
|
|
* Fix: extract the smart_discuss step into a separate reference file so
|
|
* autonomous.md stays under the token limit.
|
|
*
|
|
* At ~4 chars/token, 10K tokens ≈ 40K chars. We target < 38K to stay
|
|
* comfortably under the limit with room for future additions.
|
|
*/
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const PROJECT_ROOT = path.join(__dirname, '..');
|
|
|
|
// ─── Size threshold ──────────────────────────────────────────────────────────
|
|
|
|
// 38K chars ≈ 9,500 tokens — stays below 10K with margin
|
|
const AUTONOMOUS_SIZE_LIMIT = 38 * 1024;
|
|
|
|
// ─── File paths ──────────────────────────────────────────────────────────────
|
|
|
|
const AUTONOMOUS_PATH = path.join(PROJECT_ROOT, 'get-shit-done', 'workflows', 'autonomous.md');
|
|
const SMART_DISCUSS_REF = path.join(PROJECT_ROOT, 'get-shit-done', 'references', 'autonomous-smart-discuss.md');
|
|
|
|
// ─── autonomous.md size ──────────────────────────────────────────────────────
|
|
|
|
describe('autonomous.md size constraints (#2196)', () => {
|
|
test('autonomous.md file exists', () => {
|
|
assert.ok(fs.existsSync(AUTONOMOUS_PATH), `Missing: ${AUTONOMOUS_PATH}`);
|
|
});
|
|
|
|
test('autonomous.md is under 38K chars (below Claude Code 10K-token Read limit)', () => {
|
|
const raw = fs.readFileSync(AUTONOMOUS_PATH, 'utf-8');
|
|
const content = raw.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
|
|
assert.ok(
|
|
content.length < AUTONOMOUS_SIZE_LIMIT,
|
|
`autonomous.md is ${content.length} chars, expected < ${AUTONOMOUS_SIZE_LIMIT} to stay under ` +
|
|
`the 10K token Read limit. Extract smart_discuss step to autonomous-smart-discuss.md reference.`
|
|
);
|
|
});
|
|
});
|
|
|
|
// ─── Reference file exists ───────────────────────────────────────────────────
|
|
|
|
describe('autonomous-smart-discuss.md reference file', () => {
|
|
test('autonomous-smart-discuss.md exists', () => {
|
|
assert.ok(
|
|
fs.existsSync(SMART_DISCUSS_REF),
|
|
`Missing: ${SMART_DISCUSS_REF} — smart_discuss step must be extracted to this file`
|
|
);
|
|
});
|
|
|
|
test('autonomous.md references autonomous-smart-discuss.md', () => {
|
|
const content = fs.readFileSync(AUTONOMOUS_PATH, 'utf-8');
|
|
assert.ok(
|
|
content.includes('autonomous-smart-discuss.md'),
|
|
'autonomous.md must reference autonomous-smart-discuss.md after extraction'
|
|
);
|
|
});
|
|
});
|
|
|
|
// ─── Reference file contains key content ────────────────────────────────────
|
|
|
|
describe('autonomous-smart-discuss.md contains key smart_discuss content', () => {
|
|
test('reference file contains smart_discuss step instructions', () => {
|
|
const content = fs.readFileSync(SMART_DISCUSS_REF, 'utf-8');
|
|
const hasSmartDiscuss =
|
|
content.includes('smart_discuss') ||
|
|
content.includes('Smart Discuss') ||
|
|
content.includes('grey area') ||
|
|
content.includes('grey_area');
|
|
assert.ok(hasSmartDiscuss, 'autonomous-smart-discuss.md must contain smart discuss step content');
|
|
});
|
|
|
|
test('reference file contains CONTEXT.md writing instructions', () => {
|
|
const content = fs.readFileSync(SMART_DISCUSS_REF, 'utf-8');
|
|
assert.ok(
|
|
content.includes('CONTEXT.md'),
|
|
'autonomous-smart-discuss.md must contain instructions for writing CONTEXT.md'
|
|
);
|
|
});
|
|
});
|