918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
54 lines
2.2 KiB
JavaScript
54 lines
2.2 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Reads .md/.json/.yml product files whose deployed text IS what the
|
|
// runtime loads — testing text content tests the deployed contract.
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('Playwright-MCP UI verification integration', () => {
|
|
test('verify-work.md mentions automated UI verification', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(__dirname, '..', 'get-shit-done', 'workflows', 'verify-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
content.toLowerCase().includes('playwright') || content.includes('automated') && content.includes('UI'),
|
|
'verify-work.md should mention automated UI verification option'
|
|
);
|
|
});
|
|
|
|
test('ui-review.md mentions Playwright-MCP when available', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(__dirname, '..', 'get-shit-done', 'workflows', 'ui-review.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
content.toLowerCase().includes('playwright') || content.includes('mcp__playwright'),
|
|
'ui-review.md should reference Playwright-MCP'
|
|
);
|
|
});
|
|
|
|
test('gsd-ui-auditor.md includes automated screenshot guidance', () => {
|
|
const content = fs.readFileSync(
|
|
path.join(__dirname, '..', 'agents', 'gsd-ui-auditor.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
content.toLowerCase().includes('playwright') || content.includes('screenshot') || content.includes('automated'),
|
|
'gsd-ui-auditor.md should mention automated screenshot verification'
|
|
);
|
|
});
|
|
|
|
test('automated verification is optional/conditional (falls back to manual)', () => {
|
|
const verifyContent = fs.readFileSync(
|
|
path.join(__dirname, '..', 'get-shit-done', 'workflows', 'verify-work.md'), 'utf-8'
|
|
);
|
|
// Must include a fallback / "if available" conditional
|
|
const hasConditional =
|
|
verifyContent.includes('if available') ||
|
|
verifyContent.includes('when available') ||
|
|
verifyContent.includes('if Playwright') ||
|
|
verifyContent.includes('fall back');
|
|
assert.ok(hasConditional, 'Playwright integration must be conditional with manual fallback');
|
|
});
|
|
});
|