VS Code is a net-new EoS runtime that — unlike every prior migration — is NOT CLI-installed (Marketplace/VSIX extension). It has zero runtime==='vscode' branches in bin/install.js and stays that way (regression-guarded); it is driven entirely through the negotiated imperative Host-Integration adapter. Registry + validator (the hard part): - capabilities/vscode/capability.json (role:runtime): full hostIntegration block (imperative / palette / active vscode.lm model / engine hook bus / sandboxed-storage / mcp transport / sandboxed-web runtime; dispatch nested, maxDepth 5 per VS Code's documented subagent depth). - capability-validator.cjs extended so a role:runtime capability can legitimately declare "extension-distributed, no config directory": new configHome.kind:'none' + installSurface:'none' (+ GATE-A pairing + the parity maps), with localConfigDir and configHome.name made conditional on kind!=='none'. All 18 runtimes still validate; getDirName returns a distinct sentinel (not '.claude') for a no-config runtime. - The add-a-registry-runtime tax: NON_INSTALLABLE_RUNTIMES exemption in the runtime-flags drift guard, vscode added to global-config-home SPECIAL_CASED, EXPECTED_PROFILES.vscode='ide', and the config-adapter/derivation/pin-count guards updated. No golden-install fixture, model-catalog, or CONFIGURATION rows (vscode never enters allRuntimes). Dispatch + extension surface: - Fixed vscode/extension.js's createHub()-no-args bug (every dispatch was UnknownCommand, masked by a vacuous reachability test) — now reuses the shared dispatchGsdCommand subprocess-shim (Node/desktop); the reachability test is tightened to assert real dispatch. - Promoted the #1933 host binding to a shipped vscode/host-binding.js; activate() now composes the model/hookBus/stateIO seams through it. Corrected the model seam to VS Code's real API (vscode.lm.selectChatModels() -> model.sendRequest(); vscode.lm.sendRequest does not exist) so the binding actually composes on real desktop VS Code instead of throwing. - New vscode/browser.js Web Extension entry with ZERO Node APIs (the engine's config/capability loading is Node-bound, so the web entry registers the surface and directs full dispatch to the native MCP server — honestly documented). - UPGRADE 1: GSD skills as native Language Model Tools (contributes.languageModelTools + vscode.lm.registerTool), invoke() dispatching through the hub. - UPGRADE 2: native subagent dispatch wired onto #runSubagent / chat.subagents.allowInvocationsFromSubagents (fail-soft on API availability, maxDepth 5 enforced). - vscode/package.json: browser entry, engines.vscode ^1.105, chatParticipants + languageModelTools contributions; fixed a stale activationPoints->activationEvents manifest key. Added "vscode" to the package files array. Docs (## vscode matrix section) + changeset (Added). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
99 lines
4.6 KiB
JavaScript
99 lines
4.6 KiB
JavaScript
'use strict';
|
|
/**
|
|
* Drift-guard + collapse: getGlobalConfigHomeFragment must be the SINGLE source
|
|
* of truth for the runtime → global config-home path-fragment mapping used by
|
|
* `getConfigDirFromHome` in bin/install.js for hook path.join() codegen.
|
|
*
|
|
* Collapses the prior branch `if (runtime === 'x') return "'...'"` chain
|
|
* (install.js ~514-543) into one table — ADR-1239 Phase B / #1679, AC2 slice 2.
|
|
*
|
|
* Invariants pinned here:
|
|
* 1. Each of the 13 table runtimes returns its exact verbatim source fragment
|
|
* (byte-identical to the prior chain — golden install parity asserts the
|
|
* generated hook output is unchanged).
|
|
* 2. claude + unknown + empty fall back to the default "'.claude'" fragment.
|
|
* 3. antigravity is intentionally NOT in the table (handled dynamically by the
|
|
* caller via resolveAntigravityGlobalDir).
|
|
* 4. Drift guard: every registry runtime EXCEPT {claude, antigravity} has a
|
|
* table entry — so adding a runtime forces a deliberate fragment decision
|
|
* here (the add-a-host tax this collapse removes).
|
|
*
|
|
* ADR-1239 Phase B (#1679). Behavioral tests only.
|
|
*/
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const runtimeNamePolicy = require('../gsd-core/bin/lib/runtime-name-policy.cjs');
|
|
const registry = require('../gsd-core/bin/lib/capability-registry.cjs');
|
|
|
|
const { getGlobalConfigHomeFragment } = runtimeNamePolicy;
|
|
|
|
// Golden oracle: the exact source-string fragments the prior install.js chain
|
|
// emitted, preserved verbatim. These are path.join() arg-source snippets (the
|
|
// embedded quotes/commas are intentional — they get spliced into generated hook
|
|
// scripts). Pinned here as the test oracle.
|
|
const GOLDEN_FRAGMENT_MAP = {
|
|
copilot: "'.copilot'",
|
|
opencode: "'.config', 'opencode'",
|
|
kilo: "'.config', 'kilo'",
|
|
codex: "'.codex'",
|
|
cursor: "'.cursor'",
|
|
windsurf: "'.windsurf'",
|
|
augment: "'.augment'",
|
|
trae: "'.trae'",
|
|
qwen: "'.qwen'",
|
|
hermes: "'.hermes'",
|
|
codebuddy: "'.codebuddy'",
|
|
cline: "'.cline'",
|
|
kimi: "'.config', 'agents'",
|
|
zcode: "'.zcode'",
|
|
pi: "'.pi', 'agent'",
|
|
};
|
|
|
|
// Runtimes intentionally NOT in the table: claude is the default; antigravity is
|
|
// resolved dynamically by the caller (resolveAntigravityGlobalDir + path.relative);
|
|
// vscode (#2103) is extension-distributed with no file-projected config home at
|
|
// all — getGlobalConfigHomeFragment is never invoked for it (no install surface).
|
|
const SPECIAL_CASED = new Set(['claude', 'antigravity', 'vscode']);
|
|
|
|
test('getGlobalConfigHomeFragment: golden map matches for all 13 table runtimes', () => {
|
|
for (const [id, expected] of Object.entries(GOLDEN_FRAGMENT_MAP)) {
|
|
const actual = getGlobalConfigHomeFragment(id);
|
|
assert.strictEqual(
|
|
actual,
|
|
expected,
|
|
`getGlobalConfigHomeFragment('${id}') diverged from golden.\n` +
|
|
` actual: ${JSON.stringify(actual)}\n` +
|
|
` expected: ${JSON.stringify(expected)}`,
|
|
);
|
|
}
|
|
});
|
|
|
|
test('getGlobalConfigHomeFragment fallback: claude/unknown/empty return the default fragment', () => {
|
|
assert.strictEqual(getGlobalConfigHomeFragment('claude'), "'.claude'",
|
|
'claude must return the default fragment (it is special-cased as the default)');
|
|
assert.strictEqual(getGlobalConfigHomeFragment('unknown'), "'.claude'",
|
|
'unknown runtime must return the default fragment');
|
|
assert.strictEqual(getGlobalConfigHomeFragment(''), "'.claude'",
|
|
'empty input must return the default fragment');
|
|
});
|
|
|
|
test('drift guard: every registry runtime except {claude, antigravity} has a table entry (add-a-host tax removed)', () => {
|
|
// A newly-added registry runtime that is NOT claude/antigravity MUST get a
|
|
// deliberate fragment entry here — otherwise it silently falls through to the
|
|
// '.claude' default. claude (default) and antigravity (caller-dynamic) are the
|
|
// only legitimate absences.
|
|
const tableIds = new Set(Object.keys(GOLDEN_FRAGMENT_MAP));
|
|
const missing = Object.keys(registry.runtimes)
|
|
.filter((id) => !SPECIAL_CASED.has(id) && !tableIds.has(id));
|
|
assert.deepEqual(missing, [],
|
|
`registry runtimes missing a fragment table entry (add one to GOLDEN_FRAGMENT_MAP + the module table, or add to SPECIAL_CASED if caller-dynamic): ${missing.join(', ')}`);
|
|
});
|
|
|
|
test('drift guard: table keys are a subset of the registry (no stale entries)', () => {
|
|
const registryIds = new Set(Object.keys(registry.runtimes));
|
|
const stale = Object.keys(GOLDEN_FRAGMENT_MAP).filter((id) => !registryIds.has(id));
|
|
assert.deepEqual(stale, [],
|
|
`fragment table references runtimes not in the registry (stale entries): ${stale.join(', ')}`);
|
|
});
|