* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) Golden/read-only parity tests and registry alignment, query handler fixes (check-completion, state-mutation, commit, validate, summary, etc.), and WAITING.json dual-write for .gsd/.planning readers. Refs gsd-build/get-shit-done#2341 * fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback) - Recognize in-flight 🟡 milestone bullets like 🚧. - Derive from last **vX.Y Title** before ## Phases when emoji absent. - Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y in cleaned text instead of first (avoids v1.0 from shipped list). - Fixes init.execute-phase milestone_version and buildStateFrontmatter after state.begin-phase (syncStateFrontmatter). * feat(sdk): phase list, plan task structure, requirements extract handlers - Register phase.list-plans, phase.list-artifacts, plan.task-structure, requirements.extract-from-plans (SDK-only; golden-policy exceptions). - Add unit tests; document in QUERY-HANDLERS.md. - writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored. * feat(sdk): centralize getGsdAgentsDir in query helpers Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary ~/.claude/agents, legacy path). Use from init and docs-init init bundles. docs(15): add 15-CONTEXT for autonomous phase-15 run. * feat(sdk): query CLI CJS fallback and session correlation - createRegistry(eventStream, sessionId) threads correlation into mutation events - gsd-sdk query falls back to gsd-tools.cjs when no native handler matches (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings - Export createRegistry from @gsd-build/sdk; add sdk/README.md - Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId - Agents: prefer node dist/cli.js query over cat/grep for STATE and plans * fix(sdk): init phase_found parity, docs-init agents path, state field extract - Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal) - docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled - state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard) - Tests: commit_docs default true; config-get golden uses temp config; golden integration green Refs: #2302 * refactor(sdk): share SessionJsonlRecord in profile-extract-messages CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages. * fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify) - Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command - plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment - check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default - state.validate/sync: phaseTokenMatches + comparePhaseNum ordering - verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter - audit-open: has_scan_errors, unreadable rows, human report when scans fail - requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note - ingest-docs: repo-root path containment; classifier output slug-hash Golden parity test strips has_scan_errors until CJS adds field. * fix: Resolve CodeRabbit security and quality findings - Secure intel.ts and cli.ts against path traversal - Catch and validate git add status in commit.ts - Expand roadmap milestone marker extraction - Fix parsing array-of-objects in frontmatter YAML - Fix unhandled config evaluations - Improve coverage test parity mapping * test: raise planner character extraction limit to 48K * fix(sdk): resolve TS build error in docs-init passing config
104 lines
3.4 KiB
TypeScript
104 lines
3.4 KiB
TypeScript
/**
|
|
* Ship preflight checks (`check.ship-ready`).
|
|
*
|
|
* Consolidates git/gh checks from `ship.md` into a single structured query.
|
|
* All subprocess calls are wrapped in try/catch — never throws on git/gh failures.
|
|
* See `.planning/research/decision-routing-audit.md` §3.9.
|
|
*/
|
|
|
|
import { execSync } from 'node:child_process';
|
|
import { GSDError, ErrorClassification } from '../errors.js';
|
|
import { normalizePhaseName } from './helpers.js';
|
|
import { checkVerificationStatus } from './check-verification-status.js';
|
|
import type { QueryHandler } from './utils.js';
|
|
|
|
function runSyncSafe(cmd: string, cwd: string): string | null {
|
|
try {
|
|
return execSync(cmd, { cwd, encoding: 'utf-8', stdio: ['pipe', 'pipe', 'pipe'] }).trim();
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function boolSyncSafe(cmd: string, cwd: string): boolean {
|
|
return runSyncSafe(cmd, cwd) !== null;
|
|
}
|
|
|
|
export const checkShipReady: QueryHandler = async (args, projectDir) => {
|
|
const raw = args[0];
|
|
if (!raw) {
|
|
throw new GSDError('phase number required for check ship-ready', ErrorClassification.Validation);
|
|
}
|
|
|
|
normalizePhaseName(raw); // validate format
|
|
|
|
const blockers: string[] = [];
|
|
|
|
// git checks — all wrapped in try/catch via helpers
|
|
const porcelain = runSyncSafe('git status --porcelain', projectDir);
|
|
const clean_tree = porcelain !== null && porcelain === '';
|
|
|
|
const current_branch = runSyncSafe('git rev-parse --abbrev-ref HEAD', projectDir);
|
|
const on_feature_branch =
|
|
current_branch !== null &&
|
|
current_branch !== 'main' &&
|
|
current_branch !== 'master';
|
|
|
|
// Determine base branch
|
|
let base_branch: string | null = null;
|
|
if (current_branch) {
|
|
const mergeRef = runSyncSafe(`git config --get branch.${current_branch}.merge`, projectDir);
|
|
if (mergeRef) {
|
|
base_branch = mergeRef.replace('refs/heads/', '');
|
|
} else {
|
|
// Fallback: check if 'main' branch exists, else 'master'
|
|
const mainExists = boolSyncSafe('git rev-parse --verify main', projectDir);
|
|
base_branch = mainExists ? 'main' : 'master';
|
|
}
|
|
}
|
|
|
|
const remoteOut = runSyncSafe('git remote', projectDir);
|
|
const remote_configured = remoteOut !== null && remoteOut.trim().length > 0;
|
|
|
|
// gh availability
|
|
const gh_available =
|
|
boolSyncSafe('gh --version', projectDir) ||
|
|
boolSyncSafe('which gh', projectDir);
|
|
|
|
// gh_authenticated: advisory — skip actual auth check to avoid slow network call
|
|
const gh_authenticated = false;
|
|
|
|
// Verification status
|
|
let verification_passed = false;
|
|
try {
|
|
const verRes = await checkVerificationStatus([raw], projectDir);
|
|
const vdata = verRes.data as Record<string, unknown>;
|
|
verification_passed = vdata.status !== 'fail';
|
|
} catch {
|
|
verification_passed = false;
|
|
}
|
|
|
|
// Collect blockers
|
|
if (!verification_passed) blockers.push('verification status is fail or missing');
|
|
if (!clean_tree) blockers.push('working tree is not clean (uncommitted changes)');
|
|
if (!on_feature_branch) blockers.push('not on a feature branch (currently on main/master or unknown)');
|
|
if (!remote_configured) blockers.push('no git remote configured');
|
|
|
|
const ready = verification_passed && clean_tree && on_feature_branch && remote_configured;
|
|
|
|
return {
|
|
data: {
|
|
ready,
|
|
verification_passed,
|
|
clean_tree,
|
|
on_feature_branch,
|
|
current_branch,
|
|
base_branch,
|
|
remote_configured,
|
|
gh_available,
|
|
gh_authenticated,
|
|
blockers,
|
|
},
|
|
};
|
|
};
|