* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
289 lines
10 KiB
TypeScript
289 lines
10 KiB
TypeScript
/**
|
|
* Configuration Module — single source of truth for config loading,
|
|
* legacy-key normalization, defaults merge, and explicit on-disk migration.
|
|
*
|
|
* ADR-457 build-at-publish: the hand-written bin/lib/configuration.cjs collapsed
|
|
* to a TypeScript source of truth. Behaviour is preserved byte-for-behaviour
|
|
* from the prior hand-written .cjs; only types are added.
|
|
*/
|
|
|
|
import { readFileSync, writeFileSync, existsSync, readdirSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
|
|
// In .cts (CommonJS output) files, `require` is available as a global.
|
|
const _require: NodeRequire = require;
|
|
|
|
// ─── Manifest requires ───────────────────────────────────────────────────────
|
|
function loadConfigurationManifest(fileName: string): Record<string, unknown> {
|
|
const candidates = [
|
|
// Installed runtime layout: gsd-core/bin/shared/*.manifest.json
|
|
join(__dirname, '..', 'shared', fileName),
|
|
];
|
|
let lastErr: Error | null = null;
|
|
for (const candidate of candidates) {
|
|
try {
|
|
return _require(candidate) as Record<string, unknown>;
|
|
} catch (err) {
|
|
const e = err as NodeJS.ErrnoException;
|
|
const isMissingCandidate =
|
|
e && e.code === 'MODULE_NOT_FOUND' && String(e.message || '').includes(candidate);
|
|
if (!isMissingCandidate) throw err;
|
|
lastErr = e;
|
|
}
|
|
}
|
|
throw new Error(
|
|
`${fileName} not found. Tried:\n${candidates.map((p) => ` ${p}`).join('\n')}\nLast error: ${lastErr?.message}`
|
|
);
|
|
}
|
|
|
|
const CONFIG_DEFAULTS = loadConfigurationManifest('config-defaults.manifest.json');
|
|
const SCHEMA_MANIFEST = loadConfigurationManifest('config-schema.manifest.json') as {
|
|
validKeys: string[];
|
|
runtimeStateKeys: string[];
|
|
dynamicKeyPatterns: Array<{ source: string; [k: string]: unknown }>;
|
|
};
|
|
const VALID_CONFIG_KEYS = new Set<string>(SCHEMA_MANIFEST.validKeys);
|
|
const RUNTIME_STATE_KEYS = new Set<string>(SCHEMA_MANIFEST.runtimeStateKeys);
|
|
|
|
interface DynamicKeyPattern {
|
|
source: string;
|
|
test: (key: string) => boolean;
|
|
[k: string]: unknown;
|
|
}
|
|
|
|
const DYNAMIC_KEY_PATTERNS: DynamicKeyPattern[] = SCHEMA_MANIFEST.dynamicKeyPatterns.map((p) => {
|
|
const pattern = new RegExp(p.source);
|
|
return {
|
|
...p,
|
|
test: (key: string) => {
|
|
pattern.lastIndex = 0;
|
|
return pattern.test(key);
|
|
},
|
|
};
|
|
});
|
|
|
|
// ─── Depth → Granularity mapping ─────────────────────────────────────────────
|
|
const DEPTH_TO_GRANULARITY: Record<string, string> = {
|
|
quick: 'coarse',
|
|
standard: 'standard',
|
|
comprehensive: 'fine',
|
|
};
|
|
|
|
// ─── Internal helpers ─────────────────────────────────────────────────────────
|
|
function planningDir(cwd: string, workstream?: string): string {
|
|
if (!workstream)
|
|
return join(cwd, '.planning');
|
|
return join(cwd, '.planning', 'workstreams', workstream);
|
|
}
|
|
|
|
function detectSubRepos(cwd: string): string[] {
|
|
const results: string[] = [];
|
|
try {
|
|
const entries = readdirSync(cwd, { withFileTypes: true });
|
|
for (const entry of entries) {
|
|
if (!entry.isDirectory())
|
|
continue;
|
|
if (entry.name.startsWith('.') || entry.name === 'node_modules')
|
|
continue;
|
|
const gitPath = join(cwd, entry.name, '.git');
|
|
try {
|
|
if (existsSync(gitPath)) {
|
|
results.push(entry.name);
|
|
}
|
|
}
|
|
catch { /* ignore */ }
|
|
}
|
|
}
|
|
catch { /* ignore */ }
|
|
return results.sort();
|
|
}
|
|
|
|
function deepMergeConfig(base: Record<string, unknown>, overlay: Record<string, unknown>): Record<string, unknown> {
|
|
const result: Record<string, unknown> = { ...base };
|
|
for (const key of Object.keys(overlay)) {
|
|
const ov = overlay[key];
|
|
if (ov !== null && ov !== undefined && typeof ov === 'object' && !Array.isArray(ov)) {
|
|
const bv = base[key];
|
|
if (bv !== null && bv !== undefined && typeof bv === 'object' && !Array.isArray(bv)) {
|
|
result[key] = deepMergeConfig(bv as Record<string, unknown>, ov as Record<string, unknown>);
|
|
}
|
|
else {
|
|
result[key] = deepMergeConfig({}, ov as Record<string, unknown>);
|
|
}
|
|
}
|
|
else {
|
|
result[key] = ov;
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
|
|
// ─── Exported types ───────────────────────────────────────────────────────────
|
|
|
|
interface Normalization {
|
|
from: string;
|
|
to: string;
|
|
value: unknown;
|
|
requiresFilesystem?: boolean;
|
|
}
|
|
|
|
interface NormalizeLegacyKeysResult {
|
|
parsed: Record<string, unknown>;
|
|
normalizations: Normalization[];
|
|
}
|
|
|
|
interface LoadConfigOptions {
|
|
workstream?: string;
|
|
onNormalizations?: (normalizations: Normalization[]) => void;
|
|
}
|
|
|
|
interface MigrateOnDiskResult {
|
|
migrated: boolean;
|
|
normalizations: Normalization[];
|
|
wrote: string | null;
|
|
}
|
|
|
|
// ─── Exported functions ───────────────────────────────────────────────────────
|
|
function normalizeLegacyKeys(parsed: Record<string, unknown>): NormalizeLegacyKeysResult {
|
|
const result: Record<string, unknown> = { ...parsed };
|
|
const normalizations: Normalization[] = [];
|
|
// 1. branching_strategy → git.branching_strategy
|
|
if (Object.prototype.hasOwnProperty.call(result, 'branching_strategy')) {
|
|
const value = result['branching_strategy'];
|
|
const git = (result['git'] ?? {}) as Record<string, unknown>;
|
|
if (git['branching_strategy'] === undefined) {
|
|
result['git'] = { ...git, branching_strategy: value };
|
|
}
|
|
else {
|
|
// canonical nested wins — just delete the stale top-level
|
|
result['git'] = { ...git };
|
|
}
|
|
delete result['branching_strategy'];
|
|
normalizations.push({ from: 'branching_strategy', to: 'git.branching_strategy', value });
|
|
}
|
|
// 2. top-level sub_repos → planning.sub_repos
|
|
if (Object.prototype.hasOwnProperty.call(result, 'sub_repos')) {
|
|
const value = result['sub_repos'];
|
|
const planning = (result['planning'] ?? {}) as Record<string, unknown>;
|
|
if (planning['sub_repos'] === undefined) {
|
|
result['planning'] = { ...planning, sub_repos: value };
|
|
}
|
|
else {
|
|
// canonical nested wins — just drop the stale top-level
|
|
result['planning'] = { ...planning };
|
|
}
|
|
delete result['sub_repos'];
|
|
normalizations.push({ from: 'sub_repos', to: 'planning.sub_repos', value });
|
|
}
|
|
// 3. multiRepo: true → marker (filesystem detection deferred to migrateOnDisk / caller)
|
|
if (result['multiRepo'] === true) {
|
|
delete result['multiRepo'];
|
|
normalizations.push({ from: 'multiRepo', to: 'planning.sub_repos', value: true, requiresFilesystem: true });
|
|
}
|
|
// 4. top-level depth → granularity
|
|
if (Object.prototype.hasOwnProperty.call(result, 'depth') && !Object.prototype.hasOwnProperty.call(result, 'granularity')) {
|
|
const rawDepth = result['depth'] as string;
|
|
const mapped = DEPTH_TO_GRANULARITY[rawDepth] ?? rawDepth;
|
|
result['granularity'] = mapped;
|
|
delete result['depth'];
|
|
normalizations.push({ from: 'depth', to: 'granularity', value: mapped });
|
|
}
|
|
return { parsed: result, normalizations };
|
|
}
|
|
|
|
function mergeDefaults(parsed: Record<string, unknown>): Record<string, unknown> {
|
|
// Start with a deep clone of defaults, then overlay parsed
|
|
const defaults = structuredClone(CONFIG_DEFAULTS);
|
|
return deepMergeConfig(defaults, parsed);
|
|
}
|
|
|
|
function loadConfig(cwd: string, options?: LoadConfigOptions): Record<string, unknown> {
|
|
const configPath = join(planningDir(cwd, options?.workstream), 'config.json');
|
|
let raw: string;
|
|
try {
|
|
raw = readFileSync(configPath, 'utf-8');
|
|
}
|
|
catch {
|
|
// File missing — return defaults
|
|
return mergeDefaults({});
|
|
}
|
|
const trimmed = raw.trim();
|
|
if (trimmed === '') {
|
|
return mergeDefaults({});
|
|
}
|
|
let parsed: unknown;
|
|
try {
|
|
parsed = JSON.parse(trimmed);
|
|
}
|
|
catch (err) {
|
|
const msg = err instanceof Error ? err.message : String(err);
|
|
throw new Error(`Failed to parse config at ${configPath}: ${msg}`);
|
|
}
|
|
if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed)) {
|
|
throw new Error(`Config at ${configPath} must be a JSON object`);
|
|
}
|
|
const { parsed: normalized, normalizations } = normalizeLegacyKeys(parsed as Record<string, unknown>);
|
|
if (options?.onNormalizations && normalizations.length > 0) {
|
|
options.onNormalizations(normalizations);
|
|
}
|
|
return mergeDefaults(normalized);
|
|
}
|
|
|
|
function migrateOnDisk(cwd: string, workstream?: string): MigrateOnDiskResult {
|
|
const configPath = join(planningDir(cwd, workstream), 'config.json');
|
|
let raw: string;
|
|
try {
|
|
raw = readFileSync(configPath, 'utf-8');
|
|
}
|
|
catch {
|
|
// File missing — nothing to migrate
|
|
return { migrated: false, normalizations: [], wrote: null };
|
|
}
|
|
const trimmed = raw.trim();
|
|
if (trimmed === '') {
|
|
return { migrated: false, normalizations: [], wrote: null };
|
|
}
|
|
let parsed: unknown;
|
|
try {
|
|
parsed = JSON.parse(trimmed);
|
|
}
|
|
catch {
|
|
// Malformed — can't migrate
|
|
return { migrated: false, normalizations: [], wrote: null };
|
|
}
|
|
const { parsed: normalized, normalizations } = normalizeLegacyKeys(parsed as Record<string, unknown>);
|
|
if (normalizations.length === 0) {
|
|
return { migrated: false, normalizations: [], wrote: null };
|
|
}
|
|
// Resolve multiRepo filesystem detection
|
|
const result: Record<string, unknown> = { ...normalized };
|
|
for (const norm of normalizations) {
|
|
if (norm.requiresFilesystem) {
|
|
const detected = detectSubRepos(cwd);
|
|
if (detected.length > 0) {
|
|
const planning = (result['planning'] ?? {}) as Record<string, unknown>;
|
|
result['planning'] = { ...planning, sub_repos: detected, commit_docs: false };
|
|
}
|
|
}
|
|
}
|
|
try {
|
|
writeFileSync(configPath, JSON.stringify(result, null, 2));
|
|
}
|
|
catch (err) {
|
|
const msg = err instanceof Error ? err.message : String(err);
|
|
throw new Error(`Failed to write migrated config at ${configPath}: ${msg}`);
|
|
}
|
|
return { migrated: true, normalizations, wrote: configPath };
|
|
}
|
|
|
|
export {
|
|
loadConfig,
|
|
normalizeLegacyKeys,
|
|
mergeDefaults,
|
|
migrateOnDisk,
|
|
CONFIG_DEFAULTS,
|
|
VALID_CONFIG_KEYS,
|
|
RUNTIME_STATE_KEYS,
|
|
DYNAMIC_KEY_PATTERNS,
|
|
};
|