Files
msd-core/commands/gsd/plan-review-convergence.md
Jeremy McSpadden f61b97276e fix(#724): block convergence on actionable review findings (#728)
* fix(#724): block convergence on actionable review findings

* merge: integrate clean next (#936 inline) onto author tip + re-apply cursor fixes (Mode field, REVIEWS.md extraction) and review hardening (#724)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-10 14:54:15 -04:00

3.3 KiB

name, description, argument-hint, allowed-tools, requires
name description argument-hint allowed-tools requires
gsd:plan-review-convergence Cross-AI plan convergence - replan until review concerns are resolved. <phase> [--codex] [--gemini] [--claude] [--opencode] [--ollama] [--lm-studio] [--llama-cpp] [--text] [--ws <name>] [--all] [--max-cycles N]
Read
Write
Bash
Glob
Grep
Agent
Skill
AskUserQuestion
phase
review
Cross-AI plan convergence loop — an outer revision gate around gsd-review and gsd-planner. Repeatedly: review plans with external AI CLIs → if HIGH or actionable non-HIGH concerns remain → replan with --reviews feedback → re-review. Stops when no unresolved HIGH concerns or actionable MEDIUM/LOW findings remain outside PLAN.md, or when max cycles is reached.

Flow: Skill("gsd-plan-phase") → Agent→Skill("gsd-review") → check unresolved HIGH + actionable non-HIGH → Skill("gsd-plan-phase --reviews") → Agent→Skill("gsd-review") → ... → Converge or escalate

Replaces gsd-plan-phase's internal gsd-plan-checker with external AI reviewers (codex, gemini, etc.). Plan-phase runs inline (bare Skill at depth 0) so it can spawn gsd-planner/gsd-plan-checker at depth 1. Review runs inside an isolated Agent (gsd-review is a Bash leaf — no sub-agents needed). Orchestrator only does loop control.

Orchestrator role: Parse arguments, validate phase, run plan-phase inline (Skill at depth 0), spawn an Agent for gsd-review, check unresolved HIGH and actionable non-HIGH counts, stall detection, escalation gate.

<execution_context> @$HOME/.claude/gsd-core/workflows/plan-review-convergence.md @$HOME/.claude/gsd-core/references/revision-loop.md @$HOME/.claude/gsd-core/references/gates.md @$HOME/.claude/gsd-core/references/agent-contracts.md </execution_context>

<runtime_note> Copilot (VS Code): Use vscode_askquestions wherever this workflow calls AskUserQuestion. They are equivalent — vscode_askquestions is the VS Code Copilot implementation of the same interactive question API. Do not skip questioning steps because AskUserQuestion appears unavailable; use vscode_askquestions instead. </runtime_note>

Phase number: extracted from $ARGUMENTS (required)

Flags:

  • --codex — Use Codex CLI as reviewer (default if no reviewer specified)
  • --gemini — Use Gemini CLI as reviewer
  • --claude — Use Claude CLI as reviewer (separate session)
  • --opencode — Use OpenCode as reviewer
  • --ollama — Use local Ollama server as reviewer (OpenAI-compatible, default host http://localhost:11434; configure model via review.models.ollama)
  • --lm-studio — Use local LM Studio server as reviewer (OpenAI-compatible, default host http://localhost:1234; configure model via review.models.lm_studio)
  • --llama-cpp — Use local llama.cpp server as reviewer (OpenAI-compatible, default host http://localhost:8080; configure model via review.models.llama_cpp)
  • --all — Use all available CLIs and running local model servers
  • --max-cycles N — Maximum replan→review cycles (default: 3)

Feature gate: This command requires workflow.plan_review_convergence=true. Enable with: gsd config-set workflow.plan_review_convergence true

Execute end-to-end. Preserve all workflow gates (pre-flight, revision loop, stall detection, escalation).