* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
7.9 KiB
Cross-AI Plan Convergence via Existing Orchestration Commands
- Status: Proposed
- Date: 2026-05-24
- Issue: #15
Current orchestration commands (/gsd-autonomous and /gsd-progress --next --auto) route planning through gsd-plan-phase and only use local/Claude subagent review paths. The cross-AI convergence path already exists (/gsd-plan-review-convergence, /gsd-review, review.default_reviewers, review.models.*) but is not wired into these orchestrators. This creates a gap: users can configure cross-AI reviewers yet still get local-only planning in autonomous/auto-chain execution.
Decision
Do not add a new command. Add convergence as an orchestration policy in existing commands, with /gsd-progress as the primary operator surface.
- Add a shared plan strategy seam for orchestration workflows:
plan_strategy=local|convergelocalmaps togsd-plan-phaseconvergemaps togsd-plan-review-convergence
- Expose the strategy via existing entry points:
/gsd-progress --next --auto --converge(primary)/gsd-autonomous --converge(parity path for users who prefer autonomous directly)- keep
--cross-aias a compatibility alias for--converge
- Reuse existing reviewer selection semantics from
/gsd-reviewand/gsd-plan-review-convergence:- explicit reviewer flags (
--codex,--gemini,--claude,--opencode,--ollama,--lm-studio,--llama-cpp) --allreview.default_reviewersandreview.models.*config
- explicit reviewer flags (
- Add pass-through flags (no new command surface):
--converge(primary)--cross-ai(alias)- reviewer selector flags listed above
--max-cycles N(forwarded per phase)
- Keep convergence behind existing feature gate:
- if
workflow.plan_review_convergence=falseand--converge(or alias) is requested, fail fast with actionable enable instructions.
- if
- Keep post-execution review behavior unchanged in this slice (
gsd-code-reviewandgsd-ui-reviewstay as-is). Cross-AI code-review fanout is deferred. - Define convergence eligibility and allowed AIs via config (no new command):
- enable gate:
workflow.plan_review_convergence=true - allowed reviewer set:
review.default_reviewers(for no-flag converge runs) - per-reviewer model selection:
review.models.*
- enable gate:
Interface Contract
Existing CLI Surfaces (No New Command)
/gsd-progress --next --auto [--converge|--cross-ai] [reviewer flags] [--max-cycles N]/gsd-autonomous [existing flags] [--converge|--cross-ai] [reviewer flags] [--max-cycles N]
Planning Step Routing
plan_strategy=local:- orchestrator step uses
gsd-plan-phase(current behavior).
- orchestrator step uses
plan_strategy=converge:- orchestrator step uses
gsd-plan-review-convergence. - convergence workflow remains owner of HIGH counting (
CYCLE_SUMMARY), stall detection, and escalation.
- orchestrator step uses
Failure Policy
- If
--converge(or--cross-ai) is requested but convergence gate is disabled:- stop before planning dispatch
- emit exact enable command:
gsd config-set workflow.plan_review_convergence true
- no silent downgrade to
localstrategy.
Configuration Contract (Enable + Allowed AIs)
Convergence is configurable without introducing new config namespaces.
- Enable convergence:
workflow.plan_review_convergence: true
- Define which AIs are allowed by default for convergence runs:
review.default_reviewers: ["codex", "gemini"](example)
- Optionally pin models per allowed reviewer:
review.models.codex,review.models.gemini, etc.
Precedence for reviewer selection in converge mode:
- Explicit CLI reviewer flags (
--codex,--gemini,--all, etc.) review.default_reviewers- If neither resolves to any reviewer, fail fast with actionable message.
Example config:
{
"workflow": {
"plan_review_convergence": true
},
"review": {
"default_reviewers": ["codex", "gemini"],
"models": {
"codex": "gpt-5.4",
"gemini": "gemini-2.5-pro"
}
}
}
Flag Naming
Issue #15 asks for a flag such as --converge or --cross-ai on autonomous execution. --converge is the better primary term because it names the behavior (plan-review convergence loop), not the transport (external AI) or mode label (autonomous).
- Primary:
--converge - Alias:
--cross-ai - Avoid: introducing
--autonomous-*variants (the command already defines that mode)
Options Considered
-
Autonomous-only flag (
/gsd-autonomous --cross-ai)- Files:
commands/gsd/autonomous.md,workflows/autonomous.md - Problem: solves issue #15 directly but leaves
/gsd-progress --next --autoinconsistent. - Benefit: smallest blast radius.
- Drawback: two orchestration modes diverge in behavior.
- Files:
-
Progress-primary + autonomous parity (Chosen)
- Files:
commands/gsd/progress.md,workflows/progress.md,workflows/next.md, plus autonomous wiring - Problem: must keep two orchestrators aligned.
- Solution: one shared plan-strategy seam consumed by both commands.
- Benefit: better locality; users who already drive from
progress --next --autoget convergence without switching workflows.
- Files:
-
Config-only global toggle (no per-run flag)
- Files: config schema + both orchestrators
- Benefit: minimal CLI syntax expansion.
- Drawback: less control per run; harder to do targeted high-cost convergence only when needed.
- Decision: defer; keep explicit runtime flag.
Rubber-Duck Design Notes
Expected behavior: the two existing orchestration entry points should be able to opt into cross-AI plan convergence without adding another top-level command.
Actual behavior: both orchestration entry points always take the local planning route, so external reviewers are never reached unless the user abandons orchestration flow and runs convergence manually.
Wrong assumptions surfaced:
- "Enabling
workflow.plan_review_convergencechanges orchestration behavior." It does not unless the convergence command is explicitly routed. - "Cross-AI config propagates automatically into autonomous/next flows." It only applies where convergence/review workflows are invoked.
- "Adding a separate command is required." Existing orchestration commands are sufficient if they expose a strategy seam and clear flag naming.
Root architectural gap: orchestration flows lack a plan strategy seam (local vs converge).
Scope
In scope
- Plan strategy seam shared by existing orchestration commands.
--cross-aipass-through contract on existing commands.--convergeprimary flag naming and--cross-aicompatibility alias.- Feature-gate behavior contract for convergence strategy.
- Config contract for enabling convergence and selecting allowed AIs.
- Documentation updates tied to command/config behavior.
Out of scope
- New top-level command creation.
- Reworking
gsd-code-reviewinto cross-AI convergence loop. - New reviewer config schema (reuse existing
review.*keys). - Changing default planning strategy without explicit opt-in.
- Altering
gsd-plan-review-convergenceinternal loop semantics.
Consequences
- No new command tax on docs, routing, and long-term maintenance.
- Existing orchestration habits (
progress --next --autoand autonomous) can opt into convergence consistently. - Existing review configuration gets leverage without new schema.
- Backward compatibility is preserved by default.
- Explicit failure on disabled gate avoids silent false-confidence automation.
References
- Issue: #15
commands/gsd/progress.mdgsd-core/workflows/progress.mdgsd-core/workflows/next.mdcommands/gsd/autonomous.mdgsd-core/workflows/autonomous.mdcommands/gsd/plan-review-convergence.mdgsd-core/workflows/plan-review-convergence.mdcommands/gsd/review.mddocs/COMMANDS.md(/gsd-plan-review-convergence,/gsd-review)docs/CONFIGURATION.md(workflow.plan_review_convergence,review.default_reviewers,review.models.*)