* refactor(#455): implement typed surfaces to retire grep tests Production surfaces added: - hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS as a typed array; gsd-check-update-worker.js now requires it instead of declaring an inline array - bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS, export it alongside runtimeMap/allRuntimes (already exported) - scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind require.main===module so tests can require the file without triggering a build - get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command, emitting typed IR { agent_type, block, skills_count } for test assertions - get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch Category-B source-grep migrations: - tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex - tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports - tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import - tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS - tests/copilot-install.test.cjs: replace src.includes() checks with typed assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText - tests/agent-skills.test.cjs: migrate to --json typed IR assertions pending-migration-to-typed-ir token cleared (87 of 87 files): - 78 files already had source-text-is-the-product; removed duplicate token - 5 files already used typed assertions; reclassified or annotated - 4 files required individual reclassification to source-text-is-the-product or architectural-invariant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): document --json typed surfaces for agent-skills, progress, validate context Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(#455): add changeset fragment for new --json surfaces Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#455): complete grep migration for files flagged by lint-tests The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir` from ~80 test files without replacing their assertions or adding the correct exemption annotation. The files were NOT source-grep tests — they read .md workflow/agent/command/reference files (source-text-is-the-product) or hook source files for structural invariants (structural-regression-guard). No assertion logic was changed; only the correct allow-test-rule annotation was added to each file per CONTRIBUTING.md exception matrix. 73 files: `source-text-is-the-product` — workflow/agent/command/reference .md 7 files: `structural-regression-guard` — hook .js / bin/install.js structural checks Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
116 lines
3.8 KiB
JavaScript
116 lines
3.8 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
||
// Workflow .md / agent .md / command .md / reference .md files — their text
|
||
// IS what the runtime loads. Testing text content tests the deployed contract.
|
||
// Per CONTRIBUTING.md exception matrix.
|
||
|
||
/**
|
||
* Regression guard for #1777: product names must not have parenthetical descriptions.
|
||
*
|
||
* Community PRs repeatedly add editorial commentary in parentheses next to
|
||
* product names (licensing, parent company, architecture). This test scans
|
||
* all README files and ensures install-block comment lines contain only the
|
||
* product name — no parenthetical text of any kind.
|
||
*/
|
||
const { describe, test } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('fs');
|
||
const path = require('path');
|
||
|
||
const ROOT = path.join(__dirname, '..');
|
||
|
||
// Product names that appear in install blocks as comment headers
|
||
const PRODUCTS = [
|
||
'Claude Code', 'Claude', 'OpenCode', 'Kilo', 'Codex', 'Copilot',
|
||
'Cursor', 'Windsurf', 'Antigravity', 'Trae', 'Cline', 'Augment',
|
||
'Gemini', 'Gemini CLI',
|
||
];
|
||
|
||
// README files to scan (root + i18n variants + docs)
|
||
const README_FILES = [
|
||
'README.md',
|
||
'README.ko-KR.md',
|
||
'README.ja-JP.md',
|
||
'README.zh-CN.md',
|
||
'README.pt-BR.md',
|
||
'docs/zh-CN/README.md',
|
||
'docs/ko-KR/README.md',
|
||
'docs/ja-JP/README.md',
|
||
'docs/pt-BR/README.md',
|
||
'docs/README.md',
|
||
].filter(f => fs.existsSync(path.join(ROOT, f)));
|
||
|
||
describe('product name purity (#1777)', () => {
|
||
test('no README install-block comments contain parenthetical descriptions', () => {
|
||
const violations = [];
|
||
|
||
for (const file of README_FILES) {
|
||
const content = fs.readFileSync(path.join(ROOT, file), 'utf-8');
|
||
const lines = content.split('\n');
|
||
|
||
for (let i = 0; i < lines.length; i++) {
|
||
const line = lines[i];
|
||
// Match shell comment lines that start with # followed by a product name
|
||
// and then have parenthetical text: # ProductName (something)
|
||
// Also match fullwidth parens used in CJK: # ProductName(something)
|
||
const match = line.match(/^#\s+(\S+(?:\s+\S+)?)\s*[((].+[))]/);
|
||
if (!match) continue;
|
||
|
||
const name = match[1];
|
||
// Check if this is actually a product name line (not a random comment)
|
||
const isProduct = PRODUCTS.some(p =>
|
||
name === p || name.startsWith(p)
|
||
);
|
||
if (isProduct) {
|
||
violations.push([
|
||
file + ':' + (i + 1),
|
||
line.trim(),
|
||
].join(' — '));
|
||
}
|
||
}
|
||
}
|
||
|
||
assert.strictEqual(
|
||
violations.length, 0,
|
||
[
|
||
'Product names in README install blocks must not have parenthetical descriptions.',
|
||
'Found violations:',
|
||
...violations.map(v => ' ' + v),
|
||
].join('\n')
|
||
);
|
||
});
|
||
|
||
test('CHANGELOG does not include parenthetical product descriptions', () => {
|
||
const changelog = path.join(ROOT, 'CHANGELOG.md');
|
||
if (!fs.existsSync(changelog)) return;
|
||
|
||
const content = fs.readFileSync(changelog, 'utf-8');
|
||
const violations = [];
|
||
|
||
for (const product of PRODUCTS) {
|
||
// Match "ProductName (something)" but not "ProductName (v1.2.3)" (version refs are ok)
|
||
const pattern = new RegExp(
|
||
product.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') +
|
||
'\\s*\\([^)]*(?!v?\\d+\\.\\d)[^)]*\\)',
|
||
'g'
|
||
);
|
||
const matches = content.match(pattern);
|
||
if (matches) {
|
||
for (const m of matches) {
|
||
// Skip version references like "Claude Code (v1.32.0)"
|
||
if (/\(v?\d+\.\d+/.test(m)) continue;
|
||
violations.push(m);
|
||
}
|
||
}
|
||
}
|
||
|
||
assert.strictEqual(
|
||
violations.length, 0,
|
||
[
|
||
'CHANGELOG must not include parenthetical product descriptions.',
|
||
'Found:',
|
||
...violations.map(v => ' ' + v),
|
||
].join('\n')
|
||
);
|
||
});
|
||
});
|