* fix(workflows,docs): scrub stale /gsd-code-review-fix and /gsd-plan-milestone-gaps refs (#3029, #3034) #2790 consolidated /gsd-code-review-fix into /gsd-code-review --fix and deleted /gsd-plan-milestone-gaps in favor of inline gap planning as part of /gsd-audit-milestone's output. The deletion was propagated through some surfaces (#2950 covered help/do/settings/discuss-phase/etc.) but several user-facing surfaces still emitted the old forms: #3029 — /gsd-code-review-fix references in: - agents/gsd-code-fixer.md (description, "Spawned by", recovery prose) - get-shit-done/workflows/code-review.md (offer text) - get-shit-done/workflows/execute-phase.md (offer text) - get-shit-done/workflows/code-review-fix.md (internal retry hints) - docs/INVENTORY.md (agent + workflow rows) - docs/CONFIGURATION.md (workflow.code_review row) - docs/USER-GUIDE.md (3 occurrences in walkthrough) - docs/AGENTS.md (gsd-code-fixer agent stub) - docs/FEATURES.md (commands list + REQ-REVIEW-04) All replaced with /gsd-code-review --fix. Internal retry hints in the workflow file itself updated to point at the new form. Release notes (docs/RELEASE-*.md) and gsd-ns-review's "absorbed by" deletion note left unchanged — historical/explanatory content. #3034 — /gsd-plan-milestone-gaps references in: - get-shit-done/workflows/audit-milestone.md (<offer_next> blocks for gaps_found and tech_debt: lines 281, 323) - commands/gsd/complete-milestone.md (gaps_found pre-flight: lines 46, 57) Replaced with inline closure path: /gsd-phase --insert <N> "Close gap: <REQ-ID> ..." /gsd-discuss-phase <N> /gsd-plan-phase <N> /gsd-execute-phase <N> Plus a Nyquist-coverage hint pointing at /gsd-validate-phase / /gsd-secure-phase for retroactive audit-chain hygiene gaps. The gsd-ns-project SKILL.md "deleted by #2790" note is preserved (it's the canonical pointer for future readers asking what happened to the command). Tests: - tests/bug-3029-3034-stale-command-routes.test.cjs — parser-based assertions per fixed surface, plus a structural cross-check that gsd-ns-project keeps the deletion note. 15 tests, all green. - 6905/6905 full suite passes. Closes #3029 Closes #3034 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address CR feedback on PR #3038 — argument order, structural tests, agent count CR findings on PR #3038: 1. **docs/USER-GUIDE.md (Major)** — `--fix` examples used flag-first form (`/gsd-code-review --fix 3`), but the supported CLI grammar is phase-first (`/gsd-code-review 3 --fix`). The original sed-based replacement preserved the position of the `gsd-code-review-fix` token, producing the wrong order. Fixed in USER-GUIDE.md (3 occurrences) and the same drift in the workflow surfaces: - get-shit-done/workflows/code-review-fix.md (2 retry hints) - get-shit-done/workflows/code-review.md (offer text) - get-shit-done/workflows/execute-phase.md (offer text) 2. **docs/AGENTS.md (Minor)** — internal count drift: line 483 said "Ten additional agents" but line 725 said "12 advanced/specialized". Filesystem reality: 33 agents total, 21 primary, 12 specialized (count of `### ` stubs in the Advanced and Specialized section). Updated lines 3, 13, 483 to use 12/33 and added the two missing names (doc-classifier, doc-synthesizer) to the inline list at line 13. 3. **tests:94 (Major refactor suggestion)** — `.includes()` token checks were source-grep style. Refactored to a typed-IR pattern: extract the SET of slash-command tokens via regex, assert membership on the parsed Set instead of substring scanning the raw file text. Added the `allow-test-rule` comment explaining the IR-build vs IR-assertion split per scripts/lint-no-source-grep.cjs convention. 4. **tests:130 (Major)** — replacement-path assertion was file-wide and could false-pass on generic mentions of "inline" elsewhere in the file. Refactored: `extractOfferBlocks(content)` returns the typed list of `<offer_next>` and "Pre-flight" blocks where the deleted command previously lived, and the assertion runs against those blocks specifically. Now requires `/gsd-phase --insert` or inline-audit prose to appear in the same offer block, not just somewhere in the file. 15/15 targeted tests pass. 6905/6905 full suite pass. Lints clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
13 KiB
<required_reading> Read all files referenced by the invoking prompt's execution_context before starting. </required_reading>
<available_agent_types> Valid GSD subagent types (use exact names — do not fall back to 'general-purpose'):
- gsd-integration-checker — Checks cross-phase integration </available_agent_types>
0. Initialize Milestone Context
INIT=$(gsd-sdk query init.milestone-op)
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
AGENT_SKILLS_CHECKER=$(gsd-sdk query agent-skills gsd-integration-checker)
Extract from init JSON: milestone_version, milestone_name, phase_count, completed_phases, commit_docs.
Resolve integration checker model:
integration_checker_model=$(gsd-sdk query resolve-model gsd-integration-checker --raw)
1. Determine Milestone Scope
# Get phases in milestone (sorted numerically, handles decimals)
gsd-sdk query phases.list
- Parse version from arguments or detect current from ROADMAP.md
- Identify all phase directories in scope
- Extract milestone definition of done from ROADMAP.md
- Extract requirements mapped to this milestone from REQUIREMENTS.md
2. Read All Phase Verifications
For each phase directory, read the VERIFICATION.md:
# For each phase, use find-phase to resolve the directory (handles archived phases)
PHASE_INFO=$(gsd-sdk query find-phase 01 --raw)
# Extract directory from JSON, then read VERIFICATION.md from that directory
# Repeat for each phase number from ROADMAP.md
From each VERIFICATION.md, extract:
- Status: passed | gaps_found
- Critical gaps: (if any — these are blockers)
- Non-critical gaps: tech debt, deferred items, warnings
- Anti-patterns found: TODOs, stubs, placeholders
- Requirements coverage: which requirements satisfied/blocked
If a phase is missing VERIFICATION.md, flag it as "unverified phase" — this is a blocker.
3. Spawn Integration Checker
With phase context collected:
Extract MILESTONE_REQ_IDS from REQUIREMENTS.md traceability table — all REQ-IDs assigned to phases in this milestone.
Task(
prompt="Check cross-phase integration and E2E flows.
Phases: {phase_dirs}
Phase exports: {from SUMMARYs}
API routes: {routes created}
Milestone Requirements:
{MILESTONE_REQ_IDS — list each REQ-ID with description and assigned phase}
MUST map each integration finding to affected requirement IDs where applicable.
Verify cross-phase wiring and E2E user flows.
${AGENT_SKILLS_CHECKER}",
subagent_type="gsd-integration-checker",
model="{integration_checker_model}"
)
ORCHESTRATOR RULE — CODEX RUNTIME: After calling Task() above, stop working on this task immediately. Do not read more files, edit code, or run tests related to this task while the subagent is active. Wait for the subagent to return its result. This prevents duplicate work, conflicting edits, and wasted context. Only resume when the subagent result is available.
4. Collect Results
Combine:
- Phase-level gaps and tech debt (from step 2)
- Integration checker's report (wiring gaps, broken flows)
5. Check Requirements Coverage (3-Source Cross-Reference)
MUST cross-reference three independent sources for each requirement:
5a. Parse REQUIREMENTS.md Traceability Table
Extract all REQ-IDs mapped to milestone phases from the traceability table:
- Requirement ID, description, assigned phase, current status, checked-off state (
[x]vs[ ])
5b. Parse Phase VERIFICATION.md Requirements Tables
For each phase's VERIFICATION.md, extract the expanded requirements table:
- Requirement | Source Plan | Description | Status | Evidence
- Map each entry back to its REQ-ID
5c. Extract SUMMARY.md Frontmatter Cross-Check
For each phase's SUMMARY.md, extract requirements-completed from YAML frontmatter:
for summary in .planning/phases/*-*/*-SUMMARY.md; do
[ -e "$summary" ] || continue
gsd-sdk query summary-extract "$summary" --fields requirements_completed --pick requirements_completed
done
5d. Status Determination Matrix
For each REQ-ID, determine status using all three sources:
| VERIFICATION.md Status | SUMMARY Frontmatter | REQUIREMENTS.md | → Final Status |
|---|---|---|---|
| passed | listed | [x] |
satisfied |
| passed | listed | [ ] |
satisfied (update checkbox) |
| passed | missing | any | partial (verify manually) |
| gaps_found | any | any | unsatisfied |
| missing | listed | any | partial (verification gap) |
| missing | missing | any | unsatisfied |
5e. FAIL Gate and Orphan Detection
REQUIRED: Any unsatisfied requirement MUST force gaps_found status on the milestone audit.
Orphan detection: Requirements present in REQUIREMENTS.md traceability table but absent from ALL phase VERIFICATION.md files MUST be flagged as orphaned. Orphaned requirements are treated as unsatisfied — they were assigned but never verified by any phase.
5.5. Nyquist Compliance Discovery
Skip if workflow.nyquist_validation is explicitly false (absent = enabled).
NYQUIST_CONFIG=$(gsd-sdk query config-get workflow.nyquist_validation --raw 2>/dev/null)
If false: skip entirely.
For each phase directory, check *-VALIDATION.md. If exists, parse frontmatter (nyquist_compliant, wave_0_complete).
Classify per phase:
| Status | Condition |
|---|---|
| COMPLIANT | nyquist_compliant: true and all tasks green |
| PARTIAL | VALIDATION.md exists, nyquist_compliant: false or red/pending |
| MISSING | No VALIDATION.md |
Add to audit YAML: nyquist: { compliant_phases, partial_phases, missing_phases, overall }
Discovery only — never auto-calls /gsd-validate-phase.
6. Aggregate into v{version}-MILESTONE-AUDIT.md
Create .planning/v{version}-v{version}-MILESTONE-AUDIT.md with:
---
milestone: {version}
audited: {timestamp}
status: passed | gaps_found | tech_debt
scores:
requirements: N/M
phases: N/M
integration: N/M
flows: N/M
gaps: # Critical blockers
requirements:
- id: "{REQ-ID}"
status: "unsatisfied | partial | orphaned"
phase: "{assigned phase}"
claimed_by_plans: ["{plan files that reference this requirement}"]
completed_by_plans: ["{plan files whose SUMMARY marks it complete}"]
verification_status: "passed | gaps_found | missing | orphaned"
evidence: "{specific evidence or lack thereof}"
integration: [...]
flows: [...]
tech_debt: # Non-critical, deferred
- phase: 01-auth
items:
- "TODO: add rate limiting"
- "Warning: no password strength validation"
- phase: 03-dashboard
items:
- "Deferred: mobile responsive layout"
---
Plus full markdown report with tables for requirements, phases, integration, tech debt.
Status values:
passed— all requirements met, no critical gaps, minimal tech debtgaps_found— critical blockers existtech_debt— no blockers but accumulated deferred items need review
7. Present Results
Route by status (see <offer_next>).
<offer_next> Output this markdown directly (not as a code block). Route based on status:
If passed:
✓ Milestone {version} — Audit Passed
Score: {N}/{M} requirements satisfied Report: .planning/v{version}-MILESTONE-AUDIT.md
All requirements covered. Cross-phase integration verified. E2E flows complete.
───────────────────────────────────────────────────────────────
▶ Next Up — [${PROJECT_CODE}] ${PROJECT_TITLE}
Complete milestone — archive and tag
/clear then:
/gsd-complete-milestone {version}
───────────────────────────────────────────────────────────────
If gaps_found:
⚠ Milestone {version} — Gaps Found
Score: {N}/{M} requirements satisfied Report: .planning/v{version}-MILESTONE-AUDIT.md
Unsatisfied Requirements
{For each unsatisfied requirement:}
- {REQ-ID}: {description} (Phase {X})
- {reason}
Cross-Phase Issues
{For each integration gap:}
- {from} → {to}: {issue}
Broken Flows
{For each flow gap:}
- {flow name}: breaks at {step}
Nyquist Coverage
| Phase | VALIDATION.md | Compliant | Action |
|---|---|---|---|
| {phase} | exists/missing | true/false/partial | /gsd-validate-phase {N} |
Phases needing validation: run /gsd-validate-phase {N} for each flagged phase.
───────────────────────────────────────────────────────────────
▶ Next Up — [${PROJECT_CODE}] ${PROJECT_TITLE}
Close the gaps inline — gap planning happens as part of this audit's output (see the Unsatisfied Requirements, Cross-Phase Issues, Broken Flows, and Nyquist Coverage sections above). Insert one closure phase per gap (or per group of related gaps) using the standard phase chain:
/clear then:
/gsd-phase --insert "Close gap: — " /gsd-discuss-phase /gsd-plan-phase /gsd-execute-phase
For Nyquist-coverage gaps flagged in the table above, prefer running
/gsd-validate-phase <N> for each flagged phase (and /gsd-secure-phase <N> if SECURITY.md was flagged) before inserting a new closure phase —
they may close the gap retroactively without a new phase.
───────────────────────────────────────────────────────────────
Also available:
- cat .planning/v{version}-MILESTONE-AUDIT.md — see full report
- /gsd-complete-milestone {version} — proceed anyway (accept tech debt)
───────────────────────────────────────────────────────────────
If tech_debt (no blockers but accumulated debt):
⚡ Milestone {version} — Tech Debt Review
Score: {N}/{M} requirements satisfied Report: .planning/v{version}-MILESTONE-AUDIT.md
All requirements met. No critical blockers. Accumulated tech debt needs review.
Tech Debt by Phase
{For each phase with debt:} Phase {X}: {name}
- {item 1}
- {item 2}
Total: {N} items across {M} phases
───────────────────────────────────────────────────────────────
▶ Options
A. Complete milestone — accept debt, track in backlog
/gsd-complete-milestone {version}
B. Plan a cleanup phase — address the debt above before completing. Insert a closure phase using the standard chain:
/clear then:
/gsd-phase --insert "Address tech debt: " /gsd-discuss-phase /gsd-plan-phase /gsd-execute-phase
─────────────────────────────────────────────────────────────── </offer_next>
<success_criteria>
- Milestone scope identified
- All phase VERIFICATION.md files read
- SUMMARY.md
requirements-completedfrontmatter extracted for each phase - REQUIREMENTS.md traceability table parsed for all milestone REQ-IDs
- 3-source cross-reference completed (VERIFICATION + SUMMARY + traceability)
- Orphaned requirements detected (in traceability but absent from all VERIFICATIONs)
- Tech debt and deferred gaps aggregated
- Integration checker spawned with milestone requirement IDs
- v{version}-MILESTONE-AUDIT.md created with structured requirement gap objects
- FAIL gate enforced — any unsatisfied requirement forces gaps_found status
- Nyquist compliance scanned for all milestone phases (if enabled)
- Missing VALIDATION.md phases flagged with validate-phase suggestion
- Results presented with actionable next steps </success_criteria>