Files
msd-core/tests/explore-command.test.cjs
Tom Boucher b8c33647d8 refactor(tests): retire output-grep & source-grep via typed surfaces (finish #2974) (#462)
* refactor(#455): implement typed surfaces to retire grep tests

Production surfaces added:
- hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS
  as a typed array; gsd-check-update-worker.js now requires it instead of
  declaring an inline array
- bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS,
  export it alongside runtimeMap/allRuntimes (already exported)
- scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind
  require.main===module so tests can require the file without triggering a build
- get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command,
  emitting typed IR { agent_type, block, skills_count } for test assertions
- get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch

Category-B source-grep migrations:
- tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex
- tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports
- tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import
- tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS
- tests/copilot-install.test.cjs: replace src.includes() checks with typed
  assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText
- tests/agent-skills.test.cjs: migrate to --json typed IR assertions

pending-migration-to-typed-ir token cleared (87 of 87 files):
- 78 files already had source-text-is-the-product; removed duplicate token
- 5 files already used typed assertions; reclassified or annotated
- 4 files required individual reclassification to source-text-is-the-product
  or architectural-invariant

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): document --json typed surfaces for agent-skills, progress, validate context

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): add changeset fragment for new --json surfaces

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): complete grep migration for files flagged by lint-tests

The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir`
from ~80 test files without replacing their assertions or adding the correct
exemption annotation. The files were NOT source-grep tests — they read .md
workflow/agent/command/reference files (source-text-is-the-product) or hook
source files for structural invariants (structural-regression-guard). No
assertion logic was changed; only the correct allow-test-rule annotation was
added to each file per CONTRIBUTING.md exception matrix.

73 files: `source-text-is-the-product` — workflow/agent/command/reference .md
7 files:  `structural-regression-guard` — hook .js / bin/install.js structural checks

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 11:39:52 -04:00

78 lines
3.8 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
describe('explore command', () => {
test('command file exists', () => {
const p = path.join(__dirname, '..', 'commands', 'gsd', 'explore.md');
assert.ok(fs.existsSync(p), 'commands/gsd/explore.md should exist');
});
test('command file has required frontmatter', () => {
const p = path.join(__dirname, '..', 'commands', 'gsd', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(content.includes('name: gsd:explore'), 'Command must have name frontmatter');
assert.ok(content.includes('description:'), 'Command must have description frontmatter');
assert.ok(content.includes('allowed-tools:'), 'Command must have allowed-tools frontmatter');
});
test('workflow file exists', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
assert.ok(fs.existsSync(p), 'workflows/explore.md should exist');
});
test('workflow references questioning.md and domain-probes.md', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(content.includes('questioning.md'), 'Workflow must reference questioning.md');
assert.ok(content.includes('domain-probes.md'), 'Workflow must reference domain-probes.md');
});
test('workflow documents all 6 output types', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(content.includes('Note'), 'Workflow must document Note output type');
assert.ok(content.includes('Todo'), 'Workflow must document Todo output type');
assert.ok(content.includes('Seed'), 'Workflow must document Seed output type');
assert.ok(content.includes('Research question'), 'Workflow must document Research question output type');
assert.ok(content.includes('Requirement'), 'Workflow must document Requirement output type');
assert.ok(content.includes('New phase') || content.includes('phase'), 'Workflow must document New phase output type');
});
test('workflow enforces one question at a time principle', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(content.includes('one question at a time'), 'Workflow must mention "one question at a time" principle');
});
test('workflow requires user confirmation before writing artifacts', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(
content.includes('explicit user selection') || content.includes('Never write artifacts without'),
'Workflow must require user confirmation before writing artifacts'
);
});
test('workflow respects commit_docs config', () => {
const p = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(content.includes('commit_docs'), 'Workflow must respect commit_docs configuration');
});
test('command references the workflow via execution_context', () => {
const p = path.join(__dirname, '..', 'commands', 'gsd', 'explore.md');
const content = fs.readFileSync(p, 'utf-8');
assert.ok(
content.includes('workflows/explore.md'),
'Command must reference workflows/explore.md in execution_context'
);
});
});