918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
67 lines
2.5 KiB
JavaScript
67 lines
2.5 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* Regression test for #2388: plan-phase silently renames feature branch
|
|
* when phase slug has changed since the branch was created.
|
|
*
|
|
* Fix: plan-phase.md must include an explicit instruction not to create,
|
|
* rename, or switch git branches during the planning workflow.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const PLAN_PHASE_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'plan-phase.md');
|
|
|
|
describe('bug-2388: plan-phase must not rename or create git branches', () => {
|
|
test('plan-phase.md exists', () => {
|
|
assert.ok(fs.existsSync(PLAN_PHASE_PATH), 'plan-phase.md should exist');
|
|
});
|
|
|
|
test('plan-phase.md contains explicit no-branch-rename instruction', () => {
|
|
const content = fs.readFileSync(PLAN_PHASE_PATH, 'utf-8');
|
|
// Must say "do not" and mention branch in the context of phase slug/rename
|
|
const hasBranchGuard = (
|
|
/do not.{0,80}branch/i.test(content) ||
|
|
/branch.{0,80}do not/i.test(content) ||
|
|
/NEVER.{0,80}branch/i.test(content) ||
|
|
/branch.{0,80}NEVER/i.test(content)
|
|
);
|
|
assert.ok(
|
|
hasBranchGuard,
|
|
'plan-phase.md must include an explicit instruction not to create or rename git branches'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md mentions phase rename does not affect branch name', () => {
|
|
const content = fs.readFileSync(PLAN_PHASE_PATH, 'utf-8');
|
|
// Should explain that a phase rename in ROADMAP.md is plan-level, not git-level
|
|
const hasPlanLevelExplanation = (
|
|
content.includes('phase rename') ||
|
|
content.includes('phase_slug') ||
|
|
content.includes('branch identity') ||
|
|
content.includes('branch name')
|
|
);
|
|
assert.ok(
|
|
hasPlanLevelExplanation,
|
|
'plan-phase.md should clarify that phase slug changes do not change the git branch'
|
|
);
|
|
});
|
|
|
|
test('plan-phase.md does not contain git checkout -b instruction', () => {
|
|
const content = fs.readFileSync(PLAN_PHASE_PATH, 'utf-8');
|
|
// The workflow should not instruct the LLM to run git checkout -b
|
|
assert.ok(
|
|
!content.includes('git checkout -b'),
|
|
'plan-phase.md must not instruct LLM to create a new branch via git checkout -b'
|
|
);
|
|
});
|
|
});
|