05db5b53e4
* fix(#853): gate manager/autonomous bg dispatch by runtime
/gsd-manager and /gsd-autonomous --interactive dispatched Plan/Execute
via Agent(run_in_background=true). On Claude Code a backgrounded agent
has no Agent/Task tool, so it cannot spawn the nested subagents those
pipelines need — per-plan worktree-isolated executors, the plan-checker,
and the verifier. The phases reported complete but isolation and
independent verification silently never ran, even with use_worktrees /
plan_check / verifier enabled.
Both workflows now resolve the runtime (config-get runtime, default
claude) before dispatching: run plan/execute INLINE on Claude Code so
the nested pipeline runs, and background-dispatch only on runtimes where
a backgrounded agent can still nest. Mirrors execute-phase.md's existing
Codex fail-closed precedent. Reconciles the stale unconditional
background/overlap/lean-context claims elsewhere in both workflows and
in the docs. Adds a content regression test pinning the gate.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* docs(#853): add changeset for runtime-gated bg dispatch
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit 3697e6768f)
47 lines
2.4 KiB
JavaScript
47 lines
2.4 KiB
JavaScript
'use strict';
|
|
/**
|
|
* Regression guard — bug(#853): /gsd-manager and /gsd-autonomous --interactive
|
|
* silently skipped worktree isolation + independent verification because they
|
|
* dispatched Plan/Execute via Agent(run_in_background=true). On Claude Code a
|
|
* backgrounded agent has no Agent/Task tool, so it cannot spawn the nested
|
|
* subagents (worktree executors, plan-checker, verifier). The workflows must
|
|
* now resolve the runtime and run inline on Claude Code.
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const WORKFLOWS_DIR = path.join(__dirname, '..', 'gsd-core', 'workflows');
|
|
const MANAGER = fs.readFileSync(path.join(WORKFLOWS_DIR, 'manager.md'), 'utf8');
|
|
const AUTONOMOUS = fs.readFileSync(path.join(WORKFLOWS_DIR, 'autonomous.md'), 'utf8');
|
|
|
|
describe('bug-853 — manager/autonomous gate background dispatch by runtime', () => {
|
|
test('manager.md resolves the runtime before dispatching plan/execute', () => {
|
|
// Two dispatch sites (plan + execute), each must resolve the runtime.
|
|
const matches = MANAGER.match(/config-get runtime/g) || [];
|
|
assert.ok(matches.length >= 2, 'manager.md must resolve runtime for both plan and execute dispatch');
|
|
});
|
|
|
|
test('manager.md documents why Claude Code cannot background-dispatch', () => {
|
|
assert.match(MANAGER, /backgrounded agent has no `Agent`\/`Task` tool/);
|
|
});
|
|
|
|
test('manager.md runs plan/execute inline on Claude Code', () => {
|
|
assert.match(MANAGER, /If `RUNTIME` is `claude`[\s\S]{0,400}?Skill\(skill="gsd-plan-phase"/);
|
|
assert.match(MANAGER, /If `RUNTIME` is `claude`[\s\S]{0,400}?Skill\(skill="gsd-execute-phase"/);
|
|
});
|
|
|
|
test('autonomous.md gates interactive background dispatch by runtime', () => {
|
|
const autoRuntimeMatches = AUTONOMOUS.match(/config-get runtime/g) || [];
|
|
assert.ok(autoRuntimeMatches.length >= 2, 'autonomous.md must resolve runtime in both 3b (plan) and 3c (execute) interactive branches');
|
|
assert.match(AUTONOMOUS, /backgrounded agent has no `Agent`\/`Task` tool/);
|
|
});
|
|
|
|
test('autonomous.md runs plan/execute inline on Claude Code in interactive mode', () => {
|
|
assert.match(AUTONOMOUS, /On Claude Code \(`RUNTIME` is `claude`\)[\s\S]{0,400}?Skill\(skill="gsd-plan-phase"/);
|
|
assert.match(AUTONOMOUS, /On Claude Code \(`RUNTIME` is `claude`\)[\s\S]{0,400}?Skill\(skill="gsd-execute-phase"/);
|
|
});
|
|
});
|