* feat: Phase 2 caller migration — gsd-sdk query in workflows (#2122) Cherry-picked orchestration rewrites from feat/sdk-foundation (#2008, 4018fee) onto current main, resolving conflicts to keep upstream worktree guards and post-merge test gate. SDK stub registry omitted (out of Phase 2 scope per #2122). Refs: #2122 #2008 Made-with: Cursor * docs: add gsd-sdk query migration blurb Made-with: Cursor * docs(workflows): extend Phase 2 gsd-sdk query caller migration - Swap node gsd-tools.cjs for gsd-sdk query in review, plan-phase, execute-plan, ship, extract_learnings, ai-integration-phase, eval-review, next, thread - Document graphify CJS-only in gsd-planner; dual-path in CLI-TOOLS and ARCHITECTURE - Update tests: workstreams gsd-sdk path, thread frontmatter.get, workspace init.*, CRLF-safe autonomous frontmatter parse - CHANGELOG: Phase 2 caller migration scope Made-with: Cursor * docs(phase2): USER-GUIDE + remaining gsd-sdk query call sites - USER-GUIDE: dual-path CLI section; state validate/sync use full CJS path - Commands: debug (config-get+tdd), quick (security note), intel Task prompt - Agent: gsd-debug-session-manager resolve-model via jq - Workflows: milestone-summary, forensics, next, complete-milestone/verify-work (audit-open CJS notes), discuss-phase, progress, verify-phase, add/insert/remove phase, transition, manager, quick workflow; remove-phase commit without --files - Test: quick-session-management accepts frontmatter.get - CHANGELOG: Phase 2 follow-up bullet Made-with: Cursor * docs(phase2): align gsd-sdk query examples in commands and agents - init.* query names; frontmatter.get uses positional field name - state.* handlers use positional args; commit uses positional paths - CJS-only notes for from-gsd2 and graphify; learnings.query wording - CHANGELOG: Phase 2 orchestration doc pass Made-with: Cursor * docs(phase2): normalize gsd-sdk query commit to positional file paths - Strip --files from commit examples in workflows, references, commands - Keep commit-to-subrepo ... --files (separate handler) - git-planning-commit.md: document positional args - Tests: new-project commit line, state.record-session, gates CRLF, roadmap.analyze - CHANGELOG [Unreleased] Made-with: Cursor * feat(sdk): gsd-sdk query parity with gsd-tools and PR 2179 registry fixes - Route query via longest-prefix match and dotted single-token expansion; fall back to runGsdToolsQuery (same argv as node gsd-tools.cjs) for full CLI coverage. - Parse gsd-sdk query permissively so gsd-tools flags (--json, --verify, etc.) are not rejected by strict parseArgs. - resolveGsdToolsPath: honor GSD_TOOLS_PATH; prefer bundled get-shit-done copy over project .claude installs; export runGsdToolsQuery from the SDK. - Fix gsd-tools audit-open (core.output; pass object for --json JSON). - Register summary-extract as alias of summary.extract; fix audit-fix workflow to call audit-uat instead of invalid init.audit-uat (PR review). Updates QUERY-HANDLERS.md and CHANGELOG [Unreleased]. Made-with: Cursor * fix(sdk): Phase 2 scope — Trek-e review (#2179, #2122) - Remove gsd-sdk query passthrough to gsd-tools.cjs; drop GSD_TOOLS_PATH - Consolidate argv routing in resolveQueryArgv(); update USAGE and QUERY-HANDLERS - Surface @file: read failures in GSDTools.parseOutput - execute-plan: defer Task Commit Protocol to gsd-executor - stale-colon-refs: skip .planning/ and root CLAUDE.md (gitignored overlays) - CHANGELOG [Unreleased]: maintainer review and routing notes Made-with: Cursor
118 lines
3.9 KiB
JavaScript
118 lines
3.9 KiB
JavaScript
/**
|
|
* Stale /gsd: colon reference detection test
|
|
*
|
|
* Guards against regression of bug #1748: after the command naming migration
|
|
* from colon to hyphen format, no stale colon references should remain in
|
|
* source, workflows, commands, docs, issue templates, or hooks.
|
|
*
|
|
* Test input strings that deliberately test colon-to-hyphen conversion are
|
|
* allowed (they are the INPUT to a converter function). Everything else is stale.
|
|
*
|
|
* Uses node:test and node:assert/strict (NOT Jest).
|
|
*/
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const ROOT = path.resolve(__dirname, '..');
|
|
|
|
/**
|
|
* Recursively collect files matching the given extensions, excluding
|
|
* CHANGELOG.md, node_modules/, .git/, dist/, local planning overlays, and
|
|
* root CLAUDE.md (gitignored local IDE overlay — see repo .gitignore).
|
|
*/
|
|
function collectFiles(dir, extensions, results = []) {
|
|
const EXCLUDED_DIRS = new Set(['node_modules', '.git', 'dist', '.claude', '.worktrees', '.planning']);
|
|
let entries;
|
|
try {
|
|
entries = fs.readdirSync(dir, { withFileTypes: true });
|
|
} catch {
|
|
return results;
|
|
}
|
|
for (const entry of entries) {
|
|
if (EXCLUDED_DIRS.has(entry.name)) continue;
|
|
const full = path.join(dir, entry.name);
|
|
if (entry.isDirectory()) {
|
|
collectFiles(full, extensions, results);
|
|
} else if (entry.isFile()) {
|
|
if (entry.name === 'CLAUDE.md' && path.resolve(dir) === path.resolve(ROOT)) {
|
|
continue;
|
|
}
|
|
const ext = path.extname(entry.name);
|
|
if (extensions.has(ext) && entry.name !== 'CHANGELOG.md') {
|
|
results.push(full);
|
|
}
|
|
}
|
|
}
|
|
return results;
|
|
}
|
|
|
|
/**
|
|
* Determine whether a /gsd: match in a test file is a legitimate test input
|
|
* (i.e., the input string fed to a colon-to-hyphen converter).
|
|
*/
|
|
function isTestInput(filePath, line) {
|
|
const rel = path.relative(ROOT, filePath).replace(/\\/g, '/');
|
|
|
|
// SDK test files (.ts) that test sanitizer stripping of /gsd: patterns
|
|
if (rel === 'sdk/src/prompt-sanitizer.test.ts') return true;
|
|
if (rel === 'sdk/src/init-runner.test.ts') return true;
|
|
if (rel === 'sdk/src/phase-prompt.test.ts') return true;
|
|
|
|
// Conversion test files: input strings to convert* functions contain /gsd:
|
|
const conversionTestFiles = [
|
|
'tests/windsurf-conversion.test.cjs',
|
|
'tests/augment-conversion.test.cjs',
|
|
'tests/cursor-conversion.test.cjs',
|
|
'tests/antigravity-install.test.cjs',
|
|
'tests/copilot-install.test.cjs',
|
|
'tests/codex-config.test.cjs',
|
|
'tests/trae-install.test.cjs',
|
|
'tests/codebuddy-install.test.cjs',
|
|
];
|
|
|
|
if (conversionTestFiles.includes(rel)) {
|
|
const trimmed = line.trim();
|
|
// JSDoc block-comment lines with /gsd: in description are stale
|
|
if (/^\*/.test(trimmed)) return false;
|
|
// Everything else in conversion test files is a test input
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
describe('No stale /gsd: colon references (#1748)', () => {
|
|
test('all /gsd: references should be hyphenated except test inputs', () => {
|
|
const extensions = new Set(['.md', '.js', '.cjs', '.ts', '.yml', '.sh', '.svg']);
|
|
const files = collectFiles(ROOT, extensions);
|
|
|
|
const staleRefs = [];
|
|
const pattern = /\/gsd:[a-z]/g;
|
|
|
|
for (const filePath of files) {
|
|
const content = fs.readFileSync(filePath, 'utf8');
|
|
const lines = content.split('\n');
|
|
|
|
for (let i = 0; i < lines.length; i++) {
|
|
const line = lines[i];
|
|
if (!pattern.test(line)) continue;
|
|
pattern.lastIndex = 0;
|
|
|
|
if (!isTestInput(filePath, line)) {
|
|
const rel = path.relative(ROOT, filePath).replace(/\\/g, '/');
|
|
staleRefs.push(` ${rel}:${i + 1}: ${line.trim()}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (staleRefs.length > 0) {
|
|
assert.fail(
|
|
`Found ${staleRefs.length} stale /gsd: colon reference(s) that should use /gsd- hyphen format:\n${staleRefs.join('\n')}`
|
|
);
|
|
}
|
|
});
|
|
});
|