The claude-orchestration capability (#1143) shipped registered 'active' but fully inert: detectWorkflowBackend/emitWorkflowScript had no caller outside their own CLI router, and execute-phase.md declared an execute:wave:pre hook point that the workflow body never rendered — so claude_orchestration.enabled:true had zero effect on real runs. Approach B (maintainer-chosen): - execute-phase.md now renders the execute:wave:pre hook (gsd_run loop render-hooks execute:wave:pre) at a new step 2.75, immediately before each wave's Agent() dispatch — fixing the latent dead-hook gap for any pre-wave capability. - Move the claude-orchestration contribution execute:wave:post -> execute:wave:pre (a pre-wave backend selector belongs before dispatch, not after); rename fragments/execute-wave-post.md -> execute-wave-pre.md with prose instructing the orchestrator to call resolve-wave-dispatch before step 3. Unrelated wave:post contributions (ui.safety-gate, drift, external-job, mempalace) untouched. - New .cts seam resolveWaveDispatch(input) composes detectWorkflowBackend + emitWorkflowScript into one {backend:'inline'|'workflow', ...} result; exposed as gsd-tools claude-orchestration resolve-wave-dispatch. This is a real non-CLI-router, non-test caller of both functions. Fail-closed: any gate miss (disabled, non-Claude runtime, Workflow tool absent, SDK below floor, execution_backend:inline, malformed input) or an emit failure resolves to inline with a byte-identical result shape — no regression to the default-off execute-phase path. Regression tests (tests/fix-2285-*) cover happy-path activation + SDK-floor BVA, the fail-closed gate-miss table with detectWorkflowBackend parity, a fast-check composition property, capability.json contribution assertions, and a source-contract guard that execute:wave:pre is now actually rendered. Dependent registry-shape assertions updated in-scope. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
225 lines
10 KiB
JavaScript
225 lines
10 KiB
JavaScript
"use strict";
|
|
/**
|
|
* Claude orchestration command router — CLI dispatcher for
|
|
* `gsd-tools claude-orchestration <subcommand>`.
|
|
*
|
|
* #1143 — thin CLI adapter over the pure `claude-orchestration.cjs` module.
|
|
* Lets execute-phase (or any orchestrator) invoke the Workflow-backend
|
|
* detection and the Workflow-script emitter through the standard capability
|
|
* command surface (ADR-959) instead of a bare `require()`.
|
|
*
|
|
* Router signature: { args, cwd, raw, error } — identical to the other host
|
|
* routers; discovered by dispatchCapabilityCommand via the registry's
|
|
* commandFamilies index.
|
|
*
|
|
* Subcommands:
|
|
* detect-backend [--runtime <id>] [--agent-sdk-version <ver>] [--no-nested-dispatch]
|
|
* Resolves whether the Workflow backend should activate. `--runtime`
|
|
* defaults to the GSD_RUNTIME env var (or 'unknown'). Reads the
|
|
* `claude_orchestration.*` keys from .planning/config.json. Emits
|
|
* { available, backend, reason }.
|
|
*
|
|
* emit-workflow --waves <path> --run-id <id> [--phase-dir <dir>] [--budget <n>]
|
|
* Reads a wave/plan manifest JSON file and emits the generated Workflow
|
|
* script + summary. The manifest shape matches emitWorkflowScript's input:
|
|
* { waves: [{ id, plans: [{ id, brief, files_modified: string[], use_worktree?: boolean }] }] }.
|
|
* `use_worktree` defaults to true; pass `false` for a plan the inline path
|
|
* (execute-phase.md step 2.5) would also keep out of worktree isolation
|
|
* (submodule-touching plans — #2772 / #2285 finding 1).
|
|
*
|
|
* resolve-wave-dispatch --waves <path> --run-id <id> [--runtime <id>]
|
|
* [--agent-sdk-version <ver>] [--no-nested-dispatch] [--phase-dir <dir>]
|
|
* [--budget <n>]
|
|
* #2285 — the single composed seam a PRE-wave dispatch-backend selector
|
|
* (`execute:wave:pre`) uses: resolves detect-backend + emit-workflow in
|
|
* ONE call. Emits { backend: 'inline'|'workflow', reason, script?, summary? }.
|
|
* Fail-closed identically to detect-backend/emit-workflow individually —
|
|
* any gate miss, or an emit failure on a malformed --waves manifest,
|
|
* resolves to 'inline' with no script.
|
|
*/
|
|
var __importDefault = (this && this.__importDefault) || function (mod) {
|
|
return (mod && mod.__esModule) ? mod : { "default": mod };
|
|
};
|
|
const node_fs_1 = __importDefault(require("node:fs"));
|
|
const node_path_1 = __importDefault(require("node:path"));
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const io = require("./io.cjs");
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const core = require("./claude-orchestration.cjs");
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const configLoader = require("./config-loader.cjs");
|
|
const { output } = io;
|
|
const { detectWorkflowBackend, emitWorkflowScript, resolveWaveDispatch } = core;
|
|
const CAPABLE_HOST = { dispatch: { nested: true, background: true } };
|
|
function usage(error) {
|
|
error('Usage: gsd-tools claude-orchestration <detect-backend|emit-workflow|resolve-wave-dispatch> [...]\n' +
|
|
' detect-backend [--runtime <id>] [--agent-sdk-version <ver>] [--no-nested-dispatch]\n' +
|
|
' emit-workflow --waves <path> --run-id <id> [--phase-dir <dir>] [--budget <n>]\n' +
|
|
' resolve-wave-dispatch --waves <path> --run-id <id> [--runtime <id>] [--agent-sdk-version <ver>] [--no-nested-dispatch] [--phase-dir <dir>] [--budget <n>]');
|
|
}
|
|
function argValue(args, flag) {
|
|
const i = args.indexOf(flag);
|
|
return i !== -1 && i + 1 < args.length ? args[i + 1] : undefined;
|
|
}
|
|
/**
|
|
* Resolve the `claude_orchestration.*` config slice from the project config
|
|
* (federated keys are merged by loadConfig as a nested object), flattened into
|
|
* the dotted-key shape `detectWorkflowBackend`/`resolveWaveDispatch` expect. A
|
|
* config read failure degrades to an empty slice — it must not break the core
|
|
* loop. Shared by `detect-backend` and `resolve-wave-dispatch`.
|
|
*/
|
|
function resolveFlatClaudeOrchestrationConfig(cwd) {
|
|
let claudeSlice = {};
|
|
try {
|
|
const loaded = configLoader.loadConfig(cwd);
|
|
const slice = loaded['claude_orchestration'];
|
|
if (slice && typeof slice === 'object' && !Array.isArray(slice)) {
|
|
claudeSlice = slice;
|
|
}
|
|
}
|
|
catch {
|
|
claudeSlice = {};
|
|
}
|
|
const flatConfig = {};
|
|
for (const k of Object.keys(claudeSlice)) {
|
|
flatConfig['claude_orchestration.' + k] = claudeSlice[k];
|
|
}
|
|
return flatConfig;
|
|
}
|
|
/**
|
|
* Resolve `--runtime`/`--agent-sdk-version`/`--no-nested-dispatch` into the
|
|
* `{ runtimeId, hostIntegration, agentSdkVersion }` triple both `detect-backend`
|
|
* and `resolve-wave-dispatch` pass to the pure detection seam.
|
|
*/
|
|
function resolveDetectionArgs(args) {
|
|
const runtimeId = argValue(args, '--runtime') || process.env['GSD_RUNTIME'] || 'unknown';
|
|
const agentSdkVersion = argValue(args, '--agent-sdk-version');
|
|
const noNested = args.includes('--no-nested-dispatch');
|
|
const hostIntegration = noNested ? { dispatch: { nested: false, background: true } } : CAPABLE_HOST;
|
|
return { runtimeId, hostIntegration, agentSdkVersion };
|
|
}
|
|
/**
|
|
* Read and parse a `--waves <path>` manifest file.
|
|
*
|
|
* #2285 finding 2: a real read/parse failure (`ok:false`) is DISTINCT from a
|
|
* manifest that parsed fine but has no top-level `waves` key (`ok:true, waves:
|
|
* undefined`) — collapsing both into the same sentinel made the missing-key
|
|
* case exit 0 with ZERO output (fail-silent), breaking the "exit 0 => parseable
|
|
* JSON verdict" contract callers rely on. Only the `ok:false` (read/parse threw)
|
|
* case calls `error(...)` and should short-circuit the caller; `ok:true` with a
|
|
* missing/malformed `waves` value must flow through to `emitWorkflowScript`'s
|
|
* own validation (matching how `{"waves": null}` already behaves) so the caller
|
|
* emits an explicit, non-empty verdict instead of silently doing nothing.
|
|
*/
|
|
function readWavesManifest(wavesPath, error) {
|
|
try {
|
|
const content = node_fs_1.default.readFileSync(node_path_1.default.resolve(wavesPath), 'utf8');
|
|
const parsed = JSON.parse(content);
|
|
return { ok: true, waves: parsed['waves'] };
|
|
}
|
|
catch (e) {
|
|
error('could not read/parse --waves file "' + wavesPath + '": ' + (e instanceof Error ? e.message : String(e)));
|
|
return { ok: false };
|
|
}
|
|
}
|
|
/**
|
|
* Detect whether the Workflow backend should activate for the current/given
|
|
* runtime. Reads `claude_orchestration.*` from the project config; runtime and
|
|
* SDK version come from flags (the orchestrator already knows these) or env.
|
|
*/
|
|
function cmdDetectBackend(args, cwd, raw) {
|
|
const { runtimeId, hostIntegration, agentSdkVersion } = resolveDetectionArgs(args);
|
|
const flatConfig = resolveFlatClaudeOrchestrationConfig(cwd);
|
|
const result = detectWorkflowBackend({ runtimeId, hostIntegration, config: flatConfig, agentSdkVersion });
|
|
output(result, raw);
|
|
}
|
|
/**
|
|
* Emit a Workflow script from a wave/plan manifest file.
|
|
*/
|
|
function cmdEmitWorkflow(args, _cwd, raw, error) {
|
|
const wavesPath = argValue(args, '--waves');
|
|
const runId = argValue(args, '--run-id');
|
|
const phaseDir = argValue(args, '--phase-dir') || '.planning/phases/current';
|
|
const budgetRaw = argValue(args, '--budget');
|
|
if (!wavesPath) {
|
|
error('emit-workflow requires --waves <path>');
|
|
return;
|
|
}
|
|
if (!runId) {
|
|
error('emit-workflow requires --run-id <id>');
|
|
return;
|
|
}
|
|
const read = readWavesManifest(wavesPath, (msg) => error('emit-workflow: ' + msg));
|
|
if (!read.ok)
|
|
return; // read/parse failure — error() already surfaced it loudly above
|
|
const budgetTokens = budgetRaw !== undefined ? parseInt(budgetRaw, 10) : undefined;
|
|
const budget = (typeof budgetTokens === 'number' && !Number.isNaN(budgetTokens)) ? budgetTokens : undefined;
|
|
const result = emitWorkflowScript({
|
|
phaseDir,
|
|
runId,
|
|
waves: read.waves,
|
|
budgetTokens: budget,
|
|
});
|
|
if (!result.ok) {
|
|
error('emit-workflow: ' + result.reason);
|
|
return;
|
|
}
|
|
output({ script: result.script, summary: result.summary }, raw);
|
|
}
|
|
/**
|
|
* #2285 — the single composed seam a PRE-wave dispatch-backend selector
|
|
* (`execute:wave:pre`) uses: resolves `detect-backend` + `emit-workflow` in
|
|
* ONE call via `resolveWaveDispatch`. Emits
|
|
* `{ backend: 'inline'|'workflow', reason, script?, summary? }`.
|
|
*/
|
|
function cmdResolveWaveDispatch(args, cwd, raw, error) {
|
|
const wavesPath = argValue(args, '--waves');
|
|
const runId = argValue(args, '--run-id');
|
|
const phaseDir = argValue(args, '--phase-dir') || '.planning/phases/current';
|
|
const budgetRaw = argValue(args, '--budget');
|
|
if (!wavesPath) {
|
|
error('resolve-wave-dispatch requires --waves <path>');
|
|
return;
|
|
}
|
|
if (!runId) {
|
|
error('resolve-wave-dispatch requires --run-id <id>');
|
|
return;
|
|
}
|
|
const read = readWavesManifest(wavesPath, (msg) => error('resolve-wave-dispatch: ' + msg));
|
|
if (!read.ok)
|
|
return; // read/parse failure — error() already surfaced it loudly above
|
|
const { runtimeId, hostIntegration, agentSdkVersion } = resolveDetectionArgs(args);
|
|
const flatConfig = resolveFlatClaudeOrchestrationConfig(cwd);
|
|
const budgetTokens = budgetRaw !== undefined ? parseInt(budgetRaw, 10) : undefined;
|
|
const budget = (typeof budgetTokens === 'number' && !Number.isNaN(budgetTokens)) ? budgetTokens : undefined;
|
|
const result = resolveWaveDispatch({
|
|
runtimeId,
|
|
hostIntegration,
|
|
config: flatConfig,
|
|
agentSdkVersion,
|
|
phaseDir,
|
|
runId,
|
|
waves: read.waves,
|
|
budgetTokens: budget,
|
|
});
|
|
output(result, raw);
|
|
}
|
|
function routeClaudeOrchestrationCommand(opts) {
|
|
const { args, cwd, raw, error } = opts;
|
|
// args[0] is the family ('claude-orchestration'); the subcommand is args[1].
|
|
const subcommand = args[1];
|
|
if (subcommand === 'detect-backend') {
|
|
cmdDetectBackend(args, cwd, raw);
|
|
}
|
|
else if (subcommand === 'emit-workflow') {
|
|
cmdEmitWorkflow(args, cwd, raw, error);
|
|
}
|
|
else if (subcommand === 'resolve-wave-dispatch') {
|
|
cmdResolveWaveDispatch(args, cwd, raw, error);
|
|
}
|
|
else {
|
|
usage(error);
|
|
}
|
|
}
|
|
module.exports = { routeClaudeOrchestrationCommand };
|