Files
msd-core/tests/cross-ai-execution.test.cjs
Tom Boucher 5fa4dcd78c fix: recover silently-excluded test dirs + test-architecture audit hardening (#1195)
* fix: recurse test discovery so subdir test suites actually run

scripts/run-tests.cjs discovered tests with a flat readdirSync(testDir),
silently excluding tests/observability/ (4 files), tests/dispatch/ (1) and
tests/installer-migrations/ (1) — 94 passing tests — from `npm test` and all
CI lanes. Walk the tree recursively (relative subpaths preserved), classify
suites by basename, and add a fail-on-zero-executed guard for suite/default
runs (escape hatch GSD_ALLOW_EMPTY_SUITE=1) while preserving the empty
--files/--files-from path the CI inert lane relies on.

Unit suite 735 -> 741 files; surfaces ADR-227's observability/dispatch seam.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: retire 5 verified-worthless tests

Adversarial verification confirmed these 5 prove nothing — their coverage is
provided more strictly elsewhere:
- enh-2790 'has a name: field' spot-checks (command-contract enforces /^gsd[:-]/)
- command-routing-hub duplicate construct + duplicate ERROR_KINDS assertions
- no-cjs-sdk-handsync-tooling (guarded files that never existed on main; bug-190
  covers the real retired SDK artifacts)
- runtime-artifact-layout cline edge case (subsumed by the explicit-global test
  and bug-782-cline-skills-emission)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: add ADR-218 release version-validation coverage

ADR-218 (reject leading-zero versions like 1.01.0; npm duplicate pre-check) had
zero tests — the logic lived only in release.yml bash. Add a test that extracts
the actual rejection regexes from the workflow and exercises them against a
boundary table (leading-zero/malformed rejected, valid accepted) plus structural
wiring assertions. Goes red if the regex is reverted to [0-9]+.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: redesign weak tests into behavioral, deterministic assertions

Per the ADR test audit, rewrite 27 weak test files (test-only, no source
changes) so each can go red for the defect it guards:
- kill pass-always assert.ok(true) placeholders (research-cli, worktree-baseref,
  bug-260 security guard, eslint-rules x24, clusters '|| true')
- replace source-text grep with behavioral calls (install Kilo, sh-hook-paths,
  plan-review-convergence) and add a repo-layout governance test
- de-flake real-clock/Math.random coupling (phase last_updated, bug-3707 mtime,
  context-utilization property, feat-3594)
- fix independence/shared-state violations (bug-492 singleton, issue-844 tmpRoot,
  core reapStaleTempFiles, active-workstream TTY, feat-488 GSD_HOME)
- strengthen property/shape-only tests (research-provider/store classification +
  collision) and unconditional plugin.json schema validation (issue-766)

Verified: all 28 files run together 1220 pass / 0 fail / 1 skip.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: add no-tautological-assert lint rule, error in test suite

New custom ESLint rule (eslint-rules/no-tautological-assert.cjs) bans asserts
that can never fail: assert(true)/assert.ok(<always-truthy literal>),
'cond || true' inside an assert, and equality asserts comparing two identical
literals. Wired as error on tests/**; full sweep confirmed zero existing
violations so the suite stays green. Prevents the placeholder-assert regressions
the audit redesigns just removed. RuleTester coverage added (6 valid, 8 invalid).

Note: no-only-tests was already enforced via eslint-plugin-no-only-tests, so no
duplicate rule was added.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: gate new allow-test-rule exemptions to require an issue ref

ADR-456 requires any allow-test-rule exemption added after the ADR to carry a
tracking issue number, but nothing enforced it. New ratchet gate
(scripts/lint-allow-test-rule-refs.cjs, wired into lint:ci) fails when a NEW
allow-test-rule comment lacks a #NNN/URL reference; the 323 existing untracked
exemptions are grandfathered in an allowlist that ratchets down as they gain
refs. Red-green verified (novel untracked offender fails; compliant passes).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* docs: add ADR test-audit evidence report (#1192)

Full risk-first qa-test-architect audit of the ADR portfolio (37 ADRs + 4
platform lenses, adversarial verification of retire verdicts) that drove the
P0 discovery fix, ADR-218 coverage, 5 retires, 27 redesigns, and the two new
lint gates. Filed as point-in-time evidence under docs/issueevidence/, named
for tracking issue #1192.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: replace pre-existing raw NUL byte with escape in feat-3594 fixture

feat-3594's null-byte parser fixture contained a literal NUL byte (pre-existing
on next at b10e5681 — confirmed: base blob has 1 NUL, this fix has 0), which
made git treat the file as binary and would break grep/editors. Switch to the
\x00 escape; the runtime string value (a real NUL in the parser input) is
unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: address adversarial-review findings

Codex adversarial pass over the branch:
- capability-registry drift test no longer mutates the committed generated
  capability-registry.cjs in place (concurrency hazard) — uses in-memory
  checkPipeline comparison instead.
- allow-test-rule ratchet now detects exemptions in ALL comment forms (block
  /* */ too, matching no-source-grep) so a block comment can't bypass it;
  one newly-surfaced pre-existing offender grandfathered (323->324).
- install.test Kilo case asserts on what install(false,'kilo') actually writes
  rather than manually calling configureKiloPermissions (masked the call site).
- issue-766 drops the undeclared transitive ajv dep for explicit structural
  assertions from the schema fixture.
- adr-218 test notes the hotfix leading-zero gap is tracked in #1186.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: address code-review findings (subdir discovery, rule + test gaps)

xhigh code review surfaced 15 confirmed issues, all fixed:
- run-tests.cjs --files now resolves subdir tests by bare basename + handles
  Windows backslash paths (ambiguous basenames error clearly).
- affected-tests-lib.cjs listTestFiles made recursive — the targeted CI lane was
  silently dropping changed subdir tests (same false-green class the audit fixed).
- no-tautological-assert now catches 'true || cond' and empty []/{}  equality.
- verify-test-quality: restore provenance-classification coverage, tighten the
  writeFile circular-detection check, guard the module-level file read.
- sh-hook-paths: cover the global-install .sh delegation branch (#2045 guard).
- active-workstream null-guard runs deterministically (no longer skipped on TTY).
- adr-218 structural guards tightened (major/minor leading-zero; needs: membership).
- repo-layout AGENTS.md guard no longer false-alarms on equivalent refactors.
- cross-ai ordering guard fails red when the step is missing.
- issue-766 parses required fields from the schema fixture (auto-enforced).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: stub USERPROFILE alongside HOME in feat-488 (Windows parity)

The feat-488 redesign stubbed process.env.HOME but not USERPROFILE; os.homedir()
resolves from USERPROFILE on Windows, so the home stub was not hermetic there —
caught by windows-test-parity-guard (stubsHomeNoUserProfile). Save/set/restore
USERPROFILE symmetrically with HOME (delete-if-originally-undefined).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: reconcile allow-test-rule allowlist after rebase onto next

Rebasing onto current next pulled in merged PR #1170, which added
inventory-headings-countfree.test.cjs (a baseline allow-test-rule exemption) and
deleted inventory-counts.test.cjs. Grandfather the former and prune the latter so
the ratchet matches the merged tree. No new debt from this PR.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-13 23:35:08 -04:00

153 lines
6.8 KiB
JavaScript

const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const CONFIG_PATH = path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'config.cjs');
const EXECUTE_PHASE_PATH = path.join(__dirname, '..', 'gsd-core', 'workflows', 'execute-phase.md');
const CONFIG_TEMPLATE_PATH = path.join(__dirname, '..', 'gsd-core', 'templates', 'config.json');
// Read shared fixtures once at module load so tests are independent of each other's
// execution order and do not share mutable state.
const executePhaseContent = fs.readFileSync(EXECUTE_PHASE_PATH, 'utf-8');
const configTemplate = JSON.parse(fs.readFileSync(CONFIG_TEMPLATE_PATH, 'utf-8'));
// Extract the cross_ai_delegation step body once; used by several assertions below.
const CROSS_AI_STEP_OPEN = '<step name="cross_ai_delegation">';
const CROSS_AI_STEP_START = executePhaseContent.indexOf(CROSS_AI_STEP_OPEN);
const CROSS_AI_STEP_END =
executePhaseContent.indexOf('</step>', CROSS_AI_STEP_START) + '</step>'.length;
const crossAiSection = CROSS_AI_STEP_START >= 0
? executePhaseContent.substring(CROSS_AI_STEP_START, CROSS_AI_STEP_END)
: '';
// Extract the parse_args step body once.
const PARSE_ARGS_STEP_OPEN = '<step name="parse_args"';
const PARSE_ARGS_STEP_START = executePhaseContent.indexOf(PARSE_ARGS_STEP_OPEN);
const PARSE_ARGS_STEP_END =
executePhaseContent.indexOf('</step>', PARSE_ARGS_STEP_START) + '</step>'.length;
const parseArgsSection = PARSE_ARGS_STEP_START >= 0
? executePhaseContent.substring(PARSE_ARGS_STEP_START, PARSE_ARGS_STEP_END)
: '';
describe('workflow.cross_ai_execution feature', () => {
describe('config keys', () => {
test('workflow.cross_ai_execution is in VALID_CONFIG_KEYS', () => {
const { VALID_CONFIG_KEYS } = require(CONFIG_PATH);
assert.ok(VALID_CONFIG_KEYS.has('workflow.cross_ai_execution'),
'VALID_CONFIG_KEYS must include workflow.cross_ai_execution');
});
test('workflow.cross_ai_command is in VALID_CONFIG_KEYS', () => {
const { VALID_CONFIG_KEYS } = require(CONFIG_PATH);
assert.ok(VALID_CONFIG_KEYS.has('workflow.cross_ai_command'),
'VALID_CONFIG_KEYS must include workflow.cross_ai_command');
});
test('workflow.cross_ai_timeout is in VALID_CONFIG_KEYS', () => {
const { VALID_CONFIG_KEYS } = require(CONFIG_PATH);
assert.ok(VALID_CONFIG_KEYS.has('workflow.cross_ai_timeout'),
'VALID_CONFIG_KEYS must include workflow.cross_ai_timeout');
});
});
describe('config template defaults', () => {
test('config template has cross_ai_execution default of false', () => {
assert.strictEqual(configTemplate.workflow.cross_ai_execution, false,
'cross_ai_execution should default to false');
});
test('config template has cross_ai_command default of empty string', () => {
assert.strictEqual(configTemplate.workflow.cross_ai_command, '',
'cross_ai_command should default to empty string');
});
test('config template has cross_ai_timeout default of 300 seconds', () => {
assert.strictEqual(configTemplate.workflow.cross_ai_timeout, 300,
'cross_ai_timeout should default to 300 seconds');
});
});
describe('execute-phase.md cross-AI step', () => {
test('execute-phase.md has a cross-AI execution step', () => {
assert.ok(executePhaseContent.includes(CROSS_AI_STEP_OPEN),
'execute-phase.md must have a step named cross_ai_delegation');
});
test('cross-AI step appears between discover_and_group_plans and execute_waves', () => {
const discoverIdx = executePhaseContent.indexOf('<step name="discover_and_group_plans">');
const crossAiIdx = executePhaseContent.indexOf(CROSS_AI_STEP_OPEN);
const executeIdx = executePhaseContent.indexOf('<step name="execute_waves">');
assert.ok(crossAiIdx >= 0, 'cross_ai_delegation step is missing from execute-phase.md');
assert.ok(discoverIdx < crossAiIdx, 'cross_ai_delegation must come after discover_and_group_plans');
assert.ok(crossAiIdx < executeIdx, 'cross_ai_delegation must come before execute_waves');
});
test('cross-AI step handles --cross-ai flag', () => {
assert.ok(executePhaseContent.includes('--cross-ai'),
'execute-phase.md must reference --cross-ai flag');
});
test('cross-AI step handles --no-cross-ai flag', () => {
assert.ok(executePhaseContent.includes('--no-cross-ai'),
'execute-phase.md must reference --no-cross-ai flag');
});
test('cross-AI step uses stdin-based prompt delivery', () => {
// The step must describe piping prompt via stdin, not shell interpolation
assert.ok(executePhaseContent.includes('stdin'),
'cross-AI step must describe stdin-based prompt delivery');
});
test('cross-AI step validates summary output', () => {
// The step must describe validating the captured summary
assert.ok(
crossAiSection.includes('SUMMARY') && crossAiSection.includes('valid'),
'cross-AI step must validate the summary output'
);
});
test('cross-AI step warns about dirty working tree', () => {
assert.ok(
crossAiSection.includes('dirty') || crossAiSection.includes('uncommitted') || crossAiSection.includes('working tree'),
'cross-AI step must warn about dirty/uncommitted changes from external command'
);
});
test('cross-AI step reads cross_ai_command from config', () => {
assert.ok(
crossAiSection.includes('cross_ai_command'),
'cross-AI step must read cross_ai_command from config'
);
});
test('cross-AI step reads cross_ai_timeout from config', () => {
assert.ok(
crossAiSection.includes('cross_ai_timeout'),
'cross-AI step must read cross_ai_timeout from config'
);
});
test('cross-AI step handles failure with retry/skip/abort', () => {
assert.ok(crossAiSection.includes('retry'), 'cross-AI step must offer retry on failure');
assert.ok(crossAiSection.includes('skip'), 'cross-AI step must offer skip on failure');
assert.ok(crossAiSection.includes('abort'), 'cross-AI step must offer abort on failure');
});
test('cross-AI step skips normal executor for handled plans', () => {
assert.ok(
crossAiSection.includes('skip') && (crossAiSection.includes('executor') || crossAiSection.includes('execute_waves')),
'cross-AI step must describe skipping normal executor for cross-AI handled plans'
);
});
test('parse_args step includes --cross-ai and --no-cross-ai', () => {
assert.ok(parseArgsSection.includes('--cross-ai'),
'parse_args step must parse --cross-ai flag');
assert.ok(parseArgsSection.includes('--no-cross-ai'),
'parse_args step must parse --no-cross-ai flag');
});
});
});