Files
msd-core/sdk/src/gsd-tools.ts
Rezolv c5b1445529 feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
2026-04-20 18:09:02 -04:00

596 lines
20 KiB
TypeScript

/**
* GSD Tools Bridge — programmatic access to GSD planning operations.
*
* By default routes commands through the SDK **query registry** (same handlers as
* `gsd-sdk query`) so `PhaseRunner`, `InitRunner`, and `GSD` share contracts with
* the typed CLI. Runner hot-path helpers (`initPhaseOp`, `phasePlanIndex`,
* `phaseComplete`, `initNewProject`, `configSet`, `commit`) call
* `registry.dispatch()` with canonical keys when native query is active, avoiding
* repeated argv resolution. When a workstream is set, dispatches to `gsd-tools.cjs` so
* workstream env stays aligned with CJS.
*/
import { execFile } from 'node:child_process';
import { readFile } from 'node:fs/promises';
import { existsSync } from 'node:fs';
import { join } from 'node:path';
import { homedir } from 'node:os';
import { fileURLToPath } from 'node:url';
import type { InitNewProjectInfo, PhaseOpInfo, PhasePlanIndex, RoadmapAnalysis } from './types.js';
import type { GSDEventStream } from './event-stream.js';
import { GSDError, exitCodeFor } from './errors.js';
import { createRegistry } from './query/index.js';
import { resolveQueryArgv } from './query/registry.js';
import { normalizeQueryCommand } from './query/normalize-query-command.js';
import { formatStateLoadRawStdout } from './query/state-project-load.js';
// ─── Error type ──────────────────────────────────────────────────────────────
export class GSDToolsError extends Error {
constructor(
message: string,
public readonly command: string,
public readonly args: string[],
public readonly exitCode: number | null,
public readonly stderr: string,
options?: { cause?: unknown },
) {
super(message, options);
this.name = 'GSDToolsError';
}
}
// ─── GSDTools class ──────────────────────────────────────────────────────────
const DEFAULT_TIMEOUT_MS = 30_000;
const BUNDLED_GSD_TOOLS_PATH = fileURLToPath(
new URL('../../get-shit-done/bin/gsd-tools.cjs', import.meta.url),
);
function formatRegistryRawStdout(matchedCmd: string, data: unknown): string {
if (matchedCmd === 'state.load') {
return formatStateLoadRawStdout(data);
}
if (matchedCmd === 'commit') {
const d = data as Record<string, unknown>;
if (d.committed === true) {
return d.hash != null ? String(d.hash) : 'committed';
}
if (d.committed === false) {
const r = String(d.reason ?? '');
if (
r.includes('commit_docs') ||
r.includes('skipped') ||
r.includes('gitignored') ||
r === 'skipped_commit_docs_false'
) {
return 'skipped';
}
if (r.includes('nothing') || r.includes('nothing_to_commit')) {
return 'nothing';
}
return r || 'nothing';
}
return JSON.stringify(data, null, 2);
}
if (matchedCmd === 'config-set') {
const d = data as Record<string, unknown>;
if ((d.updated === true || d.set === true) && d.key !== undefined) {
const v = d.value;
if (v === null || v === undefined) {
return `${d.key}=`;
}
if (typeof v === 'object') {
return `${d.key}=${JSON.stringify(v)}`;
}
return `${d.key}=${String(v)}`;
}
return JSON.stringify(data, null, 2);
}
if (matchedCmd === 'state.begin-phase' || matchedCmd === 'state begin-phase') {
const d = data as Record<string, unknown>;
const u = d.updated as string[] | undefined;
return Array.isArray(u) && u.length > 0 ? 'true' : 'false';
}
if (typeof data === 'string') {
return data;
}
return JSON.stringify(data, null, 2);
}
export class GSDTools {
private readonly projectDir: string;
private readonly gsdToolsPath: string;
private readonly timeoutMs: number;
private readonly workstream?: string;
private readonly registry: ReturnType<typeof createRegistry>;
private readonly preferNativeQuery: boolean;
constructor(opts: {
projectDir: string;
gsdToolsPath?: string;
timeoutMs?: number;
workstream?: string;
/** When set, mutation handlers emit the same events as `gsd-sdk query`. */
eventStream?: GSDEventStream;
/** Correlation id for mutation events when `eventStream` is set. */
sessionId?: string;
/**
* When true (default), route known commands through the SDK query registry.
* Set false in tests that substitute a mock `gsdToolsPath` script.
*/
preferNativeQuery?: boolean;
}) {
this.projectDir = opts.projectDir;
this.gsdToolsPath =
opts.gsdToolsPath ?? resolveGsdToolsPath(opts.projectDir);
this.timeoutMs = opts.timeoutMs ?? DEFAULT_TIMEOUT_MS;
this.workstream = opts.workstream;
this.preferNativeQuery = opts.preferNativeQuery ?? true;
this.registry = createRegistry(opts.eventStream, opts.sessionId);
}
private shouldUseNativeQuery(): boolean {
return this.preferNativeQuery && !this.workstream;
}
private nativeMatch(command: string, args: string[]) {
const [normCmd, normArgs] = normalizeQueryCommand(command, args);
const tokens = [normCmd, ...normArgs];
return resolveQueryArgv(tokens, this.registry);
}
private toToolsError(command: string, args: string[], err: unknown): GSDToolsError {
if (err instanceof GSDError) {
return new GSDToolsError(
err.message,
command,
args,
exitCodeFor(err.classification),
'',
{ cause: err },
);
}
const msg = err instanceof Error ? err.message : String(err);
return new GSDToolsError(
msg,
command,
args,
1,
'',
err instanceof Error ? { cause: err } : undefined,
);
}
/**
* Enforce {@link GSDTools.timeoutMs} for in-process registry dispatches so native
* routing cannot hang indefinitely (subprocess path already uses `execFile` timeout).
*/
private async withRegistryDispatchTimeout<T>(
legacyCommand: string,
legacyArgs: string[],
work: Promise<T>,
): Promise<T> {
let timeoutId: ReturnType<typeof setTimeout> | undefined;
const timeoutPromise = new Promise<never>((_, reject) => {
timeoutId = setTimeout(() => {
reject(
new GSDToolsError(
`gsd-tools timed out after ${this.timeoutMs}ms: ${legacyCommand} ${legacyArgs.join(' ')}`,
legacyCommand,
legacyArgs,
null,
'',
),
);
}, this.timeoutMs);
});
try {
// Promise.race rejects when the timeout fires but does not cancel the handler promise;
// native handlers may still run to completion (unlike subprocess + execFile timeout).
return await Promise.race([work, timeoutPromise]);
} finally {
if (timeoutId !== undefined) {
clearTimeout(timeoutId);
}
}
}
/**
* Direct registry dispatch for a known handler key — skips `resolveQueryArgv` on the hot path
* used by PhaseRunner / InitRunner (`initPhaseOp`, `phasePlanIndex`, etc.).
* When native query is off (e.g. workstream or tests with `preferNativeQuery: false`), delegates to `exec`.
*
* When native query is on, `registry.dispatch` failures are wrapped as {@link GSDToolsError} and
* **not** retried via the legacy `gsd-tools.cjs` subprocess — callers see the handler error
* explicitly. Only commands with no registry match fall through to subprocess routing in {@link exec}.
*/
private async dispatchNativeJson(
legacyCommand: string,
legacyArgs: string[],
registryCmd: string,
registryArgs: string[],
): Promise<unknown> {
if (!this.shouldUseNativeQuery()) {
return this.exec(legacyCommand, legacyArgs);
}
try {
const result = await this.withRegistryDispatchTimeout(
legacyCommand,
legacyArgs,
this.registry.dispatch(registryCmd, registryArgs, this.projectDir),
);
return result.data;
} catch (err) {
if (err instanceof GSDToolsError) throw err;
throw this.toToolsError(legacyCommand, legacyArgs, err);
}
}
/**
* Same as {@link dispatchNativeJson} for handlers whose CLI contract is raw stdout (`execRaw`),
* including the same “no silent fallback to CJS on handler failure” behaviour.
*/
private async dispatchNativeRaw(
legacyCommand: string,
legacyArgs: string[],
registryCmd: string,
registryArgs: string[],
): Promise<string> {
if (!this.shouldUseNativeQuery()) {
return this.execRaw(legacyCommand, legacyArgs);
}
try {
const result = await this.withRegistryDispatchTimeout(
legacyCommand,
legacyArgs,
this.registry.dispatch(registryCmd, registryArgs, this.projectDir),
);
return formatRegistryRawStdout(registryCmd, result.data).trim();
} catch (err) {
if (err instanceof GSDToolsError) throw err;
throw this.toToolsError(legacyCommand, legacyArgs, err);
}
}
// ─── Core exec ───────────────────────────────────────────────────────────
/**
* Execute a gsd-tools command and return parsed JSON output.
* Handles the `@file:` prefix pattern for large results.
*
* With native query enabled, a matching registry handler runs in-process;
* if that handler throws, the error is surfaced (no automatic fallback to `gsd-tools.cjs`).
*/
async exec(command: string, args: string[] = []): Promise<unknown> {
if (this.shouldUseNativeQuery()) {
const matched = this.nativeMatch(command, args);
if (matched) {
try {
const result = await this.withRegistryDispatchTimeout(
command,
args,
this.registry.dispatch(matched.cmd, matched.args, this.projectDir),
);
return result.data;
} catch (err) {
if (err instanceof GSDToolsError) throw err;
throw this.toToolsError(command, args, err);
}
}
}
const wsArgs = this.workstream ? ['--ws', this.workstream] : [];
const fullArgs = [this.gsdToolsPath, command, ...args, ...wsArgs];
return new Promise<unknown>((resolve, reject) => {
const child = execFile(
process.execPath,
fullArgs,
{
cwd: this.projectDir,
maxBuffer: 10 * 1024 * 1024, // 10MB
timeout: this.timeoutMs,
env: { ...process.env },
},
async (error, stdout, stderr) => {
const stderrStr = stderr?.toString() ?? '';
if (error) {
if (error.killed || (error as NodeJS.ErrnoException).code === 'ETIMEDOUT') {
reject(
new GSDToolsError(
`gsd-tools timed out after ${this.timeoutMs}ms: ${command} ${args.join(' ')}`,
command,
args,
null,
stderrStr,
),
);
return;
}
reject(
new GSDToolsError(
`gsd-tools exited with code ${error.code ?? 'unknown'}: ${command} ${args.join(' ')}${stderrStr ? `\n${stderrStr}` : ''}`,
command,
args,
typeof error.code === 'number' ? error.code : (error as { status?: number }).status ?? 1,
stderrStr,
),
);
return;
}
const raw = stdout?.toString() ?? '';
try {
const parsed = await this.parseOutput(raw);
resolve(parsed);
} catch (parseErr) {
reject(
new GSDToolsError(
`Failed to parse gsd-tools output for "${command}": ${parseErr instanceof Error ? parseErr.message : String(parseErr)}\nRaw output: ${raw.slice(0, 500)}`,
command,
args,
0,
stderrStr,
),
);
}
},
);
child.on('error', (err) => {
reject(
new GSDToolsError(
`Failed to execute gsd-tools: ${err.message}`,
command,
args,
null,
'',
),
);
});
});
}
/**
* Parse gsd-tools output, handling `@file:` prefix.
*/
private async parseOutput(raw: string): Promise<unknown> {
const trimmed = raw.trim();
if (trimmed === '') {
return null;
}
let jsonStr = trimmed;
if (jsonStr.startsWith('@file:')) {
const filePath = jsonStr.slice(6).trim();
try {
jsonStr = await readFile(filePath, 'utf-8');
} catch (err) {
const reason = err instanceof Error ? err.message : String(err);
throw new Error(`Failed to read gsd-tools @file: indirection at "${filePath}": ${reason}`);
}
}
return JSON.parse(jsonStr);
}
// ─── Raw exec (no JSON parsing) ───────────────────────────────────────
/**
* Execute a gsd-tools command and return raw stdout without JSON parsing.
* Use for commands like `config-set` that return plain text, not JSON.
*/
async execRaw(command: string, args: string[] = []): Promise<string> {
if (this.shouldUseNativeQuery()) {
const matched = this.nativeMatch(command, args);
if (matched) {
try {
const result = await this.withRegistryDispatchTimeout(
command,
args,
this.registry.dispatch(matched.cmd, matched.args, this.projectDir),
);
return formatRegistryRawStdout(matched.cmd, result.data).trim();
} catch (err) {
if (err instanceof GSDToolsError) throw err;
throw this.toToolsError(command, args, err);
}
}
}
const wsArgs = this.workstream ? ['--ws', this.workstream] : [];
const fullArgs = [this.gsdToolsPath, command, ...args, ...wsArgs, '--raw'];
return new Promise<string>((resolve, reject) => {
const child = execFile(
process.execPath,
fullArgs,
{
cwd: this.projectDir,
maxBuffer: 10 * 1024 * 1024,
timeout: this.timeoutMs,
env: { ...process.env },
},
(error, stdout, stderr) => {
const stderrStr = stderr?.toString() ?? '';
if (error) {
reject(
new GSDToolsError(
`gsd-tools exited with code ${error.code ?? 'unknown'}: ${command} ${args.join(' ')}${stderrStr ? `\n${stderrStr}` : ''}`,
command,
args,
typeof error.code === 'number' ? error.code : (error as { status?: number }).status ?? 1,
stderrStr,
),
);
return;
}
resolve((stdout?.toString() ?? '').trim());
},
);
child.on('error', (err) => {
reject(
new GSDToolsError(
`Failed to execute gsd-tools: ${err.message}`,
command,
args,
null,
'',
),
);
});
});
}
// ─── Typed convenience methods ─────────────────────────────────────────
async stateLoad(): Promise<string> {
return this.dispatchNativeRaw('state', ['load'], 'state.load', []);
}
async roadmapAnalyze(): Promise<RoadmapAnalysis> {
return this.exec('roadmap', ['analyze']) as Promise<RoadmapAnalysis>;
}
async phaseComplete(phase: string): Promise<string> {
return this.dispatchNativeRaw('phase', ['complete', phase], 'phase.complete', [phase]);
}
async commit(message: string, files?: string[]): Promise<string> {
const args = [message];
if (files?.length) {
args.push('--files', ...files);
}
return this.dispatchNativeRaw('commit', args, 'commit', args);
}
async verifySummary(path: string): Promise<string> {
return this.execRaw('verify-summary', [path]);
}
async initExecutePhase(phase: string): Promise<string> {
return this.execRaw('state', ['begin-phase', '--phase', phase]);
}
/**
* Query phase state from gsd-tools.cjs `init phase-op`.
* Returns a typed PhaseOpInfo describing what exists on disk for this phase.
*/
async initPhaseOp(phaseNumber: string): Promise<PhaseOpInfo> {
const result = await this.dispatchNativeJson(
'init',
['phase-op', phaseNumber],
'init.phase-op',
[phaseNumber],
);
return result as PhaseOpInfo;
}
/**
* Get a config value via the `config-get` surface (CJS and registry use the same key path).
*/
async configGet(key: string): Promise<string | null> {
const result = await this.dispatchNativeJson(
'config-get',
[key],
'config-get',
[key],
);
return result as string | null;
}
/**
* Begin phase state tracking in gsd-tools.cjs.
*/
async stateBeginPhase(phaseNumber: string): Promise<string> {
return this.execRaw('state', ['begin-phase', '--phase', phaseNumber]);
}
/**
* Get the plan index for a phase, grouping plans into dependency waves.
* Returns typed PhasePlanIndex with wave assignments and completion status.
*/
async phasePlanIndex(phaseNumber: string): Promise<PhasePlanIndex> {
const result = await this.dispatchNativeJson(
'phase-plan-index',
[phaseNumber],
'phase-plan-index',
[phaseNumber],
);
return result as PhasePlanIndex;
}
/**
* Query new-project init state from gsd-tools.cjs `init new-project`.
* Returns project metadata, model configs, brownfield detection, etc.
*/
async initNewProject(): Promise<InitNewProjectInfo> {
const result = await this.dispatchNativeJson('init', ['new-project'], 'init.new-project', []);
return result as InitNewProjectInfo;
}
/**
* Set a config value via gsd-tools.cjs `config-set`.
* Handles type coercion (booleans, numbers, JSON) on the gsd-tools side.
* Note: config-set returns `key=value` text, not JSON, so we use execRaw.
*/
async configSet(key: string, value: string): Promise<string> {
return this.dispatchNativeRaw('config-set', [key, value], 'config-set', [key, value]);
}
}
/**
* Run `gsd-sdk query` semantics in-process: normalize argv, resolve registry, dispatch.
* Returns handler JSON payload (same as stdout from the `gsd-sdk query` CLI without `--pick`).
*/
export async function runGsdToolsQuery(projectDir: string, queryArgv: string[]): Promise<unknown> {
const { createRegistry } = await import('./query/index.js');
const { resolveQueryArgv } = await import('./query/registry.js');
const { normalizeQueryCommand } = await import('./query/normalize-query-command.js');
const { GSDError, ErrorClassification } = await import('./errors.js');
if (queryArgv.length === 0 || !queryArgv[0]) {
throw new GSDError('runGsdToolsQuery requires a command', ErrorClassification.Validation);
}
const queryCommand = queryArgv[0];
const [normCmd, normArgs] = normalizeQueryCommand(queryCommand, queryArgv.slice(1));
const registry = createRegistry();
const tokens = [normCmd, ...normArgs];
const matched = resolveQueryArgv(tokens, registry);
if (!matched) {
throw new GSDError(
`Unknown command: "${tokens.join(' ')}". No native handler registered.`,
ErrorClassification.Validation,
);
}
const result = await registry.dispatch(matched.cmd, matched.args, projectDir);
return result.data;
}
// ─── Path resolution ────────────────────────────────────────────────────────
/**
* Resolve gsd-tools.cjs path.
* Probe order: SDK-bundled repo copy → `project/.claude/get-shit-done/` →
* `~/.claude/get-shit-done/`.
*/
export function resolveGsdToolsPath(projectDir: string): string {
const candidates = [
BUNDLED_GSD_TOOLS_PATH,
join(projectDir, '.claude', 'get-shit-done', 'bin', 'gsd-tools.cjs'),
join(homedir(), '.claude', 'get-shit-done', 'bin', 'gsd-tools.cjs'),
];
return candidates.find(candidate => existsSync(candidate)) ?? candidates[candidates.length - 1]!;
}