6b196ef638
* fix(release): finalize job calls sync-next-version.cjs to bump next after final release (#2423) The release pipeline's 'finalize' job shipped X.Y.0 to npm 'latest' and merged to main, but never bumped 'next' to match. 'scripts/sync-next-version.cjs' exists exactly for this — its docstring promises to run 'for every release type (rc / hotfix / final)' — but it was wired only into the 'rc' job (release.yml:479), not 'finalize'. As a result, after 1.7.0 shipped on 2026-07-15, 'next' stayed at 1.7.0-rc.6 and every npm script banner on 'next' (and feature branches cut from it) reported the stale rc version. Regression of #1104 — closed incomplete (covered rc only, not final). This patch: - adds a 'Sync next branch to the published release' step to the 'finalize' job, mirroring the rc job's pattern at line 479 (uses VERSION from inputs.version rather than PRE_VERSION from steps.prerelease, since finalize does not run the prerelease step); - gates it on !inputs.dry_run + continue-on-error:true (matches rc); - adds tests/release-finalize-syncs-next-version.test.cjs — a structural YAML assertion that fails against the pre-fix workflow and passes after. Failing-first demonstrated during development; the test parses job blocks by indentation rather than grep so it stays valid as the file grows. Root-cause diagnosis: scripts/sync-next-version.cjs:14 docstring admits 'used by release.yml's rc job, which has no next-targeting PR of its own'. release.yml:506-685 (finalize job) had no sync-next-version step before this patch. Every prior rc.N release has a matching 'chore: sync next package version to 1.7.0-rc.N' commit; there is no such commit for 1.7.0. * chore(release): sync next package version to 1.7.0 (#2423) Replays the canonical 'chore: sync next package version to <v>' commit that the release pipeline's rc job auto-produces via scripts/sync-next-version.cjs, for the 1.7.0 final release that shipped on 2026-07-15 (commitdd4c90f82'chore: finalize v1.7.0' on main). Without this, 'next' (and every feature branch cut from it) carried 1.7.0-rc.6 indefinitely and reported it in every npm script banner (e.g. 'lint:ci'). Bumps 43 synchronized manifests via the npm 'version' lifecycle hook (scripts/sync-manifest-versions.cjs --stage + scripts/gen-capability-registry.cjs --write), matching the file set of commit27f69cc48('chore: sync next package version to 1.7.0-rc.6') and commitdd4c90f82('chore: finalize v1.7.0'). This is the immediate Layer-1 repair for #2423. Layer-2 (prevent recurrence) is the workflow patch in the previous commit; Layer-3 (regression test) ships with it. Future X.Y.0 final releases will produce this commit automatically once the workflow fix lands. * test(release): tighten #2423 dry-run gate assertion to the sync step Code review of fix/2423 found that test #3 ('gates sync-next-version on !inputs.dry_run') asserted too loosely: it scanned the entire finalize block for any '!inputs.dry_run' line, so it would still pass if the gate were stripped from the sync-next-version step specifically — the exact regression the test name promises to catch. The finalize job has multiple steps with their own !inputs.dry_run gates (e.g. Verify publish), so the loose version masked the very bug it claimed to detect. Tighten by extracting the specific YAML step block containing 'scripts/sync-next-version.cjs' and asserting the gate appears within THAT step's lines, not anywhere in the job. Verified the tightened test: - PASSES against the post-fix workflow (sync step has its own gate) - FAILS when the sync step's gate is stripped (even when other steps in finalize retain their own !inputs.dry_run gates) — the exact regression that previously slipped through Adds extractStepBlockContaining(jobBlock, marker) helper alongside the existing extractJobBlock(text, jobName). Reuses the same indentation- based parsing, so it stays valid as the file grows. * chore(changeset): backfill pr:2437 in .changeset/sturdy-ibex-jump.md CLAUDE.md changeset convention: 'Use placeholder pr:0 during initial commit. Backfill immediately after gh api POST /pulls returns the real number.' PR #2437 created from branch fix/2423-release-finalize-sync-next-version. * fix(#2423): add see #2423 to allow-test-rule exemption per ADR-456 CI lint-allow-test-rule-refs failed on PR #2437: ADR-456 requires new allow-test-rule exemptions added after the ADR's acceptance to include a tracking issue number in the comment, in the form // allow-test-rule: <reason> (see #NNN) The exemption added in commit 976c8b0a2 lacked this ref. Fixed. Verified locally: node scripts/lint-allow-test-rule-refs.cjs → ok lint-allow-test-rule-refs: 173 grandfathered exemption(s) tracked, no novel untracked offenders
62 lines
1.2 KiB
JSON
62 lines
1.2 KiB
JSON
{
|
|
"id": "code-review",
|
|
"role": "feature",
|
|
"version": "1.7.0",
|
|
"title": "Code review",
|
|
"description": "Source-file code review and review-fix workflow support for completed execution work.",
|
|
"tier": "full",
|
|
"requires": [],
|
|
"engines": {
|
|
"gsd": ">=1.6.0"
|
|
},
|
|
"runtimeCompat": {
|
|
"supported": [
|
|
"*"
|
|
],
|
|
"unsupported": []
|
|
},
|
|
"skills": [
|
|
"code-review"
|
|
],
|
|
"agents": [
|
|
"gsd-code-reviewer",
|
|
"gsd-code-fixer"
|
|
],
|
|
"hooks": [],
|
|
"config": {
|
|
"workflow.code_review": {
|
|
"type": "boolean",
|
|
"default": true,
|
|
"description": "Enable code-review participation in post-execution review flows."
|
|
},
|
|
"workflow.code_review_depth": {
|
|
"type": "enum",
|
|
"values": [
|
|
"quick",
|
|
"standard",
|
|
"deep"
|
|
],
|
|
"default": "standard",
|
|
"description": "Default depth for code review when no --depth override is supplied."
|
|
}
|
|
},
|
|
"steps": [
|
|
{
|
|
"point": "execute:post",
|
|
"ref": {
|
|
"skill": "code-review"
|
|
},
|
|
"produces": [
|
|
"REVIEW.md"
|
|
],
|
|
"consumes": [
|
|
"SUMMARY.md"
|
|
],
|
|
"when": "workflow.code_review",
|
|
"onError": "skip"
|
|
}
|
|
],
|
|
"contributions": [],
|
|
"gates": []
|
|
}
|