* chore: rebuild ADR index as a generated artifact and enforce lifecycle invariants
The ADR index in docs/adr/README.md was hand-maintained with nothing checking
it, and had drifted to 40 of 65 ADRs. The absent rows included the entire
capability family (857/894/959/1016/1143/1213/1244) and ADR-1239 (EoS) itself,
so the decisions a reader most needed were the ones they could not find.
Make the index a derived artifact, matching the repo's existing generated-file
idiom (lint:generated-sync), and enforce the corpus' lifecycle invariants:
- scripts/gen-adr-index.cjs generates the index between markers and validates
the status vocabulary (Accepted/Proposed/Superseded/Legacy/Retired),
successor links, id/filename agreement, and supersession symmetry.
- Wire --check into lint:generated-sync so drift fails CI.
Correct the lifecycle metadata the gate surfaced, without flipping any status:
- ADR-1239 (EoS) declared it subsumed ADR-1016/58/3660/894; none recorded it.
Add reciprocal "Subsumed by" pointers + dated amendments. Subsumption keeps
the target Accepted -- these are live adapters, not dead decisions.
- ADR-857/894 carry dated status caveats: they read Proposed while the
capability system shipped and epic #857 is closed. Ratification is a
maintainer act and is deliberately left open.
- Link ADR-0005/0007/0012/3524 -> ADR-0174 and ADR-0010 -> ADR-0009; record
the reciprocal Supersedes on ADR-0009.
- ADR-218 declared itself "ADR-0175" -- an unfinished rename.
- The 0011 PRD moves from the non-canonical "Draft" to "Legacy".
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: capture stderr via spawnSync; record ADR-0010 draft supersession
Two fixes surfaced by the first gsd-test run and by regenerating the index:
- tests/adr-index-gate.test.cjs used execFileSync, which only surfaces stderr
through the thrown error on non-zero exit. The `--write` path exits 0 while
reporting outstanding violations on stderr, so the helper always saw ''.
spawnSync captures both streams on both outcomes.
- The hand-maintained index recorded 0010-skill-surface-budget-module.md as
"earlier draft superseded by ADR-0011" while the file itself still said
Proposed. Deriving the index from the files would have dropped that
assertion and resurrected a superseded draft as a live decision, so it is
recorded at its source, with the reciprocal Supersedes on ADR-0011.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: drop the dead sdk/ model-catalog candidate retired by ADR-0174
src/model-catalog.cts resolved model-catalog.json through three candidates, the
second being sdk/shared/model-catalog.json three levels up. That was the legacy
source-repo fallback kept by the #3288 fix ("check the co-located path FIRST,
before the legacy source-repo path").
ADR-0174 then retired the @opengsd/gsd-sdk package boundary and deleted the sdk/
tree (11918dcc3), so the candidate can no longer resolve in any layout: a source
repo has no sdk/, and an install layout points it at ~/.claude/sdk/shared/, which
the installer never writes -- the original #3288 bug. It was dead weight implying
a package boundary this repo no longer has.
No test depends on it: the #3288 regression tests in tests/install.test.cjs write
their own synthetic old-path fixture and assert it throws.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* docs: ratify nine shipped ADRs; record why ten others stay Proposed
The corpus carried 19 Proposed ADRs, most describing architecture that had
already shipped. A Proposed label on live architecture tells contributors and
agents the decision is an unbuilt idea -- the capability system and EoS were
both being misread that way.
Audited all 19 against the shipped tree and GitHub. Each candidate flip then had
to survive two independent reviewers instructed to refute it.
Ratified Proposed -> Accepted, each with a dated Ratification section carrying
the verified evidence (file:line, symbols, tests, issue state):
857 capability system 894 declaration format 1244 capability ecosystem
1577 injection boundary 1610 size-budget ratchet 1990 existing-code onboarding
15 cross-AI convergence 22 plan-drift guard 0011 default reviewers
Held ten, each now carrying a "Why this is still Proposed" section naming the
blocker and its unblock condition, so the audit is not repeated:
2264 its own headline acceptance criterion is unmet in the tree
230 live branch protection contradicts the decided spec (1 approval, not 2)
660 the namesake release/<version> re-cut is manual, not automated
959 issue #2346 is approved and plans its graduation as its own ADR
1213 the shipped writer's return shape differs from the decided interface
443 the orchestrator override path has no live caller
1143 / 1606 each states its own bar for acceptance; neither is met
612 / 1671 legitimately open
Shipped code proved necessary but not sufficient: eight ADRs had every named
module, symbol, and test present with their epics closed, and still failed the
bar. That lesson is written into README.md's ratification procedure.
Also corrected ADR-857's "Supersedes (generalizes)" to "Subsumes": taken
literally it would have marked two live seams dead -- ADR-0011 (surface.cts:348)
and ADR-58 (runtime-artifact-install-plan.cts:82). Both keep Accepted status and
gain Subsumed-by pointers.
Index: Active 39->48, Proposed 19->10, Superseded/Legacy 7. 65 total.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: harden gen-adr-index against hostile titles and non-ADR filenames (#2356)
Three findings from the pre-PR orthogonal security review, all confirmed:
- An ADR title containing the literal ADR-INDEX:END marker was emitted verbatim
into its table cell, relocating the splice boundary so the NEXT --write
spliced against the wrong marker and truncated README.md. Titles now render
through cellText(), which escapes pipes and angle brackets -- making an HTML
comment (and any other HTML) unformable from ADR-authored text.
- A docs/adr/*.md without a numeric prefix crashed on match(...)[1] of null.
Such a file is also invisible to the index -- the very failure this gate
exists to prevent -- so it is now reported as a naming-convention violation
naming the file and the fix.
- Tests leaked their mkdtemp dirs. They now use helpers.createTempDir/cleanup
via t.after(); helpers.cleanup carries the Windows-EBUSY retry budget that a
raw fs.rmSync lacks (caught by local/no-raw-rmsync-in-tests).
Adds five regression tests: marker hijack, HTML injection, pipe cell-break,
non-conforming filename, and splice stability across repeated writes.
Refs #2356
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: close two gate false-passes; read ## Supersedes sections (#2356)
Second round of confirmed findings from the pre-PR orthogonal code review. Both
false-passes matter more than a false-fail: a gate that silently misses a
violation is worse than no gate, because it is trusted.
- A relation field mixing a link with a bare id silently dropped the bare claim:
the check tested `rel.links.length` (does this field have ANY link?) instead
of whether THAT id was linked. `Supersedes: [ADR-0001](...), ADR-0011` passed
clean -- accepting exactly the ambiguous bare reference the rule forbids. Now
each bare id is checked against the ids actually linked in the same field, so
a repeat in trailing prose stays quiet while an unlinked claim is flagged.
- The ratification guard (`statusToken !== 'Accepted'`) skipped BOTH relation
directions, which killed the IN check entirely: `supersedes.in` is only ever
populated on an ADR whose status IS `Superseded`, so a dangling `Superseded by
X` where X never claims it always passed. The guard now applies to OUT only --
a prospective claim must not obligate its target, but an ADR's statement about
ITSELF is always owed a reciprocal.
- Fixing that surfaced a parser gap: ADR-0174 declares its supersessions in a
`## Supersedes` table SECTION, not a header field, and headerBlock() stops at
the first `##`. The repo's best-documented supersession was invisible. Section
form is now parsed for both relations.
- Replaced a vacuous test: the em-dash negation case passed whether or not
NEGATED_RELATION_RE matched (a mutation to /$^/ survived). It now carries a
link that would create a failing asymmetric relation if negation did not fire.
Also removes docs/adr/9401-test-target.md -- a synthetic fixture a reviewer
created in the worktree while reproducing a finding, swept in by `git add -A`.
Adds regression tests for each: mixed link+bare, linked-and-repeated-in-prose,
dangling superseded-by from a non-Accepted ADR, and the ADR-0174 section shape.
Refs #2356
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: escape backslashes before pipes in the ADR index cell renderer (#2356)
CodeQL js/incomplete-sanitization (high) on scripts/gen-adr-index.cjs: cellText()
escaped `|` -> `\|` without first escaping the backslash. Markdown's escape
character is the backslash, so the input `\|` became `\\|`, which renders as a
literal backslash followed by an UNESCAPED pipe -- re-opening the cell break the
pipe escape exists to prevent. Order is load-bearing: escape the escape
character first, then everything that emits one.
Same class as the index-marker hijack fixed earlier: ADR-authored text breaking
out of the cell it is rendered into.
Adds a regression test asserting a `\|`-bearing title leaves exactly the row's
own 5 unescaped delimiters and cannot forge a Status cell. Uses split(/\r?\n/)
per local/no-crlf-fragile-split -- a literal "\n" split is CRLF-fragile on the
Windows CI leg.
Refs #2356
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
13 KiB
Skill Surface Budget Module owns install-time skill listing curation
- Status: Superseded by ADR-0011 (Skill Surface Budget Module — install-time profile staging and runtime surface control); originally Proposed (2026-05-12)
- Date: 2026-05-12
Provenance of this status (2026-07-16). This file said
Proposedwhile the hand-maintained index inREADME.mdrecorded it as "Skill Surface Budget Module — earlier draft superseded by ADR-0011", status "Superseded by 0011". The index was right and the file was stale. When the index became a generated artifact (derived from these files), that assertion would have been silently dropped and this superseded draft would have reappeared as a liveProposeddecision — so it is recorded here, at its source, instead. This is the one status corrected from the old index rather than left for ratification, because leaving it would have lost a decision the maintainer had already made.
We propose extending the existing install profile seam (gsd-core/bin/lib/install-profiles.cjs) into a Skill Surface Budget Module that owns which subset of GSD's 66 skills is written to the runtime config dirs, and that owns the per-skill requires: dependency manifest used to keep that subset closed under cross-skill references. GSD currently ships a binary --minimal / full toggle; runtimes that enumerate skills (Claude Code, OpenCode, etc.) cap the <available_skills> system-prompt block at skillListingBudgetFraction of the context window (default 1% = ~2k tokens at 200k), and GSD alone consumes ~60% of that cap (#3408). Further description shrinkage is unavailable — scripts/lint-descriptions.cjs already enforces a hard 100-char ceiling and the mean is 72.5 chars. The remaining lever is surfacing fewer skills, which requires a typed profile model plus a dependency manifest, not more ad-hoc allowlists.
Decision
- Add a Skill Surface Budget Module by extending
gsd-core/bin/lib/install-profiles.cjsas the single owner for whichcommands/gsd/*.mdandagents/gsd-*.mdfiles are staged into the per-runtime copy pipeline. - Replace the single
MINIMAL_SKILL_ALLOWLISTconstant with a typedPROFILESmap keyed by profile name. Each profile is a base set of skills; the module computes the transitive closure over each skill's declaredrequires:set before staging. - Add a
requires:frontmatter field to every skill whose body references another GSD skill. The dependency graph in the research memo (docs/research/2026-05-12-skill-surface-budget.md§3.1) is the migration spec for this pass. - Extend
bin/install.jsargument parsing to accept--profile=<name>and--profile=<name1>,<name2>(composable). Preserve--minimal/--core-onlyas aliases for--profile=core. Default install (no flag) remainsfullfor back-compat. - Persist the active profile to
~/.claude/skills/.gsd-profile(and runtime-equivalent locations) sogsd updatere-applies the same profile instead of expanding silently to full. - Add
scripts/lint-skill-deps.cjsand wire it into the existingnpm run lint:descriptionspretest gate. The lint fails if:- a skill body references another skill not in its
requires:set, or - any profile would ship a skill whose
requires:closure is not satisfied.
- a skill body references another skill not in its
- Keep the interactive install picker behind the same
AskUserQuestion-style flow already used for runtime/location selection. Non-interactive installs (CI,npx --yes) fall back to--profile=fullunless overridden.
Initial Scope
First migration slice should land the profile model and one new tier above core:
- Profile map (typed):
core(current minimal, 7 skills includingphase),standard(~13 skills covering the audit + main-loop + utility floor),full(current default, 66 skills). requires:frontmatter added to the hot nodes of the dependency graph first:phase(38 callers),review(11),config(7),progress(5),update(5). These are the skills whose absence silently breaks others, so they need explicitrequired_byaudit before any profile narrows them out.- Confirm-and-lock the latent bug fix surfaced by the audit:
phaseis referenced by 38 skills and now belongs inMINIMAL_SKILL_ALLOWLIST/PROFILES.core. Keep explicit coverage in minimal/core tests so this cannot regress. - CLI surface:
--profile=, comma-composed profiles,--profile=helplisting each profile's contents and token cost. - Profile marker persistence +
gsd updatere-application.
It should not in the first pass:
- Build a runtime enable/disable surface (
/gsd:surface). Track as a follow-up ADR (see "Open questions"). - Split GSD into multiple npm packages. The packaging-level alternative was considered and rejected — see research memo §4 Option F.
- Consolidate further skills (e.g. collapsing
*-phaseinto a dispatcher). Track separately as IA cleanup; orthogonal to surface curation.
Migration Inventory
gsd-core/bin/lib/install-profiles.cjs
- Replace
MINIMAL_SKILL_ALLOWLISTObject.freeze constant withPROFILESObject.freeze map of profile-name → base skill set. - Replace
isMinimalMode(mode)withresolveProfile(mode)returning a typed{name, skills: Set, agents: Set}after transitive-closure computation. - Replace
shouldInstallSkill(name, mode)withshouldInstallSkill(name, resolvedProfile). - Replace
stageSkillsForMode(srcDir, mode)withstageSkillsForProfile(srcDir, resolvedProfile). Add a siblingstageAgentsForProfilesince this module now owns agent staging too (current--minimalskips agents wholesale; tiered profiles need finer control). - Keep the existing exit-cleanup machinery (
STAGED_DIRS,ensureExitCleanup) unchanged — the bug surface it covers is the same.
bin/install.js
These call sites should migrate behind the Skill Surface Budget Module:
--minimal/--core-onlyflag parsing —bin/install.js:123-124_effectiveInstallModeplumbing +isMinimalMode()checks —bin/install.js:7634-8465(passes through to per-runtime copy fns)- minimal-agent skip block —
bin/install.js:8167-8207(becomes "skip agents not in profile") - runtime-specific copy entry points that consume
stageSkillsForMode— 13 sites per the existing comment ininstall-profiles.cjs - usage help block —
bin/install.js:508(add--profile=documentation)
Frontmatter changes
- Add
requires:field to every skill incommands/gsd/*.mdwhose body references another GSD skill. Audit data lists the full set (docs/research/2026-05-12-skill-surface-budget.md§3.1). Estimate: 25-30 files touched in Phase 1. - Field is optional. Absence = "no GSD-skill dependencies."
lint-skill-deps.cjsenforces consistency, not presence.
New: scripts/lint-skill-deps.cjs
- Walks
commands/gsd/*.md, parsesrequires:, walks the body forgsd:<name>or\b<stem>\breferences to other skills (same matching rules documented indocs/research/2026-05-12-skill-surface-budget.md§3.1). - Fails CI if
requires:set ≠ actual references (modulo ignore-list for prose mentions that aren't actual dispatches). - Walks
PROFILESfrominstall-profiles.cjs, fails if any profile's transitive closure references a skill not in the profile. - Wires into
npm run lint:descriptions(or as a siblinglint:skill-deps) andpretest.
Profile marker
- New
~/.claude/skills/.gsd-profile(and per-runtime equivalents under.codex/,.cursor/, etc. as enumerated ininstall.js) containing the active profile name. - Installer Migration Module (ADR-0008) gains a one-shot migration: if marker absent and skills dir matches
coreexactly, writecore; otherwise writefull. Migrations are idempotent per existing module contract.
Tests expected to move with the seam
tests/install-profiles-*.test.cjs(any existing) — extend to assert profile resolution, transitive closure, and--profile=core,standardcomposition.- New
tests/skill-surface-budget-*.test.cjscovering:- profile closure: a profile that lists
discuss-phasemust transitively includephaseifdiscuss-phaserequires it - lint failures: a skill body that references an un-required skill makes
lint:skill-depsfail - marker persistence:
gsd install --profile=standardfollowed bygsd updatepreservesstandard - minimal back-compat:
--minimalresolves to--profile=coreand emits the same file set as today (modulo thephase-inclusion bug fix)
- profile closure: a profile that lists
Interface sketch
The module should accept typed profile intent and return a typed resolved profile:
// install-profiles.cjs (extended)
resolveProfile({
modes: ['core' | 'standard' | 'full'],
skillsManifest: ManifestMap, // parsed `requires:` graph
})
// → { name: 'standard', skills: Set<string>, agents: Set<string> }
Profile composition: --profile=core,standard resolves to union(closure(core), closure(standard)). --profile=full is the identity profile (every skill).
stageSkillsForProfile(srcDir, resolvedProfile) // returns staged dir path
stageAgentsForProfile(srcAgentsDir, resolvedProfile) // new
Profile marker IO is typed too, not stringly:
readActiveProfile(runtimeConfigDir) // → 'core' | 'standard' | 'full' | null
writeActiveProfile(runtimeConfigDir, profileName)
Per-skill frontmatter contract:
---
name: gsd:plan-phase
description: ...
requires: [phase, discuss-phase] # GSD skills only; not Claude Code primitives
---
requires: lists GSD skills (file stems). It does not include Claude Code built-ins (Read, Bash, etc.) — those continue to live in allowed-tools: per existing convention.
Consequences
- The skill-set written by the installer becomes a typed first-class artifact, not a side effect of file copies + an allowlist constant. ADR-0008 (Installer Migration Module) gains a clean handle for safe profile migrations on upgrade.
gsd updatestops silently re-expanding a--minimalinstall to full — a current foot-gun documented inline ininstall-profiles.cjs(its module-level comment recommendsgsd updatewithout--minimalto "expand to the full surface"; that path remains available, but the defaultgsd updatenow respects the recorded profile).- The
requires:manifest creates a new authoring obligation (~30 files in Phase 1), enforced by CI. Skill authors who add a/gsd:phasereference in a new skill body have to updaterequires:. The lint script keeps drift low-cost. - The
phase-in-minimal latent gap (research memo §3.1) gets resolved as a side effect of adopting closure-based profile resolution —phaseis auto-included whenever any minimal-loop skillrequires:it. - First-time install UX gains a profile picker. The default remains
fullfor non-interactive (npx --yes) installs, so back-compat for CI scripts is preserved. - The module becomes the canonical place to land future Anthropic platform features (lazy descriptions, per-plugin budgets,
.disabledtoggles — see Open Questions). It does not, in this ADR, use those features. - If accepted,
CONTEXT.mdshould gain a canonical Skill Surface Budget Module entry alongside the existing seam entries, and future architecture reviews should treat ad-hoccommands/gsd/filtering outside this seam as drift.
Open questions
- Whether the Phase-2 runtime
/gsd:surfacecommand (research memo §4 Option B) should be its own ADR or an amendment to this one. Leaning separate ADR because it introduces persistent runtime state outside the install pipeline. - Profile naming bikeshed.
core / standard / fullis the working proposal. Alternatives surveyed:minimal / recommended / everything, functional names (planning, audit, research). Settle in the implementation PR after a contributor poll. - Whether the
requires:field should also be consumed by/gsd:helpto render a "skills you have installed and what depends on what" graph. Likely yes, but out of scope for this ADR. - Whether to keep
phaseexplicitly listed incoreforever vs relying purely on closure semantics. Current recommendation: keep explicit listing because minimal mode has a back-compat allowlist path. - Whether telemetry (opt-in) is worth proposing to inform where the
standardprofile line goes. Without it, the cut points are author-intuition. Track separately; not a blocker. - Whether the Anthropic platform asks (research memo §6 — lazy descriptions, per-plugin budgets, dependency-aware listing,
.disabledtoggles) should be filed before or after this ADR ships. Recommendation: file as a feedback bundle when ADR is accepted, so we ship Phase 1 unilaterally and platform improvements compose on top.
References
- Feature issue:
#3408 - Research input:
docs/research/2026-05-12-skill-surface-budget.md - Existing seam being extended:
gsd-core/bin/lib/install-profiles.cjs - Description budget enforcement:
scripts/lint-descriptions.cjs - Installer dispatch site:
bin/install.js:123-124,:8167-8207 - See
0008-installer-migration-module.md(the migration that records the profile marker lives here) - See
0005-sdk-architecture-seam-map.md(the seam map this module joins)