msd-core/tests/bug-2643-skill-frontmatter-name.test.cjs

'use strict';

process.env.GSD_TEST_MODE = '1';

/**
 * Bug #2643: workflows emit Skill(skill="gsd:<cmd>") but flat-skills install
 * registers `gsd-<cmd>` as the frontmatter `name:`. Claude Code uses the
 * frontmatter name (not dir name) as the skill identity — so the emitted
 * `name:` must match the colon form used by workflow Skill() calls.
 *
 * The directory name stays hyphenated for Windows path safety.
 */

const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');

const ROOT = path.join(__dirname, '..');
const {
  convertClaudeCommandToClaudeSkill,
  skillFrontmatterName,
} = require(path.join(ROOT, 'bin', 'install.js'));

const WORKFLOWS_DIR = path.join(ROOT, 'get-shit-done', 'workflows');
const COMMANDS_DIR = path.join(ROOT, 'commands', 'gsd');

function collectFiles(dir, results) {
  if (!results) results = [];
  let entries;
  try { entries = fs.readdirSync(dir, { withFileTypes: true }); } catch { return results; }
  for (const e of entries) {
    const full = path.join(dir, e.name);
    if (e.isDirectory()) collectFiles(full, results);
    else if (e.name.endsWith('.md')) results.push(full);
  }
  return results;
}

function extractSkillNames(content) {
  const names = new Set();
  const rx = /Skill\(skill=['"]gsd:([a-z0-9-]+)['"]/gi;
  let m;
  while ((m = rx.exec(content)) !== null) names.add('gsd:' + m[1]);
  return names;
}

describe('skill frontmatter name parity (#2643)', () => {
  test('skillFrontmatterName helper emits colon form', () => {
    assert.strictEqual(typeof skillFrontmatterName, 'function');
    assert.strictEqual(skillFrontmatterName('gsd-execute-phase'), 'gsd:execute-phase');
    assert.strictEqual(skillFrontmatterName('gsd-plan-phase'), 'gsd:plan-phase');
    assert.strictEqual(skillFrontmatterName('gsd:next'), 'gsd:next');
  });

  test('convertClaudeCommandToClaudeSkill emits name: gsd:<cmd>', () => {
    const input = '---\nname: old\ndescription: test\n---\n\nBody.';
    const result = convertClaudeCommandToClaudeSkill(input, 'gsd-execute-phase');
    assert.match(result, /^---\nname: gsd:execute-phase\n/);
  });

  test('every workflow Skill(skill="gsd:<cmd>") resolves to an emitted skill name', () => {
    const workflowFiles = collectFiles(WORKFLOWS_DIR);
    const referenced = new Set();
    for (const f of workflowFiles) {
      const src = fs.readFileSync(f, 'utf-8');
      for (const n of extractSkillNames(src)) referenced.add(n);
    }
    assert.ok(referenced.size > 0, 'expected at least one Skill(skill="gsd:<cmd>") reference');

    const emitted = new Set();
    const cmdFiles = fs.readdirSync(COMMANDS_DIR).filter(f => f.endsWith('.md'));
    for (const cmd of cmdFiles) {
      const base = cmd.replace(/\.md$/, '');
      const skillDirName = 'gsd-' + base;
      const src = fs.readFileSync(path.join(COMMANDS_DIR, cmd), 'utf-8');
      const out = convertClaudeCommandToClaudeSkill(src, skillDirName);
      const m = out.match(/^---\nname:\s*(.+)$/m);
      if (m) emitted.add(m[1].trim());
    }

    const missing = [];
    for (const r of referenced) if (!emitted.has(r)) missing.push(r);
    assert.deepStrictEqual(
      missing,
      [],
      'workflow refs not emitted as skill names: ' + missing.join(', '),
    );
  });
});