msd-core/tests/workflow-compat.test.cjs

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.

/**
 * Regression guard for #1759: the --no-input flag was removed from Claude Code
 * >= v2.1.81 and causes an immediate crash ("error: unknown option '--no-input'").
 *
 * The -p / --print flag already handles non-interactive output so --no-input
 * must never appear in workflow, command, or agent files.
 */
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');

const ROOT = path.join(__dirname, '..');

/** Recursively collect all .md files under a directory. */
function collectMdFiles(dir) {
  const results = [];
  if (!fs.existsSync(dir)) return results;
  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
    const full = path.join(dir, entry.name);
    if (entry.isDirectory()) {
      results.push(...collectMdFiles(full));
    } else if (entry.isFile() && entry.name.endsWith('.md')) {
      results.push(full);
    }
  }
  return results;
}

const SCAN_DIRS = [
  path.join(ROOT, 'msd-core', 'workflows'),
  path.join(ROOT, 'msd-core', 'references'),
  path.join(ROOT, 'commands', 'msd'),
  path.join(ROOT, 'agents'),
];

describe('workflow CLI compatibility (#1759)', () => {
  test('no workflow/command/agent file uses the deprecated --no-input flag', () => {
    const violations = [];

    for (const dir of SCAN_DIRS) {
      for (const file of collectMdFiles(dir)) {
        const content = fs.readFileSync(file, 'utf-8');
        if (content.includes('--no-input')) {
          const rel = path.relative(ROOT, file);
          violations.push(rel);
        }
      }
    }

    assert.strictEqual(
      violations.length,
      0,
      [
        '--no-input was removed in Claude Code >= v2.1.81 and must not appear in any workflow/command/agent file.',
        'Use -p / --print instead (already implies non-interactive output).',
        'Violations found:',
        ...violations.map(v => '  ' + v),
      ].join('\n')
    );
  });
});


// ────────────────────────────────────────────────────────────────────────
// Folded from tests/feat-41-ship-tdd-audit-gate-status.test.cjs — consolidation epic #1969 (B8 #1977)
// ────────────────────────────────────────────────────────────────────────
{
  const { describe: __foldDescribe } = require('node:test');
  __foldDescribe("folded:feat-41-ship-tdd-audit-gate-status (consolidation epic #1969 B8 #1977)", () => {
'use strict';

// feat(#41): /msd-ship generate_pr_body emits a TDD Audit table + an aggregate
// `gate-status:` trailer so the per-commit TDD gate trail survives squash-merge.
// These assertions pin the shipped workflow prose in msd-core/workflows/ship.md.

const fs = require('node:fs');
const path = require('node:path');
const assert = require('node:assert/strict');
const { describe, test } = require('node:test');

const repoRoot = path.resolve(__dirname, '..');
function readRepoFile(relativePath) {
  return fs.readFileSync(path.join(repoRoot, relativePath), 'utf8');
}

describe('feat-41: ship.md TDD Audit gate-status extraction', () => {
  const workflow = readRepoFile('msd-core/workflows/ship.md');

  test('adds a "## TDD Audit" section to the generated PR body', () => {
    assert.match(workflow, /## TDD Audit/);
  });

  test('shipped TDD-Audit trailer token round-trips through git (#3962)', (t) => {
    // `_` is not a valid git trailer token character, so a `gate-status:`
    // trailer is invisible to interpret-trailers and %(trailers:key=...) -- the
    // audit read returned empty for every commit and self-suppression hid it.
    // Extract the token the shipped workflow actually reads, then prove REAL
    // git can match a commit carrying that exact trailer.
    const { createTempGitProject, cleanup } = require('./helpers.cjs');
    const { runGit } = require('./helpers/process-seam.cjs');
    const tokenMatch = workflow.match(/trailers:key=([A-Za-z-]+),/);
    assert.ok(tokenMatch, 'ship.md must read %(trailers:key=<token>,...) with a simple token');
    const token = tokenMatch[1];
    assert.ok(!token.includes('_'),
      `trailer token "${token}" contains "_" -- git ignores such trailers entirely (#3962)`);

    const tmpDir = createTempGitProject('msd-3962-');
    t.after(() => cleanup(tmpDir));
    const msg = `test(2-01): probe\n\n${token}: skill\n`;
    const c = runGit(['commit', '--allow-empty', '-m', msg], { cwd: tmpDir });
    assert.equal(c.outcome, 'exited', `probe commit must exit cleanly: ${c.stderr}`);
    const r = runGit(
      ['log', '-1', `--format=%(trailers:key=${token},valueonly)`],
      { cwd: tmpDir },
    );
    assert.equal(r.stdout.trim(), 'skill',
      `a commit carrying "${token}: skill" must read back as "skill" via the shipped token`);
  });

  test('extracts gate-status via Git native trailer machinery, not a raw body grep', () => {
    assert.match(workflow, /trailers:key=gate-status/);
  });

  test('scopes the scan to the merge-base..HEAD range', () => {
    assert.match(workflow, /merge-base/);
    assert.match(workflow, /\.\.HEAD/);
    assert.match(workflow, /BASE_BRANCH/);
  });

  test('excludes merge commits from the audit', () => {
    assert.match(workflow, /--no-merges/);
  });

  test('renders a Test commit / Impl commit / gate-status table', () => {
    assert.match(workflow, /Test commit[\s\S]*Impl commit[\s\S]*gate-status/);
  });

  test('pairs conventional-commit test: rows with their impl commit', () => {
    assert.match(workflow, /test:/);
    assert.match(workflow, /pair/i);
  });

  test('escapes pipe characters in commit subjects so the table is not broken', () => {
    assert.match(workflow, /[Ee]scape[\s\S]{0,60}\|/);
  });

  test('counts commits lacking a recognized gate-status trailer as missing', () => {
    assert.match(workflow, /missing/);
  });

  test('is informational and never blocks the ship', () => {
    assert.match(workflow, /informational|never block|non-blocking/i);
  });

  test('emits the aggregate trailer in the exact, stable key order', () => {
    assert.match(
      workflow,
      /gate-status:\s*skill=[^,]*,\s*fallback=[^,]*,\s*exempt=[^,]*,\s*missing=/,
    );
  });

  test('places the aggregate trailer on the final line so squash-merge carries it', () => {
    assert.match(workflow, /squash/i);
    assert.match(workflow, /final line|last line/i);
  });

  // ─── #2431: TDD Audit section self-suppresses when all commits are missing ─
  //
  // The execute pipeline only writes `gate-status:` git trailers when TDD mode
  // is active. Without TDD mode, every commit is `missing` and the section is
  // pure noise. The fix adds a self-suppress instruction: skip the section
  // entirely when every commit normalizes to `missing`. This is data-driven
  // (no inline config-get of a capability-owned key — Phase 6 compliant).

  test('#2431: documents self-suppress when every commit is missing', () => {
    assert.match(workflow, /self-suppress/i,
      'ship.md must instruct the agent to self-suppress the TDD Audit when all commits are missing (#2431)');
    assert.match(workflow, /100%.?missing|every commit.*missing/i,
      'ship.md must explain that a 100%-missing table is noise and should be skipped (#2431)');
  });

  test('#2431: step 9 (aggregate trailer) is also gated on real values existing', () => {
    // The aggregate gate-status trailer is the companion to the TDD Audit
    // section; both must be skipped together when no real gate-status exists.
    // `\z` is a Perl/Ruby end-of-input anchor with NO meaning in JavaScript — it
    // matched a literal `z`, so the lazy span silently stopped at the first `z`
    // whenever `**10.` was absent, truncating the captured step. `$` (no /m flag)
    // is the JS end-of-input anchor.
    const step9 = workflow.match(/\*\*9\.\s*Aggregate gate-status trailer[\s\S]*?(?=\*\*10\.|$)/);
    assert.ok(step9, 'step 9 must exist in the workflow');
    assert.match(step9[0], /step 8|at least one|real/i,
      'step 9 must reference step 8 or require at least one real gate-status value (#2431)');
  });

  test('#2431: does NOT read workflow.tdd_mode inline (ADR-857 Phase 6 compliant)', () => {
    // ADR-857 Phase 6 forbids host loop workflows from reading capability-owned
    // config keys via inline config-get. workflow.tdd_mode is owned by the tdd
    // capability. The self-suppress approach avoids any config-get — it's
    // purely data-driven (check the actual trailer values).
    assert.doesNotMatch(workflow, /config-get\s+workflow\.tdd_mode/,
      'ship.md must NOT read workflow.tdd_mode via inline config-get (ADR-857 Phase 6 violation — use self-suppress instead, #2431)');
  });

  test('does not disturb the frozen #3167 core section order (Key Decisions precedes the new section)', () => {
    assert.match(workflow, /## Key Decisions[\s\S]*## TDD Audit/);
  });

  // Hardening assertions added after adversarial review.

  test('pairs test: rows only with feat:/fix: impl commits, skipping refactor/docs/chore', () => {
    assert.match(workflow, /feat:[\s\S]{0,20}fix:/);
    assert.match(workflow, /skipping[\s\S]{0,80}(refactor|docs|chore)/i);
  });

  test('normalizes the gate-status cell to a known token, never raw trailer text', () => {
    assert.match(workflow, /normaliz[a-z]*[\s\S]{0,120}missing/i);
    assert.match(workflow, /never the raw/i);
  });

  test('treats a commit with multiple gate-status trailers as missing', () => {
    assert.match(workflow, /more than one[\s\S]{0,40}gate-status/i);
  });

  test('hardens every table cell against pipe/newline injection', () => {
    assert.match(workflow, /strip[\s\S]{0,20}\\r/);
  });

  test('guards record/field delimiters against adversarial commit messages', () => {
    assert.match(workflow, /NUL|%x00|delimiter/i);
  });
});
  });
}