Files
msd-core/tests/ask-user-questions-fallback.test.cjs
Tom Boucher b8c33647d8 refactor(tests): retire output-grep & source-grep via typed surfaces (finish #2974) (#462)
* refactor(#455): implement typed surfaces to retire grep tests

Production surfaces added:
- hooks/managed-hooks-registry.cjs: new CJS module exporting MANAGED_HOOKS
  as a typed array; gsd-check-update-worker.js now requires it instead of
  declaring an inline array
- bin/install.js: elevate inline gsdHooks to module-level GSD_UNINSTALL_HOOKS,
  export it alongside runtimeMap/allRuntimes (already exported)
- scripts/build-hooks.js: export HOOKS_TO_COPY; guard build() behind
  require.main===module so tests can require the file without triggering a build
- get-shit-done/bin/lib/init.cjs: add --json mode to agent-skills command,
  emitting typed IR { agent_type, block, skills_count } for test assertions
- get-shit-done/bin/gsd-tools.cjs: wire --json flag for agent-skills dispatch

Category-B source-grep migrations:
- tests/managed-hooks.test.cjs: require MANAGED_HOOKS from registry, drop fs.readFileSync+regex
- tests/orphaned-hooks.test.cjs: require MANAGED_HOOKS+HOOKS_TO_COPY as typed exports
- tests/hooks-opt-in.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS import
- tests/install-minimal-hooks.test.cjs: replace gsdHooks regex-parse with GSD_UNINSTALL_HOOKS
- tests/copilot-install.test.cjs: replace src.includes() checks with typed
  assertions on runtimeMap, allRuntimes, parseRuntimeInput, buildRuntimePromptText
- tests/agent-skills.test.cjs: migrate to --json typed IR assertions

pending-migration-to-typed-ir token cleared (87 of 87 files):
- 78 files already had source-text-is-the-product; removed duplicate token
- 5 files already used typed assertions; reclassified or annotated
- 4 files required individual reclassification to source-text-is-the-product
  or architectural-invariant

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): update workflow-guard test to typed GSD_UNINSTALL_HOOKS import; isolate HOME in runtime-launcher (D) test

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): guard install.js main() behind require.main===module so the typed export is require-safe

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): document --json typed surfaces for agent-skills, progress, validate context

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(#455): add changeset fragment for new --json surfaces

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#455): complete grep migration for files flagged by lint-tests

The branch commit 4e630d99 stripped `allow-test-rule: pending-migration-to-typed-ir`
from ~80 test files without replacing their assertions or adding the correct
exemption annotation. The files were NOT source-grep tests — they read .md
workflow/agent/command/reference files (source-text-is-the-product) or hook
source files for structural invariants (structural-regression-guard). No
assertion logic was changed; only the correct allow-test-rule annotation was
added to each file per CONTRIBUTING.md exception matrix.

73 files: `source-text-is-the-product` — workflow/agent/command/reference .md
7 files:  `structural-regression-guard` — hook .js / bin/install.js structural checks

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 11:39:52 -04:00

89 lines
3.3 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Workflow .md / agent .md / command .md / reference .md files — their text
// IS what the runtime loads. Testing text content tests the deployed contract.
// Per CONTRIBUTING.md exception matrix.
/**
* Regression guard for #2012: AskUserQuestion is Claude Code-only — non-Claude
* runtimes (OpenAI Codex, Gemini, etc.) render it as a markdown code block
* instead of triggering the interactive TUI, so the session stalls.
*
* Every workflow that calls AskUserQuestion MUST include a TEXT_MODE fallback
* instruction so that, when `workflow.text_mode` is true (or `--text` is
* passed), all AskUserQuestion calls are replaced with plain-text numbered
* lists that any runtime can handle.
*
* The canonical fallback phrase is:
* "TEXT_MODE" (or "text_mode") paired with "plain-text" (or "plain text")
* near the first AskUserQuestion reference in the file.
*/
'use strict';
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const ROOT = path.join(__dirname, '..');
const WORKFLOWS_DIR = path.join(ROOT, 'get-shit-done', 'workflows');
/**
* Return true if the file content contains a TEXT_MODE / text_mode fallback
* instruction for AskUserQuestion calls.
*
* Acceptable forms (case-insensitive on key terms):
* - "TEXT_MODE" + "plain-text" or "plain text"
* - "text_mode" + "plain-text" or "plain text"
* - "text mode" + "plain-text" or "plain text"
*/
function hasTextModeFallback(content) {
const lower = content.toLowerCase();
const hasTextMode =
lower.includes('text_mode') ||
lower.includes('text mode');
const hasPlainText =
lower.includes('plain-text') ||
lower.includes('plain text') ||
lower.includes('numbered list');
return hasTextMode && hasPlainText;
}
describe('AskUserQuestion text-mode fallback (#2012)', () => {
test('every workflow that uses AskUserQuestion includes a TEXT_MODE plain-text fallback', () => {
const violations = [];
const files = fs.readdirSync(WORKFLOWS_DIR).filter(f => f.endsWith('.md'));
for (const fname of files) {
const fpath = path.join(WORKFLOWS_DIR, fname);
const content = fs.readFileSync(fpath, 'utf-8');
if (!content.includes('AskUserQuestion')) continue;
if (!hasTextModeFallback(content)) {
violations.push(fname);
}
}
assert.strictEqual(
violations.length,
0,
[
'AskUserQuestion is Claude Code-only (issue #2012).',
'Every workflow that uses AskUserQuestion must include a TEXT_MODE fallback',
'so non-Claude runtimes (OpenAI Codex, Gemini, etc.) can present questions',
'as plain-text numbered lists instead of stalling on an unexecuted tool call.',
'',
'Add this near the argument-parsing section of each workflow:',
' Set TEXT_MODE=true if --text is present in $ARGUMENTS OR text_mode from',
' init JSON is true. When TEXT_MODE is active, replace every AskUserQuestion',
' call with a plain-text numbered list and ask the user to type their choice',
' number.',
'',
'Workflows missing the fallback:',
...violations.map(v => ' get-shit-done/workflows/' + v),
].join('\n')
);
});
});