9faacc0c15
* test(#3148): bound the long tail and delete the allowlist Migrates the final 170 unbounded sync spawn sites across 49 files, then removes the allowlist entirely. local/no-unbounded-spawn now runs with no exemption surface across tests/**: there is no file to add a name to. drift-detection's throw-native git() helper routes to gitOrThrow -- bare runGit would have taken 16 call sites quiet on failure. commands.test.cjs has two independently-scoped runGsdTools/runCli helpers, one already bounded and one not; they are kept distinct rather than unified, the same trap as the two same-named git() helpers in Wave 1. runNpm's bound was erasable. Its options spread callerOptions after the defaults, so an explicit timeout:undefined silently dropped the 180000ms bound -- the rule flagged it and was right; it was not a false positive. Fixed by destructuring with a default, with a test that fails when the default is removed. Two sites stay on a raw spawn with an explicit timeout because the seam cannot express them: one needs shell:true for npm.cmd on Windows, one redirects stdout to a real fd. Both are the rule's own documented second option, not an escape from it. Closure verified rather than asserted: the derivation scan reports 0 unbounded spawn helpers and 0 unbounded direct git call sites, and a temporary file carrying an unbounded spawn still errors with the allowlist gone. Closes #3064. * test(#3148): close a hole in the guard's own eslint-disable ban The ban listed only the top level of tests/, so it was blind to 37 .cjs files under tests/helpers, qa, observability, fixtures and dispatch. With the allowlist deleted this test is the sole remaining way to detect someone silencing the rule inline, so the gap was load-bearing: a nested file could carry an unbounded spawn plus an eslint-disable and pass everything. Proven before and after. A probe planted under tests/helpers with both was invisible to the guard and clean under eslint; after making the listing recursive the guard fails on it. The scanned set goes from 771 files to 808. Pre-existing since the guard shipped, but this wave is what promoted it to sole defense, so it is fixed here rather than filed. Also converts the last hand-rolled throw check to throwIfFailed and the last re-derived legacy shape to compose toLegacyResult, which makes the epic's none-remain claim true rather than nearly true. toLegacyResult itself is not widened -- eight callers depend on its shape and one consumer does not justify changing a shared contract. * fix(#3148): correct seam incoherence at the bound and a slow review-lane error path Two real failures from the remote runner, both fixed at the cause. The seam could return outcome TIMED_OUT together with exitCode 0. At the exact bound spawnSync reports ETIMEDOUT while the child has already exited with a real status, and toSeamResult classified on the error code while passing status straight through -- an incoherent pair its own boundary test was written to catch, and did. A status that is not null is direct evidence the child exited on its own, so it now decides the outcome before the error-code branches run. process-seam.cjs was deliberately untouched by every earlier wave; this is a defect in the module itself, kept surgical, with a unit test that fails against the old logic. review-lane with an unknown subcommand fell through to its usage error only after loading the capability registry and building a per-lane plan, which spawns one child process per lane -- up to twelve. The error path took ~1288ms instead of ~119ms, and under bench load it outran a caller's spawn timeout and was killed before writing anything, which is the empty stdout and stderr CI saw. It now fails fast before any of that work begins. This is the epic's first production change. It is user-facing, so it carries a changeset rather than a no-changelog label. * test(#3148): replace a real-race timeout test with a deterministic one E9 raced git rev-parse against a 1ms bound and assumed git always lost. On a warm container git finishes first, spawnSync returns status 0 with no error at all, the seam correctly classifies EXITED, and gitOrThrow correctly does not throw -- so the test failed on both lanes. A probe confirms a genuine timeout always carries status null, so this was never the seam misbehaving. Raising the bound would only lengthen the odds, which is the same defect with better luck. The test now drives gitOrThrow against a stubbed runGit that returns a synthetic TIMED_OUT result, so it asserts exactly what it always meant to -- that a timeout propagates as a throw -- with no timing dependence. Five consecutive runs are identical where the old one varied. I wrote this test in Wave 0; it is a real-race test by construction and CLAUDE.md says to replace those rather than re-run them. * chore(#3148): backfill changeset PR number 3192 --------- Co-authored-by: sim <sim@local>
117 lines
4.2 KiB
JavaScript
117 lines
4.2 KiB
JavaScript
'use strict';
|
|
|
|
/**
|
|
* Bug #1529 parity / drift guard.
|
|
*
|
|
* The runtime → project-instruction-file mapping is shared between two
|
|
* parallel surfaces:
|
|
* (A) the Node surface — `getProjectInstructionFile` in runtime-name-policy.cjs,
|
|
* consumed by profile-output.cjs (the generate-claude-md handler).
|
|
* (B) the bash surface — `gsd-tools query project-instruction-file --runtime <r>`,
|
|
* consumed by gsd-core/workflows/new-project.md to set $INSTRUCTION_FILE.
|
|
*
|
|
* Per DEFECT.GENERATIVE-FIX, any shared mapping between two surfaces MUST
|
|
* carry a parity assertion that fails when they diverge. This test is that
|
|
* guard: it asserts (A) and (B) return the same filename for every runtime,
|
|
* AND that the new-project.md workflow derives $INSTRUCTION_FILE from the
|
|
* shared query rather than a hardcoded codex-only branch (the original bug).
|
|
*
|
|
* Boundary coverage (per RULESET.TESTS.boundary-coverage): claude (the
|
|
* kept-as-is case) and an unknown runtime (the AGENTS.md default) are both
|
|
* exercised alongside every runtime family in the mapping table.
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { runNode } = require('./helpers/process-seam.cjs');
|
|
const { throwIfFailed } = require('./helpers/git-fixture.cjs');
|
|
const { PROBE_TIMEOUT_MS } = require('./helpers/timeouts.cjs');
|
|
|
|
const ROOT = path.join(__dirname, '..');
|
|
const RUNTIME_NAME_POLICY_PATH = path.join(
|
|
ROOT,
|
|
'gsd-core',
|
|
'bin',
|
|
'lib',
|
|
'runtime-name-policy.cjs',
|
|
);
|
|
const GSD_TOOLS_PATH = path.join(ROOT, 'gsd-core', 'bin', 'gsd-tools.cjs');
|
|
const NEW_PROJECT_WORKFLOW_PATH = path.join(
|
|
ROOT,
|
|
'gsd-core',
|
|
'workflows',
|
|
'new-project.md',
|
|
);
|
|
|
|
const { getProjectInstructionFile } = require(RUNTIME_NAME_POLICY_PATH);
|
|
|
|
const RUNTIMES = [
|
|
'claude',
|
|
'codex',
|
|
'opencode',
|
|
'kilo',
|
|
'kimi',
|
|
'copilot',
|
|
'antigravity',
|
|
'gemini',
|
|
'future-runtime-xyz',
|
|
'',
|
|
];
|
|
|
|
function queryInstructionFile(runtime) {
|
|
const args = [
|
|
GSD_TOOLS_PATH,
|
|
'query',
|
|
'project-instruction-file',
|
|
'--runtime',
|
|
runtime,
|
|
];
|
|
const r = runNode(args, {
|
|
cwd: ROOT,
|
|
env: { ...process.env, GSD_RUNTIME: '' },
|
|
timeoutMs: PROBE_TIMEOUT_MS,
|
|
});
|
|
throwIfFailed(r, `node ${args.join(' ')}`);
|
|
return r.stdout.trim();
|
|
}
|
|
|
|
describe('bug #1529: getProjectInstructionFile ↔ gsd-tools query parity', () => {
|
|
for (const runtime of RUNTIMES) {
|
|
const label = runtime === '' ? '<empty>' : runtime;
|
|
test(`Node function and CLI query agree for runtime=${label}`, () => {
|
|
const fromFunction = getProjectInstructionFile(runtime);
|
|
const fromQuery = queryInstructionFile(runtime);
|
|
assert.strictEqual(
|
|
fromQuery,
|
|
fromFunction,
|
|
`gsd-tools query project-instruction-file --runtime ${label} returned "${fromQuery}" but getProjectInstructionFile() returned "${fromFunction}"; the two surfaces drifted.`,
|
|
);
|
|
});
|
|
}
|
|
});
|
|
|
|
describe('bug #1529: new-project.md workflow uses the shared policy query', () => {
|
|
// allow-test-rule: structural-regression-guard (#1529)
|
|
// the workflow's bash block MUST invoke the
|
|
// shared `gsd_run query project-instruction-file` query rather than a hardcoded
|
|
// codex-only `if/else` branch; there is no typed IR for "this bash block calls a
|
|
// specific gsd-tools query instead of a hardcoded mapping".
|
|
const workflow = fs.readFileSync(NEW_PROJECT_WORKFLOW_PATH, 'utf8');
|
|
|
|
test('workflow derives INSTRUCTION_FILE from the shared query', () => {
|
|
assert.ok(
|
|
/INSTRUCTION_FILE=\$\(gsd_run query project-instruction-file --runtime "\$RUNTIME"\)/.test(workflow),
|
|
'new-project.md must derive INSTRUCTION_FILE via `gsd_run query project-instruction-file --runtime "$RUNTIME"` (the shared policy adapter)',
|
|
);
|
|
});
|
|
|
|
test('workflow no longer hardcodes the codex-only branch', () => {
|
|
assert.ok(
|
|
!/if \[ "\$RUNTIME" = "codex" \]; then INSTRUCTION_FILE="AGENTS\.md"; else INSTRUCTION_FILE="\.claude\/CLAUDE\.md"; fi/.test(workflow),
|
|
'new-project.md must not contain the retired codex-only `if [ "$RUNTIME" = "codex" ]; then INSTRUCTION_FILE="AGENTS.md"; else INSTRUCTION_FILE=".claude/CLAUDE.md"; fi` branch (#1529 regression guard)',
|
|
);
|
|
});
|
|
});
|