* fix(#1521): resolve own runtime + worktrees-off for all non-Claude installs Generalizes the Codex-only #1515/#1519 fix to every non-Claude runtime, and wires it into the real install path (where it was previously dead-on-arrival). Root causes: 1. The runtime-default stamping lived only in `_applyRuntimeRewrites`, but the installer emits `gsd-core/workflows/*.md` via `copyWithPathReplacement`, which never calls it — so a real `--codex`/`--cursor`/etc. install emitted `--default claude` and worktrees-on. RUNTIME mis-resolved to claude and the workflow ran executors unisolated against the main checkout. (#1515/#1519 were also dead-on-arrival in real installs; this repairs them.) 2. Only `case 'codex'` was stamped; every other non-Claude runtime kept the Claude default. Fix: - New `_stampNonClaudeRuntimeDefaults(content, runtime)` (single shared helper) stamps `--default <runtime>` + `use_worktrees=false` for every `runtime != claude`; called from both `_applyRuntimeRewrites` and, crucially, `copyWithPathReplacement` in bin/install.js (the real workflow emit path). - Generalize the fail-closed worktree guard `= codex` -> `!= claude` in execute-phase/quick/diagnose-issues (worktree isolation is Claude-Code-only). - Flip manager/autonomous inline-vs-background gating to `codex -> background, everything-else -> inline` (research: only Codex can background-nest the pipeline's subagents; all others run inline, which they support). Worktree-capability determination is research-backed (official docs for all 14 non-Claude runtimes: none honor GSD's isolation="worktree" mechanism, only Codex background-nests). New end-to-end real-install test asserts the EMITTED workflow is stamped — the regression guard that would have caught the dead-on-arrival bug. Closes #1521 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vX5eUtWa2wsZEyeMf5i3r * chore(#1521): backfill changeset PR number (#1537) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vX5eUtWa2wsZEyeMf5i3r --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
72 lines
3.9 KiB
JavaScript
72 lines
3.9 KiB
JavaScript
'use strict';
|
|
/**
|
|
* Regression guard — bug(#853): /gsd-manager and /gsd-autonomous --interactive
|
|
* silently skipped worktree isolation + independent verification because they
|
|
* dispatched Plan/Execute via Agent(run_in_background=true). On Claude Code a
|
|
* backgrounded agent has no Agent/Task tool, so it cannot spawn the nested
|
|
* subagents (worktree executors, plan-checker, verifier). The workflows must
|
|
* now resolve the runtime and run inline everywhere except Codex, which is the
|
|
* only supported runtime where a backgrounded agent can still nest subagents.
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const WORKFLOWS_DIR = path.join(__dirname, '..', 'gsd-core', 'workflows');
|
|
const MANAGER = fs.readFileSync(path.join(WORKFLOWS_DIR, 'manager.md'), 'utf8');
|
|
const AUTONOMOUS = fs.readFileSync(path.join(WORKFLOWS_DIR, 'autonomous.md'), 'utf8');
|
|
|
|
describe('bug-853 — manager/autonomous gate background dispatch by runtime', () => {
|
|
test('manager.md resolves the runtime before dispatching plan/execute', () => {
|
|
// Two dispatch sites (plan + execute), each must resolve the runtime.
|
|
const matches = MANAGER.match(/config-get runtime/g) || [];
|
|
assert.ok(matches.length >= 2, 'manager.md must resolve runtime for both plan and execute dispatch');
|
|
});
|
|
|
|
test('manager.md documents why most runtimes cannot background-dispatch', () => {
|
|
// Accept both old singular form (backgrounded agent has no) and new plural form (backgrounded agents have no)
|
|
assert.match(MANAGER, /backgrounded agents? ha(?:s|ve) no `Agent`\/`Task` tool/);
|
|
});
|
|
|
|
test('manager.md gates background dispatch on codex and runs plan/execute inline otherwise', () => {
|
|
// Codex takes the background path
|
|
assert.match(MANAGER, /If `RUNTIME` is `codex`[\s\S]{0,400}?run_in_background=true/);
|
|
// Inline is the default/else branch for plan — anchored on the explicit non-Codex label
|
|
assert.match(
|
|
MANAGER,
|
|
/Otherwise \(Claude Code or any other non-Codex runtime\)[\s\S]{0,400}?Skill\(skill="gsd-plan-phase"/,
|
|
);
|
|
// Inline is the default/else branch for execute — anchored on the explicit non-Codex label
|
|
assert.match(
|
|
MANAGER,
|
|
/Otherwise \(Claude Code or any other non-Codex runtime\)[\s\S]{0,400}?Skill\(skill="gsd-execute-phase"/,
|
|
);
|
|
});
|
|
|
|
test('autonomous.md gates interactive background dispatch by runtime', () => {
|
|
const autoRuntimeMatches = AUTONOMOUS.match(/config-get runtime/g) || [];
|
|
assert.ok(autoRuntimeMatches.length >= 2, 'autonomous.md must resolve runtime in both 3b (plan) and 3c (execute) interactive branches');
|
|
// Accept both old singular form (backgrounded agent has no) and new plural form (backgrounded agents have no)
|
|
assert.match(AUTONOMOUS, /backgrounded agents? ha(?:s|ve) no `Agent`\/`Task` tool/);
|
|
});
|
|
|
|
test('autonomous.md gates interactive background dispatch on codex; runs plan/execute inline otherwise', () => {
|
|
// Codex block: run_in_background=true appears within the codex branch and gsd-plan-phase is nearby
|
|
assert.match(AUTONOMOUS, /If `RUNTIME` is `codex`[\s\S]{0,1200}?run_in_background=true[\s\S]{0,600}?gsd-plan-phase/);
|
|
// Codex block: run_in_background=true appears within the codex branch and gsd-execute-phase is nearby
|
|
assert.match(AUTONOMOUS, /If `RUNTIME` is `codex`[\s\S]{0,3000}?run_in_background=true[\s\S]{0,200}?gsd-execute-phase/);
|
|
// Inline is the otherwise/else branch for plan — anchored on the explicit non-Codex label
|
|
assert.match(
|
|
AUTONOMOUS,
|
|
/Otherwise \(Claude Code or any other non-Codex runtime\)[\s\S]{0,400}?Skill\(skill="gsd-plan-phase"/,
|
|
);
|
|
// Inline is the otherwise/else branch for execute — anchored on the explicit non-Codex label
|
|
assert.match(
|
|
AUTONOMOUS,
|
|
/Otherwise \(Claude Code or any other non-Codex runtime\)[\s\S]{0,400}?Skill\(skill="gsd-execute-phase"/,
|
|
);
|
|
});
|
|
});
|