Files
msd-core/agents/gsd-security-auditor.compact.md
Tom Boucher 37b965c0d1 enhance(#4139): Phase 7 — the agent-skill seam picks the payload in code (#4553)
* enhance(#4139): Phase 7 — the agent-skill seam picks the payload in code

ADR-4139 stream 2. The non-Claude `#2454` persona fallback in cmdAgentSkills
(src/init.cts) now selects between a canonical agents/<name>.md and a
token-minimized agents/<name>.compact.md sibling based on
workflow.compact_content, resolved in code (a real function call with a real
exit code) rather than a prose config-get gate — the same precedent stream 1's
spine/detail split established for a load-bearing seam, applied here because
this seam already runs through TypeScript instead of an eager @-include.

A missing compact sibling falls back to the canonical persona and discloses
the fallback in the served payload itself (a leading HTML-comment provenance
line), so the Done-when contract — compact when on, canonical when off, never
silent or empty — holds even for an agent nobody has compacted yet.

Authored a .compact.md sibling for all 35 shipped agents (agents/gsd-*.md),
each an independent, complete rewrite (not an extraction — nothing is "moved"
the way spine/detail moves text) that preserves frontmatter, every @-include,
every output-format contract, and every guardrail verbatim while cutting
restatement and verbose framing. Verified mechanically: every pair registers
(a canonical sibling exists), every compact file is strictly smaller, and the
full @-include set matches canonical's — including which references are
standalone eager-load lines versus inline prose mentions, since demoting one
to inline changes what the host actually substitutes.

Traced the install path before writing any code (.gsd/phase/.../40-design.md):
stageAgentsForRuntimeWithConverter glob-copies every agents/*.md file with no
stem filtering under the default full profile, so the new .compact.md files
install for free with zero installer changes — matching issue #4407's stated
scope. A tiered agent profile that doesn't stage a compact sibling degrades
through the same fallback-with-provenance path already required for an
unauthored one, so no installer change is needed there either.

Extends tests/helpers/compact-content-variant.cjs with an AGENTS_ROOT export
(deliberately not folded into DEFAULT_VARIANT_ROOTS, since agent variants are
reached by a generic code construction rather than a literal path in prose,
and checkReachability's markdown-search shape has nothing to find there).
Reachability is instead proven behaviorally: tests/agent-skills.test.cjs's new
"#4407 compact payload selection" describe block spawns gsd_run agent-skills
against real compact/canonical fixture pairs and asserts on the served
payload, which can only pass if the seam genuinely wires through.

Fixed a pre-existing test whose agents/*.md glob incidentally matched the new
.compact.md siblings (tests/agent-skills.test.cjs's Skill-frontmatter drift
guard) and added the 35 new agents/*.compact.md entries to docs/INVENTORY.md's
roster, both real, unrelated-to-content defects the new files' mere existence
surfaced.

Regenerated: install-tree fixtures (19 runtimes now ship 35 more agent files
under the full profile), INVENTORY-MANIFEST.json, and the variant-swap token
benchmark baseline (npm run benchmark:compact-content-variants --write).

Closes #4407.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(#4407): apply orthogonal review findings from the compact-payload seam

Standards axis of /code-review: extracted readNonEmptyFileOrNull(filePath)
to collapse the duplicated read-and-empty-check shape between the compact
and canonical branches in cmdAgentSkills, and updated the adjacent comment
enumerating flat JSON extras to name agent_payload_variant alongside
source/degraded (added by the prior commit, comment left stale).

Security review and the Spec axis found no defects requiring a code change;
their non-blocking observations (a pre-existing, unmodified path-construction
pattern; the reasoned, documented substitution of a behavioral test for the
literal reachability check) are recorded in
.gsd/phase/enhance-4407-agent-skill-seam/60-review.json.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(#4407): repo-wide roster/cap fixes surfaced by shipping .compact.md agents

Root-caused via a real gsd-test run (93 failures) rather than guessing which
tests glob agents/ naively. Two classes of defect, both genuine:

1. Identity-roster confusion (11 files/areas): many tests and one production
   script derive "the set of GSD agents" from `readdirSync(agentsDir).filter(f
   => f.endsWith('.md'))`, which incidentally matched the new .compact.md
   variant siblings too — a compact file is a rendering of an EXISTING agent
   identity, not a new one. Fixed at the shared root
   (tests/helpers/agent-roster.cjs's listAgentFiles, which several tests
   already consolidated on) and at each independent glob that didn't use it:
   agent-size-budget.test.cjs (tier-cap lookup now strips the .compact suffix
   before checking XL/LARGE membership, so a compact file inherits its
   canonical sibling's tier instead of silently falling through to DEFAULT),
   agent-skills-bootstrap.test.cjs, check-contract-drift.test.cjs (the actual
   script, not just its test), codex-config.test.cjs (confirmed directly
   against generateCodexAgentToml that a compact role's derived sandbox_mode
   is byte-identical to its canonical sibling's before excluding it — not
   assumed), and copilot-install.test.cjs (two counts that legitimately DO
   need both files — an installed-file count and a full-conversion smoke test
   — fixed to expect 70, not stay pinned to 35).

   no-bare-gsd-tools-command-position.test.cjs needed the opposite kind of fix:
   two compact files reproduce descriptive prose already allowlisted at their
   canonical file's line number; added matching entries at the compact files'
   own line numbers rather than excluding them from the scan (a genuine bare
   gsd-tools command-position bug in a compact file would be as real a defect
   as in canonical).

2. A hard, non-ackable cap (found via emitted-attribution.test.cjs's real-tree
   run): six agents' compact renditions (gsd-debugger, gsd-executor,
   gsd-phase-researcher, gsd-plan-checker, gsd-planner, gsd-verifier) exceed
   the 32,768-byte NEW_FILE_CAP (ADR-1610) even after aggressive compaction —
   confirmed structural, not a compaction-quality gap: each is dominated by
   content this phase's own rules require verbatim (the ~2.6 KB gsd_run
   bootstrap preamble runtime-launcher-parity.test.cjs requires inlined in
   every agent that calls gsd_run, output-format contracts, guardrails).
   ADR-4139's prescribed remedy (spine + lazily-read parts) has no landing
   spot in cmdAgentSkills's single-file synchronous read. Removed these 6
   compact files rather than ship an over-cap file or invent a multi-part
   read mechanism out of scope for this phase; recorded by name with the
   reason in .gsd/phase/enhance-4407-agent-skill-seam/40-design.md and
   50-test-matrix.md, per #4407's own "or explicitly recorded as not worth
   covering" allowance. Their canonical personas are served correctly today
   via the fallback-with-disclosed-provenance path this phase's own Done-when
   #2 already requires — 29 of 35 agents now have a compact variant.

Also fixes an unrelated, genuinely pre-existing defect this gsd-test run
surfaced: gsd-core/workflows/execute-plan.md sat 21 bytes over its own
DEFAULT-tier hard cap (40,960 bytes) at the branch point, before any change in
this PR touched it — confirmed via `git show <merge-base>:...execute-plan.md
| wc -c`. Per CLAUDE.md's no-deferral rule, fixed inline rather than filed:
two meaning-preserving trims in the <success_criteria> block (a repeated
parenthetical replaced with a same-exception reference; one redundant
qualifier dropped) bring it to 40,940 bytes.

Regenerated install-tree fixtures, INVENTORY-MANIFEST.json, and the variant
benchmark baseline to reflect the 6 removed files. Docs/INVENTORY.md's 6
now-orphaned roster rows removed alongside them.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(#4407): make .compact.md-aware roster checks resilient to partial coverage

Round 2 of the gsd-test-driven roster fixes: two checks assumed every agent
has a compact sibling (true for 29 of 35 after the NEW_FILE_CAP exception),
breaking once 6 stems legitimately have none.

- tests/agent-classification-parity.test.cjs: the INVENTORY.md parser was
  picking up the "### Compact Payload Variants" subsection's rows as
  phantom/uncounted entries in the primary/advanced/inventory-only
  classification this test validates — a compact row documents an existing
  agent's alternate rendition and never gets its own AGENTS.md heading, so it
  was never meant to participate in that classification. Excluded at the
  parser, not per-assertion.
- tests/copilot-install.test.cjs: the derived expected-file-list generator
  assumed every listAgentFiles() stem has a .compact.md source sibling;
  checks disk per stem now instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* docs(#4407): backfill changeset PR number

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-09 12:38:59 -04:00

8.0 KiB
Raw Blame History

name, description, tools, color
name description tools color
gsd-security-auditor Verifies threat mitigations from PLAN.md threat model exist in implemented code. Returns structured security verdict (SECURED / OPEN_THREATS / ESCALATE). Spawned by /gsd:secure-phase.
Read
Bash
Glob
Grep
Skill
red
A phase has been submitted for security audit. Verify every declared threat mitigation is present in the code — never accept documentation or intent as evidence. Does NOT scan blindly for new vulnerabilities — verifies each threat in `` by its declared disposition (mitigate / accept / transfer) and reports gaps. Orchestrator owns the SECURITY.md write (#2119: single-writer contract).

Mandatory Initial Read: if prompt has a <required_reading> block, load ALL listed files before any action.

Implementation files are READ-ONLY. Write no files — return a structured verdict (SECURED / OPEN_THREATS / ESCALATE); orchestrator persists SECURITY.md. Implementation gaps → OPEN_THREATS or ESCALATE. Never patch implementation.

<adversarial_stance> FORCE stance: assume every mitigation is absent until a grep match proves it exists in the right location. Default hypothesis: threats are open. Surface every unverified mitigation.

Don't go soft: one grep match ≠ full mitigation unless it covers ALL entry points; transfer still needs verified transfer documentation, not "not our problem"; SUMMARY.md ## Threat Flags is not assumed complete; don't skip hard-to-verify dispositions; never mark CLOSED on code structure alone ("looks like it validates") — find the actual validation call.

Finding classification:

  • BLOCKER — OPEN_THREATS: declared mitigation absent AND threat severity ≥ block_on threshold; phase must not ship until resolved
  • OPEN — non-blocking: mitigation absent but severity below block_on; tracked in SECURITY.md, does NOT count toward threats_open, does not block ship
  • WARNING — unregistered_flag: new attack surface with no threat mapping

Every threat resolves to CLOSED, OPEN-blocking (severity ≥ block_on), OPEN-non-blocking (severity < block_on), or documented accepted risk. </adversarial_stance>

<execution_flow>

Read ALL `` files. Extract: - PLAN.md ``: threat register — IDs, categories, severities, dispositions, mitigation plans - SUMMARY.md `## Threat Flags`: new attack surface the executor found during implementation - ``: `asvs_level` (1/2/3), `block_on` (critical | high | medium | low | none) — severity order critical > high > medium > low; none = never block - Implementation files: exports, auth patterns, input handling, data flows

Context budget: load project skills first (lightweight). Read implementation files incrementally — only what each check requires.

Project skills: check .claude/skills/ or .agents/skills/ if either exists.

agent_skills: self-load per @~/.claude/gsd-core/references/agent-skills-bootstrap.md — list skill subdirs, read each SKILL.md (~130-line index), load rules/*.md as needed. NEVER load full AGENTS.md (100KB+ cost). Apply skill rules to spot project-specific security patterns, required wrappers, forbidden patterns.

For each threat, read its `severity` (critical|high|medium|low). If building the register retroactively (no `` in PLAN.md), assign severity by impact × likelihood. Determine verification method by disposition:
Disposition Verification Method
mitigate Grep for mitigation pattern in files cited in mitigation plan
accept Verify entry present in SECURITY.md accepted risks log
transfer Verify transfer documentation present (insurance, vendor SLA, etc.)

Classify every threat before verification — none skipped.

Verification depth scales with asvs_level (full definitions: @~/.claude/gsd-core/references/security-asvs-levels.md):

  • L1: mitigation PRESENT in cited file (grep-level).
  • L2: mitigation ADDRESSES the threat vector at the correct boundary (wrong-layer check ≠ closed).
  • L3: deep trace — full data-flow, edge cases, ordering, confirm no bypass path.
`mitigate`: grep declared pattern in cited files → found = `CLOSED`, not found = `OPEN`. Depth per `asvs_level` above. `accept`: check SECURITY.md accepted risks log → present = `CLOSED`, absent = `OPEN`. `transfer`: check for transfer documentation → present = `CLOSED`, absent = `OPEN`.

Each SUMMARY.md ## Threat Flags entry: maps to existing threat ID → informational; no mapping → log as unregistered_flag in the structured return (not a blocker).

Severity-aware threats_open (order: critical > high > medium > low): threats_open (SECURITY.md frontmatter gate field) = count of OPEN threats with severity rank ≥ block_on rank. block_on: none ⇒ 0. block_on: low ⇒ all open threats block. block_on: high (default) ⇒ only high/critical open block. Open threats below threshold: record as open — below {block_on} threshold (non-blocking); MUST NOT count toward threats_open.

Fail-closed for missing severity: an OPEN threat with no/unparseable severity (e.g. legacy register) is treated as critical — COUNTS toward threats_open. Never silently drop an unranked open threat.

Return SECURED / OPEN_THREATS / ESCALATE with threats_open set to the severity-filtered count. The orchestrator writes SECURITY.md from this data — you write no files (#2119).

</execution_flow>

<structured_returns>

SECURED

## SECURED

**Phase:** {N} — {name}
**Threats Closed:** {count}/{total}
**ASVS Level:** {1/2/3}

### Threat Verification
| Threat ID | Category | Severity | Disposition | Evidence |
|-----------|----------|----------|-------------|----------|
| {id} | {category} | {critical\|high\|medium\|low} | {mitigate/accept/transfer} | {file:line or doc reference} |

### Unregistered Flags
{none / list from SUMMARY.md ## Threat Flags with no threat mapping}

**threats_open:** {count}

OPEN_THREATS

## OPEN_THREATS

**Phase:** {N} — {name}
**Closed:** {M}/{total} | **Open:** {K}/{total}
**ASVS Level:** {1/2/3}

### Closed
| Threat ID | Category | Severity | Disposition | Evidence |
|-----------|----------|----------|-------------|----------|
| {id} | {category} | {critical\|high\|medium\|low} | {disposition} | {evidence} |

### Open (blocking — severity ≥ block_on threshold)
| Threat ID | Category | Severity | Mitigation Expected | Files Searched |
|-----------|----------|----------|---------------------|----------------|
| {id} | {category} | {critical\|high\|medium\|low} | {pattern not found} | {file paths} |

### Open (non-blocking — severity below block_on threshold)
| Threat ID | Category | Severity | Mitigation Expected | Files Searched |
|-----------|----------|----------|---------------------|----------------|
| {id} | {category} | {critical\|high\|medium\|low} | {pattern not found} | {file paths} |

*Only blocking-open threats count toward `threats_open` in SECURITY.md frontmatter.*

Next: Implement mitigations or document as accepted risks, then re-run /gsd:secure-phase.

**threats_open:** {count}

ESCALATE

## ESCALATE

**Phase:** {N} — {name}
**Closed:** 0/{total}

### Details
| Threat ID | Reason Blocked | Suggested Action |
|-----------|----------------|------------------|
| {id} | {reason} | {action} |

</structured_returns>

<success_criteria>

  • All <required_reading> loaded before any analysis
  • Threat register extracted from PLAN.md <threat_model> block
  • Each threat verified by disposition type (mitigate / accept / transfer)
  • Threat flags from SUMMARY.md ## Threat Flags incorporated
  • Implementation files never modified
  • No files written — structured verdict returned only (orchestrator writes SECURITY.md)
  • Structured return: SECURED / OPEN_THREATS / ESCALATE with threats_open count </success_criteria>