Files
msd-core/tests/workflow-size-baseline.json
0xdhx bd18a593a9 fix(#2494): capture stderr and guard empty output on the claude and gemini reviewer legs (#2592)
* fix(#2494): capture stderr and guard empty output on the claude and gemini reviewer legs

The gemini and claude blocks in gsd-core/workflows/review.md were the only
two of the ten prompt-fed reviewer legs with both `2>/dev/null` and no
empty-output guard. Any failure that wrote no stdout — CLI missing,
unauthenticated, rate-limited, crashed — left a zero-byte review file with
the only diagnostic evidence already discarded.

write_reviews substitutes each file's raw content into a `## <Reviewer>
Review` section with no marker separating "empty/failed" from "ran cleanly,
nothing to report", so a failed lane silently degraded the advertised
N-reviewer consensus to N-1 while present_results reported success. Both
/gsd:review and /gsd:plan-review-convergence share the invoke_reviewers
step, so both were affected.

Both legs now redirect stderr to a `.err` sidecar and write a diagnostic
stub with the captured stderr appended when the review file comes back
empty — the same shape the codex and cursor legs already use.

Scope limit, noted in the block comment: the guard only runs if the block
itself completes. A host Bash-tool timeout that kills the whole block skips
it, the same hard bound the OpenCode block already documents. The existing
timeout guidance (#2194) covers that case and is unchanged.

Regression test extracts the two dispatch blocks verbatim from the workflow
and runs them under bash against a failing CLI stub, asserting the review
file is non-empty and carries a diagnosable message plus the captured
stderr. It fails against pre-fix review.md (4 of 5 cases).

Golden install-parity fixtures and the workflow size baseline are
regenerated: one review.md hash per fixture, one size entry.

Fixes #2494

* fix(#2494): stamp the changeset fragment with the filed PR number

The fragment was authored with the documented `pr: 0` placeholder because
the PR number does not exist until `gh pr create` returns. Now that this
PR is #2592, stamp it — scripts/changeset/parse.cjs requires pr > 0, so
the placeholder would fail the Changeset Required check.
2026-07-24 12:50:34 -04:00

94 lines
2.4 KiB
JSON

{
"add-backlog.md": 7176,
"add-phase.md": 7578,
"add-tests.md": 17247,
"add-todo.md": 11020,
"ai-integration-phase.md": 15420,
"analyze-dependencies.md": 3887,
"audit-fix.md": 12329,
"audit-milestone.md": 19034,
"audit-uat.md": 7469,
"autonomous.md": 42474,
"check-todos.md": 9761,
"cleanup.md": 10319,
"code-review-fix.md": 24906,
"code-review.md": 33110,
"complete-milestone.md": 31436,
"debug.md": 20253,
"diagnose-issues.md": 13444,
"discovery-phase.md": 13543,
"discuss-phase-assumptions.md": 28253,
"discuss-phase-power.md": 11273,
"discuss-phase.md": 31986,
"do.md": 10731,
"docs-update.md": 56494,
"edit-phase.md": 12927,
"eval-review.md": 10332,
"execute-phase.md": 93389,
"execute-plan.md": 35143,
"explore.md": 11127,
"extract-learnings.md": 12893,
"fast.md": 7613,
"forensics.md": 12531,
"graduation.md": 11987,
"health.md": 12246,
"help.md": 1722,
"import.md": 15599,
"inbox.md": 19299,
"ingest-docs.md": 19821,
"insert-phase.md": 8987,
"list-phase-assumptions.md": 4305,
"list-seeds.md": 6987,
"list-workspaces.md": 5699,
"manager.md": 27751,
"map-codebase.md": 21888,
"milestone-summary.md": 11842,
"mvp-phase.md": 13991,
"new-milestone.md": 38667,
"new-project.md": 67055,
"new-workspace.md": 11584,
"next.md": 20171,
"node-repair.md": 4173,
"note.md": 6563,
"onboard.md": 8877,
"pause-work.md": 14441,
"plan-milestone-gaps.md": 11809,
"plan-phase.md": 94399,
"plan-review-convergence.md": 26285,
"plant-seed.md": 12150,
"pr-branch.md": 15963,
"profile-user.md": 21624,
"progress.md": 32632,
"quick.md": 51977,
"reapply-patches.md": 20312,
"remove-phase.md": 8513,
"remove-workspace.md": 7916,
"resume-project.md": 17270,
"review.md": 52646,
"scan.md": 8314,
"secure-phase.md": 14627,
"session-report.md": 4044,
"settings-advanced.md": 40019,
"settings-integrations.md": 16257,
"settings.md": 33832,
"ship.md": 29367,
"sketch-wrap-up.md": 14267,
"sketch.md": 20369,
"smart-entry.md": 11489,
"spec-phase.md": 31987,
"spike-wrap-up.md": 15136,
"spike.md": 24939,
"stats.md": 6762,
"sync-skills.md": 6125,
"thread.md": 12508,
"transition.md": 22070,
"ui-phase.md": 26925,
"ui-review.md": 12166,
"ultraplan-phase.md": 10512,
"undo.md": 15323,
"update.md": 21178,
"validate-phase.md": 11856,
"verify-phase.md": 40949,
"verify-work.md": 41318
}