* feat(#4401): register workflow.compact_content as a validated config key - Add compact_content: false to the nested workflow object in gsd-core/bin/shared/config-defaults.manifest.json - Add 'workflow.compact_content': false to SCHEMA_DEFAULTS in src/config.cts so an absent key resolves to false via config-get --raw - validKeys entry in config-schema.manifest.json already present Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(#4401): behavioral and boundary tests for workflow.compact_content - 19 behavioral tests covering config-set/config-get round trip, invalid-shape rejection (banana, 42, empty string), the corrected null-unset semantics (#2046), absent-key resolution against config-defaults.manifest.json, config-new-project wiring, and doc-row shape assertions - Drops the install-tree fixture-parity block (and its docstring item) that asserted gsd-core/references/compact-content-gate.md and gsd-core/workflows/compact/map-codebase.md fixture entries — those paths belong to #4402 and do not exist on this filtered branch Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(#4401): document workflow.compact_content in both config references - One 4-cell row in docs/CONFIGURATION.md (workflow.* run) - One 5-cell row under Workflow Fields in gsd-core/references/planning-config.md - Both cross-reference ADR-4139 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(#4401): add changeset - Added-type fragment, pr: 4401 (issue number; backfill to the real PR number is a required follow-up once the PR is opened, per D-08 and CHANGESET-PR- FIELD-DRIFT) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(#4401): backfill changeset pr field to #4441 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(#4401): derive workflow.compact_content default from CONFIG_DEFAULTS SCHEMA_DEFAULTS['workflow.compact_content'] hardcoded the literal false instead of deriving it from CONFIG_DEFAULTS the way 3 of its 8 sibling entries do (smart_zone_tokens, pr_strict, inline_plan_threshold), leaving a single-source-of-truth drift risk: a future manifest-only edit to the default could silently diverge from this literal, only caught later by the D-03 test if it ever happened to manifest. Adds compact_content to CONFIG_DEFAULTS in src/config-loader.cts and derives SCHEMA_DEFAULTS from it in src/config.cts, matching the majority sibling pattern. Found during maintainer review (review-open-prs) of this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#4401): map compact_content in config-field-docs NAMESPACE_MAP The previous commit added compact_content to CONFIG_DEFAULTS in src/config-loader.cts but missed the matching entry in tests/config-field-docs.test.cjs's NAMESPACE_MAP, which maps flat CONFIG_DEFAULTS keys to their namespaced doc form before checking gsd-core/references/planning-config.md for a match. Without it, the test looked for a bare `compact_content` doc reference instead of the actual `workflow.compact_content` row, and failed: "CONFIG_DEFAULTS keys missing from planning-config.md: compact_content". Found by actually running gsd-test against the branch rather than trusting the plausible-looking fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * test(#4401): register compact-content-4139 test in the docs-guard lane tests/compact-content-4139.test.cjs's D-06 tests read docs/CONFIGURATION.md directly (fs.readFileSync) to assert the workflow.compact_content doc row's shape, which makes it a doc-reading test file under the #3753 docs-guard lane. It was never added to scripts/docs-guard-registry.cjs's DOCS_GUARD_TESTS map and carries no docs-guard-exempt marker, so tests/ci-docs-guard-registry.test.cjs's registration lint correctly failed: "compact-content-4139.test.cjs reads a docs/ path but is not registered in the docs-guard lane and carries no docs-guard-exempt marker". Registers it with ['docs/CONFIGURATION.md'] (the only real docs/-prefixed path it reads; gsd-core/references/planning-config.md is outside this registry's docs/ scope, matching the sibling config-field-docs.test.cjs entry's existing convention). Found by actually running gsd-test against the branch — this gap predates the maintainer's config-loader.cts fix and was already present in the original PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Tom Boucher <trekkie@nomorestars.com> Co-authored-by: sim <sim@local>
115 lines
3.5 KiB
JSON
115 lines
3.5 KiB
JSON
{
|
|
"_comment": "Canonical CONFIG_DEFAULTS for the Configuration Module. Nested shape is canonical. CJS flat projection (branching_strategy, sub_repos, etc.) is handled by consumers at the boundary. Security keys (security_enforcement, security_asvs_level, security_block_on) and post_planning_gaps live in workflow.* as their canonical location. resolve_model_ids, context_window, phase_naming are CJS-originated top-level keys included here. brave_search, firecrawl, exa_search default to false in the manifest; at runtime buildNewProjectConfig detects API keys. The plan_checker (CJS flat) \u2192 workflow.plan_check (canonical nested) divergence is resolved: canonical name is workflow.plan_check. _auto_chain_active is a runtime-state field included for completeness.",
|
|
"model_profile": "balanced",
|
|
"commit_docs": true,
|
|
"parallelization": true,
|
|
"search_gitignored": false,
|
|
"brave_search": false,
|
|
"firecrawl": false,
|
|
"exa_search": false,
|
|
"resolve_model_ids": false,
|
|
"context_window": 200000,
|
|
"phase_naming": "sequential",
|
|
"project_code": null,
|
|
"phase_id_convention": null,
|
|
"mode": "interactive",
|
|
"claude_md_path": "./.claude/CLAUDE.md",
|
|
"git": {
|
|
"branching_strategy": "none",
|
|
"create_tag": true,
|
|
"base_branch": null,
|
|
"phase_branch_template": "gsd/phase-{phase}-{slug}",
|
|
"milestone_branch_template": "gsd/{milestone}-{slug}",
|
|
"quick_branch_template": null
|
|
},
|
|
"workflow": {
|
|
"research": true,
|
|
"plan_check": true,
|
|
"verifier": true,
|
|
"nyquist_validation": true,
|
|
"ai_integration_phase": true,
|
|
"agent_hint_routing": true,
|
|
"human_verify_mode": "end-of-phase",
|
|
"auto_advance": false,
|
|
"_auto_chain_active": false,
|
|
"node_repair": true,
|
|
"node_repair_budget": 2,
|
|
"smart_zone_tokens": 100000,
|
|
"ui_phase": true,
|
|
"ui_safety_gate": true,
|
|
"text_mode": false,
|
|
"compact_content": false,
|
|
"research_before_questions": false,
|
|
"discuss_mode": "discuss",
|
|
"skip_discuss": false,
|
|
"max_discuss_passes": 3,
|
|
"subagent_timeout": 300000,
|
|
"context_coverage_gate": true,
|
|
"code_review": true,
|
|
"code_review_depth": "standard",
|
|
"code_review_depth_overrides": [],
|
|
"code_review_command": null,
|
|
"pattern_mapper": true,
|
|
"plan_bounce": false,
|
|
"plan_bounce_script": null,
|
|
"plan_bounce_passes": 2,
|
|
"inline_plan_threshold": 2,
|
|
"auto_prune_state": false,
|
|
"post_planning_gaps": true,
|
|
"security_enforcement": true,
|
|
"security_asvs_level": 1,
|
|
"security_block_on": "high",
|
|
"context_guard_mode": "warn"
|
|
},
|
|
"planning": {
|
|
"commit_docs": true,
|
|
"pr_strict": false,
|
|
"search_gitignored": false,
|
|
"sub_repos": [],
|
|
"granularity": "standard"
|
|
},
|
|
"hooks": {
|
|
"context_warnings": true,
|
|
"workflow_guard": false
|
|
},
|
|
"ship": {
|
|
"pr_body_sections": []
|
|
},
|
|
"graphify": {
|
|
"auto_update": false
|
|
},
|
|
"agent_skills": {},
|
|
"effort": {
|
|
"default": "high",
|
|
"routing_tier_defaults": {
|
|
"light": "low",
|
|
"standard": "high",
|
|
"heavy": "xhigh"
|
|
},
|
|
"agent_overrides": {}
|
|
},
|
|
"fast_mode": {
|
|
"enabled": false,
|
|
"routing_tier_defaults": {
|
|
"light": true,
|
|
"standard": false,
|
|
"heavy": false
|
|
},
|
|
"agent_overrides": {}
|
|
},
|
|
"plan_review": {
|
|
"source_grounding": true,
|
|
"source_grounding_authority": "grep"
|
|
},
|
|
"review": {
|
|
"max_prompt_tokens": null
|
|
},
|
|
"capabilities": {
|
|
"strict_known_registries": null,
|
|
"auto_update": false
|
|
},
|
|
"security": {
|
|
"injection_blocking": false
|
|
}
|
|
}
|