3078279a9a
* feat(planner): add reachability_check step to prevent unreachable code Closes #1495 * fix: trim gsd-planner.md below 50000-char limit after rebase The reachability_check addition pushed the file to 50,275 chars when merged with the assign_waves additions from #1600. Condense both sections while preserving all logic; file is now 49,859 chars. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(security): normalize CRLF before prompt-stuffing length check On Windows, git checks out files with CRLF line endings. JavaScript's String.length counts \r characters, so a 49,859-byte file measures as 51,126 chars on Windows — falsely tripping the 50,000-char security scanner. Normalize CRLF → LF before measuring in security.cjs and in the reachability-check test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: trim gsd-planner.md to stay under 50000-char limit after merge with main After rebasing onto main (which added mcp_tool_usage block), combined content reached 50031 chars. Remove suggested log format from assign_waves rule to bring file to 49972 chars, well under the 50000-char security scanner limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
54 lines
2.4 KiB
JavaScript
54 lines
2.4 KiB
JavaScript
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('gsd-planner reachability_check step', () => {
|
|
const plannerPath = path.join(__dirname, '..', 'agents', 'gsd-planner.md');
|
|
let content;
|
|
|
|
test('planner file exists', () => {
|
|
assert.ok(fs.existsSync(plannerPath));
|
|
content = fs.readFileSync(plannerPath, 'utf-8');
|
|
});
|
|
|
|
test('contains reachability_check step', () => {
|
|
content = content || fs.readFileSync(plannerPath, 'utf-8');
|
|
assert.ok(content.includes('<step name="reachability_check">'), 'Missing reachability_check step');
|
|
});
|
|
|
|
test('reachability_check appears after derive_must_haves', () => {
|
|
content = content || fs.readFileSync(plannerPath, 'utf-8');
|
|
const mustHavesIdx = content.indexOf('derive_must_haves');
|
|
const reachabilityIdx = content.indexOf('reachability_check');
|
|
assert.ok(mustHavesIdx > -1, 'derive_must_haves step not found');
|
|
assert.ok(reachabilityIdx > -1, 'reachability_check step not found');
|
|
assert.ok(reachabilityIdx > mustHavesIdx, 'reachability_check must come after derive_must_haves');
|
|
});
|
|
|
|
test('reachability_check appears before estimate_scope', () => {
|
|
content = content || fs.readFileSync(plannerPath, 'utf-8');
|
|
const reachabilityIdx = content.indexOf('reachability_check');
|
|
const estimateIdx = content.indexOf('estimate_scope');
|
|
assert.ok(estimateIdx > -1, 'estimate_scope step not found');
|
|
assert.ok(reachabilityIdx < estimateIdx, 'reachability_check must come before estimate_scope');
|
|
});
|
|
|
|
test('reachability_check includes creation path check', () => {
|
|
content = content || fs.readFileSync(plannerPath, 'utf-8');
|
|
assert.ok(content.includes('creation path') || content.includes('creation_path') || content.includes('reachable'),
|
|
'Missing creation path verification logic');
|
|
});
|
|
|
|
test('reachability_check includes UNREACHABLE marker', () => {
|
|
content = content || fs.readFileSync(plannerPath, 'utf-8');
|
|
assert.ok(content.includes('UNREACHABLE'), 'Missing UNREACHABLE marker for failed checks');
|
|
});
|
|
|
|
test('file stays under 50000 char limit (CRLF-normalized)', () => {
|
|
content = content || fs.readFileSync(plannerPath, 'utf-8');
|
|
const normalized = content.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
|
|
assert.ok(normalized.length < 50000, `File is ${normalized.length} chars, over the 50000 limit`);
|
|
});
|
|
});
|