Files
msd-core/sdk/src/query/check-gates.ts
Rezolv c5b1445529 feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) (#2341)
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A)

Golden/read-only parity tests and registry alignment, query handler fixes
(check-completion, state-mutation, commit, validate, summary, etc.), and
WAITING.json dual-write for .gsd/.planning readers.

Refs gsd-build/get-shit-done#2341

* fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback)

- Recognize in-flight 🟡 milestone bullets like 🚧.
- Derive from last **vX.Y Title** before ## Phases when emoji absent.
- Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y
  in cleaned text instead of first (avoids v1.0 from shipped list).
- Fixes init.execute-phase milestone_version and buildStateFrontmatter after
  state.begin-phase (syncStateFrontmatter).

* feat(sdk): phase list, plan task structure, requirements extract handlers

- Register phase.list-plans, phase.list-artifacts, plan.task-structure,
  requirements.extract-from-plans (SDK-only; golden-policy exceptions).
- Add unit tests; document in QUERY-HANDLERS.md.
- writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored.

* feat(sdk): centralize getGsdAgentsDir in query helpers

Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary
~/.claude/agents, legacy path). Use from init and docs-init init bundles.

docs(15): add 15-CONTEXT for autonomous phase-15 run.

* feat(sdk): query CLI CJS fallback and session correlation

- createRegistry(eventStream, sessionId) threads correlation into mutation events
- gsd-sdk query falls back to gsd-tools.cjs when no native handler matches
  (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings
- Export createRegistry from @gsd-build/sdk; add sdk/README.md
- Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId
- Agents: prefer node dist/cli.js query over cat/grep for STATE and plans

* fix(sdk): init phase_found parity, docs-init agents path, state field extract

- Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal)

- docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled

- state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard)

- Tests: commit_docs default true; config-get golden uses temp config; golden integration green

Refs: #2302

* refactor(sdk): share SessionJsonlRecord in profile-extract-messages

CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages.

* fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify)

- Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command

- plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment

- check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default

- state.validate/sync: phaseTokenMatches + comparePhaseNum ordering

- verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter

- audit-open: has_scan_errors, unreadable rows, human report when scans fail

- requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note

- ingest-docs: repo-root path containment; classifier output slug-hash

Golden parity test strips has_scan_errors until CJS adds field.

* fix: Resolve CodeRabbit security and quality findings
- Secure intel.ts and cli.ts against path traversal
- Catch and validate git add status in commit.ts
- Expand roadmap milestone marker extraction
- Fix parsing array-of-objects in frontmatter YAML
- Fix unhandled config evaluations
- Improve coverage test parity mapping

* test: raise planner character extraction limit to 48K

* fix(sdk): resolve TS build error in docs-init passing config
2026-04-20 18:09:02 -04:00

113 lines
3.3 KiB
TypeScript

/**
* Safety gate consolidation (`check.gates`).
*
* Checks blocking conditions before proceeding with a workflow — replaces
* per-workflow gate logic in `next.md`, `execute-phase.md`, `discuss-phase.md`.
* See `.planning/research/decision-routing-audit.md` §3.2.
*/
import { readFile } from 'node:fs/promises';
import { existsSync } from 'node:fs';
import { join } from 'node:path';
import { GSDError, ErrorClassification } from '../errors.js';
import { normalizePhaseName, planningPaths } from './helpers.js';
import { findPhase } from './phase.js';
import type { QueryHandler } from './utils.js';
interface Blocker {
gate: string;
file: string;
severity: 'blocking';
anti_patterns: string[];
}
interface Warning {
gate: string;
phase: string;
items: string[];
message: string;
}
async function readFileSafe(filePath: string): Promise<string | null> {
try {
return await readFile(filePath, 'utf-8');
} catch {
return null;
}
}
export const checkGates: QueryHandler = async (args, projectDir) => {
const workflow = args[0];
if (!workflow) {
throw new GSDError('workflow name required for check gates', ErrorClassification.Validation);
}
// Parse optional --phase flag
let phaseNum: string | null = null;
const phaseIdx = args.indexOf('--phase');
if (phaseIdx !== -1 && args[phaseIdx + 1]) {
phaseNum = args[phaseIdx + 1];
}
const blockers: Blocker[] = [];
const warnings: Warning[] = [];
const paths = planningPaths(projectDir);
// Gate 1: .continue-here.md in project root
const continueHerePath = join(projectDir, '.continue-here.md');
if (existsSync(continueHerePath)) {
blockers.push({
gate: 'continue-here',
file: '.continue-here.md',
severity: 'blocking',
anti_patterns: ['continue-here.md present — another session may be in progress'],
});
}
// Gate 2: STATE.md error/failed status
const stateContent = await readFileSafe(paths.state);
if (stateContent) {
const hasErrorStatus =
/^status:\s*(error|failed)/im.test(stateContent) ||
/##\s*Error/i.test(stateContent);
if (hasErrorStatus) {
blockers.push({
gate: 'state-error',
file: '.planning/STATE.md',
severity: 'blocking',
anti_patterns: ['STATE.md status is error/failed'],
});
}
}
// Gate 3: Verification debt — check VERIFICATION.md in phase dir if phase provided
if (phaseNum) {
const phaseRes = await findPhase([phaseNum], projectDir);
const pdata = phaseRes.data as Record<string, unknown>;
if (pdata.found && pdata.directory) {
const phaseDirFull = join(projectDir, pdata.directory as string);
const verPath = join(phaseDirFull, 'VERIFICATION.md');
const verContent = await readFileSafe(verPath);
if (verContent) {
const failLines = verContent.match(/\|\s*FAIL\s*\|[^\n]*/gi) || [];
if (failLines.length > 0) {
warnings.push({
gate: 'verification-debt',
phase: normalizePhaseName(phaseNum),
items: failLines.map(l => `FAIL: ${l.trim()}`),
message: `${failLines.length} FAIL row(s) in VERIFICATION.md`,
});
}
}
}
}
return {
data: {
passed: blockers.length === 0,
blockers,
warnings,
},
};
};