c5b1445529
* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) Golden/read-only parity tests and registry alignment, query handler fixes (check-completion, state-mutation, commit, validate, summary, etc.), and WAITING.json dual-write for .gsd/.planning readers. Refs gsd-build/get-shit-done#2341 * fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback) - Recognize in-flight 🟡 milestone bullets like 🚧. - Derive from last **vX.Y Title** before ## Phases when emoji absent. - Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y in cleaned text instead of first (avoids v1.0 from shipped list). - Fixes init.execute-phase milestone_version and buildStateFrontmatter after state.begin-phase (syncStateFrontmatter). * feat(sdk): phase list, plan task structure, requirements extract handlers - Register phase.list-plans, phase.list-artifacts, plan.task-structure, requirements.extract-from-plans (SDK-only; golden-policy exceptions). - Add unit tests; document in QUERY-HANDLERS.md. - writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored. * feat(sdk): centralize getGsdAgentsDir in query helpers Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary ~/.claude/agents, legacy path). Use from init and docs-init init bundles. docs(15): add 15-CONTEXT for autonomous phase-15 run. * feat(sdk): query CLI CJS fallback and session correlation - createRegistry(eventStream, sessionId) threads correlation into mutation events - gsd-sdk query falls back to gsd-tools.cjs when no native handler matches (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings - Export createRegistry from @gsd-build/sdk; add sdk/README.md - Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId - Agents: prefer node dist/cli.js query over cat/grep for STATE and plans * fix(sdk): init phase_found parity, docs-init agents path, state field extract - Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal) - docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled - state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard) - Tests: commit_docs default true; config-get golden uses temp config; golden integration green Refs: #2302 * refactor(sdk): share SessionJsonlRecord in profile-extract-messages CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages. * fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify) - Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command - plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment - check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default - state.validate/sync: phaseTokenMatches + comparePhaseNum ordering - verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter - audit-open: has_scan_errors, unreadable rows, human report when scans fail - requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note - ingest-docs: repo-root path containment; classifier output slug-hash Golden parity test strips has_scan_errors until CJS adds field. * fix: Resolve CodeRabbit security and quality findings - Secure intel.ts and cli.ts against path traversal - Catch and validate git add status in commit.ts - Expand roadmap milestone marker extraction - Fix parsing array-of-objects in frontmatter YAML - Fix unhandled config evaluations - Improve coverage test parity mapping * test: raise planner character extraction limit to 48K * fix(sdk): resolve TS build error in docs-init passing config
90 lines
2.6 KiB
TypeScript
90 lines
2.6 KiB
TypeScript
import { mkdtemp, mkdir, writeFile } from 'node:fs/promises';
|
|
import { rmSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { describe, it, expect } from 'vitest';
|
|
import { checkConfigGates } from './config-gates.js';
|
|
|
|
function cleanupTempDir(dir: string): void {
|
|
try {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
} catch {
|
|
/* ignore */
|
|
}
|
|
}
|
|
|
|
describe('checkConfigGates', () => {
|
|
it('returns merged workflow defaults when config is absent', async () => {
|
|
const dir = await mkdtemp(join(tmpdir(), 'gsd-cg-'));
|
|
try {
|
|
await mkdir(join(dir, '.planning'), { recursive: true });
|
|
const { data } = await checkConfigGates([], dir);
|
|
expect(data).toMatchObject({
|
|
workflow: null,
|
|
research_enabled: true,
|
|
plan_checker_enabled: true,
|
|
nyquist_validation: true,
|
|
ui_phase: true,
|
|
auto_advance: false,
|
|
auto_chain_active: false,
|
|
code_review: true,
|
|
context_window: 200000,
|
|
});
|
|
} finally {
|
|
cleanupTempDir(dir);
|
|
}
|
|
});
|
|
|
|
it('treats string "false" as false and honors plan_checker alias', async () => {
|
|
const dir = await mkdtemp(join(tmpdir(), 'gsd-cg-'));
|
|
try {
|
|
await mkdir(join(dir, '.planning'), { recursive: true });
|
|
await writeFile(
|
|
join(dir, '.planning', 'config.json'),
|
|
JSON.stringify({
|
|
workflow: {
|
|
nyquist_validation: 'false',
|
|
plan_checker: false,
|
|
},
|
|
}),
|
|
'utf-8',
|
|
);
|
|
const { data } = await checkConfigGates([], dir);
|
|
expect(data.nyquist_validation).toBe(false);
|
|
expect(data.plan_checker_enabled).toBe(false);
|
|
expect(data.plan_check).toBe(false);
|
|
} finally {
|
|
cleanupTempDir(dir);
|
|
}
|
|
});
|
|
|
|
it('reflects workflow overrides from config.json', async () => {
|
|
const dir = await mkdtemp(join(tmpdir(), 'gsd-cg-'));
|
|
try {
|
|
await mkdir(join(dir, '.planning'), { recursive: true });
|
|
await writeFile(
|
|
join(dir, '.planning', 'config.json'),
|
|
JSON.stringify({
|
|
workflow: {
|
|
research: false,
|
|
auto_advance: true,
|
|
_auto_chain_active: true,
|
|
},
|
|
context_window: 100000,
|
|
}),
|
|
'utf-8',
|
|
);
|
|
const { data } = await checkConfigGates(['plan-phase'], dir);
|
|
expect(data).toMatchObject({
|
|
workflow: 'plan-phase',
|
|
research_enabled: false,
|
|
auto_advance: true,
|
|
auto_chain_active: true,
|
|
context_window: 100000,
|
|
});
|
|
} finally {
|
|
cleanupTempDir(dir);
|
|
}
|
|
});
|
|
});
|