## Helper deduplication (16 files)
Two genuinely-duplicated test helpers extracted to tests/helpers.cjs:
- captureConsole(fn) → {stdout, stderr} with ANSI strip + exception
re-throw after console restore (preserves the #2775 CR contract).
Removed from 6 bug-N test files (bug-2775, bug-2829, bug-3033,
bug-3211, bug-3231, bug-3359) where the implementation was either
byte-identical or trivially-different. installer-migration-install-
integration's captureConsole has a different signature ({value,
output}) and stays as-is.
- toPosixPath(p) → p with path.sep → '/'. Returns input unchanged if
null/undefined for safe optional-chain composition. Replaces the
local normalizePath in bug-3491-nested-git-worktree (the
prune-orphaned-worktrees inline normalizeSlashes was already swapped
for canonicalPath in the cluster-J batch).
## makeTmp/mkScratch wrappers (8 files)
Reduced each local wrapper from a 3-line fs.mkdtempSync(path.join(
os.tmpdir(), ...)) block to a 1-line arrow delegating to
createTempDir (already in helpers.cjs). Bug-number prefix conventions
stay local for readability:
- bug-2256, bug-2794, feat-3023, feat-3024 → `gsd-<bug>-${prefix}-`
- bug-3288 → makeTmpDir = createTempDir (identity)
- bug-3571 → 'gsd-3571-' (no parameter)
- feat-3595 → mkScratch = `fs-fault-${name}-`
- project-root-generator → 'gsd-parity-'
bug-3288 also collapsed local rmTmpDir into `cleanup` from helpers
(removes a separate inline rmSync site).
## CLAUDE.md — MemPalace protocol
Adds explicit instruction to call mempalace_status at session start
and mempalace_search / mempalace_kg_query before answering questions
about people, past work, or prior decisions in this project.
## Why this is a real consolidation
Initial survey suggested the bug-N test files could be parameterized
into one install-end-to-end.test.cjs — that turned out to oversell the
savings (~200 LOC on 2238) and to bury per-bug fixture context in a
table. The genuinely duplicated surface was the helpers themselves:
captureConsole copy-pasted ~6×, makeTmp variant copy-pasted ~8×.
Extracting them retires ~170 LOC of pure copy-paste without changing
any test semantics.
Validated: holodeck (ubuntu docker) 11232/0 pass; ratchet guard
still 7/7 at baseline.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
153 lines
5.9 KiB
JavaScript
153 lines
5.9 KiB
JavaScript
'use strict';
|
|
/**
|
|
* CJS parity test — project-root module
|
|
*
|
|
* For every fixture from sdk/src/project-root/index.test.ts, asserts that
|
|
* both the SDK (ESM, via dynamic import) and the generated CJS artifact
|
|
* return identical paths. This confirms that the generator correctly
|
|
* captures the function body and that all dependencies (sep, dirname,
|
|
* relative, etc.) are properly shimmed in the CJS preamble.
|
|
*/
|
|
|
|
const { describe, it, before, afterEach } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const os = require('node:os');
|
|
const path = require('node:path');
|
|
|
|
// CJS artifact — synchronous require
|
|
const { findProjectRoot: findProjectRootCjs } = require('../get-shit-done/bin/lib/project-root.generated.cjs');
|
|
|
|
// SDK ESM — loaded once before all tests via dynamic import
|
|
let findProjectRootSdk;
|
|
before(async () => {
|
|
const mod = await import('../sdk/dist/project-root/index.js');
|
|
findProjectRootSdk = mod.findProjectRoot;
|
|
});
|
|
|
|
// ── Fixture helpers ─────────────────────────────────────────────────────────
|
|
|
|
const { createTempDir } = require('./helpers.cjs');
|
|
const makeTmp = () => createTempDir('gsd-parity-');
|
|
|
|
function writeConfig(dir, content) {
|
|
fs.mkdirSync(path.join(dir, '.planning'), { recursive: true });
|
|
fs.writeFileSync(path.join(dir, '.planning', 'config.json'), JSON.stringify(content));
|
|
}
|
|
|
|
function assertParity(startDir) {
|
|
const sdkResult = findProjectRootSdk(startDir);
|
|
const cjsResult = findProjectRootCjs(startDir);
|
|
assert.strictEqual(
|
|
cjsResult,
|
|
sdkResult,
|
|
`parity failure for startDir="${startDir}": SDK="${sdkResult}" CJS="${cjsResult}"`,
|
|
);
|
|
return sdkResult;
|
|
}
|
|
|
|
// ── Tests ────────────────────────────────────────────────────────────────────
|
|
|
|
describe('project-root CJS/SDK parity', () => {
|
|
let workspace;
|
|
|
|
before(() => {
|
|
workspace = makeTmp();
|
|
});
|
|
|
|
afterEach(() => {
|
|
// Clean the workspace tree and recreate fresh for next test
|
|
try { fs.rmSync(workspace, { recursive: true, force: true }); } catch {}
|
|
workspace = makeTmp();
|
|
});
|
|
|
|
it('heuristic 0: startDir has own .planning/ — returns startDir', () => {
|
|
fs.mkdirSync(path.join(workspace, '.planning'), { recursive: true });
|
|
assertParity(workspace);
|
|
});
|
|
|
|
it('no ancestor .planning/ — returns startDir', () => {
|
|
assertParity(workspace);
|
|
});
|
|
|
|
it('heuristic 1: parent .planning/config.json lists child in sub_repos', () => {
|
|
writeConfig(workspace, { sub_repos: ['child'] });
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(path.join(child, '.git'), { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, workspace);
|
|
});
|
|
|
|
it('heuristic 1 nested: deeply nested dir inside sub_repo', () => {
|
|
writeConfig(workspace, { sub_repos: ['child'] });
|
|
const nested = path.join(workspace, 'child', 'src', 'utils');
|
|
fs.mkdirSync(path.join(workspace, 'child', '.git'), { recursive: true });
|
|
fs.mkdirSync(nested, { recursive: true });
|
|
const result = assertParity(nested);
|
|
assert.strictEqual(result, workspace);
|
|
});
|
|
|
|
it('heuristic 1 nested key: planning.sub_repos config shape', () => {
|
|
writeConfig(workspace, { planning: { sub_repos: ['child'] } });
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(path.join(child, '.git'), { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, workspace);
|
|
});
|
|
|
|
it('heuristic 2: multiRepo: true with .git in ancestor chain', () => {
|
|
writeConfig(workspace, { multiRepo: true });
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(path.join(child, '.git'), { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, workspace);
|
|
});
|
|
|
|
it('heuristic 3: parent has .planning/ and child has .git, no config', () => {
|
|
fs.mkdirSync(path.join(workspace, '.planning'), { recursive: true });
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(path.join(child, '.git'), { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, workspace);
|
|
});
|
|
|
|
it('malformed config.json falls back to heuristic 3', () => {
|
|
fs.mkdirSync(path.join(workspace, '.planning'), { recursive: true });
|
|
fs.writeFileSync(path.join(workspace, '.planning', 'config.json'), '{ not json');
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(path.join(child, '.git'), { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, workspace);
|
|
});
|
|
|
|
it('empty sub_repos with no .git — returns startDir', () => {
|
|
writeConfig(workspace, { sub_repos: [] });
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(child, { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, child);
|
|
});
|
|
|
|
it('#1362: child has own .planning/ — returns child not workspace', () => {
|
|
writeConfig(workspace, { sub_repos: ['child'] });
|
|
const child = path.join(workspace, 'child');
|
|
fs.mkdirSync(path.join(child, '.planning'), { recursive: true });
|
|
const result = assertParity(child);
|
|
assert.strictEqual(result, child);
|
|
});
|
|
|
|
it('depth limit: .planning/ is 12 levels up — returns startDir (depth=10 cap)', () => {
|
|
// CANONICALIZATION NOTE: SDK has FIND_PROJECT_ROOT_MAX_DEPTH=10; CJS now
|
|
// also uses 10 (was unbounded before). At 12 levels the walk stops before
|
|
// reaching workspace, so startDir is returned.
|
|
fs.mkdirSync(path.join(workspace, '.planning'), { recursive: true });
|
|
let dir = workspace;
|
|
for (let i = 1; i <= 12; i++) {
|
|
dir = path.join(dir, `l${i}`);
|
|
}
|
|
fs.mkdirSync(dir, { recursive: true });
|
|
const result = assertParity(dir);
|
|
assert.strictEqual(result, dir);
|
|
});
|
|
});
|