* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
237 lines
9.1 KiB
TypeScript
237 lines
9.1 KiB
TypeScript
/**
|
|
* Update-context resolver (issue #498, candidate 3).
|
|
*
|
|
* ADR-457 build-at-publish: the hand-written bin/lib/update-context.cjs
|
|
* collapsed to a TypeScript source of truth. Behaviour is preserved
|
|
* byte-for-behaviour from the prior hand-written .cjs; only types are added.
|
|
*/
|
|
|
|
import path from 'node:path';
|
|
import nodeFs from 'node:fs';
|
|
import nodeOs from 'node:os';
|
|
|
|
/** Runtime → candidate relative dir pairs. */
|
|
export type RuntimeDirEntry = [string, string];
|
|
|
|
// Runtime -> candidate relative dir. Order matters: it is the probe order, and
|
|
// mirrors the RUNTIME_DIRS array the bash used (a runtime may have several
|
|
// candidate dirs). Kept here, not derived from the installer's getDirName,
|
|
// because update detection probes ALL historical dirs per runtime.
|
|
export const RUNTIME_DIRS: RuntimeDirEntry[] = [
|
|
['claude', '.claude'],
|
|
['opencode', '.config/opencode'],
|
|
['opencode', '.opencode'],
|
|
['antigravity', '.gemini/antigravity-ide'],
|
|
['antigravity', '.gemini/antigravity-cli'],
|
|
['antigravity', '.gemini/antigravity'],
|
|
['antigravity', '.agent'], // local Antigravity install dir (#503; bin/install.js getDirName('antigravity'))
|
|
['gemini', '.gemini'],
|
|
['kilo', '.config/kilo'],
|
|
['kilo', '.kilo'],
|
|
['codex', '.codex'],
|
|
];
|
|
|
|
const SEMVER_PREFIX = /^\d+\.\d+\.\d+/;
|
|
|
|
function expandHome(p: string | undefined | null, home: string): string {
|
|
if (!p) return '';
|
|
return p.startsWith('~/') ? path.join(home, p.slice(2)) : p;
|
|
}
|
|
|
|
function versionFile(dir: string): string { return path.join(dir, 'gsd-core', 'VERSION'); }
|
|
function markerFile(dir: string): string { return path.join(dir, 'gsd-core', 'workflows', 'update.md'); }
|
|
|
|
export interface FsAdapter {
|
|
exists(p: string): boolean;
|
|
readFile(p: string): string | null;
|
|
}
|
|
|
|
// Detection: a dir "has GSD" if it carries a VERSION file or the update.md
|
|
// workflow marker.
|
|
function hasInstall(fs: FsAdapter, dir: string): boolean {
|
|
return fs.exists(versionFile(dir)) || fs.exists(markerFile(dir));
|
|
}
|
|
|
|
// Read VERSION at dir; return a trimmed semver string, or null if missing/invalid.
|
|
function validVersionAt(fs: FsAdapter, dir: string): string | null {
|
|
const raw = fs.readFile(versionFile(dir));
|
|
if (raw == null) return null;
|
|
const trimmed = String(raw).trim();
|
|
return SEMVER_PREFIX.test(trimmed) ? trimmed : null;
|
|
}
|
|
|
|
// A version is TRUSTED only when BOTH the VERSION file and the update.md marker
|
|
// exist (and VERSION is valid semver).
|
|
function trustedVersionAt(fs: FsAdapter, dir: string | undefined): string | null {
|
|
return dir && fs.exists(markerFile(dir)) ? validVersionAt(fs, dir) : null;
|
|
}
|
|
|
|
export interface InferPreferredRuntimeOpts {
|
|
fs: FsAdapter;
|
|
env: Record<string, string | undefined>;
|
|
preferredConfigDir: string;
|
|
}
|
|
|
|
// Infer the preferred runtime from preferredConfigDir config files, then env.
|
|
export function inferPreferredRuntime({ fs, env, preferredConfigDir }: InferPreferredRuntimeOpts): string {
|
|
if (preferredConfigDir) {
|
|
if (fs.exists(path.join(preferredConfigDir, 'kilo.json')) ||
|
|
fs.exists(path.join(preferredConfigDir, 'kilo.jsonc'))) return 'kilo';
|
|
if (fs.exists(path.join(preferredConfigDir, 'opencode.json')) ||
|
|
fs.exists(path.join(preferredConfigDir, 'opencode.jsonc'))) return 'opencode';
|
|
if (fs.exists(path.join(preferredConfigDir, 'config.toml'))) return 'codex';
|
|
}
|
|
if (env['CODEX_HOME']) return 'codex';
|
|
if (env['ANTIGRAVITY_CONFIG_DIR']) return 'antigravity';
|
|
if (env['GEMINI_CONFIG_DIR']) return 'gemini';
|
|
if (env['KILO_CONFIG_DIR'] || env['KILO_CONFIG']) return 'kilo';
|
|
if (env['OPENCODE_CONFIG_DIR'] || env['OPENCODE_CONFIG']) return 'opencode';
|
|
if (env['CLAUDE_CONFIG_DIR']) return 'claude';
|
|
return 'claude';
|
|
}
|
|
|
|
export interface EnvRuntimeDirsOpts {
|
|
env: Record<string, string | undefined>;
|
|
home: string;
|
|
}
|
|
|
|
// Absolute env-override candidates, mirroring the bash ENV_RUNTIME_DIRS block.
|
|
export function envRuntimeDirs({ env, home }: EnvRuntimeDirsOpts): RuntimeDirEntry[] {
|
|
const out: RuntimeDirEntry[] = [];
|
|
const ex = (v: string | undefined) => expandHome(v, home);
|
|
if (env['CLAUDE_CONFIG_DIR']) out.push(['claude', ex(env['CLAUDE_CONFIG_DIR'])]);
|
|
if (env['ANTIGRAVITY_CONFIG_DIR']) out.push(['antigravity', ex(env['ANTIGRAVITY_CONFIG_DIR'])]);
|
|
if (env['GEMINI_CONFIG_DIR']) out.push(['gemini', ex(env['GEMINI_CONFIG_DIR'])]);
|
|
if (env['KILO_CONFIG_DIR']) out.push(['kilo', ex(env['KILO_CONFIG_DIR'])]);
|
|
else if (env['KILO_CONFIG']) out.push(['kilo', path.dirname(ex(env['KILO_CONFIG']))]);
|
|
else if (env['XDG_CONFIG_HOME']) out.push(['kilo', path.join(ex(env['XDG_CONFIG_HOME']), 'kilo')]);
|
|
if (env['OPENCODE_CONFIG_DIR']) out.push(['opencode', ex(env['OPENCODE_CONFIG_DIR'])]);
|
|
else if (env['OPENCODE_CONFIG']) out.push(['opencode', path.dirname(ex(env['OPENCODE_CONFIG']))]);
|
|
else if (env['XDG_CONFIG_HOME']) out.push(['opencode', path.join(ex(env['XDG_CONFIG_HOME']), 'opencode')]);
|
|
if (env['CODEX_HOME']) out.push(['codex', ex(env['CODEX_HOME'])]);
|
|
return out;
|
|
}
|
|
|
|
// Stable reorder: entries whose runtime === preferred first, original order kept.
|
|
function preferFirst(entries: RuntimeDirEntry[], preferred: string): RuntimeDirEntry[] {
|
|
const pref = entries.filter(([rt]) => rt === preferred);
|
|
const rest = entries.filter(([rt]) => rt !== preferred);
|
|
return [...pref, ...rest];
|
|
}
|
|
|
|
export interface ResolveUpdateContextOpts {
|
|
home: string;
|
|
cwd: string;
|
|
env?: Record<string, string | undefined>;
|
|
fs: FsAdapter;
|
|
preferredConfigDir?: string;
|
|
preferredRuntime?: string;
|
|
}
|
|
|
|
export interface UpdateContext {
|
|
installedVersion: string;
|
|
scope: 'LOCAL' | 'GLOBAL' | 'UNKNOWN';
|
|
runtime: string;
|
|
gsdDir: string;
|
|
}
|
|
|
|
/**
|
|
* Pure resolver. Returns { installedVersion, scope, runtime, gsdDir }.
|
|
*/
|
|
export function resolveUpdateContext({
|
|
home,
|
|
cwd,
|
|
env = {},
|
|
fs,
|
|
preferredConfigDir = '',
|
|
preferredRuntime = '',
|
|
}: ResolveUpdateContextOpts): UpdateContext {
|
|
// Expand a leading `~/` before any probe.
|
|
preferredConfigDir = expandHome(preferredConfigDir, home);
|
|
const preferred = preferredRuntime || inferPreferredRuntime({ fs, env, preferredConfigDir });
|
|
|
|
// Fast path: a validated preferredConfigDir (custom --config-dir install).
|
|
if (preferredConfigDir && hasInstall(fs, preferredConfigDir)) {
|
|
const resolvedPref = path.resolve(preferredConfigDir);
|
|
let scope: 'LOCAL' | 'GLOBAL' = 'GLOBAL';
|
|
for (const [, reldir] of RUNTIME_DIRS) {
|
|
if (path.resolve(cwd, reldir) === resolvedPref) { scope = 'LOCAL'; break; }
|
|
}
|
|
return {
|
|
installedVersion: trustedVersionAt(fs, preferredConfigDir) ?? '0.0.0',
|
|
scope,
|
|
runtime: preferred,
|
|
gsdDir: preferredConfigDir,
|
|
};
|
|
}
|
|
|
|
const orderedEnv = preferFirst(envRuntimeDirs({ env, home }), preferred);
|
|
const orderedRuntime = preferFirst(RUNTIME_DIRS, preferred);
|
|
|
|
// LOCAL probe (relative to cwd).
|
|
let localRuntime = '', localDir = '';
|
|
for (const [rt, reldir] of orderedRuntime) {
|
|
const cand = path.resolve(cwd, reldir);
|
|
if (hasInstall(fs, cand)) { localRuntime = rt; localDir = cand; break; }
|
|
}
|
|
|
|
// GLOBAL probe: absolute env candidates first, then $HOME-relative.
|
|
let globalRuntime = '', globalDir = '';
|
|
for (const [rt, absdir] of orderedEnv) {
|
|
if (hasInstall(fs, absdir)) { globalRuntime = rt; globalDir = path.resolve(absdir); break; }
|
|
}
|
|
if (!globalRuntime) {
|
|
for (const [rt, reldir] of orderedRuntime) {
|
|
const cand = path.resolve(home, reldir);
|
|
if (hasInstall(fs, cand)) { globalRuntime = rt; globalDir = cand; break; }
|
|
}
|
|
}
|
|
|
|
const localValid = trustedVersionAt(fs, localDir);
|
|
const isLocal = !!localValid && (!globalDir || localDir !== globalDir);
|
|
|
|
if (isLocal) {
|
|
return { installedVersion: localValid, scope: 'LOCAL', runtime: localRuntime, gsdDir: localDir };
|
|
}
|
|
const globalValid = trustedVersionAt(fs, globalDir);
|
|
if (globalValid) {
|
|
return { installedVersion: globalValid, scope: 'GLOBAL', runtime: globalRuntime, gsdDir: globalDir };
|
|
}
|
|
// A runtime dir was detected (VERSION or marker present) but is not a
|
|
// complete, valid install: keep scope/runtime/dir and report 0.0.0 so the
|
|
// caller re-installs.
|
|
if (localRuntime && (!globalDir || localDir !== globalDir)) {
|
|
return { installedVersion: '0.0.0', scope: 'LOCAL', runtime: localRuntime, gsdDir: localDir };
|
|
}
|
|
if (globalRuntime) {
|
|
return { installedVersion: '0.0.0', scope: 'GLOBAL', runtime: globalRuntime, gsdDir: globalDir };
|
|
}
|
|
return { installedVersion: '0.0.0', scope: 'UNKNOWN', runtime: 'claude', gsdDir: '' };
|
|
}
|
|
|
|
export interface LoadUpdateContextOpts {
|
|
home?: string;
|
|
cwd?: string;
|
|
env?: Record<string, string | undefined>;
|
|
preferredConfigDir?: string;
|
|
preferredRuntime?: string;
|
|
}
|
|
|
|
/**
|
|
* CLI wiring: resolve against the real filesystem.
|
|
*/
|
|
export function loadUpdateContext(opts: LoadUpdateContextOpts = {}): UpdateContext {
|
|
const fs: FsAdapter = {
|
|
exists: (p: string) => nodeFs.existsSync(p),
|
|
readFile: (p: string) => { try { return nodeFs.readFileSync(p, 'utf8'); } catch { return null; } },
|
|
};
|
|
return resolveUpdateContext({
|
|
home: opts.home ?? nodeOs.homedir(),
|
|
cwd: opts.cwd ?? process.cwd(),
|
|
env: opts.env ?? process.env,
|
|
fs,
|
|
preferredConfigDir: opts.preferredConfigDir ?? '',
|
|
preferredRuntime: opts.preferredRuntime ?? '',
|
|
});
|
|
}
|