* fix(#2636): surface gsd-sdk query failures and add workflow↔handler parity check Root cause: workflows invoked `gsd-sdk query agent-skills <slug>` with a trailing `2>/dev/null`, swallowing stderr and exit code. When the installed `@gsd-build/sdk` npm was stale (pre-query), the call resolved to an empty string and `agent_skills.<slug>` config was never injected into spawn prompts — silently. The handler exists on main (sdk/src/query/skills.ts), so this is a publish-drift + silent-fallback bug, not a missing handler. Fix: - Remove bare `2>/dev/null` from every `gsd-sdk query agent-skills …` invocation in workflows so SDK failures surface to stderr. - Apply the same rule to other no-fallback calls (audit-open, write-profile, generate-* profile handlers, frontmatter.get in commands). Best-effort cleanup calls (config-set workflow._auto_chain_active false) keep exit-code forgiveness via `|| true` but no longer suppress stderr. Parity tests: - New: tests/bug-2636-gsd-sdk-query-silent-swallow.test.cjs — fails if any `gsd-sdk query agent-skills … 2>/dev/null` is reintroduced. - Existing: tests/gsd-sdk-query-registry-integration.test.cjs already asserts every workflow noun resolves to a registered handler; confirmed passing post-change. Note: npm republish of @gsd-build/sdk is a separate release concern and is not included in this PR. * fix(#2636): address review — restore broken markdown fences and shell syntax The previous commit's mass removal of '2>/dev/null' suffixes also collapsed adjacent closing code fences and 'fi' tokens onto the command line, producing malformed markdown blocks and 'truefi' / 'true fi' shell syntax errors in the workflows. Repaired sites: - commands/gsd/quick.md, thread.md (frontmatter.get fences) - workflows/complete-milestone.md (audit-open fence) - workflows/profile-user.md (write-profile + generate-* fences) - workflows/verify-work.md (audit-open --json fence) - workflows/execute-phase.md (truefi -> true / fi) - workflows/plan-phase.md, discuss-phase-assumptions.md, discuss-phase/modes/chain.md (true fi -> true / fi) All 5450 tests pass.
5.6 KiB
<required_reading> @~/.claude/get-shit-done/references/ui-brand.md </required_reading>
<available_agent_types> Valid GSD subagent types (use exact names — do not fall back to 'general-purpose'):
- gsd-security-auditor — Verifies threat mitigation coverage </available_agent_types>
0. Initialize
INIT=$(gsd-sdk query init.phase-op "${PHASE_ARG}")
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
AGENT_SKILLS_AUDITOR=$(gsd-sdk query agent-skills gsd-security-auditor)
Parse: phase_dir, phase_number, phase_name, phase_slug, padded_phase.
AUDITOR_MODEL=$(gsd-sdk query resolve-model gsd-security-auditor --raw)
SECURITY_CFG=$(gsd-sdk query config-get workflow.security_enforcement --raw 2>/dev/null || echo "true")
If SECURITY_CFG is false: exit with "Security enforcement disabled. Enable via /gsd:settings."
Display banner: GSD > SECURE PHASE {N}: {name}
1. Detect Input State
SECURITY_FILE=$(ls "${PHASE_DIR}"/*-SECURITY.md 2>/dev/null | head -1)
PLAN_FILES=$(ls "${PHASE_DIR}"/*-PLAN.md 2>/dev/null)
SUMMARY_FILES=$(ls "${PHASE_DIR}"/*-SUMMARY.md 2>/dev/null)
- State A (
SECURITY_FILEnon-empty): Audit existing - State B (
SECURITY_FILEempty,PLAN_FILESandSUMMARY_FILESnon-empty): Run from artifacts - State C (
SUMMARY_FILESempty): Exit — "Phase {N} not executed. Run /gsd:execute-phase {N} first."
2. Discovery
2a. Read Phase Artifacts
Read PLAN.md — extract <threat_model> block: trust boundaries, STRIDE register (threat_id, category, component, disposition, mitigation_plan).
2b. Read Summary Threat Flags
Read SUMMARY.md — extract ## Threat Flags entries.
2c. Build Threat Register
Per threat: { threat_id, category, component, disposition, mitigation_pattern, files_to_check }
3. Threat Classification
Classify each threat:
| Status | Criteria |
|---|---|
| CLOSED | mitigation found OR accepted risk documented in SECURITY.md OR transfer documented |
| OPEN | none of the above |
Build: { threat_id, category, component, disposition, status, evidence }
If threats_open: 0 → skip to Step 6 directly.
4. Present Threat Plan
Text mode (workflow.text_mode: true in config or --text flag): Set TEXT_MODE=true if --text is present in $ARGUMENTS OR text_mode from init JSON is true. When TEXT_MODE is active, replace every AskUserQuestion call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where AskUserQuestion is not available.
Call AskUserQuestion with threat table and options:
- "Verify all open threats" → Step 5
- "Accept all open — document in accepted risks log" → add to SECURITY.md accepted risks, set all CLOSED, Step 6
- "Cancel" → exit
5. Spawn gsd-security-auditor
Task(
prompt="Read ~/.claude/agents/gsd-security-auditor.md for instructions.\n\n" +
"<files_to_read>{PLAN, SUMMARY, impl files, SECURITY.md}</files_to_read>" +
"<threat_register>{threat register}</threat_register>" +
"<config>asvs_level: {SECURITY_ASVS}, block_on: {SECURITY_BLOCK_ON}</config>" +
"<constraints>Never modify implementation files. Verify mitigations exist — do not scan for new threats. Escalate implementation gaps.</constraints>" +
"${AGENT_SKILLS_AUDITOR}",
subagent_type="gsd-security-auditor",
model="{AUDITOR_MODEL}",
description="Verify threat mitigations for Phase {N}"
)
Handle return:
## SECURED→ record closures → Step 6## OPEN_THREATS→ record closed + open, present user with accept/block choice → Step 6## ESCALATE→ present to user → Step 6
6. Write/Update SECURITY.md
State B (create):
- Read template from
~/.claude/get-shit-done/templates/SECURITY.md - Fill: frontmatter, threat register, accepted risks, audit trail
- Write to
${PHASE_DIR}/${PADDED_PHASE}-SECURITY.md
State A (update):
- Update threat register statuses, append to audit trail:
## Security Audit {date}
| Metric | Count |
|--------|-------|
| Threats found | {N} |
| Closed | {M} |
| Open | {K} |
ENFORCING GATE: If threats_open > 0 after all options exhausted (user did not accept, not all verified closed):
GSD > PHASE {N} SECURITY BLOCKED
{K} threats open — phase advancement blocked until threats_open: 0
▶ Fix mitigations then re-run: /gsd:secure-phase {N}
▶ Or document accepted risks in SECURITY.md and re-run.
Do NOT emit next-phase routing. Stop here.
7. Commit
gsd-sdk query commit "docs(phase-${PHASE}): add/update security threat verification"
8. Results + Routing
Secured (threats_open: 0):
GSD > PHASE {N} THREAT-SECURE
threats_open: 0 — all threats have dispositions.
▶ /gsd:validate-phase {N} validate test coverage
▶ /gsd:verify-work {N} run UAT
Display /clear reminder.
<success_criteria>
- Security enforcement checked — exit if false
- Input state detected (A/B/C) — state C exits cleanly
- PLAN.md threat model parsed, register built
- SUMMARY.md threat flags incorporated
- threats_open: 0 → skip directly to Step 6
- User gate with threat table presented
- Auditor spawned with complete context
- All three return formats (SECURED/OPEN_THREATS/ESCALATE) handled
- SECURITY.md created or updated
- threats_open > 0 BLOCKS advancement (no next-phase routing emitted)
- Results with routing presented on success </success_criteria>