* test(4): reproduce non-idempotent phase complete + unclamped percent in CJS CLI RED regression tests for issue #4: - T1: double invocation of cmdPhaseComplete double-increments **Completed Phases:** in STATE.md body (blind parseInt+1 instead of deriving from ROADMAP) - T2: progress percent can exceed 100% when Completed Phases > Total Phases The CJS path (bin/lib/phase.cjs:cmdPhaseComplete) has the bug; the SDK path (phase-lifecycle.ts:phaseComplete, fixed in ~PR#3520) already derives completed_phases from ROADMAP Complete-row count, making it idempotent. References: - Issue #4 (open-gsd/get-shit-done-redux) - ADR-3524 (docs/adr/3524-cjs-sdk-hard-seam.md) - /tmp/adr-3524-review-findings.md (architectural justification) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(4): add sdk/scripts/gen-phase-lifecycle-policy.mjs generator + freshness check placeholder Generates phase-lifecycle-policy.generated.cjs from sdk/src/query/phase-lifecycle-policy.ts. All functions in phase-lifecycle-policy.ts are pure transforms (no I/O), directly serializable via Function.prototype.toString(). The GSDError dependency is replaced with a lightweight stub that throws plain Error objects — CJS callers that need process.exit(1) behavior catch these and delegate to error(). This is the "I/O adapter pattern" from ADR-3524 Section 4 applied to pure helpers. References: - ADR-3524 (docs/adr/3524-cjs-sdk-hard-seam.md) - /tmp/adr-3524-review-findings.md (architectural justification) - Issue #4 (open-gsd/get-shit-done-redux) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(4): add sdk/scripts/gen-phase.mjs generator Generates phase.generated.cjs from sdk/src/query/phase.ts. Only pure helpers (isCanonicalPlanFile, describeNonCanonicalPlans) are generated; async query handlers (findPhase, phasePlanIndex) are I/O-bound and remain per-side per ADR-3524 Section 4. References: - ADR-3524 (docs/adr/3524-cjs-sdk-hard-seam.md) - /tmp/adr-3524-review-findings.md (architectural justification) - Issue #4 (open-gsd/get-shit-done-redux) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(4): add sdk/scripts/gen-phase-lifecycle.mjs + core idempotency fix logic Generates phase-lifecycle.generated.cjs providing two pure functions that are the root-cause fix for issue #4: 1. deriveProgressFromRoadmap(roadmapContent): counts Complete rows in ROADMAP progress table — makes completed_phases idempotent (derived from ground truth instead of blind +1). Direct transcription of the SDK's "Root cause 1 fix" block in phase-lifecycle.ts (~line 1644). 2. clampPercent(completed, total): percent capped at 100 — prevents >100% progress when Completed Phases exceeds Total Phases. Design note: the full phase lifecycle mutations (add, insert, remove, complete) are inherently async and I/O-bound. Per ADR-3524 Section 4 ("I/O stays per-side"), those are NOT generated. Only the pure-computation kernel is extracted, following the I/O adapter pattern: pure logic shared; each side (CJS sync, SDK async) supplies its own I/O adapter. The pure functions are defined in the generator as real JS functions and serialized via Function.prototype.toString() — same technique as gen-project-root.mjs — rather than embedded in template literals (which would require double-escaping all regex backslashes). References: - ADR-3524 (docs/adr/3524-cjs-sdk-hard-seam.md) - /tmp/adr-3524-review-findings.md (architectural justification) - Issue #4 (open-gsd/get-shit-done-redux) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(4): emit phase.generated.cjs, phase-lifecycle.generated.cjs, phase-lifecycle-policy.generated.cjs Three generated CJS artifacts from their respective generator scripts: - phase.generated.cjs (1.7K): isCanonicalPlanFile + describeNonCanonicalPlans from sdk/src/query/phase.ts - phase-lifecycle.generated.cjs (3.6K): deriveProgressFromRoadmap + clampPercent — the idempotency+clamp fix for issue #4 - phase-lifecycle-policy.generated.cjs (7.0K): 14 pure phase naming/directory helpers from sdk/src/query/phase-lifecycle-policy.ts Run to regenerate: node sdk/scripts/gen-phase.mjs node sdk/scripts/gen-phase-lifecycle.mjs node sdk/scripts/gen-phase-lifecycle-policy.mjs References: - ADR-3524 (docs/adr/3524-cjs-sdk-hard-seam.md) - Issue #4 (open-gsd/get-shit-done-redux) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(4): migrate bin/lib/phase.cjs cmdPhaseComplete to use generated helpers Replace the blind-increment + unclamped percent bug in cmdPhaseComplete with the idempotent ROADMAP-derived approach: read freshly-updated ROADMAP, call deriveProgressFromRoadmap() from phase-lifecycle.generated.cjs, fall back to existing value when ROADMAP is unavailable. clampPercent() prevents >100%. Root cause fix for issue #4: the original parseInt(completedRaw) + 1 on every call made phase complete non-idempotent; the missing Math.min(100, ...) clamp allowed Progress to exceed 100%. I/O adapter pattern (ADR-3524 §4): pure computation in generated module; CJS supplies sync readFileSync; SDK supplies async readFile. Same logic, two adapters. Closes: Tests in 4-phase-complete-cjs-regression.test.cjs go GREEN. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(4): add freshness checks + npm scripts for phase generated artifacts (D4/D6) Add check-phase-fresh.mjs, check-phase-lifecycle-fresh.mjs, and check-phase-lifecycle-policy-fresh.mjs (same pattern as check-project-root-fresh.mjs: import buildXCjs() from the generator, regenerate in-memory, byte-compare to committed file, exit 1 if stale). Add gen:phase, check:phase-fresh, gen:phase-lifecycle, check:phase-lifecycle-fresh, gen:phase-lifecycle-policy, check:phase-lifecycle-policy-fresh to sdk/package.json. Note: gen:phase-lifecycle / check:phase-lifecycle-fresh do not require 'npm run build' because the generator defines pure functions directly rather than importing dist. Update shared-module-handsync-allowlist.json: reclassify phase.cjs justification to reflect that it now consumes phase-lifecycle.generated.cjs for cmdPhaseComplete. The *.generated.cjs files are excluded by the lint scanner (excludes *.generated.cjs) so no new allowlist entries are required for the generated artifacts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(4): add freshness-check CI steps for phase, phase-lifecycle, phase-lifecycle-policy Add three drift-check steps to .github/workflows/test.yml following the same pattern as the existing freshness checks (ubuntu-latest + node 24 only): - SDK generated phase artifact drift check - SDK generated phase-lifecycle artifact drift check - SDK generated phase-lifecycle-policy artifact drift check These guard against editors modifying the generated *.cjs files directly. They run check-phase-fresh.mjs, check-phase-lifecycle-fresh.mjs, and check-phase-lifecycle-policy-fresh.mjs respectively (added in D4). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(4): amend ADR-3524 — phase * I/O adapter pattern for issue #4 (D8) Append a 2026-05-23 amendment to docs/adr/3524-cjs-sdk-hard-seam.md documenting the Phase * cooperating-sibling retirement: three new generator scripts extract pure-computation helpers from phase.ts / phase-lifecycle.ts / phase-lifecycle-policy.ts, cmdPhaseComplete migrates to deriveProgressFromRoadmap + clampPercent for idempotency, freshness checks + CI steps added. Clarifies what is NOT generated (async I/O-bound mutation handlers stay per-side per Section 4) and notes open drift bugs #6 and #26 for traceability. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(4): add changeset fragment for cmdPhaseComplete fix Refs #4 * fix(154): use canonical /gsd:plan-phase form in phase-lifecycle-policy.ts Replaces the retired /gsd-plan-phase slash command reference with the canonical colon-namespaced /gsd:plan-phase in the TS source template string that feeds the generated CJS roadmap entry helper. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore(154): regenerate phase-lifecycle-policy.generated.cjs after slash-namespace fix Regenerated via node sdk/scripts/gen-phase-lifecycle-policy.mjs after fixing /gsd-plan-phase → /gsd:plan-phase in the TS source. Generated file now contains the canonical colon form. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(154): cross-platform frontmatter regex anchor in 4-phase-complete-cjs-regression.test.cjs Replaces /^---\n/ with /^---\r?\n/ so the frontmatter extraction helper in the regression test tolerates Windows CRLF line endings (autocrlf=true checkout leaves \r before \n, causing /^---\n/ to never match). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs(154): add new generated CJS modules to INVENTORY.md and regenerate manifest Adds three missing rows to the CLI Modules table: - phase-lifecycle-policy.generated.cjs - phase-lifecycle.generated.cjs - phase.generated.cjs Bumps the headline count from 74 to 77 to match the filesystem. Also regenerates docs/INVENTORY-MANIFEST.json via node scripts/gen-inventory-manifest.cjs --write. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(154): regenerate phase-lifecycle-policy.generated.cjs with hyphen form Root cause: commit 6cd701f4 regenerated the CJS artifact but at that point sdk/dist/query/phase-lifecycle-policy.js already had the correct /gsd-plan-phase (hyphen) form while sdk/src/query/phase-lifecycle-policy.ts still had /gsd:plan-phase (colon). The generator uses Function.prototype.toString() on the compiled dist, so the CJS picked up the wrong string from the stale TS source that was compiled into dist at some earlier point. Fix: correct the TS source to /gsd-plan-phase and re-run gen-phase-lifecycle-policy.mjs so that buildPhaseRoadmapEntry in the CJS emits the hyphen form, satisfying the bug-3584-runtime-slash-emitters.test.cjs assertion at line 179. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(154): restore /gsd:plan-phase canonical form in phase-lifecycle-policy Commit 0c3a9c75 incorrectly reverted the slash-namespace fix by misreading sdk/dist/ (a build artifact in hyphen form for non-Claude runtimes) as the authoritative source. The canonical form for Claude-facing source is /gsd:plan-phase (colon-namespaced). Fix: revert TS source back to /gsd:plan-phase, rebuild dist, regenerate phase-lifecycle-policy.generated.cjs. Fixes bug-2543-gsd-slash-namespace test failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(154): update INVENTORY.md CLI Modules count to 79 after rebase onto main Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(154): use hyphen form /gsd-plan-phase in persisted phase section template - sdk/src/query/phase-lifecycle-policy.ts: use /gsd-plan-phase (routable hyphen form) in the phase scaffold template that gets persisted to ROADMAP.md; bug-3584 requires persisted artifacts use the hyphen form - docs/INVENTORY.md: add missing runtime-name-policy.cjs row in CLI Modules table - tests/4-phase-complete-cjs-regression.test.cjs: add maxRetries/retryDelay to rmSync calls to satisfy Windows parity ratchet (baseline was 95) - Regenerate phase-lifecycle-policy.generated.cjs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
24 KiB
CJS↔SDK hard seam — one source of truth per Shared Module
- Status: Proposed
- Date: 2026-05-14
- Tracking issue: #3524
- Related PRD:
docs/prd/3524-cjs-sdk-hard-seam.md - Extends: ADR-0005 (seam map) — adds the Shared-Module Source Policy to the seam family
- Defers to: ADR-0001 (Dispatch Policy Module), ADR-0003 (Model Catalog Module), ADR-0004 (Planning Workspace Module), ADR-0006 (Planning Path Projection Module), ADR-0009 (Shell Command Projection Module — post-Phase 3–4, also subsuming superseded ADR-0010)
We decided to harden the boundary between the CJS tooling layer (get-shit-done/bin/lib/*.cjs) and the SDK (sdk/src/**/*.ts) by making every Module that is conceptually shared between the two runtimes have exactly one hand-authored source of truth and at most one generated artifact per runtime. The trigger is the recurring drift bug class — #1535, #1542, #2047/#2052, #2638/#2655, #2653/#2670, #2687/#2706, #2798/#2816, #3055/#3116, #3523 — each of which was a fix landing on one side without the other.
The precedent shape is already in the repo. sdk/scripts/gen-command-aliases.ts emits sdk/src/query/command-aliases.generated.ts and get-shit-done/bin/lib/command-aliases.generated.cjs from one TypeScript source. sdk/scripts/check-command-aliases-fresh.mjs is the CI freshness gate. The two consuming sides are pure Adapters over the generated artifact. This ADR generalizes that pattern to the other Shared Modules and forbids the hand-synced-pair anti-pattern that produced #3523.
Decision
1. Shared-Module Source Policy
A Shared Module is any Module whose Interface is consumed identically by both the CJS toolset and the SDK. The CONTEXT.md domain glossary already calls these out — e.g. STATE.md Document Module is explicitly typed as "Shared CJS/SDK pure transform Module."
For every Shared Module:
- Exactly one hand-authored source of truth. Lives at
sdk/src/<module-name>/as TypeScript when the Module has behavior, orsdk/shared/<module-name>.manifest.jsonwhen the Module is pure data. - Generated artifacts only. The CJS-side file is
get-shit-done/bin/lib/<module-name>.generated.cjsand is emitted mechanically. It is never hand-edited. - Per-Module freshness check. A CI script
sdk/scripts/check-<module>-fresh.mjsre-runs the generator and fails if the emitted artifact differs from the committed one. Precedent:check-command-aliases-fresh.mjs. - Per-Module drift lint (when the source is data, not a generator output). Precedent:
scripts/lint-shell-command-projection-drift.cjs. The lint asserts the canonical-owner invariants that aren't captured by file-equality. - Hand-synced pairs are forbidden. A pre-merge
lint-shared-module-handsync.cjsgrepsget-shit-done/bin/lib/for non-.generated.*files whose basename matches asdk/src/query/<same-name>.tssource and fails the build unless the pair is explicitly allow-listed.
2. Module-indexed canonical-owner table
The table below indexes by Module, not by physical layer. Each row names the source of truth, the emitted artifacts, the Adapter sites, and either the new ADR section that defines the Module or the existing ADR that already owns it.
| Module | Status | Source of truth | Generated artifacts | Adapters |
|---|---|---|---|---|
| STATE.md Document Module | New under this ADR (Phase 1) — see CONTEXT.md "STATE.md Document Module" | sdk/src/state-document/index.ts (promoted from sdk/src/query/state-document.ts) |
sdk/src/query/state-document.generated.ts, get-shit-done/bin/lib/state-document.generated.cjs |
bin/lib/state.cjs and sdk/src/query/state*.ts import the generated form |
| Configuration Module | New under this ADR (Phase 2) — definition added to CONTEXT.md as part of Phase 2 | sdk/src/configuration/index.ts plus data manifests sdk/shared/config-schema.manifest.json and sdk/shared/config-defaults.manifest.json |
sdk/src/query/config-schema.generated.ts, get-shit-done/bin/lib/config-schema.generated.cjs, get-shit-done/bin/lib/configuration.generated.cjs |
bin/lib/config.cjs, bin/lib/core.cjs:loadConfig, sdk/src/config.ts |
| Workstream Inventory Module (Builder) | Amended under this ADR (Phase 3) — Builder split documented in CONTEXT.md update | sdk/src/workstream-inventory/builder.ts (pure projection from directory entries + STATE.md text + plan scan results → typed inventory) |
sdk/src/query/workstream-inventory-builder.generated.ts, get-shit-done/bin/lib/workstream-inventory-builder.generated.cjs |
Per-side fs Readers (workstream-inventory.cjs sync, workstream-inventory.ts async) call the Builder. Readers stay hand-authored because the fs idiom legitimately differs. |
| Project-Root Resolution Module | New under this ADR (Phase 4) — short CONTEXT.md entry, behavior already de-facto shared | sdk/src/project-root/index.ts |
get-shit-done/bin/lib/project-root.generated.cjs |
bin/lib/core.cjs (findProjectRoot, findEffectiveRoot), sdk/src/helpers.ts |
| Frontmatter Module | Conditional (Phase 3, only if drift catalogue confirms pair duplication) | sdk/src/frontmatter/index.ts |
get-shit-done/bin/lib/frontmatter.generated.cjs |
Existing handler call sites |
| Plan Scan Module | Conditional (Phase 3 or later) | sdk/src/plan-scan/index.ts |
get-shit-done/bin/lib/plan-scan.generated.cjs |
Phase/roadmap routers |
| CJS Command Router Adapter Module | Amended under this ADR (Phase 5). Existing Module (per CONTEXT.md) is extended so the per-family handlers map delegates to the SDK runtime bridge in-process instead of to parallel CJS handler implementations. |
sdk/src/query-runtime-bridge.ts (already exists) + per-family delegate emitter |
get-shit-done/bin/lib/cjs-command-router-adapter.cjs (existing, ~40 lines) plus per-family handlers maps that require('../../sdk/dist/query-runtime-bridge.cjs') and call QueryRuntimeBridge.execute() |
bin/gsd-tools.cjs and the seven bin/lib/*-command-router.cjs files are the consumers. Per-family CJS handler files (state.cjs, verify.cjs, init.cjs, etc.) shrink to delegates or are deleted once the SDK handler is the only implementation. |
| Command-Alias Module | Already sealed by this pattern's precedent — sdk/scripts/gen-command-aliases.ts + check-command-aliases-fresh.mjs |
No change | No change | No change |
| Dispatch Policy Module | Defer — see ADR-0001 (and its 2026-05-05 SDK Runtime Bridge amendment) | n/a | n/a | n/a |
| Model Catalog Module | Defer — see ADR-0003; the sdk/shared/model-catalog.json manifest already follows the source-of-truth policy |
n/a | n/a | n/a |
| Planning Workspace Module | Defer — see ADR-0004; withPlanningLock, workstream pointer policy, lock semantics stay where they are |
n/a | n/a | n/a |
| Planning Path Projection Module | Defer — see ADR-0006; SDK is canonical, CJS path resolution converges via Phase 4 if any divergence is found | n/a | n/a | n/a |
| Shell Command Projection Module (incl. platform fs + subprocess after Phase 3–4 expansion) | Defer — see ADR-0009; this Module is the canonical owner for platformWriteSync, platformReadSync, platformEnsureDir, execGit, execNpm, execTool, probeTty, normalizeContent |
n/a | n/a | n/a |
| Skill Surface Budget Module | Defer — see ADR-0011 (accepted, not the 0011-superseded draft) | n/a | n/a | n/a |
3. Out-of-seam Modules (per-runtime, no shared source)
These remain CJS-only. Drift cannot occur because there is no SDK counterpart. If any later needs an SDK port, that port is a new enhancement, not a parallel implementation.
bin/lib/graphify.cjsbin/lib/gsd2-import.cjsbin/lib/schema-detect.cjsbin/lib/fallow-runner.cjsbin/lib/intel.cjsbin/lib/drift.cjsbin/lib/installer-migrations.cjs(installer runtime is CJS-native; SDK consumes viasdk-package-compatibility.tsAdapter)
4. Per-side I/O Adapters legitimately differ
The per-side state Adapter, verify Adapter, and similar handlers are not in the Shared-Module table. CJS callers use synchronous fs/exec; SDK callers use async I/O and the SDK observability decorators. The pure transforms behind them (parsing, projection, normalization) are extracted into Shared Modules per the table above; the I/O remains per-side. Golden parity tests in sdk/src/golden/ pin observable behavior across the seam.
5. Enforcement (per existing repo precedents, not new conventions)
Drift is blocked at three layers, each modeled on an existing in-repo script:
- Per-Module freshness check —
sdk/scripts/check-<module>-fresh.mjs, one per Shared Module in the table. Precedent:check-command-aliases-fresh.mjs. - Per-Module drift lint (when invariants are not pure file-equality) —
scripts/lint-<module>-drift.cjs, one per data-manifest-backed Module. Precedent:lint-shell-command-projection-drift.cjs. - Hand-sync pair lint —
scripts/lint-shared-module-handsync.cjsrejects any pair of files atget-shit-done/bin/lib/<name>.cjsandsdk/src/query/<name>.ts(orsdk/src/<name>.ts) that are neither generated artifacts nor on an explicit allow-list. This blocks the #3523 anti-pattern at PR time.
CODEOWNERS extends to sdk/src/<module>/ for each Shared Module. Architecture-team review is required for changes to a source of truth.
A top-of-file banner is auto-inserted by each generator into the emitted .generated.cjs / .generated.ts files. Banner pattern follows the existing command-aliases.generated.* files: a header noting "GENERATED FILE — Source: …". No additional banner tooling is introduced.
6. New CONTEXT.md entries added by this ADR's phases
- Configuration Module (added during Phase 2): Module owning config load, legacy-key normalization, defaults merge, and explicit on-disk migration for
.planning/config.json. Interface:loadConfig(cwd) → MergedConfig(pure read, no disk write);normalizeLegacyKeys(parsed) → { parsed, normalizations[] }(idempotent, returns the list of normalizations applied for migration logging);mergeDefaults(parsed) → MergedConfig;migrateOnDisk(cwd) → MigrationReport(explicit, opt-in, called only by the installer and bygsd-tools migrate-config). Invariants: never mutates disk insideloadConfig; legacy top-level keys (branching_strategy,sub_repos,multiRepo,depth) are normalized into their canonical nested locations in the returned value; defaults come from the sharedconfig-defaults.manifest.json. - Project-Root Resolution Module (added during Phase 4): Module owning project-root and effective-root resolution heuristics including own-
.planningdetection, parent-sub_repostraversal, legacymultiRepo, and.git-ancestor fallback. - Workstream Inventory Module — Builder split (CONTEXT.md amendment during Phase 3): the existing Module entry gains a sub-paragraph noting that the pure projection logic is the source of truth and the per-side Reader Adapters are hand-authored over the generated Builder.
- CJS Command Router Adapter Module — runtime-bridge delegation (CONTEXT.md amendment during Phase 5): the existing Module entry gains a paragraph noting that the per-family
handlersmap delegates toQueryRuntimeBridge.execute()in-process viarequire('../../sdk/dist/query-runtime-bridge.cjs'). Per-side CJS handler files (state.cjs,verify.cjs, etc.) that previously held parallel implementations are reduced to delegates or deleted once their SDK counterpart is the only remaining implementation. CJS-only Module handlers (graphify, gsd2-import, schema-detect, fallow-runner, intel, drift) keep their in-process CJS implementations because no SDK counterpart exists.
Consequences
- The hand-synced-pair anti-pattern that produced #3523 becomes impossible to merge. The
lint-shared-module-handsync.cjsgate rejects any new pair that is not generated. Thecheck-<module>-fresh.mjsgates reject any edit to a generated file that is out of sync with its source. - The seam vocabulary stays inside the existing CONTEXT.md / LANGUAGE.md frame. No new layer labels ("shared core", "shared data"); the unit of seam ownership is the Module, as it already is everywhere else in this repo.
- No new build tooling is introduced. The generator pattern is the existing
gen-command-aliases.tsshape. No dual CJS+ESM bundler, nopackage.jsonexportssubpath change, notsup/rollupdecision. - Each phase ships one Shared Module. The smallest phase (STATE.md Document Module) ships first because both files are already character-identical — the deletion test passes on contact. The trigger bug class (#3523) is closed in Phase 2 by the Configuration Module. The seam becomes a real wall in Phase 5 when the CJS routers stop holding parallel handler implementations.
- CJS dispatch collapses onto the SDK runtime bridge. Once Phase 5 lands, every canonical command running via
gsd-toolsexecutes the same SDK handler thatgsd-sdk queryexecutes — in-process, not subprocess. The per-side state/verify/init/phase/roadmap/validate handler implementations in CJS are replaced by thin delegates overQueryRuntimeBridge.execute(). The result-shape contract is preserved ({ exitCode, stdoutChunks, stderrLines }per the Query CLI Output Module, ADR-0001). - Existing ADRs are deferred to, not restated. Planning Path Projection (ADR-0006), Model Catalog (ADR-0003), Planning Workspace (ADR-0004), Dispatch Policy (ADR-0001), Shell Command Projection (ADR-0009) remain authoritative for their domains. The new ADR adds Shared-Module Source Policy, the per-Module entries above, and the CJS Command Router Adapter Module amendment.
- Per-side I/O Adapter divergence is preserved at the runtime-bridge boundary. The CJS router's sync execution model is preserved:
QueryRuntimeBridge.execute()exposes a sync entry point for CJS callers (or, when the underlying SDK handler is async, the bridge runs an in-process event loop step). No subprocess hop is added. Async SDK call sites continue to use the async bridge directly. - Enforcement reuses existing scripts. Three new lint/check primitives, all modeled on scripts already in
scripts/andsdk/scripts/. CI wiring follows the existing precedent.
Out of scope
- Migrating CJS-only Modules (graphify, gsd2-import, schema-detect, fallow-runner, intel, drift) to SDK handlers — each is its own enhancement.
- Sync→async migration of CJS state/verify Adapters — leaves the per-side Adapter shape intact, which is the point.
- Defining a Verify Module before the verify surface has a shared Interface — that is precondition work for a future enhancement, not this one.
Amendments
(Append-only. Use a dated header when the decision evolves.)
2026-05-23 — validate.ts → verify.cjs generator pattern (issue #6)
Three pure helpers from sdk/src/query/validate.ts Check 8 are now generated into
get-shit-done/bin/lib/validate.generated.cjs via sdk/scripts/gen-validate.mjs,
following the same I/O adapter pattern established by PR #154 (issue #4):
Generator: sdk/scripts/gen-validate.mjs
Artifact: get-shit-done/bin/lib/validate.generated.cjs
Freshness check: sdk/scripts/check-validate-fresh.mjs
CI: .github/workflows/test.yml — "SDK generated validate artifact drift check"
Three drift items resolved (issue #6):
-
W007
activeDiskPhases—verify.cjsCheck 8 previously iterateddiskPhases(which includes archived milestone phases viaforEachArchivedPhaseToken) for the W007 check. Archived phases absent from the current ROADMAP produced false W007 warnings. Fix: W007 now iteratesactiveDiskPhases(fromcollectDiskPhases()only, withoutforEachArchivedPhaseToken), matchingvalidate.tsCheck 8 behavior. -
phaseVariants()normalization —verify.cjsCheck 8 usedparseInt(p).padStart(2,'0')for disk-existence and roadmap-membership checks, which drops letter suffixes (e.g. "3B" → "03" instead of "03B"). Phase dirs with letter-suffix padding mismatches (ROADMAP "3B", disk "03B-foo") produced false W006 and W007. Fix: both checks now usephaseVariants(p)from the generated module, which returns the full normalized Set including letter-suffix forms. -
W006 unchecked-phase variant skip —
verify.cjsCheck 8 builtnotStartedPhaseswith raw +parseInt-padded forms (drops letter suffix).phaseVariants()is now used instead, so unchecked entries like "3B" correctly suppress W006 for "03B" (and vice versa).
phaseVariants extraction note: phaseVariants is defined as a closure inside validateHealth
in the compiled output (not a module-level export). It is extracted via brace-balanced source-text
parsing from sdk/dist/query/validate.js, the same technique used for escapeRegex extraction in
gen-phase-lifecycle-policy.mjs. The function is deterministic and pure: no closures over external
state, no side effects.
Parity tests: tests/6-validate-cjs-drift-regression.test.cjs — 5 tests (all GREEN after fix,
all RED on pre-fix origin/main). Covers each drift item with concrete fixtures:
- Drift 1: two milestone archives (v1.0 old, v1.1 active); v1.0 phase absent from ROADMAP.
- Drift 2: ROADMAP "01A", disk "1A-foo" — padding mismatch.
- Drift 3: ROADMAP "3B", disk "03B-foo" — zero-padded letter-suffix mismatch.
Allowlist: scripts/shared-module-handsync-allowlist.json — verify.cjs entry updated to
reference the generator and freshness check. Classification remains cooperating-sibling (verify.cjs
is still a full implementation; only Check 8 helpers are generated).
Extension — issue #26: W005/W006-archived/I001 generator migration
PR #3479 fixed three false-positive classes in sdk/src/query/validate.ts. PR #3806 hand-ported
the three fixes to get-shit-done/bin/lib/verify.cjs but did not route them through the generator
— meaning they could drift again. Issue #26 closes this gap by extending gen-validate.mjs
(introduced in this amendment above) to also extract and export the W005/W006-archived/I001 items.
Four additional exports added to validate.generated.cjs (issue #26):
-
phaseDirNameRe(W005) — ThePHASE_DIR_NAME_REconstant/^\d{2,}(?:\.\d+)*-[\w-]+$/is now a named export fromvalidate.tsand extracted bygen-validate.mjs.verify.cjsCheck 6 consumesphaseDirNameRefrom the generated artifact instead of an inline copy. Reproducer:mkdir -p .planning/phases/999.1-foo→ zero W005 (previously fired with the\d{2}two-digits-only regex before PR #3806 / PR #3479). -
PHASE_TOKEN_FROM_DIR_RE(W006-archived) — The regex constant previously inline inverify.cjs'sforEachArchivedPhaseToken()andcollectDiskPhases(). Extracted from the module-levelconstin the compiled output.verify.cjsinline copy removed. -
MILESTONE_ARCHIVE_DIR_RE(W006-archived) — The regex constant previously inline inverify.cjs'slistMilestoneArchiveDirs(). Extracted the same way.verify.cjsinline copy removed. TogetherPHASE_TOKEN_FROM_DIR_REandMILESTONE_ARCHIVE_DIR_REensure the archive-walking logic uses the same patterns asvalidate.ts. -
canonicalPlanStem(I001) — The top-level helper function previously inline inverify.cjsCheck 7. Extracted viaextractTopLevelFunction()(brace-balanced parser).verify.cjsinline copy removed. Fix:68-01-scaffolding-PLAN.mdcorrectly matches68-01-SUMMARY.md— both reduce to68-01viacanonicalPlanStem().
W006-archived coverage note: Issue #26 describes W006-archived as "RELATED TO but DISTINCT
FROM" PR #156's W006 fix. Investigation confirmed both fixes are ALREADY in verify.cjs (from
PR #3806). The gap was generator coverage: the regex constants used by forEachArchivedPhaseToken
were inline copies with no generator protection. This amendment closes that gap by extracting them.
No new behavioral fix is required — the generator pattern extension is the deliverable.
validate.ts change: PHASE_DIR_NAME_RE promoted from inline anonymous regex to a named
export const so it appears as an extractable identifier in the compiled ESM output.
Extraction methods used:
extractConstRegExp()(new ingen-validate.mjs) — handlesconstandexport constsingle-line RegExp assignments. Used forphaseDirNameRe,PHASE_TOKEN_FROM_DIR_RE,MILESTONE_ARCHIVE_DIR_RE.extractTopLevelFunction()(new ingen-validate.mjs) — brace-balanced parser for top-level named function declarations. Used forcanonicalPlanStem.
Parity tests: tests/26-w005-w006-i001-cjs-drift-regression.test.cjs — 7 tests.
- W005: no false positive for
999.1-foo; W005 still fires for single-digit prefix. - W006-archived: no false W006 for phase archived under
milestones/v1.0-phases/; unit tests forMILESTONE_ARCHIVE_DIR_REandPHASE_TOKEN_FROM_DIR_REexport and behavior. - I001: no false I001 when long-stem PLAN matches short-stem SUMMARY via
canonicalPlanStem; I001 still fires when there is genuinely no SUMMARY; unit test forcanonicalPlanStemexport.
Cross-references: issue #26 cures the same false-positive scenarios as issue #6 but for
the W005/W006-archived/I001 check paths. The artifact validate.generated.cjs now covers all
six drift surfaces originally identified across both issues. This completes the validate.ts ↔
verify.cjs migration scope for generator-pattern coverage.
2026-05-23: Phase * cooperating-sibling retirement — I/O adapter pattern for phase lifecycle (issue #4)
Context: Issue #4 revealed that phase.cjs:cmdPhaseComplete was non-idempotent: every call blindly incremented Completed Phases by 1 and computed Progress without a 100% clamp. The SDK's phase-lifecycle.ts already contained the correct idempotent implementation ("Root cause 1 fix" block ~line 1644), but CJS had no way to share it because the mutation handlers are async I/O-bound and Section 4's "I/O stays per-side" rule prevents direct sharing.
Decision: Apply the I/O adapter pattern (Section 4) to the pure-computation kernel inside phase-lifecycle.ts:
-
Three new generator scripts extract pure helpers from the phase family:
sdk/scripts/gen-phase.mjs→get-shit-done/bin/lib/phase.generated.cjs(pure helpers:isCanonicalPlanFile,describeNonCanonicalPlans)sdk/scripts/gen-phase-lifecycle.mjs→get-shit-done/bin/lib/phase-lifecycle.generated.cjs(pure helpers:deriveProgressFromRoadmap,clampPercent)sdk/scripts/gen-phase-lifecycle-policy.mjs→get-shit-done/bin/lib/phase-lifecycle-policy.generated.cjs(14 pure policy helpers:generatePhaseSlug,computePhaseDirectory,buildPhaseRoadmapEntry, etc.)
-
phase.cjs:cmdPhaseCompleteis migrated to usederiveProgressFromRoadmap+clampPercentfrom the generated artifact. It reads the freshly-updated ROADMAP synchronously, derives the completed-phase count from Complete-row matching (idempotent), and passes it throughclampPercentto prevent >100% Progress. -
Freshness checks:
check-phase-fresh.mjs,check-phase-lifecycle-fresh.mjs,check-phase-lifecycle-policy-fresh.mjsadded. CI adds three corresponding drift-check steps alongside the existing generated-artifact drift checks. -
Allowlist:
phase.cjs ↔ phase.tsremainscooperating-siblingbecausephase.cjsstill owns the CJS sync mutation handlers (phaseAdd, phaseInsert, phaseRemove, phaseComplete) that are legitimately I/O-bound and cannot be extracted via.toString(). The allowlist justification is updated to reflect the new generator consumption.
What this is NOT: The full async mutation handlers (phaseAdd, phaseInsert, phaseRemove, phaseComplete) are inherently async I/O-bound and are NOT generated — per Section 4. This amendment only extracts the pure-computation kernel.
Open drift bugs remaining: Issue #6 (phasePlanIndex drift) and issue #26 (phase.add inline ROADMAP update drift) are separate bug reports; they are referenced here for traceability but not fixed in this amendment. Future amendments should note when those are resolved.