918f987a19
* feat(#2982): extend no-source-grep lint to catch var-binding readFileSync.includes() The base lint (scripts/lint-no-source-grep.cjs) only catches readFileSync(...).<text-method>() chained directly. The much more common var-binding form escapes it: const src = fs.readFileSync(p, 'utf8'); // 50 lines later if (src.includes('foo')) {} // ← still grep, lint missed it Scan of the test suite found ~141 files using this pattern. Implementation built TDD per #2982 with structured-IR assertions: scripts/lint-no-source-grep-extras.cjs - detectVarBindingViolations(src) — pure detector, two passes: pass 1 collects vars bound from readFileSync, pass 2 finds any <var>.<includes|startsWith|endsWith|match|search>( on those vars. - detectWrappedAssertOkMatch(src) — flags assert.ok(<expr>.match(...)) which escapes the assert.match rule. - VIOLATION enum exposes stable codes for tests to assert on. scripts/lint-no-source-grep.cjs - Wires the new detectors into the existing per-file check; one additional violation row per file with the first 3 sample tokens. tests/bug-2982-lint-var-binding.test.cjs - 13 tests, all assertions on typed VIOLATION enum / structured records. Covers all 5 text-match methods, multi-var, no-bind, string literal (must NOT trigger), wrapped assert.ok(.match), and assert.match (must NOT double-flag). Migration backlog (#2974 expanded scope): - 42 files annotated `// allow-test-rule: source-text-is-the-product` (legitimate — they read .md/.json/.yml files whose deployed text IS the product) - 3 files annotated `// allow-test-rule: pending-migration-to-typed-ir [#2974]` (read .cjs/.js source — clear migration debt) - 95 files annotated `pending-migration-to-typed-ir [#2974]` with `Per-file review may reclassify as source-text-is-the-product during migration` (mixed — manual review under #2974) After this lands the lint reports 0 violations on main; new violations in PRs surface immediately. Closes #2982 Refs #2974 * test(#2982): fix truncated test name per CR The label ended with a bare '(' from a copy-paste mishap. Now reads 'does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged'. * chore(#2982): add changeset fragment for PR #2985 * chore(#2982): add changeset fragment for PR #2985
79 lines
2.6 KiB
JavaScript
79 lines
2.6 KiB
JavaScript
// allow-test-rule: pending-migration-to-typed-ir [#2974]
|
|
// Tracked in #2974 for migration to typed-IR assertions per CONTRIBUTING.md
|
|
// "Prohibited: Raw Text Matching on Test Outputs". Per-file review may
|
|
// reclassify some entries as source-text-is-the-product during migration.
|
|
|
|
/**
|
|
* Bug #2559: Stale document references in Research phase
|
|
*
|
|
* The gsd-phase-researcher and gsd-project-researcher agents instruct
|
|
* WebSearch queries to always include "current year" (or a hardcoded
|
|
* year). This biases results toward stale dated content as time passes
|
|
* (e.g., a 2024 query run in 2026 returns stale results).
|
|
*
|
|
* Fix: Remove year-injection instructions from research agent
|
|
* WebSearch guidance so searches return current results.
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const PHASE_RESEARCHER = path.join(
|
|
__dirname,
|
|
'..',
|
|
'agents',
|
|
'gsd-phase-researcher.md'
|
|
);
|
|
const PROJECT_RESEARCHER = path.join(
|
|
__dirname,
|
|
'..',
|
|
'agents',
|
|
'gsd-project-researcher.md'
|
|
);
|
|
|
|
const FILES = [
|
|
{ label: 'gsd-phase-researcher.md', path: PHASE_RESEARCHER },
|
|
{ label: 'gsd-project-researcher.md', path: PROJECT_RESEARCHER },
|
|
];
|
|
|
|
describe('research agents do not inject year into web searches (#2559)', () => {
|
|
for (const { label, path: filePath } of FILES) {
|
|
test(`${label} contains no CURRENT_YEAR placeholder`, () => {
|
|
const content = fs.readFileSync(filePath, 'utf-8');
|
|
assert.ok(
|
|
!/CURRENT_YEAR/.test(content),
|
|
`${label} must not contain CURRENT_YEAR placeholder (causes stale-year injection)`
|
|
);
|
|
});
|
|
|
|
test(`${label} contains no hardcoded year in web search instructions`, () => {
|
|
const content = fs.readFileSync(filePath, 'utf-8');
|
|
const match = content.match(/\b20(2[3-9]|[3-9]\d)\b/);
|
|
assert.ok(
|
|
!match,
|
|
`${label} must not contain hardcoded year (found "${match && match[0]}") — biases searches toward stale content`
|
|
);
|
|
});
|
|
|
|
test(`${label} does not instruct searches to include year or current year`, () => {
|
|
const content = fs.readFileSync(filePath, 'utf-8');
|
|
// Match phrases like "include current year", "year in searches",
|
|
// "[current year]", "with year", etc.
|
|
const patterns = [
|
|
/include\s+(?:the\s+)?current\s+year/i,
|
|
/current\s+year/i,
|
|
/year\s+in\s+(?:searches|queries)/i,
|
|
/\[current year\]/i,
|
|
];
|
|
for (const pat of patterns) {
|
|
assert.ok(
|
|
!pat.test(content),
|
|
`${label} must not instruct year injection (matched /${pat.source}/)`
|
|
);
|
|
}
|
|
});
|
|
}
|
|
});
|