* test(#4153): cover unresolved update target * fix(#4153): fail closed unresolved update target * test(#4153): require a concrete recovery installer * fix(#4153): use concrete unresolved recovery command * chore(#4153): bind changeset to fork PR * test(#4153): cover portable update diagnostics * fix(#4153): keep update diagnostics portable * fix(#4153): harden update version diagnostics * test(#4153): reject jq in update version checks * test(#4153): expose step-local parser gap * fix(#4153): keep JSON parsing step-local * docs(#4153): align update target guidance * test(#4153): expose workflow runtime fallback * test(#4153): expose resolver runtime fallback * fix(#4153): leave unknown workflow runtime empty * fix(#4153): stop inferring Claude for unknown targets * test(#4153): preserve Claude workflow targeting * test(#4153): preserve known runtime directory identity * fix(#4153): recognize Claude workflow paths * fix(#4153): reuse known runtime directory identities * chore(#4153): acknowledge emitted workflow growth The fail-closed diagnostic and known-runtime preservation deliberately add 48 emitted bytes. Emitted-Drift-Ack-Growth: update.md — explicit unresolved-target diagnostics and known-runtime preservation * test(#4153): expose missing Windsurf workflow contract * docs(#4153): document Windsurf update targets * chore(#4153): bind changeset to upstream PR * fix(#4153): gate unresolved-target exit before the VERSION-missing fallback The VERSION-missing bullet in get_installed_version sat before the UPDATE_TARGET_UNRESOLVED exit and shared its trigger condition (version 0.0.0). An LLM agent reading the workflow top-to-bottom could satisfy "proceed to install" without ever reaching the fail-closed exit this PR adds, reopening the ill-defined mutating path #4153 closes. Reorder so the unresolved-target gate runs first and scope the VERSION-missing bullet to require an already-resolved target. Also drop two vacuous mutationSpies entries: they checked '--sync'/ '--reapply' (commands/gsd/update.md content) against `step`, a slice of workflows/update.md — always -1 regardless of correctness. Those routes bypass get_installed_version entirely and are already covered by install.test.cjs, reapply-patches.test.cjs, and skill-frontmatter-contract.test.cjs. * chore(#4153): point changeset pr field at fork PR #10 for fork CI * test(#4153): guard RUNTIME_DIRS/update.md table parity, confirm narrowing intent Nit 1: update.md's PREFERRED_RUNTIME prose and RUNTIME_DIRS (src/update-context.cts) are two independently maintained copies of the same runtime->dir mapping with no parity check; add one so a future edit to either surface without the other fails loudly instead of silently drifting. Nit 2: call out in the changeset that a custom --config-dir matching no known runtime, marker file, or env var now resolves unresolved instead of silently defaulting to claude -- this narrowing is intentional, it's the fail-closed behavior #4153 asks for. * fix(#4153): drop dead $UC fallback in check_latest_version's uc_field, cover unresolved-runtime fast path agy (gemini-3.8-flash-high) adversarial review of the full PR: 1. check_latest_version's uc_field() copy-pasted get_installed_version's `${2:-$UC}` fallback, but every call site here passes $2 explicitly and $UC does not exist in this step's scope -- dead, misleading reference. Use $2 directly. 2. No unit test covered resolveUpdateContext's preferredConfigDir fast path returning runtime: '' for a custom --config-dir matching no RUNTIME_DIRS suffix, marker file, or env var (the exact fail-closed case #4153 adds). Added. A third finding (update.md:90 using /gsd:update vs docs using /gsd-update) was investigated and rejected: /gsd:update is the actual registered Claude Code command name (commands/gsd/update.md name: gsd:update) and is locked by this PR's own test (tests/update-workflow.test.cjs); /gsd-update is a separate, pre-existing, intentional prose convention used in audience-facing docs (README/INVENTORY/FEATURES). Not a defect. * chore(#4153): backfill changeset pr field to upstream PR #4237 --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Test <test@test.com> Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
248 lines
9.8 KiB
TypeScript
248 lines
9.8 KiB
TypeScript
/**
|
|
* Update-context resolver (issue #498, candidate 3).
|
|
*
|
|
* ADR-457 build-at-publish: the hand-written bin/lib/update-context.cjs
|
|
* collapsed to a TypeScript source of truth. Behaviour is preserved
|
|
* byte-for-behaviour from the prior hand-written .cjs; only types are added.
|
|
*/
|
|
|
|
import path from 'node:path';
|
|
import nodeFs from 'node:fs';
|
|
import nodeOs from 'node:os';
|
|
|
|
/** Runtime → candidate relative dir pairs. */
|
|
export type RuntimeDirEntry = [string, string];
|
|
|
|
// Runtime -> candidate relative dir. Order matters: it is the probe order, and
|
|
// mirrors the RUNTIME_DIRS array the bash used (a runtime may have several
|
|
// candidate dirs). Kept here, not derived from the installer's getDirName,
|
|
// because update detection probes ALL historical dirs per runtime.
|
|
export const RUNTIME_DIRS: RuntimeDirEntry[] = [
|
|
['claude', '.claude'],
|
|
['opencode', '.config/opencode'],
|
|
['opencode', '.opencode'],
|
|
['antigravity', '.gemini/antigravity-ide'],
|
|
['antigravity', '.gemini/antigravity-cli'],
|
|
['antigravity', '.gemini/antigravity'],
|
|
['antigravity', '.agents'], // local Antigravity install dir canonical (#791; bin/install.js getDirName('antigravity'))
|
|
['antigravity', '.agent'], // local Antigravity install dir legacy (#503; backward-compat with pre-#791 installs)
|
|
['windsurf', '.windsurf'], // local Windsurf workflow dir canonical (#1615; bin/install.js getDirName('windsurf'))
|
|
['windsurf', '.devin'], // local Devin Desktop install dir legacy (#1085; backward-compat)
|
|
['kilo', '.config/kilo'],
|
|
['kilo', '.kilo'],
|
|
['codex', '.codex'],
|
|
];
|
|
|
|
const SEMVER_PREFIX = /^\d+\.\d+\.\d+/;
|
|
|
|
// Shared Codex config-root marker filename. Single-sourced here (this module
|
|
// is the pre-existing, dependency-free owner) and re-exported by
|
|
// host-runtime-detection.cts, whose detection rung reuses this exact probe
|
|
// filename (though NOT the truthiness rule below — see that module's header
|
|
// comment for the deliberate divergence).
|
|
export const CODEX_CONFIG_MARKER = 'config.toml';
|
|
|
|
function expandHome(p: string | undefined | null, home: string): string {
|
|
if (!p) return '';
|
|
return p.startsWith('~/') ? path.join(home, p.slice(2)) : p;
|
|
}
|
|
|
|
function versionFile(dir: string): string { return path.join(dir, 'gsd-core', 'VERSION'); }
|
|
function markerFile(dir: string): string { return path.join(dir, 'gsd-core', 'workflows', 'update.md'); }
|
|
|
|
export interface FsAdapter {
|
|
exists(p: string): boolean;
|
|
readFile(p: string): string | null;
|
|
}
|
|
|
|
// Detection: a dir "has GSD" if it carries a VERSION file or the update.md
|
|
// workflow marker.
|
|
function hasInstall(fs: FsAdapter, dir: string): boolean {
|
|
return fs.exists(versionFile(dir)) || fs.exists(markerFile(dir));
|
|
}
|
|
|
|
// Read VERSION at dir; return a trimmed semver string, or null if missing/invalid.
|
|
function validVersionAt(fs: FsAdapter, dir: string): string | null {
|
|
const raw = fs.readFile(versionFile(dir));
|
|
if (raw == null) return null;
|
|
const trimmed = String(raw).trim();
|
|
return SEMVER_PREFIX.test(trimmed) ? trimmed : null;
|
|
}
|
|
|
|
// A version is TRUSTED only when BOTH the VERSION file and the update.md marker
|
|
// exist (and VERSION is valid semver).
|
|
function trustedVersionAt(fs: FsAdapter, dir: string | undefined): string | null {
|
|
return dir && fs.exists(markerFile(dir)) ? validVersionAt(fs, dir) : null;
|
|
}
|
|
|
|
export interface InferPreferredRuntimeOpts {
|
|
fs: FsAdapter;
|
|
env: Record<string, string | undefined>;
|
|
preferredConfigDir: string;
|
|
}
|
|
|
|
// Infer the preferred runtime from preferredConfigDir config files, then env.
|
|
export function inferPreferredRuntime({ fs, env, preferredConfigDir }: InferPreferredRuntimeOpts): string {
|
|
if (preferredConfigDir) {
|
|
if (fs.exists(path.join(preferredConfigDir, 'kilo.json')) ||
|
|
fs.exists(path.join(preferredConfigDir, 'kilo.jsonc'))) return 'kilo';
|
|
if (fs.exists(path.join(preferredConfigDir, 'opencode.json')) ||
|
|
fs.exists(path.join(preferredConfigDir, 'opencode.jsonc'))) return 'opencode';
|
|
if (fs.exists(path.join(preferredConfigDir, CODEX_CONFIG_MARKER))) return 'codex';
|
|
const resolved = path.resolve(preferredConfigDir);
|
|
const known = RUNTIME_DIRS.find(([, reldir]) =>
|
|
resolved.endsWith(path.sep + reldir.split('/').join(path.sep)));
|
|
if (known) return known[0];
|
|
}
|
|
if (env['CODEX_HOME']) return 'codex';
|
|
if (env['ANTIGRAVITY_CONFIG_DIR']) return 'antigravity';
|
|
if (env['KILO_CONFIG_DIR'] || env['KILO_CONFIG']) return 'kilo';
|
|
if (env['OPENCODE_CONFIG_DIR'] || env['OPENCODE_CONFIG']) return 'opencode';
|
|
if (env['CLAUDE_CONFIG_DIR']) return 'claude';
|
|
return '';
|
|
}
|
|
|
|
export interface EnvRuntimeDirsOpts {
|
|
env: Record<string, string | undefined>;
|
|
home: string;
|
|
}
|
|
|
|
// Absolute env-override candidates, mirroring the bash ENV_RUNTIME_DIRS block.
|
|
export function envRuntimeDirs({ env, home }: EnvRuntimeDirsOpts): RuntimeDirEntry[] {
|
|
const out: RuntimeDirEntry[] = [];
|
|
const ex = (v: string | undefined) => expandHome(v, home);
|
|
if (env['CLAUDE_CONFIG_DIR']) out.push(['claude', ex(env['CLAUDE_CONFIG_DIR'])]);
|
|
if (env['ANTIGRAVITY_CONFIG_DIR']) out.push(['antigravity', ex(env['ANTIGRAVITY_CONFIG_DIR'])]);
|
|
if (env['KILO_CONFIG_DIR']) out.push(['kilo', ex(env['KILO_CONFIG_DIR'])]);
|
|
else if (env['KILO_CONFIG']) out.push(['kilo', path.dirname(ex(env['KILO_CONFIG']))]);
|
|
else if (env['XDG_CONFIG_HOME']) out.push(['kilo', path.join(ex(env['XDG_CONFIG_HOME']), 'kilo')]);
|
|
if (env['OPENCODE_CONFIG_DIR']) out.push(['opencode', ex(env['OPENCODE_CONFIG_DIR'])]);
|
|
else if (env['OPENCODE_CONFIG']) out.push(['opencode', path.dirname(ex(env['OPENCODE_CONFIG']))]);
|
|
else if (env['XDG_CONFIG_HOME']) out.push(['opencode', path.join(ex(env['XDG_CONFIG_HOME']), 'opencode')]);
|
|
if (env['CODEX_HOME']) out.push(['codex', ex(env['CODEX_HOME'])]);
|
|
return out;
|
|
}
|
|
|
|
// Stable reorder: entries whose runtime === preferred first, original order kept.
|
|
function preferFirst(entries: RuntimeDirEntry[], preferred: string): RuntimeDirEntry[] {
|
|
const pref = entries.filter(([rt]) => rt === preferred);
|
|
const rest = entries.filter(([rt]) => rt !== preferred);
|
|
return [...pref, ...rest];
|
|
}
|
|
|
|
export interface ResolveUpdateContextOpts {
|
|
home: string;
|
|
cwd: string;
|
|
env?: Record<string, string | undefined>;
|
|
fs: FsAdapter;
|
|
preferredConfigDir?: string;
|
|
preferredRuntime?: string;
|
|
}
|
|
|
|
export interface UpdateContext {
|
|
installedVersion: string;
|
|
scope: 'LOCAL' | 'GLOBAL' | 'UNKNOWN';
|
|
runtime: string;
|
|
gsdDir: string;
|
|
}
|
|
|
|
/**
|
|
* Pure resolver. Returns { installedVersion, scope, runtime, gsdDir }.
|
|
*/
|
|
export function resolveUpdateContext({
|
|
home,
|
|
cwd,
|
|
env = {},
|
|
fs,
|
|
preferredConfigDir = '',
|
|
preferredRuntime = '',
|
|
}: ResolveUpdateContextOpts): UpdateContext {
|
|
// Expand a leading `~/` before any probe.
|
|
preferredConfigDir = expandHome(preferredConfigDir, home);
|
|
const preferred = preferredRuntime || inferPreferredRuntime({ fs, env, preferredConfigDir });
|
|
|
|
// Fast path: a validated preferredConfigDir (custom --config-dir install).
|
|
if (preferredConfigDir && hasInstall(fs, preferredConfigDir)) {
|
|
const resolvedPref = path.resolve(preferredConfigDir);
|
|
let scope: 'LOCAL' | 'GLOBAL' = 'GLOBAL';
|
|
for (const [, reldir] of RUNTIME_DIRS) {
|
|
if (path.resolve(cwd, reldir) === resolvedPref) { scope = 'LOCAL'; break; }
|
|
}
|
|
return {
|
|
installedVersion: trustedVersionAt(fs, preferredConfigDir) ?? '0.0.0',
|
|
scope,
|
|
runtime: preferred,
|
|
gsdDir: preferredConfigDir,
|
|
};
|
|
}
|
|
|
|
const orderedEnv = preferFirst(envRuntimeDirs({ env, home }), preferred);
|
|
const orderedRuntime = preferFirst(RUNTIME_DIRS, preferred);
|
|
|
|
// LOCAL probe (relative to cwd).
|
|
let localRuntime = '', localDir = '';
|
|
for (const [rt, reldir] of orderedRuntime) {
|
|
const cand = path.resolve(cwd, reldir);
|
|
if (hasInstall(fs, cand)) { localRuntime = rt; localDir = cand; break; }
|
|
}
|
|
|
|
// GLOBAL probe: absolute env candidates first, then $HOME-relative.
|
|
let globalRuntime = '', globalDir = '';
|
|
for (const [rt, absdir] of orderedEnv) {
|
|
if (hasInstall(fs, absdir)) { globalRuntime = rt; globalDir = path.resolve(absdir); break; }
|
|
}
|
|
if (!globalRuntime) {
|
|
for (const [rt, reldir] of orderedRuntime) {
|
|
const cand = path.resolve(home, reldir);
|
|
if (hasInstall(fs, cand)) { globalRuntime = rt; globalDir = cand; break; }
|
|
}
|
|
}
|
|
|
|
const localValid = trustedVersionAt(fs, localDir);
|
|
const isLocal = !!localValid && (!globalDir || localDir !== globalDir);
|
|
|
|
if (isLocal) {
|
|
return { installedVersion: localValid, scope: 'LOCAL', runtime: localRuntime, gsdDir: localDir };
|
|
}
|
|
const globalValid = trustedVersionAt(fs, globalDir);
|
|
if (globalValid) {
|
|
return { installedVersion: globalValid, scope: 'GLOBAL', runtime: globalRuntime, gsdDir: globalDir };
|
|
}
|
|
// A runtime dir was detected (VERSION or marker present) but is not a
|
|
// complete, valid install: keep scope/runtime/dir and report 0.0.0 so the
|
|
// caller re-installs.
|
|
if (localRuntime && (!globalDir || localDir !== globalDir)) {
|
|
return { installedVersion: '0.0.0', scope: 'LOCAL', runtime: localRuntime, gsdDir: localDir };
|
|
}
|
|
if (globalRuntime) {
|
|
return { installedVersion: '0.0.0', scope: 'GLOBAL', runtime: globalRuntime, gsdDir: globalDir };
|
|
}
|
|
return { installedVersion: '0.0.0', scope: 'UNKNOWN', runtime: '', gsdDir: '' };
|
|
}
|
|
|
|
export interface LoadUpdateContextOpts {
|
|
home?: string;
|
|
cwd?: string;
|
|
env?: Record<string, string | undefined>;
|
|
preferredConfigDir?: string;
|
|
preferredRuntime?: string;
|
|
}
|
|
|
|
/**
|
|
* CLI wiring: resolve against the real filesystem.
|
|
*/
|
|
export function loadUpdateContext(opts: LoadUpdateContextOpts = {}): UpdateContext {
|
|
const fs: FsAdapter = {
|
|
exists: (p: string) => nodeFs.existsSync(p),
|
|
readFile: (p: string) => { try { return nodeFs.readFileSync(p, 'utf8'); } catch { return null; } },
|
|
};
|
|
return resolveUpdateContext({
|
|
home: opts.home ?? nodeOs.homedir(),
|
|
cwd: opts.cwd ?? process.cwd(),
|
|
env: opts.env ?? process.env,
|
|
fs,
|
|
preferredConfigDir: opts.preferredConfigDir ?? '',
|
|
preferredRuntime: opts.preferredRuntime ?? '',
|
|
});
|
|
}
|