Files
msd-core/tests/pattern.test.cjs
Tom Boucher dc3c81e93d chore(#3212): src/pattern.cts is the sole owner of runtime-value regex construction — Phase 1 (#3416)
* test(#3412): failing-first suite for the pattern-construction seam

Phase 1 of epic #3212 (ADR-3212 §1/§2/§7). Tests only — src/pattern.cts
and eslint-rules/no-adhoc-regex-escape.cjs do not exist yet, so both
suites fail with MODULE_NOT_FOUND, which is the intended RED.

Locks the measured behavior rather than the assumed behavior:
RegExp.escape hex-escapes the leading character of nearly every string
("abc" -> "\x61bc"), so the suite asserts match-equivalence against an
inlined historical oracle (the implementation being deleted) rather
than byte-equivalence of pattern text — 200 seeded fast-check runs plus
a fixed corpus, 0 mismatches. Also locks the latent character-class
range bug this phase fixes as a side effect: a hyphen-bearing value
interpolated into [...] currently forms a real range and matches an
unintended character; post-migration it must not.

* chore(#3412): src/pattern.cts owns runtime-value regex construction

Phase 1 of epic #3212 (ADR-3212 §1/§2/§6/§7). Adds the pattern seam
delegating to the built-in RegExp.escape, deletes every hand-rolled
copy, and raises the Node floor to the Active LTS line.

The census was low, three times over. ADR-3212 counted 10 copies; a
graph query found 12; the new lint rule — once live — found 27 more.
The difference is that the census counted named helper FUNCTIONS while
the rule counts the escape SHAPE, so inline .replace(<class>, '\$&')
copies were never in scope. ADR §1's actual requirement is that no
module outside the seam escapes a value for regex use, so all of them
are, and CLAUDE.md's no-defer rule makes them this change's work.
Fourth consecutive epic here whose copy count was low — the argument
for ADR-3180 Amendment 3's "state N found by the guard" rule.

Also corrected mid-implementation: the survey reported phase-id.cts's
escapeRegex had 0 external importers. It had 8 production importers,
making its removal a public-surface change to an ADR-2121-owned module
and requiring an update to that ADR's locked-surface test. Blast
radius revised Medium-High -> High.

RegExp.escape is match-equivalent but NOT text-equivalent: it
hex-escapes the leading char of nearly every string ("abc" ->
"\x61bc"). Equivalence is proven by a seeded fast-check property test
against the deleted implementation as oracle. It also fixes a latent
bug: a hyphen-bearing value interpolated into a character class
previously formed a real range and matched an unintended character.

Node floor 22 -> 24 (RegExp.escape is Node 24+), across engines,
.nvmrc, package-lock, 9 CI matrix entries, and 5 docs. The aggregate
`required-tests` context is unchanged and no job was added or removed,
so branch protection cannot be orphaned by the dropped lanes.

Enforced by eslint-rules/no-adhoc-regex-escape.cjs (shape-matched, with
structural provenance for reviewed pattern-fragment constants rather
than a name heuristic) plus a whole-tree companion guard covering the
directories ESLint's globs miss.

* fix(#3412): close the _SOURCE guard evasion, correct two false claims

Three findings from the orthogonal review pass, all fixed.

1. The ESLint rule's `_SOURCE` provenance fallback was pure identifier-
   name matching with no binding check, so `new RegExp(userInput_SOURCE)`
   — a function parameter — sailed past the guard. That is the same
   rename-evasion class issue #3410 documents, reopened by the very
   fallback meant to complement the structural check. Now bound to the
   identifier's actual binding kind: import, require-derived const, or
   module-scope const; parameters, `let`/`var`, and unresolvable
   bindings fail closed. Four RuleTester cases cover the evasion and
   prove the legitimate cross-module case still passes.

2. src/pattern.cts's own header carried the stale pre-correction counts
   (12 copies / 17 call sites) while CONTEXT.md and the design doc
   carried the corrected ones (~39 / ~44) — a self-contradiction inside
   the PR whose entire purpose is deleting divergent copies. Rewritten,
   preserving the durable lesson: a named-function census cannot see
   inline copies; only a shape-matching guard can.

3. The claim that all deleted copies threw TypeError on non-string was
   false. phase-id.cts's copy — the one with 8 external importers — did
   String(value).replace(...) and never threw. The seam's locked
   signature does not coerce, so this is a real, now-disclosed behavior
   change rather than the pure preservation the tests asserted. Audited
   all 32 invocations across the 8 importers and 6 in-file callers:
   every one is safe by construction (upstream truthy guard or a
   string-producing derivation), verified by runtime probe against the
   compiled modules rather than by TS compilation, which cannot see a
   runtime undefined. Corrected the false claim in both the test comment
   and the design doc, and added it to Known limits.

* docs(#3412): add Changed changeset for the Node 24 floor

The only user-visible break in this phase. The escape-behavior change
is internal and match-equivalent, so it carries no user-facing note.

* fix(#3412): resolve the seam's require graph in script fixtures and packaging

Checkpoint 2 came back red with 90 failures on the node24 lane. Three
distinct defects, all introduced by routing scripts/ through the new
pattern seam, none reproducible by any local gate:

1. ~82 failures — tests/adr-index-gate.test.cjs and
   tests/removed-but-needed-lint.test.cjs copy a scripts/*.cjs into an
   mkdtemp fixture and spawn it there (necessary: those scripts resolve
   their scan root from __dirname/.., so running the real script would
   scan the real repo). Each harness hand-listed the dependencies to
   copy alongside. Adding require('../gsd-core/bin/lib/pattern.cjs') to
   gen-adr-index.cjs made both lists silently incomplete ->
   MODULE_NOT_FOUND, plus 17 downstream 'did not emit parseable JSON'
   failures from the same crash.

   Fixed as a class, not an instance: new tests/helpers/copy-script-
   fixture.cjs walks a script's transitive static relative-require graph
   and copies it, so dependencies are derived and never re-declared. It
   throws (naming the unbuilt artifact) instead of letting the child die
   with a bare MODULE_NOT_FOUND. Verified for all four seam-consuming
   scripts: gen-adr-index, lint-removed-but-needed, gen-loop-host-
   contract, sync-runtime-launcher.

2. 2 failures — scripts/ ships wholesale but eslint-rules/ does not, so
   the new scripts/lint-no-adhoc-regex-escape.cjs would be
   MODULE_NOT_FOUND in a published install (#2858 guard). Excluded from
   the tarball, matching the existing precedent for gen-emitted-
   baseline.cjs, which is excluded for the identical reason, and locked
   with a test modeled on that one. Confirmed against a real npm pack:
   890 files, 0 from eslint-rules/, and gsd-core/bin/lib/pattern.cjs
   present (so the other four scripts' requires are legitimate).

3. 6 failures — tests/phase-id.test.cjs asserted the literal escaped
   source text ('0*29', 'PROJ-42'). RegExp.escape is match-equivalent to
   the retired hand-rolled escaper but NOT text-equivalent: it hex-
   escapes the leading character and all hyphens ('0*\x329',
   '\x50ROJ\x2d42'). Verified NOT a behavior change — 576 match
   decisions across all three real interpolation prefixes, zero
   divergence. Those tests now compile each source into the same heading
   regex src/roadmap.cts's searchPhaseInContent builds and assert what
   matches and what does not, including the 'i'-flag canonicalization
   the hex escape has to preserve. Re-pinning the new literals would
   have rebuilt the same brittleness one layer down. Adds a test for the
   property the escape exists for: a dot in '1.2' must not act as a
   wildcard.

Also shares one definition of 'a require' between the packaging guard
and the fixture copier, so the two cannot disagree about what they scan.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#3412): refuse to copy a fixture dependency outside the fixture root

copyScriptWithDeps resolved each relative require and joined the
repo-relative result onto fixtureRoot. A require resolving OUTSIDE the
repo yields a '../'-prefixed relative path, so path.join climbed out of
the fixture and wrote into the surrounding temp dir (verified:
repoRoot=/repo + depAbs=/etc/passwd wrote /tmp/etc/passwd).

No script in the tree does this today, so this closes an available
escape rather than an active one. Refuses via the existing unresolved-
require path so the failure names the offending specifier. Covered by a
negative proof that the guard fires and that nothing lands outside the
fixture.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(#3412): parse requires instead of pattern-matching them; restore the foreign-prefix contract

Applies all findings from the second orthogonal review round, re-run
because real code changed after round 1.

HIGH (security) — extractRequires stripped BLOCK comments before LINE
comments, so a '//' comment containing '/*' opened a phantom block
comment, and a '//' inside a string literal truncated the line. Both
hid real requires: 'const u="http://x"; require("./real.cjs")'
returned [], and four real requires in gsd-core/bin/gsd-tools.cjs were
invisible. Replaced with a real AST parse via espree.

This is ADR-3212's own Decision 4 — tokenizer-first for stateful
grammars — applied to the case it describes; comment/string/regex
nesting is exactly such a grammar, which is why the regex version was
wrong. The function was moved byte-identical out of the #2858 packaging
guard, so the bug PRE-DATES this branch and has been a live blind spot
there: a shipped script could have required an unshipped path
undetected. Fixing it makes that guard strictly stronger than on next.

espree is promoted from a transitive eslint dependency to an explicit
devDependency rather than relying on hoisting. The script parse attempt
sets ecmaFeatures.globalReturn because Node wraps CommonJS bodies in a
function, making a top-level return legal — scripts/check-coverage-gate
.cjs relies on it, and without the flag the guard throws on a file it
is supposed to scan. Verified 0 unparseable across all 324 .cjs/.js
under scripts/, bin/, and gsd-core/bin/, and 0 new violations against a
real npm pack, so the exact extractor does not newly fail the guard.

MEDIUM (security) — the repo-containment check guarded dependencies but
not the entry path. One escapesContainment predicate now guards both.

LOW (security) — containment was lexical while fs follows symlinks, and
a directory symlink could mint a fresh dedupe key per level. realpath
now resolves both repoRoot and each dependency before the decision, and
the realpath-derived path is the dedupe key. Destination layout still
uses the original repo-relative path, so copied trees are unchanged.

MAJOR (standards) — the round-1 behavioral rewrite of phase-id tests
lost the foreign-prefix contract: every assertion was satisfied by an
impl returning [A-Z]+\x2d42, i.e. ANY project code — the exact #3599
bug class the exact-source prevents. The literal assertions it replaced
were catching this. Now asserts the compiled regex REJECTS a different
prefix with the same number.

MAJOR (standards) — the test hand-duplicated production's heading regex
with no parity guard (CLAUDE.md's 'Generative Fix Divergence'). Removed
the parallel surface instead of policing it: src/roadmap.cts exports
buildPhaseHeadingRegex, searchPhaseInContent calls it, the test imports
it. Byte-identical .source and .flags verified for both escaped forms.

MINOR — '..foo' no longer false-flagged as an escape; the inverted
spurious-vs-missing doc claim corrected; the dead allow-test-rule
header removed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* chore(#3412): backfill changeset pr number to 3416

* fix(#3412): make the escape guard's own regex linear, reword an injection-scan collision

Two CI failures on PR #3416, both in code this branch added.

CodeQL js/redos (high) — REPLACE_CALL_RE's outer alternation let a
bracket run be consumed EITHER by the character-class branch OR one
character at a time by the trailing catch-all, so a failing match
explored both parses of every pair. Measured on the real regex:
n=26 -> 204ms, n=28 -> 791ms, n=30 -> 3475ms, a clean 2^n. This script
scans repo source, so a file with a long bracket run after '.replace(/'
would hang CI outright — a guard against undisciplined pattern
construction was itself the worst pattern in the diff.

Fixed the way ADR-3212 already prescribes: the catch-all branch now
excludes '[' and ']' so a bracket can only be consumed by the class
branch (this is what makes it linear), and every quantifier is bounded
(the locked bounded-quantifiers decision) as a second line of defense.
Now 0ms at n=2000. Disclosed coverage tradeoff, recorded at the
constant: a regex literal with a BARE unescaped ']' outside a class is
no longer matched by this backstop. No census shape has that form, and
the AST rule remains the primary detector.

Verified the guard did not go blind doing it: a real census-shape
violation is still reported, and an allow-adhoc-regex-escape
suppression comment is still honored.

Regression test drives the exported findViolations on a
2000-repetition adversarial input and asserts the RESULT. It makes no
wall-clock assertion — elapsed-time tests are forbidden — so a
regression surfaces as a harness timeout, which is the correct signal.

Prompt injection scan — 'must not act as a regex wildcard' in a test
comment matched the scanner's jailbreak pattern act\s+as\s+(a|an|if|
my). Reworded to 'behave as'. Deliberately NOT allowlisted: silencing a
whole test file over one phrase would blunt the scanner permanently,
and the comment has nothing to do with injection.

Neither failure was reachable from the remote runner — CodeQL and the
injection scan are not in that matrix, so the sha it passed was green
and still wrong.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-08-13 16:19:57 -04:00

205 lines
9.2 KiB
JavaScript

'use strict';
/**
* Tests for `src/pattern.cts` — the pattern-construction seam (#3212 Phase 1, #3412).
*
* Design: .gsd/phase/chore-3412-pattern-seam/40-design.md
* Test matrix: .gsd/phase/chore-3412-pattern-seam/50-test-matrix.md
* ADR: docs/adr/3212-lexical-seam-consolidation.md §1, §2, §7
*
* TDD RED: `src/pattern.cts` does not exist yet — this file's
* `require('../gsd-core/bin/lib/pattern.cjs')` throws MODULE_NOT_FOUND until
* the implementing phase adds it. That is the intended starting state (mirrors
* tests/planning-snapshot.test.cjs's RED convention).
*
* Covers test-matrix sections 1 (escapeRegex, rows 1-10), 2 (literalPattern,
* rows 11-14), and 3 (migration equivalence, rows 15-17).
*/
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
// Seeded fast-check convention: require the shared setup helper (NOT
// 'fast-check' directly) so numRuns/seed are configured globally before any
// fc.assert() call — mirrors tests/frontmatter.property.test.cjs and every
// other *.property.test.cjs file. seed: 42, overridable via GSD_FC_SEED.
const fc = require('./helpers/fast-check-setup.cjs');
const { escapeRegex, literalPattern } = require('../gsd-core/bin/lib/pattern.cjs');
// ─── Section 1: escapeRegex — rows 1-10 ───────────────────────────────────
describe('escapeRegex', () => {
test('row 1: "" returns ""', () => {
assert.strictEqual(escapeRegex(''), '');
});
test('row 2: ordinary chars only ("_x") are unchanged', () => {
assert.strictEqual(escapeRegex('_x'), '_x');
});
test('row 3: each metacharacter is escaped and the result matches its own literal form', () => {
const metachars = ['.', '*', '+', '?', '^', '$', '{', '}', '(', ')', '|', '[', ']', '\\'];
for (const ch of metachars) {
const escaped = escapeRegex(ch);
const re = new RegExp(escaped);
assert.ok(re.test(ch), `escapeRegex(${JSON.stringify(ch)}) -> ${JSON.stringify(escaped)} must match its own literal char`);
}
});
test('row 4: leading ASCII letter locks the MEASURED hex-escape ("abc" -> "\\x61bc", Node v26.5.1)', () => {
assert.strictEqual(escapeRegex('abc'), '\\x61bc');
});
test('row 5: leading digit locks the MEASURED hex-escape ("5abc" -> "\\x35abc", Node v26.5.1)', () => {
assert.strictEqual(escapeRegex('5abc'), '\\x35abc');
});
test('row 6: hyphen anywhere locks the MEASURED hex-escape ("a-b" -> "\\x61\\x2db", Node v26.5.1)', () => {
assert.strictEqual(escapeRegex('a-b'), '\\x61\\x2db');
});
test('row 7: whitespace / newline / control chars are escaped and the result still constructs', () => {
const values = [' ', '\n', '\t', '\r', 'a\nb', 'a\tb\rc'];
for (const v of values) {
const escaped = escapeRegex(v);
assert.doesNotThrow(() => new RegExp(escaped));
assert.ok(new RegExp(escaped).test(v));
}
});
// #3212 Spec-axis review correction: this throw behavior matches MOST of the
// deleted copies' `.replace` throw, but NOT ALL of them — `src/phase-id.cts`'s
// original `escapeRegex(value: unknown)` did `String(value).replace(...)` and
// never threw (`escapeRegex(42) === '42'`, `escapeRegex(null) === 'null'`, per
// the deleted `tests/phase-id.test.cjs` assertions). That is a deliberate,
// disclosed behavior change for phase-id's former callers: the seam's locked
// signature (`escapeRegex(value: string): string`, ADR §1) does not coerce, so
// a non-string reaching it now throws instead of silently stringifying.
// Mitigated by an explicit `String(...)` wrap at the one former phase-id call
// site that genuinely needed it (phaseMarkdownRegexSource's fallback branch,
// src/phase-id.cts) — the seam's throw itself is intentional and stays.
test('row 8: non-string input throws TypeError (matches 11 of the 12 deleted copies\' .replace throw — phase-id.cts\'s copy coerced instead, see comment above)', () => {
for (const bad of [null, undefined, 42, {}, [], true]) {
assert.throws(() => escapeRegex(bad), TypeError, `escapeRegex(${JSON.stringify(bad)}) must throw TypeError`);
}
});
test('row 9: a 10,000-char value does not throw and completes without catastrophic time', () => {
const big = 'a-b.c*d'.repeat(1429); // ~10,001 chars
let escaped;
assert.doesNotThrow(() => {
escaped = escapeRegex(big);
});
assert.doesNotThrow(() => new RegExp(escaped));
});
test('row 10: RegExp.escape availability — the ADR §2 floor-vs-capability assertion', () => {
assert.strictEqual(typeof RegExp.escape, 'function');
});
});
// ─── Section 2: literalPattern — rows 11-14 ───────────────────────────────
describe('literalPattern', () => {
test('row 11: value + no flags produces a RegExp matching the value literally', () => {
const re = literalPattern('abc');
assert.ok(re instanceof RegExp);
assert.ok(re.test('abc'));
});
test('row 12: value + valid flags ("gi") applies the flags', () => {
const re = literalPattern('abc', 'gi');
assert.strictEqual(re.flags, 'gi');
assert.ok(re.test('ABC'));
});
test('row 13: invalid flags ("qq") throws SyntaxError from RegExp', () => {
assert.throws(() => literalPattern('abc', 'qq'), SyntaxError);
});
test('row 14: metacharacter-heavy value matches literally, not by its metacharacter interpretation', () => {
const re = literalPattern('a.b*c');
assert.ok(re.test('a.b*c'), 'must match the literal string');
// If '.' and '*' were left live, this would ALSO match (any-char + zero-or-more)
assert.ok(!re.test('aXbYYYc'), 'must NOT match the metacharacter interpretation');
});
});
// ─── Section 3: migration equivalence — rows 15-17 (load-bearing) ─────────
describe('migration equivalence (row-9 sweep)', () => {
test('row 15: property — hand oracle and escapeRegex are match-equivalent for all (s, probe) pairs (seeded)', () => {
// `hand` is the historical oracle: the deleted pre-migration implementation,
// byte-identical across all twelve copies before this seam existed (design
// doc "Ground truth" #1; ADR §7 Class 1 census). It is inlined here ONLY as
// a test oracle for this equivalence sweep — this is NOT a 13th production
// copy of the escape helper (design doc Notes: "not a 13th production copy").
// eslint-disable-next-line local/no-adhoc-regex-escape -- historical oracle for the row-15 equivalence sweep, not a production copy (#3412)
const hand = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
fc.assert(
fc.property(
fc.string({ maxLength: 200 }),
fc.string({ maxLength: 50 }),
(s, probe) => {
const handResult = new RegExp(hand(s)).test(probe);
const seamResult = new RegExp(escapeRegex(s)).test(probe);
assert.strictEqual(
seamResult,
handResult,
`match divergence for s=${JSON.stringify(s)} probe=${JSON.stringify(probe)}`
);
}
)
);
});
test('row 16: the real corpus — phase tokens, milestone versions, STATE field names, runtime ids are match-equivalent', () => {
// eslint-disable-next-line local/no-adhoc-regex-escape -- historical oracle for the row-16 equivalence sweep, not a production copy (#3412)
const hand = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
const corpus = [
'1A',
'PROJ-05',
'999.1',
'v1.2',
'**Current Phase:**',
'claude-code',
'gemini-cli',
];
const probes = ['1A', 'PROJ-05', '999.1', 'v1.2', '**Current Phase:**', 'claude-code', 'gemini-cli', 'no-match-here'];
for (const s of corpus) {
for (const probe of probes) {
const handResult = new RegExp(hand(s)).test(probe);
const seamResult = new RegExp(escapeRegex(s)).test(probe);
assert.strictEqual(
seamResult,
handResult,
`corpus divergence for s=${JSON.stringify(s)} probe=${JSON.stringify(probe)}`
);
}
}
});
test('row 17: latent-bug fix — a hyphen interpolated into a character class no longer forms a range', () => {
// Pre-migration (hand-rolled, verified): new RegExp('[' + hand('a-z') + ']').test('m') === true
// — the unescaped '-' formed an unintended a-through-z RANGE that happened
// to match 'm'. This is design row 10's confirmed latent bug.
// eslint-disable-next-line local/no-adhoc-regex-escape -- historical oracle for the row-17 latent-bug check, not a production copy (#3412)
const hand = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
assert.strictEqual(
new RegExp('[' + hand('a-z') + ']').test('m'),
true,
'sanity check: pre-migration hand-rolled behavior was true (verified)'
);
// Post-migration (the seam): the fix. 'a', '-', 'z' are all escaped as
// discrete literal characters, so '[...]' no longer forms a range and 'm'
// (interior to the would-be range) must NOT match.
assert.strictEqual(
new RegExp('[' + escapeRegex('a-z') + ']').test('m'),
false,
'deliberate fix, not an accident: the seam must not let a value form a character-class range'
);
});
});