* test: destroy 9 config-schema.cjs/core.cjs source-grep tests, add behavioral config-set tests (#2691, #2693)
Replace source-grep theater with config-set behavioral tests:
- execute-phase-wave: config-set workflow.use_worktrees replaces VALID_CONFIG_KEYS grep
- inline-plan-threshold: delete redundant source-grep (behavioral test at L36 already covered it)
- plan-bounce: config-set for plan_bounce / plan_bounce_script / plan_bounce_passes replaces 3 key-presence greps
- code-review: config-set for code_review / code_review_depth replaces 2 greps; removes CONFIG_PATH constant
- thinking-partner: config-set features.thinking_partner replaces two greps (config-schema.cjs AND core.cjs)
Behavioral tests survive refactors (no path constants, no file reads). The config-schema.cjs →
core.cjs migration commit 990c3e64 happened because these tests groped source paths.
Add allow-test-rule: source-text-is-the-product annotations to legitimate product-content tests:
autonomous-allowed-tools, agent-frontmatter, agent-skills-awareness, bug-2334, bug-2346,
execute-phase-wave (MD reads), plan-bounce (workflow reads). Annotations explain WHY text
inspection is the right level of testing for AI instruction files.
Closes #2691
Closes #2693
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: address CodeRabbit findings on #2696
- agent-frontmatter.test.cjs: move allow-test-rule annotation from block comment
to standalone // line comment so rule scanners can detect it
- thinking-partner.test.cjs: strengthen config-set test with config-get read-back
assertion to verify the value was persisted, not just accepted (exit 0)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: tighten thinking_partner config assertion per CodeRabbit (#2696)
Replace config-get output substring check (includes('true') false-positive
risk) with a direct JSON read of .planning/config.json, asserting the
exact persisted value via strictEqual. This also validates the config file
was created, catching silent key-acceptance without persistence.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
53 lines
1.7 KiB
JavaScript
53 lines
1.7 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Agent .md files are the installed AI agents — the "Project skills" block IS the deployed
|
|
// instruction. Checking text content IS checking what runs in production.
|
|
'use strict';
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const AGENTS_DIR = path.join(__dirname, '..', 'agents');
|
|
|
|
function readAgent(name) {
|
|
return fs.readFileSync(path.join(AGENTS_DIR, `${name}.md`), 'utf8');
|
|
}
|
|
|
|
describe('project skills awareness', () => {
|
|
const agentsRequiringSkills = [
|
|
'gsd-debugger',
|
|
'gsd-integration-checker',
|
|
'gsd-security-auditor',
|
|
'gsd-nyquist-auditor',
|
|
'gsd-codebase-mapper',
|
|
'gsd-roadmapper',
|
|
'gsd-eval-auditor',
|
|
'gsd-intel-updater',
|
|
'gsd-doc-writer',
|
|
];
|
|
|
|
for (const agentName of agentsRequiringSkills) {
|
|
test(`${agentName} has Project skills block`, () => {
|
|
const content = readAgent(agentName);
|
|
assert.ok(content.includes('Project skills'), `${agentName} missing Project skills block`);
|
|
});
|
|
|
|
test(`${agentName} does not load full AGENTS.md`, () => {
|
|
const content = readAgent(agentName);
|
|
assert.ok(
|
|
!content.includes('Read AGENTS.md') && !content.includes('load AGENTS.md'),
|
|
`${agentName} should not instruct loading full AGENTS.md`
|
|
);
|
|
});
|
|
}
|
|
|
|
test('gsd-doc-writer has security note about doc_assignment user data', () => {
|
|
const content = readAgent('gsd-doc-writer');
|
|
assert.ok(
|
|
content.includes('doc_assignment') && content.includes('SECURITY'),
|
|
'gsd-doc-writer missing security note for doc_assignment block'
|
|
);
|
|
});
|
|
});
|